Commit fca0ca95 authored by Pan Bian's avatar Pan Bian Committed by Greg Kroah-Hartman

usb: return correct errno code when krealloc fails

In function wusb_dev_sec_add(), variable result takes the return value.
Its value should be negative on failures. When function krealloc() is
called, an earlier check of variable result guarantees that the value of
result must not be less than "sizeof(*secd)", and result is not
reassigned when krealloc() returns a NULL pointer. As a result, a
positive value may be returned, which makes it impossible for the caller
of wusb_dev_sec_add() to detect the error. This patch fixes the bug by
assigning -ENOMEM to result when krealloc() returns NULL.
Signed-off-by: default avatarPan Bian <bianpan2016@163.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fd3ed14e
...@@ -240,6 +240,7 @@ int wusb_dev_sec_add(struct wusbhc *wusbhc, ...@@ -240,6 +240,7 @@ int wusb_dev_sec_add(struct wusbhc *wusbhc,
if (new_secd == NULL) { if (new_secd == NULL) {
dev_err(dev, dev_err(dev,
"Can't allocate space for security descriptors\n"); "Can't allocate space for security descriptors\n");
result = -ENOMEM;
goto out; goto out;
} }
secd = new_secd; secd = new_secd;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment