Commit fcc9b50e authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman

Revert "greybus: gb-beagleplay: Ensure le for values in transport"

This reverts commit 52eb6786.

Turns out to not be correct, a new version will be generated later.

Link: https://lore.kernel.org/r/20231204131008.384583-1-ayushdevel1325@gmail.com
Cc: Ayush Singh <ayushdevel1325@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 52eb6786
...@@ -93,9 +93,9 @@ static void hdlc_rx_greybus_frame(struct gb_beagleplay *bg, u8 *buf, u16 len) ...@@ -93,9 +93,9 @@ static void hdlc_rx_greybus_frame(struct gb_beagleplay *bg, u8 *buf, u16 len)
memcpy(&cport_id, hdr->pad, sizeof(cport_id)); memcpy(&cport_id, hdr->pad, sizeof(cport_id));
dev_dbg(&bg->sd->dev, "Greybus Operation %u type %X cport %u status %u received", dev_dbg(&bg->sd->dev, "Greybus Operation %u type %X cport %u status %u received",
hdr->operation_id, hdr->type, le16_to_cpu(cport_id), hdr->result); hdr->operation_id, hdr->type, cport_id, hdr->result);
greybus_data_rcvd(bg->gb_hd, le16_to_cpu(cport_id), buf, len); greybus_data_rcvd(bg->gb_hd, cport_id, buf, len);
} }
static void hdlc_rx_dbg_frame(const struct gb_beagleplay *bg, const char *buf, u16 len) static void hdlc_rx_dbg_frame(const struct gb_beagleplay *bg, const char *buf, u16 len)
...@@ -340,15 +340,14 @@ static int gb_message_send(struct gb_host_device *hd, u16 cport, struct gb_messa ...@@ -340,15 +340,14 @@ static int gb_message_send(struct gb_host_device *hd, u16 cport, struct gb_messa
{ {
struct gb_beagleplay *bg = dev_get_drvdata(&hd->dev); struct gb_beagleplay *bg = dev_get_drvdata(&hd->dev);
struct hdlc_payload payloads[2]; struct hdlc_payload payloads[2];
__le16 cport_id = le16_to_cpu(cport);
dev_dbg(&hd->dev, "Sending greybus message with Operation %u, Type: %X on Cport %u", dev_dbg(&hd->dev, "Sending greybus message with Operation %u, Type: %X on Cport %u",
msg->header->operation_id, msg->header->type, cport); msg->header->operation_id, msg->header->type, cport);
if (le16_to_cpu(msg->header->size) > RX_HDLC_PAYLOAD) if (msg->header->size > RX_HDLC_PAYLOAD)
return dev_err_probe(&hd->dev, -E2BIG, "Greybus message too big"); return dev_err_probe(&hd->dev, -E2BIG, "Greybus message too big");
memcpy(msg->header->pad, &cport_id, sizeof(cport_id)); memcpy(msg->header->pad, &cport, sizeof(cport));
payloads[0].buf = msg->header; payloads[0].buf = msg->header;
payloads[0].len = sizeof(*msg->header); payloads[0].len = sizeof(*msg->header);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment