Commit fd07a62d authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller

net: hns3: ensure media_type is unitialized

Media type is only set if h->ae_algo->ops->get_media_type is called
so there is a possibility that media_type is uninitialized when it is
used a switch statement.  Fix this by initializing media_type to
HNAE3_MEDIA_TYPE_UNKNOWN.

Detected by CoverityScan, CID#1452624("Uninitialized scalar variable")

Fixes: 496d03e9 ("net: hns3: Add Ethtool support to HNS3 driver")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 93345c06
...@@ -304,7 +304,7 @@ static int hns3_get_link_ksettings(struct net_device *netdev, ...@@ -304,7 +304,7 @@ static int hns3_get_link_ksettings(struct net_device *netdev,
struct hnae3_handle *h = priv->ae_handle; struct hnae3_handle *h = priv->ae_handle;
u32 supported_caps; u32 supported_caps;
u32 advertised_caps; u32 advertised_caps;
u8 media_type; u8 media_type = HNAE3_MEDIA_TYPE_UNKNOWN;
u8 link_stat; u8 link_stat;
u8 auto_neg; u8 auto_neg;
u8 duplex; u8 duplex;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment