Commit fd3bbf4a authored by Gwendal Grignou's avatar Gwendal Grignou Committed by Lee Jones

mfd: cros_ec: Remove zero-size structs

Empty structure size is different between C and C++.
To prevent clang warning when compiling this include file in C++
programs, remove empty structures.
Signed-off-by: default avatarGwendal Grignou <gwendal@chromium.org>
Acked-by: default avatarEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: default avatarBenson Leung <bleung@chromium.org>
Reviewed-by: default avatarFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent e849b874
...@@ -1540,10 +1540,14 @@ struct lightbar_program { ...@@ -1540,10 +1540,14 @@ struct lightbar_program {
struct ec_params_lightbar { struct ec_params_lightbar {
uint8_t cmd; /* Command (see enum lightbar_command) */ uint8_t cmd; /* Command (see enum lightbar_command) */
union { union {
struct { /*
/* no args */ * The following commands have no args:
} dump, off, on, init, get_seq, get_params_v0, get_params_v1, *
version, get_brightness, get_demo, suspend, resume; * dump, off, on, init, get_seq, get_params_v0, get_params_v1,
* version, get_brightness, get_demo, suspend, resume
*
* Don't use an empty struct, because C++ hates that.
*/
struct __ec_todo_unpacked { struct __ec_todo_unpacked {
uint8_t num; uint8_t num;
...@@ -1597,11 +1601,13 @@ struct ec_response_lightbar { ...@@ -1597,11 +1601,13 @@ struct ec_response_lightbar {
uint8_t red, green, blue; uint8_t red, green, blue;
} get_rgb; } get_rgb;
struct { /*
/* no return params */ * The following commands have no response:
} off, on, init, set_brightness, seq, reg, set_rgb, *
demo, set_params_v0, set_params_v1, * off, on, init, set_brightness, seq, reg, set_rgb,
set_program, manual_suspend_ctrl, suspend, resume; * set_params_v0, set_params_v1, set_program,
* manual_suspend_ctrl, suspend, resume
*/
}; };
} __ec_todo_packed; } __ec_todo_packed;
...@@ -3021,9 +3027,7 @@ enum charge_state_params { ...@@ -3021,9 +3027,7 @@ enum charge_state_params {
struct ec_params_charge_state { struct ec_params_charge_state {
uint8_t cmd; /* enum charge_state_command */ uint8_t cmd; /* enum charge_state_command */
union { union {
struct { /* get_state has no args */
/* no args */
} get_state;
struct __ec_todo_unpacked { struct __ec_todo_unpacked {
uint32_t param; /* enum charge_state_param */ uint32_t param; /* enum charge_state_param */
...@@ -3049,9 +3053,8 @@ struct ec_response_charge_state { ...@@ -3049,9 +3053,8 @@ struct ec_response_charge_state {
struct __ec_align4 { struct __ec_align4 {
uint32_t value; uint32_t value;
} get_param; } get_param;
struct {
/* no return values */ /* set_param returns no args */
} set_param;
}; };
} __ec_align4; } __ec_align4;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment