Commit fd40749a authored by Richard Acayan's avatar Richard Acayan Committed by Neil Armstrong

drm/panel: sofef00: Use 16-bit brightness function

These panels communicate brightness in big endian. This is not a quirk
of the panels themselves, but rather, a part of the MIPI standard. Use
the new mipi_dsi_dcs_set_display_brightness_large() function that
properly handles 16-bit brightness instead of doing special processing
of the brightness values.
Signed-off-by: default avatarRichard Acayan <mailingradian@gmail.com>
Tested-by: default avatarCaleb Connolly <caleb@connolly.tech>
Reviewed-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: default avatarSam Ravnborg <sam@ravnborg.org>
Signed-off-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230116224909.23884-3-mailingradian@gmail.com
parent c9d27c6b
...@@ -10,7 +10,6 @@ ...@@ -10,7 +10,6 @@
#include <linux/of.h> #include <linux/of.h>
#include <linux/of_device.h> #include <linux/of_device.h>
#include <linux/regulator/consumer.h> #include <linux/regulator/consumer.h>
#include <linux/swab.h>
#include <linux/backlight.h> #include <linux/backlight.h>
#include <video/mipi_display.h> #include <video/mipi_display.h>
...@@ -213,13 +212,9 @@ static int sofef00_panel_bl_update_status(struct backlight_device *bl) ...@@ -213,13 +212,9 @@ static int sofef00_panel_bl_update_status(struct backlight_device *bl)
{ {
struct mipi_dsi_device *dsi = bl_get_data(bl); struct mipi_dsi_device *dsi = bl_get_data(bl);
int err; int err;
u16 brightness; u16 brightness = (u16)backlight_get_brightness(bl);
brightness = (u16)backlight_get_brightness(bl); err = mipi_dsi_dcs_set_display_brightness_large(dsi, brightness);
// This panel needs the high and low bytes swapped for the brightness value
brightness = __swab16(brightness);
err = mipi_dsi_dcs_set_display_brightness(dsi, brightness);
if (err < 0) if (err < 0)
return err; return err;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment