Commit fd4a8093 authored by Kunihiko Hayashi's avatar Kunihiko Hayashi Committed by David S. Miller

net: socionext: ave: Avoid using netdev_err() before calling register_netdev()

Until calling register_netdev(), ndev->dev_name isn't specified, and
netdev_err() displays "(unnamed net_device)".

    ave 65000000.ethernet (unnamed net_device) (uninitialized): invalid phy-mode setting
    ave: probe of 65000000.ethernet failed with error -22

This replaces netdev_err() with dev_err() before calling register_netdev().
Signed-off-by: default avatarKunihiko Hayashi <hayashi.kunihiko@socionext.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2df4de16
...@@ -1662,19 +1662,19 @@ static int ave_probe(struct platform_device *pdev) ...@@ -1662,19 +1662,19 @@ static int ave_probe(struct platform_device *pdev)
"socionext,syscon-phy-mode", "socionext,syscon-phy-mode",
1, 0, &args); 1, 0, &args);
if (ret) { if (ret) {
netdev_err(ndev, "can't get syscon-phy-mode property\n"); dev_err(dev, "can't get syscon-phy-mode property\n");
goto out_free_netdev; goto out_free_netdev;
} }
priv->regmap = syscon_node_to_regmap(args.np); priv->regmap = syscon_node_to_regmap(args.np);
of_node_put(args.np); of_node_put(args.np);
if (IS_ERR(priv->regmap)) { if (IS_ERR(priv->regmap)) {
netdev_err(ndev, "can't map syscon-phy-mode\n"); dev_err(dev, "can't map syscon-phy-mode\n");
ret = PTR_ERR(priv->regmap); ret = PTR_ERR(priv->regmap);
goto out_free_netdev; goto out_free_netdev;
} }
ret = priv->data->get_pinmode(priv, phy_mode, args.args[0]); ret = priv->data->get_pinmode(priv, phy_mode, args.args[0]);
if (ret) { if (ret) {
netdev_err(ndev, "invalid phy-mode setting\n"); dev_err(dev, "invalid phy-mode setting\n");
goto out_free_netdev; goto out_free_netdev;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment