Commit fd9fe1fc authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman

staging: comedi: usbduxfast: remove impossible 'if (!devpriv)' checks

The private data 'devpriv' is allocated in the (*auto_attach) before
the subdevices are initialized and the (*auto_attach) has to complete
successfully before the core will call any of the subdevice operations.
Because of this the (!devpriv) checks in the subdevice code can never
fail. Remove them.
Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: default avatarIan Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent db1876ff
...@@ -223,9 +223,6 @@ static int usbduxfast_ai_cancel(struct comedi_device *dev, ...@@ -223,9 +223,6 @@ static int usbduxfast_ai_cancel(struct comedi_device *dev,
struct usbduxfast_private *devpriv = dev->private; struct usbduxfast_private *devpriv = dev->private;
int ret; int ret;
if (!devpriv)
return -EFAULT;
down(&devpriv->sem); down(&devpriv->sem);
ret = usbduxfast_ai_stop(dev, 1); ret = usbduxfast_ai_stop(dev, 1);
up(&devpriv->sem); up(&devpriv->sem);
...@@ -317,9 +314,6 @@ static int usbduxfast_submit_urb(struct comedi_device *dev) ...@@ -317,9 +314,6 @@ static int usbduxfast_submit_urb(struct comedi_device *dev)
struct usbduxfast_private *devpriv = dev->private; struct usbduxfast_private *devpriv = dev->private;
int ret; int ret;
if (!devpriv)
return -EFAULT;
usb_fill_bulk_urb(devpriv->urb, usb, usb_rcvbulkpipe(usb, BULKINEP), usb_fill_bulk_urb(devpriv->urb, usb, usb_rcvbulkpipe(usb, BULKINEP),
devpriv->inbuf, SIZEINBUF, devpriv->inbuf, SIZEINBUF,
usbduxfast_ai_interrupt, dev); usbduxfast_ai_interrupt, dev);
...@@ -466,9 +460,6 @@ static int usbduxfast_ai_inttrig(struct comedi_device *dev, ...@@ -466,9 +460,6 @@ static int usbduxfast_ai_inttrig(struct comedi_device *dev,
struct comedi_cmd *cmd = &s->async->cmd; struct comedi_cmd *cmd = &s->async->cmd;
int ret; int ret;
if (!devpriv)
return -EFAULT;
if (trig_num != cmd->start_arg) if (trig_num != cmd->start_arg)
return -EINVAL; return -EINVAL;
...@@ -501,9 +492,6 @@ static int usbduxfast_ai_cmd(struct comedi_device *dev, ...@@ -501,9 +492,6 @@ static int usbduxfast_ai_cmd(struct comedi_device *dev,
int result; int result;
long steps, steps_tmp; long steps, steps_tmp;
if (!devpriv)
return -EFAULT;
down(&devpriv->sem); down(&devpriv->sem);
if (devpriv->ai_cmd_running) { if (devpriv->ai_cmd_running) {
dev_err(dev->class_dev, "ai_cmd not possible\n"); dev_err(dev->class_dev, "ai_cmd not possible\n");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment