Commit fdf8e2ea authored by Josef Bacik's avatar Josef Bacik

Btrfs: unlock extent range on enospc in compressed submit

A user reported a deadlock where the async submit thread was blocked on the
lock_extent() lock, and then everybody behind him was locked on the page lock
for the page he was holding.  Looking at the code I noticed we do not unlock the
extent range when we get ENOSPC and goto retry.  This is bad because we
immediately try to lock that range again to do the cow, which will cause a
deadlock.  Fix this by unlocking the range.  Thanks,
Signed-off-by: default avatarJosef Bacik <jbacik@fusionio.com>
parent 90b6d283
......@@ -700,8 +700,12 @@ static noinline int submit_compressed_extents(struct inode *inode,
async_extent->nr_pages = 0;
async_extent->pages = NULL;
if (ret == -ENOSPC)
if (ret == -ENOSPC) {
unlock_extent(io_tree, async_extent->start,
async_extent->start +
async_extent->ram_size - 1);
goto retry;
}
goto out_free;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment