Commit fe825a41 authored by NeilBrown's avatar NeilBrown Committed by Luis Henriques

md/raid0: fix bug with chunksize not a power of 2.

commit 47d68979 upstream.

Since commit 20d0189b
in v3.14-rc1 RAID0 has performed incorrect calculations
when the chunksize is not a power of 2.

This happens because "sector_div()" modifies its first argument, but
this wasn't taken into account in the patch.

So restore that first arg before re-using the variable.
Reported-by: default avatarJoe Landman <joe.landman@gmail.com>
Reported-by: default avatarDave Chinner <david@fromorbit.com>
Fixes: 20d0189bSigned-off-by: default avatarNeilBrown <neilb@suse.de>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent 9eee60ef
......@@ -320,7 +320,7 @@ static struct strip_zone *find_zone(struct r0conf *conf,
/*
* remaps the bio to the target device. we separate two flows.
* power 2 flow and a general flow for the sake of perfromance
* power 2 flow and a general flow for the sake of performance
*/
static struct md_rdev *map_sector(struct mddev *mddev, struct strip_zone *zone,
sector_t sector, sector_t *sector_offset)
......@@ -538,6 +538,7 @@ static void raid0_make_request(struct mddev *mddev, struct bio *bio)
split = bio;
}
sector = bio->bi_iter.bi_sector;
zone = find_zone(mddev->private, &sector);
tmp_dev = map_sector(mddev, zone, sector, &sector);
split->bi_bdev = tmp_dev->bdev;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment