Commit fe99d1c0 authored by Jacob Keller's avatar Jacob Keller Committed by Tony Nguyen

ice: make ice_reset_all_vfs void

The ice_reset_all_vfs function returns true if any VFs were reset, and
false otherwise. However, no callers check the return value.

Drop this return value and make the function void since the callers do
not care about this.
Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Tested-by: default avatarKonrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent dac57288
...@@ -364,7 +364,7 @@ ice_vf_clear_vsi_promisc(struct ice_vf *vf, struct ice_vsi *vsi, u8 promisc_m) ...@@ -364,7 +364,7 @@ ice_vf_clear_vsi_promisc(struct ice_vf *vf, struct ice_vsi *vsi, u8 promisc_m)
* *
* Returns true if any VFs were reset, and false otherwise. * Returns true if any VFs were reset, and false otherwise.
*/ */
bool ice_reset_all_vfs(struct ice_pf *pf) void ice_reset_all_vfs(struct ice_pf *pf)
{ {
struct device *dev = ice_pf_to_dev(pf); struct device *dev = ice_pf_to_dev(pf);
struct ice_hw *hw = &pf->hw; struct ice_hw *hw = &pf->hw;
...@@ -373,7 +373,7 @@ bool ice_reset_all_vfs(struct ice_pf *pf) ...@@ -373,7 +373,7 @@ bool ice_reset_all_vfs(struct ice_pf *pf)
/* If we don't have any VFs, then there is nothing to reset */ /* If we don't have any VFs, then there is nothing to reset */
if (!ice_has_vfs(pf)) if (!ice_has_vfs(pf))
return false; return;
mutex_lock(&pf->vfs.table_lock); mutex_lock(&pf->vfs.table_lock);
...@@ -387,7 +387,7 @@ bool ice_reset_all_vfs(struct ice_pf *pf) ...@@ -387,7 +387,7 @@ bool ice_reset_all_vfs(struct ice_pf *pf)
/* If VFs have been disabled, there is no need to reset */ /* If VFs have been disabled, there is no need to reset */
if (test_and_set_bit(ICE_VF_DIS, pf->state)) { if (test_and_set_bit(ICE_VF_DIS, pf->state)) {
mutex_unlock(&pf->vfs.table_lock); mutex_unlock(&pf->vfs.table_lock);
return false; return;
} }
/* Begin reset on all VFs at once */ /* Begin reset on all VFs at once */
...@@ -439,8 +439,6 @@ bool ice_reset_all_vfs(struct ice_pf *pf) ...@@ -439,8 +439,6 @@ bool ice_reset_all_vfs(struct ice_pf *pf)
clear_bit(ICE_VF_DIS, pf->state); clear_bit(ICE_VF_DIS, pf->state);
mutex_unlock(&pf->vfs.table_lock); mutex_unlock(&pf->vfs.table_lock);
return true;
} }
/** /**
......
...@@ -213,7 +213,7 @@ ice_vf_set_vsi_promisc(struct ice_vf *vf, struct ice_vsi *vsi, u8 promisc_m); ...@@ -213,7 +213,7 @@ ice_vf_set_vsi_promisc(struct ice_vf *vf, struct ice_vsi *vsi, u8 promisc_m);
int int
ice_vf_clear_vsi_promisc(struct ice_vf *vf, struct ice_vsi *vsi, u8 promisc_m); ice_vf_clear_vsi_promisc(struct ice_vf *vf, struct ice_vsi *vsi, u8 promisc_m);
bool ice_reset_vf(struct ice_vf *vf, bool is_vflr); bool ice_reset_vf(struct ice_vf *vf, bool is_vflr);
bool ice_reset_all_vfs(struct ice_pf *pf); void ice_reset_all_vfs(struct ice_pf *pf);
#else /* CONFIG_PCI_IOV */ #else /* CONFIG_PCI_IOV */
static inline struct ice_vf *ice_get_vf_by_id(struct ice_pf *pf, u16 vf_id) static inline struct ice_vf *ice_get_vf_by_id(struct ice_pf *pf, u16 vf_id)
{ {
...@@ -275,9 +275,8 @@ static inline bool ice_reset_vf(struct ice_vf *vf, bool is_vflr) ...@@ -275,9 +275,8 @@ static inline bool ice_reset_vf(struct ice_vf *vf, bool is_vflr)
return true; return true;
} }
static inline bool ice_reset_all_vfs(struct ice_pf *pf) static inline void ice_reset_all_vfs(struct ice_pf *pf)
{ {
return true;
} }
#endif /* !CONFIG_PCI_IOV */ #endif /* !CONFIG_PCI_IOV */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment