Commit feec9f0a authored by Nikita Travkin's avatar Nikita Travkin Committed by Bjorn Andersson

arm64: dts: qcom: acer-aspire1: Correct audio codec definition

When initially added, a mistake was made in the definition of the codec.

Despite the fact that the DMIC line is connected on the side of the
codec chip, and relevant passive components, including 0-ohm resistors
connecting the dmics, are present, the dmic line is still cut in
another place on the board, which was overlooked.

Correct this by replacing the dmic configuration with a comment
describing this hardware detail.

While at it, also add missing regulators definitions. This is not a
functional change as all the relevant regulators were already added via
the other rail supplies.

Fixes: 4a9f8f8f ("arm64: dts: qcom: Add Acer Aspire 1")
Signed-off-by: default avatarNikita Travkin <nikita@trvn.ru>
Link: https://lore.kernel.org/r/20231205-aspire1-sound-v2-2-443b7ac0a06f@trvn.ruSigned-off-by: default avatarBjorn Andersson <andersson@kernel.org>
parent 04fe8f0a
......@@ -209,9 +209,22 @@ alc5682: codec@1a {
AVDD-supply = <&vreg_l15a_1p8>;
MICVDD-supply = <&reg_codec_3p3>;
VBAT-supply = <&reg_codec_3p3>;
DBVDD-supply = <&vreg_l15a_1p8>;
LDO1-IN-supply = <&vreg_l15a_1p8>;
/*
* NOTE: The board has a path from this codec to the
* DMIC microphones in the lid, however some of the option
* resistors are absent and the microphones are connected
* to the SoC instead.
*
* If the resistors were to be changed by the user to
* connect the codec, the following could be used:
*
* realtek,dmic1-data-pin = <1>;
* realtek,dmic1-clk-pin = <1>;
*/
realtek,dmic1-data-pin = <1>;
realtek,dmic1-clk-pin = <1>;
realtek,jd-src = <1>;
};
};
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment