Commit fefb8a2a authored by Randy Dunlap's avatar Randy Dunlap Committed by Greg Kroah-Hartman

virtio_console: eliminate anonymous module_init & module_exit

Eliminate anonymous module_init() and module_exit(), which can lead to
confusion or ambiguity when reading System.map, crashes/oops/bugs,
or an initcall_debug log.

Give each of these init and exit functions unique driver-specific
names to eliminate the anonymous names.

Example 1: (System.map)
 ffffffff832fc78c t init
 ffffffff832fc79e t init
 ffffffff832fc8f8 t init

Example 2: (initcall_debug log)
 calling  init+0x0/0x12 @ 1
 initcall init+0x0/0x12 returned 0 after 15 usecs
 calling  init+0x0/0x60 @ 1
 initcall init+0x0/0x60 returned 0 after 2 usecs
 calling  init+0x0/0x9a @ 1
 initcall init+0x0/0x9a returned 0 after 74 usecs
Signed-off-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Reviewed-by: default avatarAmit Shah <amit@kernel.org>
Cc: virtualization@lists.linux-foundation.org
Cc: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20220316192010.19001-3-rdunlap@infradead.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6aec3bfe
...@@ -2238,7 +2238,7 @@ static struct virtio_driver virtio_rproc_serial = { ...@@ -2238,7 +2238,7 @@ static struct virtio_driver virtio_rproc_serial = {
.remove = virtcons_remove, .remove = virtcons_remove,
}; };
static int __init init(void) static int __init virtio_console_init(void)
{ {
int err; int err;
...@@ -2273,7 +2273,7 @@ static int __init init(void) ...@@ -2273,7 +2273,7 @@ static int __init init(void)
return err; return err;
} }
static void __exit fini(void) static void __exit virtio_console_fini(void)
{ {
reclaim_dma_bufs(); reclaim_dma_bufs();
...@@ -2283,8 +2283,8 @@ static void __exit fini(void) ...@@ -2283,8 +2283,8 @@ static void __exit fini(void)
class_destroy(pdrvdata.class); class_destroy(pdrvdata.class);
debugfs_remove_recursive(pdrvdata.debugfs_dir); debugfs_remove_recursive(pdrvdata.debugfs_dir);
} }
module_init(init); module_init(virtio_console_init);
module_exit(fini); module_exit(virtio_console_fini);
MODULE_DESCRIPTION("Virtio console driver"); MODULE_DESCRIPTION("Virtio console driver");
MODULE_LICENSE("GPL"); MODULE_LICENSE("GPL");
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment