Commit ff8aed52 authored by Matt Porter's avatar Matt Porter Committed by Greg Kroah-Hartman

greybus: fix gb_manifest_parse() successful return path

Even if we successfully parse a manifest we are returning
failure. Instead, we now proudly proclaim success.
Signed-off-by: default avatarMatt Porter <mporter@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <greg@kroah.com>
parent e86905b6
...@@ -364,6 +364,7 @@ bool gb_manifest_parse(struct gb_module *gmod, void *data, size_t size) ...@@ -364,6 +364,7 @@ bool gb_manifest_parse(struct gb_module *gmod, void *data, size_t size)
if (desc_size <= 0) { if (desc_size <= 0) {
if (!desc_size) if (!desc_size)
pr_err("zero-sized manifest descriptor\n"); pr_err("zero-sized manifest descriptor\n");
result = false;
goto out; goto out;
} }
desc = (struct greybus_descriptor *)((char *)desc + desc_size); desc = (struct greybus_descriptor *)((char *)desc + desc_size);
...@@ -379,6 +380,7 @@ bool gb_manifest_parse(struct gb_module *gmod, void *data, size_t size) ...@@ -379,6 +380,7 @@ bool gb_manifest_parse(struct gb_module *gmod, void *data, size_t size)
if (found != 1) { if (found != 1) {
pr_err("manifest must have 1 module descriptor (%u found)\n", pr_err("manifest must have 1 module descriptor (%u found)\n",
found); found);
result = false;
goto out; goto out;
} }
...@@ -394,5 +396,5 @@ bool gb_manifest_parse(struct gb_module *gmod, void *data, size_t size) ...@@ -394,5 +396,5 @@ bool gb_manifest_parse(struct gb_module *gmod, void *data, size_t size)
out: out:
release_manifest_descriptors(); release_manifest_descriptors();
return false; return result;
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment