Skip to content

L
linux

lab.nexedi.com will be down from Thursday, 20 March 2025, 07:30:00 UTC for a duration of approximately 2 hours

Commit fff489ff authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files
Options

Merge branch 'thermal-int340x' 

Merge int340x thermal driver update fixing RFIM mailbox write
commands handling for 5.17-rc1.

* thermal-int340x:
  thermal/drivers/int340x: Fix RFIM mailbox write commands
parents 125521ad 2685c77b
Hide whitespace changes
Inline Side-by-side
Showing with 73 additions and 53 deletions
drivers/thermal/intel/int340x_thermal/processor_thermal_device.h
View file @ fff489ff
...@@ -80,7 +80,8 @@ void proc_thermal_rfim_remove(struct pci_dev *pdev); ...@@ -80,7 +80,8 @@ void proc_thermal_rfim_remove(struct pci_dev *pdev);
int proc_thermal_mbox_add(struct pci_dev *pdev, struct proc_thermal_device *proc_priv); int proc_thermal_mbox_add(struct pci_dev *pdev, struct proc_thermal_device *proc_priv);
void proc_thermal_mbox_remove(struct pci_dev *pdev); void proc_thermal_mbox_remove(struct pci_dev *pdev);
int processor_thermal_send_mbox_cmd(struct pci_dev *pdev, u16 cmd_id, u32 cmd_data, u64 *cmd_resp); int processor_thermal_send_mbox_read_cmd(struct pci_dev *pdev, u16 id, u64 *resp);
int processor_thermal_send_mbox_write_cmd(struct pci_dev *pdev, u16 id, u32 data);
int proc_thermal_add(struct device *dev, struct proc_thermal_device *priv); int proc_thermal_add(struct device *dev, struct proc_thermal_device *priv);
void proc_thermal_remove(struct proc_thermal_device *proc_priv); void proc_thermal_remove(struct proc_thermal_device *proc_priv);
int proc_thermal_suspend(struct device *dev); int proc_thermal_suspend(struct device *dev);
......
drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c
View file @ fff489ff
...@@ -24,19 +24,15 @@ ...@@ -24,19 +24,15 @@
static DEFINE_MUTEX(mbox_lock); static DEFINE_MUTEX(mbox_lock);
static int send_mbox_cmd(struct pci_dev *pdev, u16 cmd_id, u32 cmd_data, u64 *cmd_resp) static int wait_for_mbox_ready(struct proc_thermal_device *proc_priv)
{ {
struct proc_thermal_device *proc_priv;
u32 retries, data; u32 retries, data;
int ret; int ret;
mutex_lock(&mbox_lock);
proc_priv = pci_get_drvdata(pdev);
/* Poll for rb bit == 0 */ /* Poll for rb bit == 0 */
retries = MBOX_RETRY_COUNT; retries = MBOX_RETRY_COUNT;
do { do {
data = readl((void __iomem *) (proc_priv->mmio_base + MBOX_OFFSET_INTERFACE)); data = readl(proc_priv->mmio_base + MBOX_OFFSET_INTERFACE);
if (data & BIT_ULL(MBOX_BUSY_BIT)) { if (data & BIT_ULL(MBOX_BUSY_BIT)) {
ret = -EBUSY; ret = -EBUSY;
continue; continue;
...@@ -45,53 +41,78 @@ static int send_mbox_cmd(struct pci_dev *pdev, u16 cmd_id, u32 cmd_data, u64 *cm ...@@ -45,53 +41,78 @@ static int send_mbox_cmd(struct pci_dev *pdev, u16 cmd_id, u32 cmd_data, u64 *cm
break; break;
} while (--retries); } while (--retries);
return ret;
}
static int send_mbox_write_cmd(struct pci_dev *pdev, u16 id, u32 data)
{
struct proc_thermal_device *proc_priv;
u32 reg_data;
int ret;
proc_priv = pci_get_drvdata(pdev);
mutex_lock(&mbox_lock);
ret = wait_for_mbox_ready(proc_priv);
if (ret) if (ret)
goto unlock_mbox; goto unlock_mbox;
if (cmd_id == MBOX_CMD_WORKLOAD_TYPE_WRITE) writel(data, (proc_priv->mmio_base + MBOX_OFFSET_DATA));
writel(cmd_data, (void __iomem *) ((proc_priv->mmio_base + MBOX_OFFSET_DATA)));
/* Write command register */ /* Write command register */
data = BIT_ULL(MBOX_BUSY_BIT) | cmd_id; reg_data = BIT_ULL(MBOX_BUSY_BIT) | id;
writel(data, (void __iomem *) ((proc_priv->mmio_base + MBOX_OFFSET_INTERFACE))); writel(reg_data, (proc_priv->mmio_base + MBOX_OFFSET_INTERFACE));
/* Poll for rb bit == 0 */ ret = wait_for_mbox_ready(proc_priv);
retries = MBOX_RETRY_COUNT;
do {
data = readl((void __iomem *) (proc_priv->mmio_base + MBOX_OFFSET_INTERFACE));
if (data & BIT_ULL(MBOX_BUSY_BIT)) {
ret = -EBUSY;
continue;
}
if (data) { unlock_mbox:
ret = -ENXIO; mutex_unlock(&mbox_lock);
goto unlock_mbox; return ret;
} }
ret = 0; static int send_mbox_read_cmd(struct pci_dev *pdev, u16 id, u64 *resp)
{
struct proc_thermal_device *proc_priv;
u32 reg_data;
int ret;
if (!cmd_resp) proc_priv = pci_get_drvdata(pdev);
break;
if (cmd_id == MBOX_CMD_WORKLOAD_TYPE_READ) mutex_lock(&mbox_lock);
*cmd_resp = readl((void __iomem *) (proc_priv->mmio_base + MBOX_OFFSET_DATA));
else
*cmd_resp = readq((void __iomem *) (proc_priv->mmio_base + MBOX_OFFSET_DATA));
break; ret = wait_for_mbox_ready(proc_priv);
} while (--retries); if (ret)
goto unlock_mbox;
/* Write command register */
reg_data = BIT_ULL(MBOX_BUSY_BIT) | id;
writel(reg_data, (proc_priv->mmio_base + MBOX_OFFSET_INTERFACE));
ret = wait_for_mbox_ready(proc_priv);
if (ret)
goto unlock_mbox;
if (id == MBOX_CMD_WORKLOAD_TYPE_READ)
*resp = readl(proc_priv->mmio_base + MBOX_OFFSET_DATA);
else
*resp = readq(proc_priv->mmio_base + MBOX_OFFSET_DATA);
unlock_mbox: unlock_mbox:
mutex_unlock(&mbox_lock); mutex_unlock(&mbox_lock);
return ret; return ret;
} }
int processor_thermal_send_mbox_cmd(struct pci_dev *pdev, u16 cmd_id, u32 cmd_data, u64 *cmd_resp) int processor_thermal_send_mbox_read_cmd(struct pci_dev *pdev, u16 id, u64 *resp)
{ {
return send_mbox_cmd(pdev, cmd_id, cmd_data, cmd_resp); return send_mbox_read_cmd(pdev, id, resp);
} }
EXPORT_SYMBOL_GPL(processor_thermal_send_mbox_cmd); EXPORT_SYMBOL_NS_GPL(processor_thermal_send_mbox_read_cmd, INT340X_THERMAL);
int processor_thermal_send_mbox_write_cmd(struct pci_dev *pdev, u16 id, u32 data)
{
return send_mbox_write_cmd(pdev, id, data);
}
EXPORT_SYMBOL_NS_GPL(processor_thermal_send_mbox_write_cmd, INT340X_THERMAL);
/* List of workload types */ /* List of workload types */
static const char * const workload_types[] = { static const char * const workload_types[] = {
...@@ -104,7 +125,6 @@ static const char * const workload_types[] = { ...@@ -104,7 +125,6 @@ static const char * const workload_types[] = {
NULL NULL
}; };
static ssize_t workload_available_types_show(struct device *dev, static ssize_t workload_available_types_show(struct device *dev,
struct device_attribute *attr, struct device_attribute *attr,
char *buf) char *buf)
...@@ -146,7 +166,7 @@ static ssize_t workload_type_store(struct device *dev, ...@@ -146,7 +166,7 @@ static ssize_t workload_type_store(struct device *dev,
data |= ret; data |= ret;
ret = send_mbox_cmd(pdev, MBOX_CMD_WORKLOAD_TYPE_WRITE, data, NULL); ret = send_mbox_write_cmd(pdev, MBOX_CMD_WORKLOAD_TYPE_WRITE, data);
if (ret) if (ret)
return false; return false;
...@@ -161,7 +181,7 @@ static ssize_t workload_type_show(struct device *dev, ...@@ -161,7 +181,7 @@ static ssize_t workload_type_show(struct device *dev,
u64 cmd_resp; u64 cmd_resp;
int ret; int ret;
ret = send_mbox_cmd(pdev, MBOX_CMD_WORKLOAD_TYPE_READ, 0, &cmd_resp); ret = send_mbox_read_cmd(pdev, MBOX_CMD_WORKLOAD_TYPE_READ, &cmd_resp);
if (ret) if (ret)
return false; return false;
...@@ -186,8 +206,6 @@ static const struct attribute_group workload_req_attribute_group = { ...@@ -186,8 +206,6 @@ static const struct attribute_group workload_req_attribute_group = {
.name = "workload_request" .name = "workload_request"
}; };
static bool workload_req_created; static bool workload_req_created;
int proc_thermal_mbox_add(struct pci_dev *pdev, struct proc_thermal_device *proc_priv) int proc_thermal_mbox_add(struct pci_dev *pdev, struct proc_thermal_device *proc_priv)
...@@ -196,7 +214,7 @@ int proc_thermal_mbox_add(struct pci_dev *pdev, struct proc_thermal_device *proc ...@@ -196,7 +214,7 @@ int proc_thermal_mbox_add(struct pci_dev *pdev, struct proc_thermal_device *proc
int ret; int ret;
/* Check if there is a mailbox support, if fails return success */ /* Check if there is a mailbox support, if fails return success */
ret = send_mbox_cmd(pdev, MBOX_CMD_WORKLOAD_TYPE_READ, 0, &cmd_resp); ret = send_mbox_read_cmd(pdev, MBOX_CMD_WORKLOAD_TYPE_READ, &cmd_resp);
if (ret) if (ret)
return 0; return 0;
......
drivers/thermal/intel/int340x_thermal/processor_thermal_rfim.c
View file @ fff489ff
...@@ -9,6 +9,8 @@ ...@@ -9,6 +9,8 @@
#include <linux/pci.h> #include <linux/pci.h>
#include "processor_thermal_device.h" #include "processor_thermal_device.h"
MODULE_IMPORT_NS(INT340X_THERMAL);
struct mmio_reg { struct mmio_reg {
int read_only; int read_only;
u32 offset; u32 offset;
...@@ -194,8 +196,7 @@ static ssize_t rfi_restriction_store(struct device *dev, ...@@ -194,8 +196,7 @@ static ssize_t rfi_restriction_store(struct device *dev,
struct device_attribute *attr, struct device_attribute *attr,
const char *buf, size_t count) const char *buf, size_t count)
{ {
u16 cmd_id = 0x0008; u16 id = 0x0008;
u64 cmd_resp;
u32 input; u32 input;
int ret; int ret;
...@@ -203,7 +204,7 @@ static ssize_t rfi_restriction_store(struct device *dev, ...@@ -203,7 +204,7 @@ static ssize_t rfi_restriction_store(struct device *dev,
if (ret) if (ret)
return ret; return ret;
ret = processor_thermal_send_mbox_cmd(to_pci_dev(dev), cmd_id, input, &cmd_resp); ret = processor_thermal_send_mbox_write_cmd(to_pci_dev(dev), id, input);
if (ret) if (ret)
return ret; return ret;
...@@ -214,30 +215,30 @@ static ssize_t rfi_restriction_show(struct device *dev, ...@@ -214,30 +215,30 @@ static ssize_t rfi_restriction_show(struct device *dev,
struct device_attribute *attr, struct device_attribute *attr,
char *buf) char *buf)
{ {
u16 cmd_id = 0x0007; u16 id = 0x0007;
u64 cmd_resp; u64 resp;
int ret; int ret;
ret = processor_thermal_send_mbox_cmd(to_pci_dev(dev), cmd_id, 0, &cmd_resp); ret = processor_thermal_send_mbox_read_cmd(to_pci_dev(dev), id, &resp);
if (ret) if (ret)
return ret; return ret;
return sprintf(buf, "%llu\n", cmd_resp); return sprintf(buf, "%llu\n", resp);
} }
static ssize_t ddr_data_rate_show(struct device *dev, static ssize_t ddr_data_rate_show(struct device *dev,
struct device_attribute *attr, struct device_attribute *attr,
char *buf) char *buf)
{ {
u16 cmd_id = 0x0107; u16 id = 0x0107;
u64 cmd_resp; u64 resp;
int ret; int ret;
ret = processor_thermal_send_mbox_cmd(to_pci_dev(dev), cmd_id, 0, &cmd_resp); ret = processor_thermal_send_mbox_read_cmd(to_pci_dev(dev), id, &resp);
if (ret) if (ret)
return ret; return ret;
return sprintf(buf, "%llu\n", cmd_resp); return sprintf(buf, "%llu\n", resp);
} }
static DEVICE_ATTR_RW(rfi_restriction); static DEVICE_ATTR_RW(rfi_restriction);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7