- 25 Oct, 2022 12 commits
-
-
Martin Kaiser authored
The mlme handlers that are called from mgt_dispatcher return an error code. mgt_dispatcher doesn't check this error code, we can remove it and change the handler functions to void. For now, make only the minimum changes to the handlers for removing the error codes. If handlers can be simplified, that'll be done it separate patches. Signed-off-by:
Martin Kaiser <martin@kaiser.cx> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150 Link: https://lore.kernel.org/r/20221024081417.66441-13-martin@kaiser.cxSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Martin Kaiser authored
OnAuth is used only in rtw_mlme_ext.c. Make this function static. Signed-off-by:
-
Martin Kaiser authored
OnAction is used only in rtw_mlme_ext.c. Make this function static. Signed-off-by:
-
Martin Kaiser authored
OnDeAuth is used only in rtw_mlme_ext.c. Make this function static. Signed-off-by:
-
Martin Kaiser authored
OnAuthClient is used only in rtw_mlme_ext.c. Make this function static. Signed-off-by:
-
Martin Kaiser authored
OnDisassoc is used only in rtw_mlme_ext.c. Make this function static. Signed-off-by:
-
Martin Kaiser authored
OnBeacon is used only in rtw_mlme_ext.c. Make this function static. Signed-off-by:
-
Martin Kaiser authored
OnProbeRsp is used only in rtw_mlme_ext.c. Make this function static. Signed-off-by:
-
Martin Kaiser authored
OnProbeReq is used only in rtw_mlme_ext.c. Make this function static. Signed-off-by:
-
Martin Kaiser authored
OnAssocRsp is used only in rtw_mlme_ext.c. Make this function static. Signed-off-by:
-
Martin Kaiser authored
OnAssocReq is used only in rtw_mlme_ext.c. Make this function static. Signed-off-by:
-
Martin Kaiser authored
Move some code around in rtw_mlme_ext.c to make it simpler. mlme_sta_tbl is used only by mgt_dispatcher. Move the table inside the function. Move mgt_dispatcher behind the handler functions. We can then make the handler functions static. Signed-off-by:
-
- 23 Oct, 2022 4 commits
-
-
Aaron Lawrence authored
Fixed multiple unnecessary parentheses as per the Linux kernel coding-style regulations. The issues were flagged by the checkpatch script. Signed-off-by:
Aaron Lawrence <t4rmin@zohomail.com> Link: https://lore.kernel.org/r/d2168b90726dda2f02279a3483b53b8d9b34cb30.1666502177.git.t4rmin@zohomail.comSigned-off-by:
-
Aaron Lawrence authored
Aligned multiple statements to match open parenthesis as per Linux kernel coding-style regulations. The issues were flagged by the checkpatch script. Signed-off-by:
-
Aaron Lawrence authored
Added a missing blank space as per the Linux kernel coding-style regulations. The issue was flagged by the checkpatch script as a warning. Signed-off-by:
-
Deepak R Varma authored
printk messages are added for program flow tracing and are left commented. These commented log messages should be removed as they are no more useful for program execution. Signed-off-by:
Deepak R Varma <drv@mailo.com> Link: https://lore.kernel.org/r/Y1L0FiKvrM9jjZG9@debian-BULLSEYE-live-builder-AMD64Signed-off-by:
-
- 22 Oct, 2022 20 commits
-
-
Emily Peri authored
Replace spaces with tab for indent and correct alignment for closing brace in rtw_ioctl_set. Issue found by checkpatch. Signed-off-by:
Emily Peri <eperi1024@gmail.com> Link: https://lore.kernel.org/r/0516cac046c617b55718fddb2aac3a50d543d84c.1666380274.git.eperi1024@gmail.comSigned-off-by:
-
Emily Peri authored
Fix checkpatch style warning by adding newline after variable declaration in rtw_ioctl_set Signed-off-by:
-
Emily Peri authored
Remove unnecessary tab in variable definition in rtw_ioctl_set. Issue found by checkpatch. Signed-off-by:
-
Deepak R Varma authored
Simple variants of macros PlatformEFIOWrite and PlatformEFIORead are defined but never used. As they do not appear to be designed for anything significant, we can remove them to avoid unexpected usage. Suggested-by:
Julia Lawall <julia.lawall@inria.fr> Signed-off-by:
-
Deepak R Varma authored
Properly spacing out code statements/instructions improves code readability. Add missing or remove extra space as necessary according to the Linux Kernel coding-style guidelines. Following errors reported by checkpatch script for inconsistent code spacing: ERROR: space prohibited before that close parenthesis ')' ERROR: space prohibited before that ',' (ctx:WxW) CHECK: spaces preferred around that '&' (ctx:VxV) Signed-off-by:
-
Deepak R Varma authored
Open braces '{" should be placed on the line of symbol declaration as per the coding-style guidelines. Improves readability and matches with style used in rest of the code. Issue reported by checkpatch script. Signed-off-by: -
Deepak R Varma authored
Spaces are prohibited as per the Linux coding style guidelines. Replace those by tabs wherever possible to improve code alignment. Error reported by checkpatch script. Signed-off-by:
-
Deepak R Varma authored
The pointer symbol '*' should be associated with the function parameter name and not its type. This improves code readability and adheres to the coding-style guidelines. Address following checkpatch reported error: ERROR: "foo * bar" should be "foo *bar" While in there, update parameter name at one place to match other function declarations. Signed-off-by:
-
Deepak R Varma authored
Space required between function and macro parameters to improve code readability. This Linux kernel coding style guideline resolves following error reported by checkpatch script: ERROR: space required after that ',' (ctx:VxV) Signed-off-by:
-
Deepak R Varma authored
Fix spelling mistakes in code comments across the driver. Signed-off-by:
-
Deepak R Varma authored
Macro "htons" is more efficient and clearer. It should be used for constants instead of the __constant_htons macro. Resolves following checkpatch script complaint: WARNING: __constant_htons should be htons Signed-off-by: -
Deepak R Varma authored
As per the Linux kernel coding-style guidelines, there is no need to use {} for single statement blocks. Issue flagged by checkpatch script. Signed-off-by: -
Deepak R Varma authored
Reformat long running computation instructions to improve code readability. Address checkpatch script complaints like: CHECK: line length of 171 exceeds 100 columns Signed-off-by:
-
Deepak R Varma authored
Follow the Linux Kernel coding style variable naming convention instead of using camelCase style. Issue reported by checkpatch script for these variables: tagLen, tagType, networkAddr, ipAddr, macAddr Signed-off-by: -
Deepak R Varma authored
Correct the misleading struct type name dim_ch_state_t to dim_ch_state since this not a typedef but a normal structure declaration. Suggested-by:
-
Peter Robinson authored
Provide a TODO file that lists the tasks that should be carried out in order to move this driver off drivers/staging. It's missing from original addition of this driver. Signed-off-by:
Peter Robinson <pbrobinson@gmail.com> Link: https://lore.kernel.org/r/20221016110743.1448067-4-pbrobinson@gmail.comSigned-off-by:
-
Peter Robinson authored
Add move to mac80211 from wext to the todo for this driver. Signed-off-by:
-
Peter Robinson authored
The driver directory where it was proposed to move to has changed, while add it add some more pieces this driver to update. Signed-off-by:
-
Peter Robinson authored
Provide a TODO file that lists the tasks that should be carried out in order to move this driver off drivers/staging. It's missing from original addition of this driver. Signed-off-by:
-
Colin Ian King authored
The variable xcnt being incremented but it is never referenced, it is redundant and can be removed. Signed-off-by:
Colin Ian King <colin.i.king@gmail.com> Link: https://lore.kernel.org/r/20221021180950.29139-1-colin.i.king@gmail.comSigned-off-by:
-
- 20 Oct, 2022 4 commits
-
-
Colin Ian King authored
The variable total_freed is accumulating skb_to_free however it is not being used after this. The use of total_freed is redundant and hence the variable can be removed. Signed-off-by:
-
Danijel Korent authored
Fixed "spaces preferred around operator" type of problems reported by checkpatch Signed-off-by:
Danijel Korent <danijel.korent@gmail.com> Link: https://lore.kernel.org/r/20221015165023.487200-1-danijel.korent@gmail.comSigned-off-by:
-
Martin Kaiser authored
Summarize the code for tx/rx blinking and for scan blinking in blink_work. The only difference is the delay for scheduling the next worker. Signed-off-by:
-
Martin Kaiser authored
Set two more state variables in the blink worker when scan blinking and tx/rx blinking are finished. bLedBlinkInProgress is true during tx/rx blinking, bLedScanBlinkInProgress is true during scan blinking. If we doing neither of the two, we may safely set both variables to false. This change makes the scan and tx/rx cases almost identical, we are now ready to summarize the two cases. Signed-off-by:
-
