1. 07 Aug, 2008 4 commits
  2. 04 Aug, 2008 5 commits
    • Alexander Beregalov's avatar
      IB/ipath: Fix printk format warnings · 70117b9e
      Alexander Beregalov authored
          ipath_driver.c:1260: warning: format '%Lx' expects type 'long long unsigned int', but argument 6 has type 'long unsigned int'
          ipath_driver.c:1459: warning: format '%Lx' expects type 'long long unsigned int', but argument 4 has type 'u64'
          ipath_intr.c:358: warning: format '%Lx' expects type 'long long unsigned int', but argument 3 has type 'u64'
          ipath_intr.c:358: warning: format '%Lu' expects type 'long long unsigned int', but argument 6 has type 'u64'
          ipath_intr.c:1119: warning: format '%Lx' expects type 'long long unsigned int', but argument 5 has type 'u64'
          ipath_intr.c:1119: warning: format '%Lx' expects type 'long long unsigned int', but argument 3 has type 'u64'
          ipath_intr.c:1123: warning: format '%Lx' expects type 'long long unsigned int', but argument 3 has type 'u64'
          ipath_intr.c:1130: warning: format '%Lx' expects type 'long long unsigned int', but argument 4 has type 'u64'
          ipath_iba7220.c:1032: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'u64'
          ipath_iba7220.c:1045: warning: format '%llX' expects type 'long long unsigned int', but argument 3 has type 'u64'
          ipath_iba7220.c:2506: warning: format '%Lu' expects type 'long long unsigned int', but argument 4 has type 'u64'
      Signed-off-by: default avatarAlexander Beregalov <a.beregalov@gmail.com>
      Cc: Sean Hefty <sean.hefty@intel.com>
      Cc: Hal Rosenstock <hal.rosenstock@gmail.com>
      Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
      70117b9e
    • Steve Wise's avatar
      RDMA/cxgb3: Fix deadlock initializing iw_cxgb3 device · be43324d
      Steve Wise authored
      Running 'ifconfig up' on the cxgb3 interface with iw_cxgb3 loaded
      causes a deadlock.  The rtnl lock is already held in this path.  The
      function fw_supports_fastreg() was introduced in 2.6.27 to
      conditionally set the IB_DEVICE_MEM_MGT_EXTENSIONS bit iff the
      firmware was at 7.0 or greater, and this function also acquires the
      rtnl lock and which thus causes a deadlock.  Further, if iw_cxgb3 is
      loaded _after_ the nic interface is brought up, then the deadlock does
      not occur and therefore fw_supports_fastreg() does need to grab the
      rtnl lock in that path.
      
      It turns out this code is all useless anyway.  The low level driver
      will NOT allow the open if the firmware isn't 7.0, so iw_cxgb3 can
      always set the MEM_MGT_EXTENSIONS bit.  Simplify...
      Signed-off-by: default avatarSteve Wise <swise@opengridcomputing.com>
      Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
      be43324d
    • Steve Wise's avatar
      RDMA/cxgb3: Fix up MW access rights · 1c355a6e
      Steve Wise authored
      - MWs don't have local read/write permissions.
      - Set the MW_BIND enabled bit if a MR has MW_BIND access.
      Signed-off-by: default avatarSteve Wise <swise@opengridcomputing.com>
      Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
      1c355a6e
    • Steve Wise's avatar
      RDMA/cxgb3: Fix QP capabilities · 5f0f66b0
      Steve Wise authored
      - Set the stag0 and fastreg capability bits only for kernel qps.
      - QP_PRIV flag is no longer used, so don't set it.
      Signed-off-by: default avatarSteve Wise <swise@opengridcomputing.com>
      Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
      5f0f66b0
    • Roland Dreier's avatar
      RDMA/cma: Remove padding arrays by using struct sockaddr_storage · 3f446754
      Roland Dreier authored
      There are a few places where the RDMA CM code handles IPv6 by doing
      
      	struct sockaddr		addr;
      	u8			pad[sizeof(struct sockaddr_in6) -
      				    sizeof(struct sockaddr)];
      
      This is fragile and ugly; handle this in a better way with just
      
      	struct sockaddr_storage	addr;
      
      [ Also roll in patch from Aleksey Senin <alekseys@voltaire.com> to
        switch to struct sockaddr_storage and get rid of padding arrays in
        struct rdma_addr. ]
      Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
      3f446754
  3. 30 Jul, 2008 2 commits
    • Vegard Nossum's avatar
      IB/ipath: Use unsigned long for irq flags · 52fd8ca6
      Vegard Nossum authored
      A few functions in the ipath driver incorrectly use unsigned int to
      hold irq flags for spin_lock_irqsave().
      
      This patch was generated using the Coccinelle framework with the
      following semantic patch:
      
      The semantic patch I used was this:
      
      @@
      expression lock;
      identifier flags;
      expression subclass;
      @@
      
      - unsigned int flags;
      + unsigned long flags;
      
      ...
      
      <+...
      
      (
       spin_lock_irqsave(lock, flags)
      |
       _spin_lock_irqsave(lock)
      |
       spin_unlock_irqrestore(lock, flags)
      |
       _spin_unlock_irqrestore(lock, flags)
      |
       read_lock_irqsave(lock, flags)
      |
       _read_lock_irqsave(lock)
      |
       read_unlock_irqrestore(lock, flags)
      |
       _read_unlock_irqrestore(lock, flags)
      |
       write_lock_irqsave(lock, flags)
      |
       _write_lock_irqsave(lock)
      |
       write_unlock_irqrestore(lock, flags)
      |
       _write_unlock_irqrestore(lock, flags)
      |
       spin_lock_irqsave_nested(lock, flags, subclass)
      |
       _spin_lock_irqsave_nested(lock, subclass)
      |
       spin_unlock_irqrestore(lock, flags)
      |
       _spin_unlock_irqrestore(lock, flags)
      |
       _raw_spin_lock_flags(lock, flags)
      |
       __raw_spin_lock_flags(lock, flags)
      )
      
      ...+>
      
      Cc: Ralph Campbell <ralph.campbell@qlogic.com>
      Cc: Julia Lawall <julia@diku.dk>
      Cc: Alexey Dobriyan <adobriyan@gmail.com>
      Signed-off-by: default avatarVegard Nossum <vegard.nossum@gmail.com>
      Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
      52fd8ca6
    • Roland Dreier's avatar
      IPoIB/cm: Set correct SG list in ipoib_cm_init_rx_wr() · e0819816
      Roland Dreier authored
      wr->sg_list should be set to the sge pointer passed in, not
      priv->cm.rx_sge.
      Reported-by: default avatarHoang-Nam Nguyen <HNGUYEN@de.ibm.com>
      Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
      e0819816
  4. 29 Jul, 2008 6 commits
  5. 28 Jul, 2008 23 commits