1. 22 May, 2023 3 commits
  2. 19 May, 2023 1 commit
  3. 18 May, 2023 3 commits
  4. 17 May, 2023 1 commit
  5. 16 May, 2023 2 commits
  6. 15 May, 2023 1 commit
  7. 12 May, 2023 10 commits
  8. 11 May, 2023 2 commits
    • Fei Yang's avatar
      drm/i915: use pat_index instead of cache_level · 9275277d
      Fei Yang authored
      Currently the KMD is using enum i915_cache_level to set caching policy for
      buffer objects. This is flaky because the PAT index which really controls
      the caching behavior in PTE has far more levels than what's defined in the
      enum. In addition, the PAT index is platform dependent, having to translate
      between i915_cache_level and PAT index is not reliable, and makes the code
      more complicated.
      
      From UMD's perspective there is also a necessity to set caching policy for
      performance fine tuning. It's much easier for the UMD to directly use PAT
      index because the behavior of each PAT index is clearly defined in Bspec.
      Having the abstracted i915_cache_level sitting in between would only cause
      more ambiguity. PAT is expected to work much like MOCS already works today,
      and by design userspace is expected to select the index that exactly
      matches the desired behavior described in the hardware specification.
      
      For these reasons this patch replaces i915_cache_level with PAT index. Also
      note, the cache_level is not completely removed yet, because the KMD still
      has the need of creating buffer objects with simple cache settings such as
      cached, uncached, or writethrough. For kernel objects, cache_level is used
      for simplicity and backward compatibility. For Pre-gen12 platforms PAT can
      have 1:1 mapping to i915_cache_level, so these two are interchangeable. see
      the use of LEGACY_CACHELEVEL.
      
      One consequence of this change is that gen8_pte_encode is no longer working
      for gen12 platforms due to the fact that gen12 platforms has different PAT
      definitions. In the meantime the mtl_pte_encode introduced specfically for
      MTL becomes generic for all gen12 platforms. This patch renames the MTL
      PTE encode function into gen12_pte_encode and apply it to all gen12. Even
      though this change looks unrelated, but separating them would temporarily
      break gen12 PTE encoding, thus squash them in one patch.
      
      Special note: this patch changes the way caching behavior is controlled in
      the sense that some objects are left to be managed by userspace. For such
      objects we need to be careful not to change the userspace settings.There
      are kerneldoc and comments added around obj->cache_coherent, cache_dirty,
      and how to bypass the checkings by i915_gem_object_has_cache_level. For
      full understanding, these changes need to be looked at together with the
      two follow-up patches, one disables the {set|get}_caching ioctl's and the
      other adds set_pat extension to the GEM_CREATE uAPI.
      
      Bspec: 63019
      
      Cc: Chris Wilson <chris.p.wilson@linux.intel.com>
      Signed-off-by: default avatarFei Yang <fei.yang@intel.com>
      Reviewed-by: default avatarAndi Shyti <andi.shyti@linux.intel.com>
      Reviewed-by: default avatarMatt Roper <matthew.d.roper@intel.com>
      Signed-off-by: default avatarAndi Shyti <andi.shyti@linux.intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20230509165200.1740-3-fei.yang@intel.com
      9275277d
    • Fei Yang's avatar
      drm/i915: preparation for using PAT index · 5e352e32
      Fei Yang authored
      This patch is a preparation for replacing enum i915_cache_level with PAT
      index. Caching policy for buffer objects is set through the PAT index in
      PTE, the old i915_cache_level is not sufficient to represent all caching
      modes supported by the hardware.
      
      Preparing the transition by adding some platform dependent data structures
      and helper functions to translate the cache_level to pat_index.
      
      cachelevel_to_pat: a platform dependent array mapping cache_level to
                         pat_index.
      
      max_pat_index: the maximum PAT index recommended in hardware specification
                     Needed for validating the PAT index passed in from user
                     space.
      
      i915_gem_get_pat_index: function to convert cache_level to PAT index.
      
      obj_to_i915(obj): macro moved to header file for wider usage.
      
      I915_MAX_CACHE_LEVEL: upper bound of i915_cache_level for the
                            convenience of coding.
      
      Cc: Chris Wilson <chris.p.wilson@linux.intel.com>
      Cc: Matt Roper <matthew.d.roper@intel.com>
      Signed-off-by: default avatarFei Yang <fei.yang@intel.com>
      Reviewed-by: default avatarAndi Shyti <andi.shyti@linux.intel.com>
      Reviewed-by: default avatarAndrzej Hajda <andrzej.hajda@intel.com>
      Signed-off-by: default avatarAndi Shyti <andi.shyti@linux.intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20230509165200.1740-2-fei.yang@intel.com
      5e352e32
  9. 08 May, 2023 3 commits
  10. 05 May, 2023 12 commits
  11. 04 May, 2023 2 commits
    • Daniele Ceraolo Spurio's avatar
      drm/i915/gsc: add support for GSC proxy interrupt · 31cc65b4
      Daniele Ceraolo Spurio authored
      The GSC notifies us of a proxy request via the HECI2 interrupt. The
      interrupt must be enabled both in the HECI layer and in our usual gt irq
      programming; for the latter, the interrupt is enabled via the same enable
      register as the GSC CS, but it does have its own mask register. When the
      interrupt is received, we also need to de-assert it in both layers.
      
      The handling of the proxy request is deferred to the same worker that we
      use for GSC load. New flags have been added to distinguish between the
      init case and the proxy interrupt.
      
      v2: Make sure not to set the reset bit when enabling/disabling the GSC
      interrupts, fix defines (Alan)
      
      v3: rebase on proxy status register check
      Signed-off-by: default avatarDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
      Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
      Reviewed-by: default avatarAlan Previn <alan.previn.teres.alexis@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20230502163854.317653-5-daniele.ceraolospurio@intel.com
      31cc65b4
    • Daniele Ceraolo Spurio's avatar
      drm/i915/gsc: add initial support for GSC proxy · 8a9bf295
      Daniele Ceraolo Spurio authored
      The GSC uC needs to communicate with the CSME to perform certain
      operations. Since the GSC can't perform this communication directly
      on platforms where it is integrated in GT, i915 needs to transfer the
      messages from GSC to CSME and back.
      The proxy flow is as follow:
      1 - i915 submits a request to GSC asking for the message to CSME
      2 - GSC replies with the proxy header + payload for CSME
      3 - i915 sends the reply from GSC as-is to CSME via the mei proxy
          component
      4 - CSME replies with the proxy header + payload for GSC
      5 - i915 submits a request to GSC with the reply from CSME
      6 - GSC replies either with a new header + payload (same as step 2,
          so we restart from there) or with an end message.
      
      After GSC load, i915 is expected to start the first proxy message chain,
      while all subsequent ones will be triggered by the GSC via interrupt.
      
      To communicate with the CSME, we use a dedicated mei component, which
      means that we need to wait for it to bind before we can initialize the
      proxies. This usually happens quite fast, but given that there is a
      chance that we'll have to wait a few seconds the GSC work has been moved
      to a dedicated WQ to not stall other processes.
      
      v2: fix code style, includes and variable naming (Alan)
      v3: add extra check for proxy status, fix includes and comments
      Signed-off-by: default avatarDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
      Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
      Reviewed-by: default avatarAlan Previn <alan.previn.teres.alexis@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20230502163854.317653-4-daniele.ceraolospurio@intel.com
      8a9bf295