1. 25 Mar, 2014 16 commits
  2. 24 Mar, 2014 18 commits
  3. 22 Mar, 2014 6 commits
    • David S. Miller's avatar
      Merge tag 'batman-adv-for-davem' of git://git.open-mesh.org/linux-merge · 860b4042
      David S. Miller authored
      Antonio Quartulli says:
      
      ====================
      Included changes:
      - use ether_addr_copy instead of memcpy when possible
      - implement new multicast packet optimisation
      - improve several kerneldoc sections
      - minor code cleanups
      
      here you have our patchset for net-next/linux-3.15.  They are 16
      patches but most of them are just small cleanups and kerneldoc
      improvements.
      
      The only big change is the one from patch 8 to 13 by Linus Lüssing
      that introduces a new multicast packets optimisation. This new
      component aims to reduce the air overhead by sending multicast packets
      as bat-unicast when only one destination exists or by dropping them
      directly at the source if the multicast group is totally empty.
      
      In patch 11 Linus introduces an atomic_t variable, that like others
      that we already have is only object of write and read, thus making the
      atomic characteristic totally useless.  Unfortunately this is part of
      our sysfs framework, that helps the developer to introduce new knobs
      by using few macros only. For this reason we decided to keep Linus'
      new knob for now, but I'd like to let you know that we are in the
      process of re-working such framework in order to convert all the
      current (useless) atomic_t to boolean in one go.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      860b4042
    • Simon Wunderlich's avatar
    • Antonio Quartulli's avatar
      batman-adv: improve DAT documentation · 151dcb3c
      Antonio Quartulli authored
      Add missing documentation for BATADV_DAT_ADDR_MAX and
      convert an existing documentation to kerneldoc
      Signed-off-by: default avatarAntonio Quartulli <antonio@open-mesh.com>
      Signed-off-by: default avatarMarek Lindner <mareklindner@neomailbox.ch>
      151dcb3c
    • Antonio Quartulli's avatar
      batman-adv: improve the TT flags documentation · 43e6f65a
      Antonio Quartulli authored
      Convert the current documentation for the TT flags in proper
      kerneldoc and improve it by adding an explanation for each
      of the flags.
      Signed-off-by: default avatarAntonio Quartulli <antonio@open-mesh.com>
      Signed-off-by: default avatarMarek Lindner <mareklindner@neomailbox.ch>
      43e6f65a
    • Linus Lüssing's avatar
      batman-adv: Send multicast packets to nodes with a WANT_ALL flag · 4c8755d6
      Linus Lüssing authored
      With this patch a node sends IPv4 multicast packets to nodes which
      have a BATADV_MCAST_WANT_ALL_IPV4 flag set and IPv6 multicast packets
      to nodes which have a BATADV_MCAST_WANT_ALL_IPV6 flag set, too.
      
      Why is this needed? There are scenarios involving bridges where
      multicast report snooping and multicast TT announcements are not
      sufficient, which would lead to packet loss for some nodes otherwise:
      
      MLDv1 and IGMPv1/IGMPv2 have a suppression mechanism
      for multicast listener reports. When we have an MLDv1/IGMPv1/IGMPv2
      querier behind a bridge then our snooping bridge is potentially not
      going to see any reports even though listeners exist because according
      to RFC4541 such reports are only forwarded to multicast routers:
      
      -----------------------------------------------------------
                  ---------------
      {Querier}---|Snoop. Switch|----{Listener}
                  ---------------
                             \           ^
                            -------
                            | br0 |  <  ???
                            -------
                                \
                           _-~---~_
                       _-~/        ~-_
                      ~   batman-adv  \-----{Sender}
                      \~_   cloud    ~/
                         -~~__-__-~_/
      
      I)  MLDv1 Query:  {Querier}  -> flooded
      II) MLDv1 Report: {Listener} -> {Querier}
      
      -> br0 cannot detect the {Listener}
      => Packets from {Sender} need to be forwarded to all
         detected listeners and MLDv1/IGMPv1/IGMPv2 queriers.
      
      -----------------------------------------------------------
      
      Note that we do not need to explicitly forward to MLDv2/IGMPv3 queriers,
      because these protocols have no report suppression: A bridge has no
      trouble detecting MLDv2/IGMPv3 listeners.
      
      Even though we do not support bridges yet we need to provide the
      according infrastructure already to not break compatibility later.
      Signed-off-by: default avatarLinus Lüssing <linus.luessing@web.de>
      Signed-off-by: default avatarMarek Lindner <mareklindner@neomailbox.ch>
      Signed-off-by: default avatarAntonio Quartulli <antonio@meshcoding.com>
      4c8755d6
    • Linus Lüssing's avatar
      batman-adv: Add IPv4 link-local/IPv6-ll-all-nodes multicast support · ab49886e
      Linus Lüssing authored
      With this patch a node may additionally perform the dropping or
      unicasting behaviour for a link-local IPv4 and link-local-all-nodes
      IPv6 multicast packet, too.
      
      The extra counter and BATADV_MCAST_WANT_ALL_UNSNOOPABLES flag is needed
      because with a future bridge snooping support integration a node with a
      bridge on top of its soft interface is not able to reliably detect its
      multicast listeners for IPv4 link-local and the IPv6
      link-local-all-nodes addresses anymore (see RFC4541, section 2.1.2.2
      and section 3).
      
      Even though this new flag does make "no difference" now, it'll ensure
      a seamless integration of multicast bridge support without needing to
      break compatibility later.
      
      Also note, that even with multicast bridge support it won't be possible
      to optimize 224.0.0.x and ff02::1 towards nodes with bridges, they will
      always receive these ranges.
      Signed-off-by: default avatarLinus Lüssing <linus.luessing@web.de>
      Signed-off-by: default avatarMarek Lindner <mareklindner@neomailbox.ch>
      Signed-off-by: default avatarAntonio Quartulli <antonio@meshcoding.com>
      ab49886e