Commits · 099a845251999648b2b24435f48b7486751d1b1b · Kirill Smelkov / linux

15 May, 2014 40 commits

staging: rtl8723au: Eliminate no-op function rtl8723au_init_recvbuf() · 099a8452

Jes Sorensen authored May 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

099a8452

staging: rtl8723au: Remove another unused queue from struct recv_priv · a61b3228

Jes Sorensen authored May 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

a61b3228

staging: rtl8723au: Remove some unused lists from struct sta_priv · 208ceb83

Jes Sorensen authored May 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

208ceb83

staging: rtl8723au: rtw_pwrctrl.c: Reduce spaghettification · d8ab7e84

Jes Sorensen authored May 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

d8ab7e84

staging: rtl8723au: pattrib->priority can't be > 15, no need for CHKBIT() · 561fb403
Jes Sorensen authored May 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
561fb403
staging: rtl8723au: qos_asm23a(): Don't pass through an invalid priority · 7855848e
Jes Sorensen authored May 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
7855848e

staging: rtl8723au: set_qos() keep userpriority in a u8 · c06209d9

Jes Sorensen authored May 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c06209d9

staging: rtl8723au: Another case of missing 'tid' bounds checking. · d7f2c23a

Jes Sorensen authored May 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

d7f2c23a

staging: rtl8723au: 'keyid' is always 0-3, no need for CHKBIT() · 4e489d91

Jes Sorensen authored May 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

4e489d91

staging: rtl8723au: No need for CHKBIT since 16 + 12 is still < 32 · 5a443893

Jes Sorensen authored May 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

5a443893

staging: rtl8723au: tid is 4 bits, so we need a 16 bit value to hold a bitmap · 072fc84d

Jes Sorensen authored May 09, 2014

Remove unused add_enable_bitmap and candidate_tid_bitmap from struct
mlme_ext_info.

In addition we don't need to use CHKBIT when we know we are dealing
with a value in the range 0-15.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

072fc84d

staging: rtl8723au: Remove local #define BIT() · 405c9f50

Jes Sorensen authored May 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

405c9f50

staging: rtl8723au: Call c2h_handler_8723a() directly instead of via HAL interface · 00cf86c9
Jes Sorensen authored May 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
00cf86c9

staging: rtl8723au: The driver only has one c2h_id_filter · 227ca8c4

Jes Sorensen authored May 09, 2014

Since we only have one function for this, there is no point in keeping
the HAL silliness.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

227ca8c4

staging: rtl8723au: c2h_evt_hdl() is always called with 3rd argument = NULL · 849befad
Jes Sorensen authored May 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
849befad

staging: rtl8723au: Declare c2h_evt_hdl static · ab281e3b

Jes Sorensen authored May 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

ab281e3b

staging: rtl8723au: Move rtw_do_join23a() prototype to rtw_ioctl_set.h · 95b0f200

Jes Sorensen authored May 09, 2014

rtw_do_join23a() is declared in rtw_ioctl_set.c so move the prototype
to it's correct place, and remove duplicate protoype from rtw_mlme.c
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

95b0f200

staging: rtl8723au: Move {WPA,RSN}_TKIP_CIPHER23A to rtw_wlan_util.c and mark them static · 78717782
Jes Sorensen authored May 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
78717782
staging: rtl8723au: Move REALTEK96B_IE23A to rtw_mlme_ext.c and mark it static · f85bd052
Jes Sorensen authored May 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
f85bd052

staging: rtl8723au: Remove unused ADPT_{FMT,AGR} macros · d39518a4

Jes Sorensen authored May 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

d39518a4

staging: rtl8723au: Get rid of FUNC_NDEV_{FMT,ARG} · a790d58e

Jes Sorensen authored May 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

a790d58e

staging: rtl8723au: Remove FUNC_ADPT_{FMT,ARG} · 9cd613c7

Jes Sorensen authored May 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

9cd613c7

staging: rtl8723au: Get rid of NDEV_FMT/NDEV_ARG macros · dc24abd4

Jes Sorensen authored May 09, 2014

Silly use-once macros that simply obfuscates the code.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

dc24abd4

staging: rtl8723au: Remove some unused prototypes · 5e3a8299

Jes Sorensen authored May 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

5e3a8299

staging: rtl8723au: Eliminate RTW_STATUS_CODE23a() · be4c5060

Jes Sorensen authored May 09, 2014

Inline the parsing of status codes. Long term we should pass back the
proper status codes and get rid of the ugly _FAIL/_SUCCESS mess. This
is one small step in that direction.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

be4c5060

staging: rtl8723au: Eliminate _rtw_queue_empty23a() · 794ff053

Jes Sorensen authored May 09, 2014

This was just a silly wrapper around list_empty()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

794ff053

staging: rtl8723au: rtw_free_recvframe23a() is always passed precvpriv->free_recv_queue · c5779a0d

Jes Sorensen authored May 09, 2014

No point in passing in the pointer to free_recv_queue, when we always
pass in the same value.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c5779a0d

staging: rtl8723au: Remove unused semaphore 'allrxreturnevt' · a954a18f

Jes Sorensen authored May 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

a954a18f

staging: rtl8723au: Remove ugly vmalloc() wrappers · 6f43d3bd

Jes Sorensen authored May 09, 2014

Finally with the last user converted, get rid of ugly vmalloc wrappers
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

6f43d3bd

staging: rtl8723au: Use kmalloc instead of vmalloc to allocate recv_frame pool · fd6d1c11
Jes Sorensen authored May 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
fd6d1c11

staging: rtl723au: Remove some obsolete misleading comments · 269746a4

Jes Sorensen authored May 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

269746a4

stating: rtl8723au: Use kmalloc instead of vmalloc to allocate pool of xmit_frame_ext · 3a35058f
Jes Sorensen authored May 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
3a35058f
staging: rtl8723au: Use kmalloc() rather than vmalloc() to allocate xmit_frames · 251ccc2d
Jes Sorensen authored May 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
251ccc2d

staging: rtl8723au: Declare rtw_alloc_xmitframe() static · 6042cbfd

Jes Sorensen authored May 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

6042cbfd

staging: rtl8723au: fix potential leak in update_bcn_wps_ie() · 086f7a4d

Christian Engelmayer authored May 09, 2014

Fix a potential leak in the error path of function update_bcn_wps_ie().
Move the affected input verification to the beginning of the function so
that it may return directly without leaking already allocated memory.
Detected by Coverity - CID 1077718.
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

086f7a4d

staging: rtl8723au: Add GFP argument to rtw_alloc_stainfo23a() · 6e8bc71d

Jes Sorensen authored May 09, 2014

No need to allocate GFP_ATOMIC when we don't need to.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

6e8bc71d

staging: rtl8723au: Use kernel memory allocator for sta_priv allocations · 2ad7c3d9

Jes Sorensen authored May 09, 2014

The kernel has a great memory allocator, use it instead of hacking up
something in the driver.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2ad7c3d9

staging: rtl8723au: Eliminate stainfo_by_offset spaghetti · 6964213a

Jes Sorensen authored May 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

6964213a

staging: rtl8723au: add GFP argument to rtw_alloc_network() · ec838b0b

Jes Sorensen authored May 09, 2014

This allows us to use GFP_KERNEL when calling from a work handler.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

ec838b0b

staging: rtl8723au: rtw_createbss_cmd23a_callback(): Relax holding of pmlmepriv->lock · 5290cd68

Jes Sorensen authored May 09, 2014

We only really need to hold pmlmepriv->lock while calling
rtw_indicate_connect23a(). rtw_get_stainfo23a() and
rtw_alloc_stainfo23a() rely on pstapriv->sta_hash_lock and the non
WIFI_AP_STATE path relies on pmlmepvi->scanned_queue.lock, except we
need to used clr_fwstate() instead of _clr_fwstate_().
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

5290cd68