Commits · 0e9596992cfc1b3804d436ccbea97b66aeca00c0 · Kirill Smelkov / linux

15 Apr, 2014 40 commits

staging: rtl8723au: update_TSF() remove unused argument and move to rtw_mlme_ext.c · 0e959699

Jes Sorensen authored Apr 15, 2014

This is only called from rtw_mlme_ext.c, so move it that and declare
it static.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

0e959699

staging: rtl8723au: clean up update_TSF() · 04fad92a

Jes Sorensen authored Apr 15, 2014

Clean up and simplify update_TSF() using proper Linux functions and
move it to rtw_mlme_ext.c which is the only user of it.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

04fad92a

staging: rtl8723au: OnBeacon23a() tidy up code · 9af36808

Jes Sorensen authored Apr 15, 2014

Clean up the excessive if() levels at the end, and use struct
ieee80211_mgmt to calculate pointers passed on to check_assoc_AP23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

9af36808

staging: rtl8723au: rtw_mlme.c: remove commented out debug code · 9aac910a

Jes Sorensen authored Apr 15, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

9aac910a

staging: rtl8723au: Remove buggy function _rtw_report_sec_ie() · 959226ac

Jes Sorensen authored Apr 15, 2014

This function was extremely buggy calling kmalloc(GFP_KERNEL) while
holding a spin lock and then potentially overflowing the buffer it had
allocated.

Since the generated output wasn't used for anything, simply rip the
whole thing out.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

959226ac

staging: rtl8723au: OnProbeReq23a(): is_valid_p2p_probereq is always false · 8e64bc58
Jes Sorensen authored Apr 15, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
8e64bc58

staging: rtl8723au: OnProbeReq23a(): Use struct ieee80211_mgmt · d3c60949

Jes Sorensen authored Apr 15, 2014

Simplify parsing of probe request frame
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

d3c60949

staging: rtl8723au: OnAssocReq23a(): use ieee80211_mgmt to calculate offset · 07d2c3b8
Jes Sorensen authored Apr 15, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
07d2c3b8

staging: rtl8723au: ioctl_cfg80211.c: Use eth_{zero,broadcast},addr() · 43c34be1

Jes Sorensen authored Apr 15, 2014

Use kernel provided macros instead of own hacks.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

43c34be1

staging: rtl8723au: Remove some unused ieee80211 structs · 29f79e05

Jes Sorensen authored Apr 15, 2014

These are duplicated from the kernel headers and not used anymore
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

29f79e05

staging: rtl8723au: Remove unused ieee880211_is_empty_essid() · 30947bbc

Jes Sorensen authored Apr 15, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

30947bbc

staging: rtl8723au: Remove unused dump_wpsie23a() · 5951a5c1

Jes Sorensen authored Apr 15, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

5951a5c1

staging: rtl8723au: Remove struct rtw_ieee802_11_elems and related code · 7e075832

Jes Sorensen authored Apr 15, 2014

This removes the double content tracking of data from IE elements. The
relevant code to validate IEs is moved to rtw_mlme_ext.c as this is
the only place where it is used.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

7e075832

staging: rtl8723au: OnAssocReq23a(): Use cfg80211_find_ie() to locate HT caps · 57ed7bbf

Jes Sorensen authored Apr 15, 2014

Use cfg80211 interface to search for HT capabilities.

This was the last user of struct rtw_ieee802_11_elems, which can now
be removed.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

57ed7bbf

staging: rtl8723au: OnAssocReq23a(): Don't check for presence of BSSID twice · 49ae9a5c
Jes Sorensen authored Apr 15, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
49ae9a5c

staging: rtl8723au: OnAssocReq23a(): Simplify parsing crypto info from the IE · 7d692530

Jes Sorensen authored Apr 15, 2014

This reduces the dependency of rtw_ieee802_11_parse_elems23a() which
is only used in this function. Follow-on patches will remove the
remaining dependencies and get rid of the function.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

7d692530

staging: rtl8723au: update_bcn_vendor_spec_ie(): Go easy on those brackets · ab6fb7a5
Jes Sorensen authored Apr 15, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
ab6fb7a5

staging: rtl8723au: Remove multiple duplicate defines of the WPA OUI · 7964eba0

Jes Sorensen authored Apr 15, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

7964eba0

staging: rtl8723au: Remove unused for_each_ie() and dump_ies23a() · daa5d2f8

Jes Sorensen authored Apr 15, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

daa5d2f8

staging: rtl8723au: Remove obsolete rtw_get_wpa{2,}_ie23a() functions · fcff60e9

Jes Sorensen authored Apr 15, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

fcff60e9

staging: rtl8723au: rtw_cfg80211_set_wpa_ie(): Remove unused variable 'pos' · 9bf29cb9
Jes Sorensen authored Apr 15, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
9bf29cb9

staging: rtl8723au: rtw_cfg80211_set_wpa_ie(): Use cfg80211_ API · 58aedb49

Jes Sorensen authored Apr 15, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

58aedb49

staging: rtl8723au: rtw_check_bcn_info23a(): Use cfg80211 to find WPA info · f88ca604
Jes Sorensen authored Apr 15, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
f88ca604

staging: rtl8723au: rtw_check_bcn_info23a(): Remove excessive brackets · c3761836

Jes Sorensen authored Apr 15, 2014

Remove excessive brackets and some general cleanups
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c3761836

staging: rtl8723au: rtw_get_cipher_info(): Convert to use cfg80211_* API · d7f03698

Jes Sorensen authored Apr 15, 2014

Use cfg80211_find_ie() and cfg80211_find_vendor_ie() rather than own
hacks.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

d7f03698

staging: rtl8723au: Use const * for parsing wpa IEs · 95c4345a

Jes Sorensen authored Apr 15, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

95c4345a

staging: rtl8723au: start_bss_network(): Use cfg80211_find_ie() · 731f9da7

Jes Sorensen authored Apr 15, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

731f9da7

staging: rtl8723au: update_sta_support_rate23a(): Use cfg80211_find_ie() · bf350274
Jes Sorensen authored Apr 15, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
bf350274

staging: rtl8723au: rtw_check_bcn_info23a(): Clean up code obfuscation · 82695d5c

Jes Sorensen authored Apr 15, 2014

There is no point doing a double check of the IE, either we found an
WLAN_EID_SSID or we didn't.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

82695d5c

staging: rtl8723au: rtw_check_bcn_info23a(): Use cfg80211_find_ie() · 3ffa4355

Jes Sorensen authored Apr 15, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

3ffa4355

staging: rtl8723au: Make rtw_check_bcn_info23() take a ieee80211_mgmt pointer · c146551f

Jes Sorensen authored Apr 15, 2014

Clean up the code by passing a struct ieee80211_mgmt pointer instead
of a raw frame pointer. In addition check we receive a beacon frame,
anything else here is an error.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c146551f

staging: rtl8723au: OnBeacon23a(): Use ieee80211_mgmt to calculate ie location · f96355b8
Jes Sorensen authored Apr 15, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
f96355b8

staging: rtl8723au: OnBeacon23a(): Use struct ieee80211_mgmt · ee79b56c

Jes Sorensen authored Apr 15, 2014

We always receive a struct ieee80211_mgmt frame here, using just
ieee80211_hdr doesn't make sense.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

ee79b56c

staging: rtl8723au: rtw_get_cur_max_rate23a(): use cfg80211_find_ie() · f0fcc4f0

Jes Sorensen authored Apr 15, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

f0fcc4f0

staging: rtl8723au: rtw_update_protection23a(): Use cfg80211_find_ie() · 4bf954b2

Jes Sorensen authored Apr 15, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

4bf954b2

staging: rtl8723au: Make mlme_handlers and action_handlers return int · e0facfa9

Jes Sorensen authored Apr 15, 2014

In addition, make them all static and move the prototypes to
rtw_mlme_ext.c.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

e0facfa9

staging: rtl8723au: OnAssocReq23a(): Clean up and use more ieee80211.h · da290c54

Jes Sorensen authored Apr 15, 2014

This converts it to use struct ieee80211_mgmt and cfg80211_find_ie().
In addition fix a potential buffer overrun in the last loop searching
through list WLAN_EID_VENDOR_SPECIFIC elements.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

da290c54

staging: rtl8723au: issue_probersp23a(): various cleanups · 858e6658

Jes Sorensen authored Apr 15, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

858e6658

staging: rtl8723au: issue_asocrsp23a(): Use cfg80211_find_ie() and cleanups · cfe4ecdc
Jes Sorensen authored Apr 15, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
cfe4ecdc
staging: rtl8723au: issue_assocreq23a(): General cleanups and use cfg80211_find_ie() · 0b2b676d
Jes Sorensen authored Apr 15, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
0b2b676d