- 15 Feb, 2024 1 commit
-
-
Colin Ian King authored
The variable id len being initialized with a value that is never read, it is being re-assigned later on in a for-loop. The initialization is redundant and can be removed. Cleans up clang scan build warning: drivers/spi/spi-dw-dma.c:580:17: warning: Although the value stored to 'len' is used in the enclosing expression, the value is never actually read from 'len' [deadcode.DeadStores] Signed-off-by:
Colin Ian King <colin.i.king@gmail.com> Acked-by:
Serge Semin <fancer.lancer@gmail.com> Link: https://msgid.link/r/20240215131603.2062332-1-colin.i.king@gmail.comSigned-off-by:
Mark Brown <broonie@kernel.org>
-
- 13 Feb, 2024 1 commit
-
-
Dan Carpenter authored
Call pci_release_regions(pdev) before returning on this error path. Fixes: 3e7cfd6a ("spi: mchp-pci1xxxx: Add support for DMA in SPI") Signed-off-by:
Dan Carpenter <dan.carpenter@linaro.org> Link: https://msgid.link/r/efc92197-4023-4bfe-bc63-452e7ed112e8@moroto.mountainSigned-off-by:
-
- 09 Feb, 2024 1 commit
-
-
Andy Shevchenko authored
In commit 8caab75f ("spi: Generalize SPI "master" to "controller"") some functions and struct members were renamed. Recent work by Uwe completes this renaming. However, there are plenty of leftovers in the comments and in-code documentation. Update them as well. Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20240209165423.2305493-1-andriy.shevchenko@linux.intel.comSigned-off-by:
-
- 08 Feb, 2024 37 commits
-
-
Krzysztof Kozlowski authored
Use existing typedef for dma_filter_fn to avoid duplicating type definition. Signed-off-by:
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20240208202154.630336-3-krzysztof.kozlowski@linaro.orgSigned-off-by:
-
Krzysztof Kozlowski authored
Add kerneldoc for dma_filter field in struct pl022_ssp_controller. Signed-off-by:
-
Krzysztof Kozlowski authored
Use existing typedef for dma_filter_fn to avoid duplicating type definition. Signed-off-by:
-
Mark Brown authored
Merge series from Tudor Ambarus <tudor.ambarus@linaro.org>: Various simple cleanups for the s3c64xx driver. Tested with gs101-spi.
-
Mark Brown authored
Merge series from Uwe Kleine-König <u.kleine-koenig@pengutronix.de>: This series finishes off the removal of some of the legacy names for SPI controllers and devices.
-
Mark Brown authored
Merge series from Tudor Ambarus <tudor.ambarus@linaro.org>: The Google GCS101 uses a variant of the Samsung SPI controller IP.
-
Thangaraj Samynathan authored
pci1xxxx_spi_transfer_with_dma adds DMA support to copy the data between host cpu buffer and SPI IO Buffer. On DMA Completion interrupt, the next SPI transaction is initiated in isr. Helper functions pci1xxxx_spi_setup, pci1xxxx_spi_setup_dma_from_io, pci1xxxx_spi_setup_dma_to_io and pci1xxxx_start_spi_xfer are added for setting up spi, setting up dma operations, and to start spi transfer respectively. In the existing implementation, codes are replaced with helper functions wherever applicable. Signed-off-by:
Thangaraj Samynathan <thangaraj.s@microchip.com> Link: https://lore.kernel.org/r/20240207080621.30742-3-thangaraj.s@microchip.comSigned-off-by:
-
Thangaraj Samynathan authored
In PCI1xxxx C0, support for DMA in PCIe endpoint is added to enhance the SPI performance. With this support, the performance is improved from 6Mbps to 17Mbps with 20Mhz clock. - DMA Supports two Channels, 0 and 1 - SPI Instance 0 uses chan 0 and SPI Instance 1 uses chan 1 - DMA can be used only if SPI is mapped to PF0 in the multi function endpoint and the MSI interrupt is supported - MSI interrupt of one of the SPI instance is assigned to the DMA and both channels 0 and 1 share the same irq, the MSI address and MSI Data of the irq is obtained and stored in DMA registers to generate interrupt Signed-off-by:
-
Tudor Ambarus authored
Add support for GS101 SPI. GS101 integrates 16 SPI nodes, all with 64 bytes FIFOs. GS101 allows just 32 bit register accesses, otherwise a Serror Interrupt is raised. Do the write reg accesses in 32 bits. Reviewed-by:
Sam Protsenko <semen.protsenko@linaro.org> Signed-off-by:
Tudor Ambarus <tudor.ambarus@linaro.org> Link: https://lore.kernel.org/r/20240207111516.2563218-5-tudor.ambarus@linaro.orgSigned-off-by:
-
Tudor Ambarus authored
Allow SoCs that require 32 bits register accesses to write data in chunks of 8 or 16 bits. One SoC that requires 32 bit register accesses is the google gs101. The operation is rare, thus open code it in the driver rather than making it generic (through asm-generic/io.h). Signed-off-by:
-
Tudor Ambarus authored
There are SoCs (gs101) that allow only 32 bit register accesses. As the requirement is rare enough, for those SoCs we'll open code in the driver some s3c64xx_iowrite{8,16}_32_rep() accessors. Prepare for such addition. Suggested-by: -
Tudor Ambarus authored
Add "google,gs101-spi" dedicated compatible for representing SPI of Google GS101 SoC. Reviewed-by:
Peter Griffin <peter.griffin@linaro.org> Acked-by:
Andi Shyti <andi.shyti@kernel.org> Signed-off-by:
-
Tudor Ambarus authored
val &= ~mask; val |= mask; is equivalent to: val |= mask; Drop the superfluous bitwise NOT operation. Reviewed-by:
-
Tudor Ambarus authored
S3C64XX_SPI_TRAILCNT brings no benefit in terms of name over S3C64XX_SPI_MAX_TRAILCNT. Remove the duplicated definition. Reviewed-by:
-
Tudor Ambarus authored
"samsung,spi-src-clk" and "num-cs" are optional dt properties. Downgrade the message from warning to debug message. Reviewed-by:
-
Tudor Ambarus authored
Drop the blank line and move the logical operation in the body of the function rather than in initialization list. Reviewed-by:
-
Tudor Ambarus authored
ETIMEDOUT is more specific than EIO, use it for wait_for_completion_timeout(). Reviewed-by:
-
Tudor Ambarus authored
Don't monopolize the name. Prepend the driver prefix to the function name. Reviewed-by:
-
Tudor Ambarus authored
DMA submit should just add the dma descriptor to a queue, without firing it. EIO is misleading and hides what happens in DMA. Propagate the dma_submit_error() error code, don't overwrite it. Signed-off-by:
-
Tudor Ambarus authored
Check the return code of dmaengine_slave_config(). Reviewed-by:
-
Tudor Ambarus authored
Move common code outside if else to avoid code duplication. Reviewed-by:
-
Tudor Ambarus authored
Else case is not needed after a return, remove it. Reviewed-by:
-
Tudor Ambarus authored
of_device_id::data is an opaque pointer. No explicit cast is needed. Remove unneeded (void *) casts in of_match_table. Reviewed-by:
-
Tudor Ambarus authored
Fix typo, s/configuartion/configuration. Reviewed-by:
-
Tudor Ambarus authored
The platform id is used as an index into the fifo_lvl_mask array. Platforms can come with a negative device ID, PLATFORM_DEVID_NONE (-1), thus we risked a negative array index. Catch such cases and fail to probe. Reviewed-by:
-
Tudor Ambarus authored
The driver uses u32 and relies on an implicit inclusion of <linux/types.h>. It is good practice to directly include all headers used, it avoids implicit dependencies and spurious breakage if someone rearranges headers and causes the implicit include to vanish. Include the missing header. Signed-off-by:
-
Tudor Ambarus authored
The driver uses GENMASK() but does not include <linux/bits.h>. It is good practice to directly include all headers used, it avoids implicit dependencies and spurious breakage if someone rearranges headers and causes the implicit include to vanish. Include the missing header. Reviewed-by:
-
Tudor Ambarus authored
The driver uses readl() but does not include <linux/io.h>. It is good practice to directly include all headers used, it avoids implicit dependencies and spurious breakage if someone rearranges headers and causes the implicit include to vanish. Include the missing header. Reviewed-by:
-
Tudor Ambarus authored
Sorting headers alphabetically helps locating duplicates, and makes it easier to figure out where to insert new headers. Reviewed-by:
-
Uwe Kleine-König authored
In commit 8caab75f ("spi: Generalize SPI "master" to "controller"") some functions and struct members were renamed. Adapt the documentation accordingly. Acked-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com> Signed-off-by:
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/3d643e22cacff12d3918ad5224baa1d01813d03b.1707324794.git.u.kleine-koenig@pengutronix.deSigned-off-by:
-
Uwe Kleine-König authored
Now that all in-tree users followed the rename, the compat stuff can go away. This completes the renaming started with commit 8caab75f ("spi: Generalize SPI "master" to "controller"") Acked-by:
-
Uwe Kleine-König authored
In commit 8caab75f ("spi: Generalize SPI "master" to "controller"") some functions and struct members were renamed. To not break all drivers compatibility macros were provided. To be able to remove these compatibility macros push the renaming into this driver. Acked-by:
-
Uwe Kleine-König authored
In commit 8caab75f ("spi: Generalize SPI "master" to "controller"") some functions and struct members were renamed. To not break all drivers compatibility macros were provided. To be able to remove these compatibility macros push the renaming into this driver. Acked-by:
Kalle Valo <kvalo@kernel.org> Acked-by:
-
Uwe Kleine-König authored
In commit 8caab75f ("spi: Generalize SPI "master" to "controller"") some functions and struct members were renamed. To not break all drivers compatibility macros were provided. To be able to remove these compatibility macros push the renaming into this driver. Acked-by:
-
Uwe Kleine-König authored
In commit 8caab75f ("spi: Generalize SPI "master" to "controller"") some functions and struct members were renamed. To not break all drivers compatibility macros were provided. To be able to remove these compatibility macros push the renaming into this driver. Reviewed-by:
Herve Codina <herve.codina@bootlin.com> Acked-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by:
-
Uwe Kleine-König authored
In commit 8caab75f ("spi: Generalize SPI "master" to "controller"") some functions and struct members were renamed. To not break all drivers compatibility macros were provided. To be able to remove these compatibility macros push the renaming into this driver. Reviewed-by:
Jarkko Sakkinen <jarkko@kernel.org> Acked-by:
-
Uwe Kleine-König authored
In commit 8caab75f ("spi: Generalize SPI "master" to "controller"") some functions and struct members were renamed. To not break all drivers compatibility macros were provided. To be able to remove these compatibility macros push the renaming into this driver. Acked-by:
Viresh Kumar <viresh.kumar@linaro.org> Acked-by:
-
