- 25 Jul, 2020 2 commits
-
-
Alexander A. Klimov authored
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Signed-off-by:
Alexander A. Klimov <grandmaster@al2klimov.de> Link: https://lore.kernel.org/r/20200723194053.72227-1-grandmaster@al2klimov.deSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Anant Thazhemadam authored
Running the checkpatch.pl script on the file for which patch was created, the following error was found to exist. ERROR: space required after that ',' (ctx:VxV) Fixed the above error which was found on line #721 by inserting a blank space at the appropriate position. Signed-off-by:
Anant Thazhemadam <anant.thazhemadam@gmail.com> Link: https://lore.kernel.org/r/20200725122041.5663-1-anant.thazhemadam@gmail.comSigned-off-by:
-
- 23 Jul, 2020 9 commits
-
-
Priti Chattopadhyay authored
Modify equality comparison involving constants by shifting the constant operand to the right side of the comparison as suggested by scripts/checkpatch.pl Signed-off-by:
Priti Chattopadhyay <pritias81@gmail.com> Link: https://lore.kernel.org/r/20200723092150.y34bentngeeci2oc@pritichattopadhyaySigned-off-by:
-
Fox Chen authored
This cleans up open brace issues reported by checkpatch.pl Signed-off-by:
Fox Chen <foxhlchen@gmail.com> Link: https://lore.kernel.org/r/20200723093002.6175-1-foxhlchen@gmail.comSigned-off-by:
-
Muhammad Usama Anjum authored
Remove a coding style error. It makes code more readable. Signed-off-by:
Muhammad Usama Anjum <musamaanjum@gmail.com> Link: https://lore.kernel.org/r/20200723132123.GA26221@musamaanjumSigned-off-by:
-
Colin Ian King authored
The variables scsicmd_id and rc is being initialized with a value that is never read and are being updated later with a new value. The initializations are redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by:Colin Ian King <colin.king@canonical.com> Link: https://lore.kernel.org/r/20200723155415.994036-1-colin.king@canonical.comSigned-off-by:
-
Muhammad Usama Anjum authored
This patch fixes the checkpatch.pl warning: WARNING: Missing or malformed SPDX-License-Identifier tag Add a the SPDX-License-Identifier tag on line 1 Other files in this folder have GPL-2.0 license. So this file should have the same license which was missing before and checkpatch.pl was giving the warning. Signed-off-by:
-
Mrinal Pandey authored
Only a single tab space is required after the if statement. Fix this issue by running scripts/checkpatch.pl on the file. Signed-off-by:
Mrinal Pandey <mrinalmni@gmail.com> Link: https://lore.kernel.org/r/20200722151900.5dcebtavkdi5cc77@mrinalpandeySigned-off-by:
-
Anmol Karn authored
This cahnge fixes a checkpatch error for "code indent should use tabs where possible". compile Tested only [Linux-next-20200722] Signed-off-by:
Anmol Karn <anmol.karan123@gmail.com> Link: https://lore.kernel.org/r/20200723072115.408070-1-anmol.karan123@gmail.comSigned-off-by:
-
Michael Straube authored
Replace tabs with spaces in declarations to cleanup whitespace in rtl8188eu_recv.c. Signed-off-by:
Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20200723075243.21924-2-straube.linux@gmail.comSigned-off-by:
-
Michael Straube authored
Clear checkpatch alignment style issues in rtl8188eu_recv.c. CHECK: Alignment should match open parenthesis The file is now checkpatch clean. Signed-off-by:
-
- 22 Jul, 2020 7 commits
-
-
Greg Kroah-Hartman authored
Merge tag 'iio-for-5.9b' of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio into staging-next Jonathan writes: Second set of new device support, cleanups etc for IIO/Counters in the 5.9 cycle There are two merge commits in here of immutable branches that may also be picked up through other trees (clocksource and input) I've put a few late breaking fixes in here that aren't worth rushing in before the merge window. One major fix for an issue introduced in the last set that can result in devices not having their parent set. This set is dominated by W=1 cleanups from Lee Jones. I won't list them all separately. They are mostly: * Kernel doc fixes * Unused variable removal. * Suppression of unused stuff that is static in headers. Counters subsystem * atmel-tcb - New counter driver after various cleanups of existing tcb code and bindings. Device support * stk311 - Trivial addition of ID for STK311-X variant. yaml conversions * kionix,kxsd9 * ti,ads8688 Features * jz47xx - Add support for touch screen channels. In this particular case the boards in question actually wire a joystick to them so we want them as simple voltage channels. The joystick driver will probably go via the input tree. Cleanups + fixes * core - A rebase issue in recent major refactoring dropped the assignment of of the device parent in the core. Put it back. * ad5592r - Fix unbalanced mutex unlocks in *_read_raw() * ad7124 - Move chip ID and name to the chip_info table plus add a read of the revision register to check the device is working during probe. * ad7192 - Ridy up ordering to put the match table near the end fo the file where it is used. * lsm6dsx - Reset the hardware timestamp after a resume to avoid an issue with missaligned timestamps after suspend. * jz47xx - Error checks on clk_enable() calls. - xlate callaback to find channel index. - Use separate chan_spec arrays for different variants rather than parts of a single list. Simplifies code. * tag 'iio-for-5.9b' of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio: (69 commits) iio: imu: st_lsm6dsx: reset hw ts after resume iio: dac: ad5592r: fix unbalanced mutex unlocks in ad5592r_read_raw() iio: core: fix/re-introduce back parent assignment iio: adc: ad7124: move chip ID & name on the chip_info table counter: Add microchip TCB capture counter dt-bindings: counter: microchip-tcb-capture counter dt-bindings: microchip: atmel,at91rm9200-tcb: add sama5d2 compatible dt-bindings: atmel-tcb: convert bindings to json-schema ARM: at91: add atmel tcb capabilities IIO: Ingenic JZ47xx: Add touchscreen mode. dt-bindings: iio/adc: Add touchscreen idx for JZ47xx SoC ADC iio/adc: ingenic: Retrieve channels list from soc data struct IIO: Ingenic JZ47xx: Add xlate cb to retrieve correct channel idx IIO: Ingenic JZ47xx: Error check clk_enable calls. dt-bindings: iio: ti,ads8688 yaml conversion iio: light: stk3310: add chip id for STK3311-X variant dt-bindings: iio: accel: kionix,kxsd9 yaml conversion. iio: adc: ad7192: move ad7192_of_match table closer to the end of the file iio: adc: rockchip_saradc: Demote seemingly unintentional kerneldoc header iio: imu: st_lsm6dsx: st_lsm6dsx: Mark 'st_lsm6dsx_accel_ext_info' as __maybe_unused ...
-
Lorenzo Bianconi authored
Reset hw time samples generator after system resume in order to avoid disalignment between system and device time reference since FIFO batching and time samples generator are disabled during suspend. Fixes: 21345107 ("iio: imu: st_lsm6dsx: add hw timestamp support") Tested-by:
Sean Nyekjaer <sean@geanix.com> Signed-off-by:
Lorenzo Bianconi <lorenzo@kernel.org> Cc: <Stable@vger.kernel.org> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Alexandru Ardelean authored
There are 2 exit paths where the lock isn't held, but try to unlock the mutex when exiting. In these places we should just return from the function. A neater approach would be to cleanup the ad5592r_read_raw(), but that would make this patch more difficult to backport to stable versions. Fixes 56ca9db8: ("iio: dac: Add support for the AD5592R/AD5593R ADCs/DACs") Reported-by:
Charles Stanhope <charles.stanhope@gmail.com> Signed-off-by:
Alexandru Ardelean <alexandru.ardelean@analog.com> Cc: <Stable@vger.kernel.org> Signed-off-by:
-
Jonathan Cameron authored
Series needed as base for a clocksource tree hence immutable branch
-
Jonathan Cameron authored
Immutable branch may be needed in input for a joystick set that is dependent on it.
-
Alexandru Ardelean authored
This was introduced initially via commit 78289b4a ("iio: core: pass parent device as parameter during allocation"), but was accidentally removed via commit 6d4ebd56 ("iio: core: wrap IIO device into an iio_dev_opaque object"). This looks like a rebase gone wrong, and ends up breaking devicetree bindings of IIO clients. This change adds back the parent assignment. Fixes 6d4ebd56: ("iio: core: wrap IIO device into an iio_dev_opaque object") Reported-by:
Dmitry Baryshkov <dbaryshkov@gmail.com> Signed-off-by:
-
Alexandru Ardelean authored
This change does the following: * removes the SPI device table in favor of the OF device table * adds 'name' && 'chip_id' fields to chip_info * implements chip ID & silicon revision checking; the device ID for AD7124-4 is 0x0, so just checking that value can be useless; but at least the silicon revision isn't 0, so a non-zero value can be used to check that "a" device is on the SPI bus; it's probably the best way to narrow it down to one of the 2 AD7124 chip IDs Signed-off-by:
-
- 21 Jul, 2020 11 commits
-
-
Ioana Ciornei authored
Avoid getting into a WARNING as below by checking, while in the prepare state of the transactional operation, if there is space for a new VLAN. If we reached the maximum number, return an appropriate error. [ 6503.657564] eth3: Commit of object (id=1) failed. [ 6503.657588] WARNING: CPU: 2 PID: 17144 at net/switchdev/switchdev.c:277 switchdev_port_obj_add_now+0xcc/0x110 ... [ 6503.657628] x1 : 70887ce26695c500 x0 : 0000000000000000 [ 6503.657630] Call trace: [ 6503.657633] switchdev_port_obj_add_now+0xcc/0x110 [ 6503.657635] switchdev_port_obj_add+0x40/0xc0 [ 6503.657638] br_switchdev_port_vlan_add+0x50/0x78 [ 6503.657640] __vlan_add+0x2dc/0x758 [ 6503.657642] nbp_vlan_add+0xc0/0x180 [ 6503.657644] br_vlan_info.isra.0+0x68/0x128 [ 6503.657646] br_process_vlan_info+0x224/0x2f8 [ 6503.657647] br_afspec+0x158/0x188 [ 6503.657649] br_setlink+0x1a4/0x290 Signed-off-by:
Ioana Ciornei <ioana.ciornei@nxp.com> Link: https://lore.kernel.org/r/20200721091919.20394-7-ioana.ciornei@nxp.comSigned-off-by:
-
Ioana Ciornei authored
Rely on the port state seen by the firmware since it will also be the one erroring out when trying to setup anything major when the port is up. Signed-off-by:
-
Ioana Ciornei authored
We should destroy the switch workqueue only after deregistering the switchdev notifiers. Without this fix, we could end up with switchdev notifications on a draining workqueue and also with a lock up since the netdevice reference count is increased (in port_switchdev_event) and not decreased ever (since the workqueue did not run). Signed-off-by:
-
Ioana Ciornei authored
Setup the STP state for all VLANs installed on the port. This is also avoiding the error situation when the DEFAULT_VLAN_ID is not installed on the port (thus the firmware complains that it cannot setup the required STP state). Signed-off-by:
-
Ioana Ciornei authored
Error out when the user tries to bridge two switch interfaces that are from different DPSW instances. This is not supported by the hardware and we should reflect this into what the user is aware of. Signed-off-by:
-
Ioana Ciornei authored
Since now we have a notifier block for each DPSW instance probed, we have to also check that the netdev is indeed connected to the notifier received. Without this, we end up with the same switchdev callback being executed multiple times (because it would be received by all notifier blocks, not just the one intended to). Also, move the function higher in the source file because it will be used in later patches from multiple places. Signed-off-by:
-
Suraj Upadhyay authored
Replace depracated MSI IRQ enablers and disablers with pci_alloc_irq_vectors and pci_free_irq_vectors respectively. Compile tested. Signed-off-by:
Suraj Upadhyay <usuraj35@gmail.com> Link: https://lore.kernel.org/r/20200719143404.GA32519@blackclownSigned-off-by:
-
Marian Posteuca authored
Fix the fallthrough warning that is reported by checkpatch. Signed-off-by:
Marian Posteuca <posteuca@mutex.one> Link: https://lore.kernel.org/r/20200720064205.10323-1-posteuca@mutex.oneSigned-off-by:
-
Darshan D V authored
As the code indent for a conditional statement is not according to the preferred coding style for the linux kernel, add code indent as necessary after a conditional statement. Signed-off-by:
Darshan D V <darshandv10@gmail.com> Link: https://lore.kernel.org/r/20200720091442.19532-2-darshandv10@gmail.comSigned-off-by:
-
Darshan D V authored
Fix the coding style error by adding a space before open parenthesis '(' in a conditional statement. Signed-off-by: -
Sumera Priyadarsini authored
This patch fixes the file cfg80211.c to avoid the checkpatch.pl warning: CHECK: Alignment should match open parenthesis Signed-off-by:
Sumera Priyadarsini <sylphrenadin@gmail.com> Link: https://lore.kernel.org/r/20200720122817.31164-1-sylphrenadin@gmail.comSigned-off-by:
-
- 20 Jul, 2020 11 commits
-
-
Kamel Bouhara authored
This drivers allows to use the capture mode of the Timer Counter Block hardware block available in Microchip SoCs through the counter subsystem. Two functions of the counter are supported for the moment: period capture and quadrature decoder. The latter is only supported by the SAMA5 series of SoCs. For the period capture mode a basic setup has been chosen that will reset the counter each time the period is actually reached. Of course the device offers much more possibilities. For quadrature mode, both channel 0 and 1 must be configured even if we only capture the position (no revolution/rotation). Signed-off-by:
Kamel Bouhara <kamel.bouhara@bootlin.com> Signed-off-by:
-
Kamel Bouhara authored
Describe the devicetree binding for the Microchip TCB module. Each counter blocks exposes three independent counters. However, when configured in quadrature decoder, both channel <0> and <1> are required for speed/position and rotation capture (yet only the position is captured). Signed-off-by:
Rob Herring <robh@kernel.org> Signed-off-by:
-
Alexandre Belloni authored
The sama5d2 TC block TIMER_CLOCK1 is different from the at91sam9x5 one. Instead of being MCK / 2, it is the TCB GCLK. Signed-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by:
-
Alexandre Belloni authored
Convert Atmel Timer Counter Blocks bindings to DT schema format using json-schema. Also move it out of mfd as it is not and has never been related to mfd. Signed-off-by:
-
Kamel Bouhara authored
Some atmel socs have extra tcb capabilities that allow using a generic clock source or enabling a quadrature decoder. Signed-off-by:
-
Artur Rojek authored
The SADC component in JZ47xx SoCs provides support for touchscreen operations (pen position and pen down pressure) in single-ended and differential modes. The touchscreen component of SADC takes a significant time to stabilize after first receiving the clock and a delay of 50ms has been empirically proven to be a safe value before data sampling can begin. Of the known hardware to use this controller, GCW Zero and Anbernic RG-350 utilize the touchscreen mode by having their joystick(s) attached to the X/Y positive/negative input pins. JZ4770 and later SoCs introduce a low-level command feature. With it, up to 32 commands can be programmed, each one corresponding to a sampling job. It allows to change the low-voltage reference, the high-voltage reference, have them connected to VCC, GND, or one of the X-/X+ or Y-/Y+ pins. This patch introduces support for 6 stream-capable channels: - channel #0 samples X+/GND - channel #1 samples Y+/GND - channel #2 samples X-/GND - channel #3 samples Y-/GND - channel #4 samples X+/X- - channel #5 samples Y+/Y- Being able to sample X-/GND and Y-/GND is useful on some devices, where one joystick is connected to the X+/Y+ pins, and a second joystick is connected to the X-/Y- pins. All the boards which probe this driver have the interrupt provided from Device Tree, with no need to handle a case where the IRQ was not provided. Co-developed-by:
Paul Cercueil <paul@crapouillou.net> Signed-off-by:
Artur Rojek <contact@artur-rojek.eu> Signed-off-by:
-
Artur Rojek authored
Introduce support for touchscreen channels found in JZ47xx SoCs. Signed-off-by:
-
Paul Cercueil authored
Instead of having one array of struct iio_chan_spec for all SoCs, and have some SoCs remove the last item of the array as they can't use it, have each SoC define its array of supported channels. Signed-off-by:
-
Artur Rojek authored
Provide an of_xlate callback in order to retrieve the correct channel specifier index from the IIO channels array. Signed-off-by:
-
Artur Rojek authored
Introduce error checks for the clk_enable calls used in this driver. As part of the changes, move clk_enable/clk_disable calls out of ingenic_adc_set_config and into respective logic of its callers. Signed-off-by:
-
Alexander A. Klimov authored
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`: If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`: If both the HTTP and HTTPS versions return 200 OK and serve the same content: Replace HTTP with HTTPS. Signed-off-by:
-
