- 16 Oct, 2016 40 commits
-
-
Bhumika Goyal authored
Some type conversions like casting a pointer to a pointer of same type, casting to the original type using addressof(&) operator etc. are not needed. Therefore, remove them. Done using coccinelle: @@ type t; t *p; t a; @@ ( - (t)(a) + a | - (t *)(p) + p | - (t *)(&a) + &a ) Signed-off-by:
Bhumika Goyal <bhumirks@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Bhumika Goyal authored
Some type conversions like casting a pointer to a pointer of same type, casting to the original type using addressof(&) operator etc. are not needed. Therefore, remove them. Done using coccinelle: @@ type t; t *p; t a; @@ ( - (t)(a) + a | - (t *)(p) + p | - (t *)(&a) + &a ) Signed-off-by:
-
Jakub Jedelsky authored
Block comments should align the * on each line as reported by checkpatch Signed-off-by:
Jakub Jedelsky <jakub.jedelsky@gmail.com> Signed-off-by:
-
Elizabeth Ferdman authored
Fix checkpatch error "missing blank line after declarations" to conform to kernel coding style. Signed-off-by:
Elizabeth Ferdman <gnudevliz@gmail.com> Signed-off-by:
-
Elizabeth Ferdman authored
Fix checkpatch error "open brace should be on previous line" since only functions should have their opening brace on a new line. Signed-off-by:
-
Benoit Hiller authored
Fixes the following sparse warning: drivers/staging/dgnc/dgnc_tty.c:933:19: warning: symbol 'find_board_by_major' was not declared. Should it be static? Signed-off-by:
Benoit Hiller <benoit.hiller@gmail.com> Signed-off-by:
-
Wayne Porter authored
Checkpatch found multiple assignments on one line so move them to their own lines. Signed-off-by:
Wayne Porter <wporter82@gmail.com> Signed-off-by:
-
Wayne Porter authored
Covert CamelCase as checkpatch suggests Signed-off-by:
-
Wayne Porter authored
Checkpatch recommended changes Signed-off-by:
-
Wayne Porter authored
Issues found with checkpatch Signed-off-by:
-
Wayne Porter authored
Checkpatch detected multiple instances of logical continuation warnings Signed-off-by:
-
Wayne Porter authored
Coding style checks found by checkpatch Signed-off-by:
-
Wayne Porter authored
Change alignment to match open parenthesis Signed-off-by:
-
Bhumika Goyal authored
Declare the structure v4l2_ioctl_ops as const as it is only stored in the ioctl_ops field of video_device structure. As this field is of type const struct v4l2_ioctl_ops *, so v4l2_ioctl_ops structures having this property can also be made const. Done using coccinelle: @r1 disable optional_qualifier @ identifier i; position p; @@ static struct v4l2_ioctl_ops i@p = {...}; @ok1@ identifier r1.i; position p; struct video_device s; @@ s.ioctl_ops=&i@p; @bad@ position p!={r1.p,ok1.p}; identifier r1.i; @@ i@p @depends on !bad disable optional_qualifier@ identifier r1.i; @@ static +const struct v4l2_ioctl_ops i={...}; @depends on !bad disable optional_qualifier@ identifier r1.i; @@ +const struct v4l2_ioctl_ops i; File size before: text data bss dec hex filename 20465 3220 32 23717 5ca5 drivers/staging/media/bcm2048/radio-bcm2048.o File size after: text data bss dec hex filename 21425 2260 32 23717 5ca5 drivers/staging/media/bcm2048/radio-bcm2048.o Signed-off-by:Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
-
Elise Lennion authored
Fix checkpatch warning: WARNING: Block comments use a trailing */ on a separate line Signed-off-by:
Elise Lennion <elise.lennion@gmail.com> Signed-off-by:
-
Sabitha George authored
This patch replaces inclusion of asm/atomic.h with linux/atomic.h and asm/io.h with linux/io.h to fix checkpatch warning in ks_wlan.h Signed-off-by:
Sabitha George <sabitha.george@gmail.com> Signed-off-by:
-
Mihaela Muraru authored
This is a patch to ks_hostif.c file that fixes up a checkpatch.pl WARNING: void function return statements are not generally useful. The 'return' statement is not useful here, because it is not necessary to be forced the exit of the function. Signed-off-by:
Mihaela Muraru <mihaela.muraru21@gmail.com> Signed-off-by:
-
Mihaela Muraru authored
Fix a issue found by checkpatch.pl tool: "WARNING: __packed is preferred over __attribute__((packed))". Replace __attribute__((packed)) with __packed. Signed-off-by:
-
Ebru Akagunduz authored
This patch removes else statement which is not usefull after a return. Issue found by checkpatch.pl. Signed-off-by:
Ebru Akagunduz <ebru.akagunduz@gmail.com> Signed-off-by:
-
Pontus Fuchs authored
Convert to %pM instead of custom code. Signed-off-by:
Pontus Fuchs <pontus.fuchs@gmail.com> Signed-off-by:
-
Pontus Fuchs authored
sdio functions takes unsigned int as address. No need to cast. Signed-off-by:
-
Muraru Mihaela authored
This is a patch to the ks_wlan_net.c file that fixes up a brace coding style warning found by checkpatch.pl tool, by deleting the unnecessary braces for single statement blocks. Signed-off-by:
-
Muraru Mihaela authored
This patch fixes a coding style WARNING: Missing a blank line after declaration, found by checkpatch.pl. By adding a blank line after declaration of a variable. Signed-off-by:
-
Philipp Hoefflin authored
Fix checkpatch "ERROR: exactly one space required after that #ifdef" error in ks_hostif.c. Signed-off-by:
Philipp Hoefflin <p.hoefflin@posteo.de> Signed-off-by:
-
Philipp Hoefflin authored
Reformat the makro ps_confirm_wait_inc() to fix several checkpatch errors and warnings: - ERROR: space required before the open brace '{' - ERROR: space required before the open parenthesis '(' - ERROR: code indent should use tabs where possible - ERROR: space required after that close brace '}' - ERROR: space required before the open parenthesis '(' - WARNING: line over 80 characters - WARNING: please, no spaces at the start of a line Signed-off-by: -
Philipp Hoefflin authored
Fix all occurences of checkpatch "ERROR: code indent should use tabs where possible" errors in ks_hostif.c. Signed-off-by:
-
Philipp Hoefflin authored
Fix all occurences of the following checkpatch errors in ks_hostif.c: - ERROR: space prohibited after that '&' (ctx:WxW) - ERROR: space prohibited after that open parenthesis '(' - ERROR: space prohibited before that close parenthesis ')' Signed-off-by: -
Juliana Rodrigues authored
Fixes a tabstop alignment checkpatch issue by removing extra blank spaces. Signed-off-by:
Juliana Rodrigues <juliana.orod@gmail.com> Signed-off-by:
-
Juliana Rodrigues authored
Removes unecessary parenthesis from rtw_led.c file that were causing checkpatch warnings. Signed-off-by:
-
Bhumika Goyal authored
Remove the functions sleep_schedulable, down_scanned_network, up_scanned_network and get_free_xmit_queue as they are not used anywhere in the kernel. Functions detected using coccinelle but changes done by hand. Script: @initialize:python@ @@ def display(name,p): print(name,p[0].file) @r1@ identifier func; type T; position p; @@ static T func@p(...) { ... } @r@ identifier r1.func; @@ func @script:python depends on !r@ func << r1.func; p << r1.p; @@ display(func,p) Signed-off-by: -
Bhumika Goyal authored
Declare the structure rtllib_qos_parameters as constant as it is only passed as the second argument to the function memcpy. This argument is constant so the fields of rtllib_qos_parameters structure are never modified and hence it can be declared as const. Done using coccinelle: @r1 disable optional_qualifier @ identifier i; position p; @@ static struct rtllib_qos_parameters i@p = {...}; @ok1@ identifier r1.i; position p; expression e1,e2; @@ memcpy(e1,&i@p,e2) @bad@ position p!={r1.p,ok1.p}; identifier r1.i; @@ i@p @depends on !bad disable optional_qualifier@ identifier r1.i; @@ static +const struct rtllib_qos_parameters i={...}; @depends on !bad disable optional_qualifier@ identifier r1.i; @@ +const struct rtllib_qos_parameters i; File size before: text data bss dec hex filename 30910 496 201 31607 7b77 drivers/staging/rtl8192e/rtl8192e/rtl_core.o File size after: text data bss dec hex filename 30942 464 201 31607 7b77 drivers/staging/rtl8192e/rtl8192e/rtl_core.o Signed-off-by: -
Elise Lennion authored
Fix checkpatch warning: WARNING: printk() should include KERN_ facility level New checkpatch warning appears after including KERN_ facility level. Fix checkpatch warning: WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... Signed-off-by:
-
Wayne Porter authored
Cleanup extra line found by checkpatch.pl Signed-off-by:
-
Elise Lennion authored
Fix checkpath warning: WARNING: Missing a blank line after declarations. Signed-off-by:
-
Elise Lennion authored
Fix checkpatch warning: WARNING: Block comments use a trailing */ on a separate line Signed-off-by:
-
Juliana Rodrigues authored
Renames the camelcased variable ANL_currFC to anl_curr_fc in order to fix a checkpatch warning. Signed-off-by:
-
Juliana Rodrigues authored
Renames the camelcased variable ASL_currBSS to asl_curr_bss in order to fix a checkpatch warning. Signed-off-by:
-
Juliana Rodrigues authored
Renames the camelcased variable CQ_currBSS to cq_curr_bss in order to fix a checkpatch warning. Signed-off-by:
-
Juliana Rodrigues authored
Renames the camelcased struct hfa384x_authenticateStation_data to hfa384x_authenticate_station_data in order to fix a checkpatch warning. Signed-off-by:
-
Juliana Rodrigues authored
Renames the camelcased struct hfa384x_AssocStatus to hfa384x_assoc_status in order to fix a checkpatch warning. Signed-off-by:
-
