- 27 Nov, 2018 15 commits
-
-
Nicolas Saenz Julienne authored
Moves the allocation of a chardev region and class creation to the init function of the driver since those functions are meant to be run on a per driver basis, as opposed to the code run in the probe function which is run in a per device basis. Signed-off-by:
Nicolas Saenz Julienne <nsaenzjulienne@suse.de> Acked-by:
Stefan Wahren <stefan.wahren@i2se.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Nicolas Saenz Julienne authored
We update sync to reflect that the firmware version is compatible with that option. We don't need to check both of them again further down the code. Signed-off-by:
-
Nicolas Saenz Julienne authored
All the memory operations featured in this file modify/access memory that is only accessed by the CPU. So we can assume that all the memory barrier handling done by the completion routines is good enough for us. Signed-off-by:
-
Nicolas Saenz Julienne authored
It is preferred in the kernel to avoid using semaphores to wait for events, as they are optimised for the opposite situation; where the common case is that they are available and may block only occasionally. FYI see this thread: https://lkml.org/lkml/2008/4/11/323. Also completions are semantically more explicit in this case. Signed-off-by:
-
Nicolas Saenz Julienne authored
It's the first thing remote_event_signal() does. Signed-off-by:
-
Nicolas Saenz Julienne authored
vchiq_init_state() initialises a series of semaphores to then call remote_event_create() on the same semaphores, which initializes them again. We get rid of the second initialization. Signed-off-by:
-
Nicolas Saenz Julienne authored
vchiq_init_state() checks the initial contents of slot_zero are correct. These are set in vchiq_init_slots(), using the same hard-coded defaults as the checks. Both functions are called sequentially and Video Core isn't yet aware of the slot's address. There is no way the contents of slot_zero changed in between functions, making the checks useless. Signed-off-by:
-
Nicolas Saenz Julienne authored
VCHIQ bulk transfers are what most people call DMA transfers. The CPU sends a list of physical addresses to the VideoCore which then access the memory directly without the need for CPU interaction. With this setup we call the CPU the "slave" and the VideoCore the "master". There seems to be an option to switch roles in vchiq. Which nobody is using nor is properly implemented. So we get rid of the "is_master == 1" option, and all the related code. Signed-off-by:
-
Nicolas Saenz Julienne authored
The function is passed to vchiq_core.c for it to go trough all the transfer elements (an array of pointers to data) and copy them into the actual transfer memory (contiguous memory). The logic in the function was "copy an element and return, except when the element is empty, in which case look for the next non-empty element and copy it. The function will be called as many times as necessary until all the elements are copied". Now, this approach already forces the function to loop around elements and felt convoluted, so it was changed to a more straightforward "Copy all the elements into memory as long as they fit". The resulting function is shorter and simpler. Signed-off-by:
-
Nicolas Saenz Julienne authored
The concept of VCHI_MEM_HANDLE_T is introduced by this header file and was meant to be used with bulk transfers. After a quick look in vchiq_core.c it is pretty clear that it actually accomplishes nothing nor alters the bulk transfers in any way. Signed-off-by:
-
Nicolas Saenz Julienne authored
The resulting code is way more readeable and intuitive compared to plain list_for_each. Signed-off-by:
-
Nicolas Saenz Julienne authored
No one is using the API neither in the actual staging tree nor in the downstream tree (https://github.com/raspberrypi/linux). Signed-off-by:
-
Nicolas Saenz Julienne authored
The implementation of both IOCTLS was the same except for one function call. This joins both implementations and updates the code to avoid unneeded indentations. Signed-off-by:
-
Nicolas Saenz Julienne authored
The function is overly complicated for what it's ultimately achieving. It's simply filling up a structure. Signed-off-by:
-
Ricardo Silva authored
To comply with checkpatch. CHECK: Lines should not end with a '(' +u8 rtl_mrate_idx_to_arfr_id( Signed-off-by:Ricardo Silva <ricsilvs1@gmail.com> Signed-off-by:
-
- 26 Nov, 2018 17 commits
-
-
Cristian Sicilia authored
Some parameters are aligned with parentheses. Some parentheses was opened at end of line. Signed-off-by:
Cristian Sicilia <sicilia.cristian@gmail.com> Signed-off-by:
-
Sergio Paracuellos authored
There is no clock driver for ralink mips and clk_enable are no-ops for this architecture. This has been also tested without using clocks and seems to work so avoid to use them in this driver. Fixes: ad9c87e1: "staging: mt7621-pci: parse and init port data from device tree" Reported-by:
NeilBrown <neil@brown.name> Signed-off-by:
Sergio Paracuellos <sergio.paracuellos@gmail.com> Tested-by:
-
Sergio Paracuellos authored
Depending of chip revision reset lines are inverted. It is also necessary to read PCIE_FTS_NUM register before enabling the phy. Hence update the code to achieve this. Fixes: 745eeeac ("staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function") Reported-by:
-
Sergio Paracuellos authored
The sysctl register are already claimed by palmbus, so pci fails to claim it. Device tree has been updated to not use it at all with pcie. Update bindings documentation. Signed-off-by:
-
Sergio Paracuellos authored
The sysctl register are already claimed by palmbus, so pci fails to claim it. Remove registers accordly from DT bindings. Fixes: 624c5227: staging: mt7621-dts: add sysctl registers base address to pcie Reported-by:
-
Sergio Paracuellos authored
The sysctl register are already claimed by palmbus, so pci fails to claim it. The best way to access the sysc registers is to use rt_sysc_[rwm]32(). Fixes: 89e9f6e6: staging: mt7621-pci: remap and use sysctl from device tree Reported-by:
-
Michael Straube authored
Add a test for successful call to cdev_alloc() to avoid potential null dereference. Issue reported by smatch. Signed-off-by:
Michael Straube <straube.linux@gmail.com> Fixes: 874bcba6 ("staging: pi433: New driver") Signed-off-by:
-
Wen Yang authored
The null check on &padapter->registrypriv is redundant since registrypriv is a struct inside padapter and can never be null, so the check is always true. we may remove it. Signed-off-by:
Wen Yang <wen.yang99@zte.com.cn> CC: devel@driverdev.osuosl.org CC: linux-kernel@vger.kernel.org Signed-off-by:
-
Michael Straube authored
Cleanup lines over 80 characters by replacing tabs with spaces or adding appropriate line breaks. Signed-off-by:
-
Michael Straube authored
Correct indentation to clear a checkpatch warning. WARNING: suspect code indent for conditional statements (8, 24) Signed-off-by:
-
Michael Straube authored
Remove return from a void function to clear a checkpatch warning. WARNING: void function return statements are not generally useful Signed-off-by:
-
Michael Straube authored
Refactor if else statement to clear checkpatch warnings. WARNING: else is not generally useful after a break or return WARNING: line over 80 characters Signed-off-by:
-
Michael Straube authored
Replace tabs with spaces, remove spaces, remove blank lines and break lines appropriatly in declarations. Signed-off-by:
-
Michael Straube authored
The function rtw_android_set_block() just returns zero. The only user is the function rtw_android_priv_cmd(). The variable bytes_written is initialized to zero and not changed before the use of rtw_android_set_block(). Remove rtw_android_set_block() and it's only use. Signed-off-by:
-
Michael Straube authored
Use __func__ instead of hardcoded function names. Reported by checkpatch. Signed-off-by:
-
Michael Straube authored
Remove unnecessary parentheses reported by checkpatch. Signed-off-by:
-
Michael Straube authored
Cleanup remaining comparsions to true. if (x == true) -> if (x) if (x != true) -> if (!x) if (!x == true) -> if (!x) Signed-off-by:
-
- 23 Nov, 2018 8 commits
-
-
Ricardo Reis Marques Silva authored
Issue found by checkpatch. CHECK: Prefer kernel type 'u32' over 'uint32_t' +static const uint32_t vbox_cursor_plane_formats[] = { CHECK: Prefer kernel type 'u32' over 'uint32_t' +static const uint32_t vbox_primary_plane_formats[] = { CHECK: Prefer kernel type 'u32' over 'uint32_t' + const uint32_t *formats; Signed-off-by:Ricardo Reis Marques Silva <ricardormsilva93@gmail.com> Signed-off-by:
-
Michael Straube authored
The local variable ret is only used to test the return value of the call to rtl8188eu_xmitframe_complete(). Use the function directly in the if test and remove the variable ret. Signed-off-by:
-
Michael Straube authored
Replace tabs with spaces and/or remove spaces in declarations to cleanup whitespace. Signed-off-by:
-
Michael Straube authored
Add spaces around '>>' and '&' to follow kernel coding style. Reported by checkpatch. Signed-off-by:
-
Michael Straube authored
Remove unnecessary parentheses in usb_ops_linux.c. Reported by checkpatch. Signed-off-by:
-
Michael Straube authored
Correct spelling mistake in a comment reported by checkpatch. checksumed -> checksummed Signed-off-by:
-
Michael Straube authored
Remove braces from single line if else statement. Reported by checkpatch. Signed-off-by:
-
Michael Straube authored
Cleanup line ending with a '(' to follow kernel coding style. Reported by checkpatch. Signed-off-by:
-
