- 04 Oct, 2022 3 commits
-
-
Shang XiaoJing authored
devm_ioremap_resource() prints error message in itself. Remove the dev_err call to avoid redundant error message. Signed-off-by:
Shang XiaoJing <shangxiaojing@huawei.com> Acked-by:
Florian Fainelli <f.fainelli@gmail.com> Acked-by:
Ray Jui <ray.jui@broadcom.com> Link: https://lore.kernel.org/r/20220923101038.18036-1-shangxiaojing@huawei.comSigned-off-by:
Linus Walleij <linus.walleij@linaro.org>
-
Quentin Schulz authored
Before the split of gpio and pinctrl sections in their own driver, rockchip_set_mux was called in pinmux_ops.gpio_set_direction for configuring a pin in its GPIO function. This is essential for cases where pinctrl is "bypassed" by gpio consumers otherwise the GPIO function is not configured for the pin and it does not work. Such was the case for the sysfs/libgpiod userspace GPIO handling. Let's call pinctrl_gpio_direction_input/output when setting the direction of a GPIO so that the pinctrl core requests from the rockchip pinctrl driver to put the pin in its GPIO function. Fixes: 9ce9a020 ("pinctrl/rockchip: drop the gpio related codes") Fixes: 936ee267 ("gpio/rockchip: add driver for rockchip gpio") Cc: stable@vger.kernel.org Reviewed-by:
Heiko Stuebner <heiko@sntech.de> Signed-off-by:
Quentin Schulz <quentin.schulz@theobroma-systems.com> Link: https://lore.kernel.org/r/20220930132033.4003377-3-foss+kernel@0leil.netSigned-off-by:
-
Quentin Schulz authored
Before the split of gpio and pinctrl sections in their own driver, rockchip_set_mux was called in pinmux_ops.gpio_set_direction for configuring a pin in its GPIO function. This is essential for cases where pinctrl is "bypassed" by gpio consumers otherwise the GPIO function is not configured for the pin and it does not work. Such was the case for the sysfs/libgpiod userspace GPIO handling. Let's re-implement the pinmux_ops.gpio_set_direction callback so that the gpio subsystem can request from the pinctrl driver to put the pin in its GPIO function. Fixes: 9ce9a020 ("pinctrl/rockchip: drop the gpio related codes") Cc: stable@vger.kernel.org Reviewed-by:
-
- 20 Sep, 2022 5 commits
-
-
Andy Shevchenko authored
Align the function names in the cy8c95x0_pmxops() to follow the struct pinmux_ops members naming schema. Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20220916205450.86278-3-andriy.shevchenko@linux.intel.comSigned-off-by:
-
Andy Shevchenko authored
The push_pull member is always accessed under the mutex, hence no need to use atomic operations on it. Signed-off-by:
-
Andy Shevchenko authored
It seems that cy8c95x0_set_mux() missed serialization of IO access. And its implementation looks half-baked. Add locking to the function. Fixes: e6cbbe42 ("pinctrl: Add Cypress cy8c95x0 support") Signed-off-by:
-
Yang Yingliang authored
In the probe path, dev_err() can be replace with dev_err_probe() which will check if error code is -EPROBE_DEFER and and prints the error name. Signed-off-by:
Yang Yingliang <yangyingliang@huawei.com> Link: https://lore.kernel.org/r/20220917122208.1894769-1-yangyingliang@huawei.comSigned-off-by:
-
Yang Yingliang authored
In the probe path, dev_err() can be replace with dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. Signed-off-by:
-
- 19 Sep, 2022 7 commits
-
-
Anjelique Melendez authored
Update the Qualcomm Technologies, Inc. PMIC GPIO binding documentation to include compatible strings for PM7250B and PM8450 PMICs. Signed-off-by:
Anjelique Melendez <quic_amelende@quicinc.com> Reviewed-by:
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20220912210624.4527-5-quic_amelende@quicinc.comSigned-off-by:
-
Jishnu Prakash authored
Add support for qcom,pm7250b-gpio variant. Signed-off-by:
Jishnu Prakash <quic_jprakash@quicinc.com> Signed-off-by:
David Collins <quic_collinsd@quicinc.com> Signed-off-by:
-
Anjelique Melendez authored
The SPMI based PMICs have the HIGH and LOW GPIO output strength mappings interchanged, fix them. Signed-off-by:
-
David Collins authored
Add support for SPMI PMIC GPIO subtypes GPIO_LV_VIN2 and GPIO_MV_VIN3. GPIO_LV_VIN2 GPIOs support two input reference voltages: VIN0 and VIN1. These are typically connected to 1.8 V and 1.2 V supplies respectively. GPIO_MV_VIN3 GPIOs support three input reference voltages: VIN0, VIN1, and VIN2. These are typically connected to Vph, 1.8 V, and 1.2 V supplies respectively. Signed-off-by:
-
Lukas Bulwahn authored
Commit b6d09f78 ("pinctrl: nomadik: Drop U8540/9540 support") removes the DB8540 pin controller driver and its config PINCTRL_DB8540. There is some code left-over in the generic nomadik pinctrl driver, i.e., drivers/pinctrl/nomadik/pinctrl-nomadik.{ch}, that is still around for the removed DB8540 pin controller driver. Remove this remaining dead code. This issue was discovered with ./scripts/checkkconfigsymbols.py. Signed-off-by:
Lukas Bulwahn <lukas.bulwahn@gmail.com> Link: https://lore.kernel.org/r/20220919065435.27747-1-lukas.bulwahn@gmail.comSigned-off-by:
-
Linus Walleij authored
This makes the Nomadik GPIO irqchip immutable. Tested on the Samsung Galaxy SIII mini GT-I8190. Cc: Marc Zyngier <maz@kernel.org> Acked-by:
Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/20220917203036.167607-2-linus.walleij@linaro.orgSigned-off-by:
-
Linus Walleij authored
The irq data passed to irc_chip handlers i the struct gpio_chip and nothing else. We are just lucky that the nomadik chip pointer is first in the struct. Use the proper dereferencing and helpers. Reported-by:
-
- 14 Sep, 2022 25 commits
-
-
Peter Chiu authored
Add wifi pins in the description and set 'maxItems' for groups and pins. Reviewed-by:
Sam Shih <sam.shih@mediatek.com> Signed-off-by:
Peter Chiu <chui-hao.chiu@mediatek.com> Reviewed-by:
Rob Herring <robh@kernel.org> Link: https://lore.kernel.org/r/20220912092440.21011-1-chui-hao.chiu@mediatek.comSigned-off-by:
-
Linus Walleij authored
Merge tag 'samsung-pinctrl-6.1' of https://git.kernel.org/pub/scm/linux/kernel/git/pinctrl/samsung into devel Samsung pinctrl drivers changes for v6.1 1. Minor fix in order of initializing pinctrl driver - GPIOs should be configured before registering gpiolib. 2. Final steps to deprecated bindings headers with register constants. The constants were moved to include files in DTS directories, because these are not suitable for bindings. Remove final references and mark binding header as deprecated to warn any users.
-
Colin Foster authored
Add missed help information and module export name to the Microsemi Ocelot and Jaguar2 SoC. Signed-off-by:
Colin Foster <colin.foster@in-advantage.com> Link: https://lore.kernel.org/r/20220909153802.3370088-1-colin.foster@in-advantage.comSigned-off-by:
-
Krzysztof Kozlowski authored
Bindings example should be indented with 4-spaces. Signed-off-by:
Bjorn Andersson <andersson@kernel.org> Link: https://lore.kernel.org/r/20220912061746.6311-34-krzysztof.kozlowski@linaro.orgSigned-off-by:
-
Krzysztof Kozlowski authored
Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by:
-
Krzysztof Kozlowski authored
Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: 'pins' is a required property 'function' is a required property 'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+' [[59]] is not of type 'object' Make the schema stricter and expect such nodes to be followed with a '-pins' suffix. Signed-off-by: -
Krzysztof Kozlowski authored
Bindings example should be indented with 4-spaces. Signed-off-by:
-
Krzysztof Kozlowski authored
Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by:
-
Krzysztof Kozlowski authored
Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: 'pins' is a required property 'function' is a required property 'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+' [[59]] is not of type 'object' Make the schema stricter and expect such nodes to be followed with a '-pins' suffix. Signed-off-by: -
Krzysztof Kozlowski authored
Bindings example should be indented with 4-spaces. Signed-off-by:
-
Krzysztof Kozlowski authored
Qualcomm TLMM pin controller bindings should reference generic TLMM schema (which also pulls generic pinctrl schema). Signed-off-by:
-
Krzysztof Kozlowski authored
Add common gpio-line-names property (used on SC7280 Herobrine boards). Signed-off-by:
-
Krzysztof Kozlowski authored
Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by:
-
Krzysztof Kozlowski authored
There are 182 GPIOs on SC7280. Signed-off-by:
-
Krzysztof Kozlowski authored
Add common gpio-line-names property and restrict gpio-reserved-ranges to fixed size. Signed-off-by:
-
Krzysztof Kozlowski authored
Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by:
-
Krzysztof Kozlowski authored
Bindings example should be indented with 4-spaces. Signed-off-by:
-
Krzysztof Kozlowski authored
Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: qcom/sm4250-oneplus-billie2.dtb: pinctrl@500000: sdc1-on-state: 'oneOf' conditional failed, one must be fixed: 'pins' is a required property 'clk', 'cmd', 'data', 'rclk' do not match any of the regexes: 'pinctrl-[0-9]+' [[26]] is not of type 'object' Make the schema stricter and expect such nodes to be followed with a '-pins' suffix. Signed-off-by: -
Krzysztof Kozlowski authored
Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by:
-
Krzysztof Kozlowski authored
Bindings example should be indented with 4-spaces. Signed-off-by:
-
Krzysztof Kozlowski authored
Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: sm8350-hdk.dtb: pinctrl@f100000: qup-uart3-default-state: 'oneOf' conditional failed, one must be fixed: 'pins' is a required property 'function' is a required property 'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+' [[59]] is not of type 'object' Make the schema stricter and expect such nodes to be followed with a '-pins' suffix. Signed-off-by: -
Krzysztof Kozlowski authored
Bindings example should be indented with 4-spaces. Signed-off-by:
-
Krzysztof Kozlowski authored
Each subnode configuring pins (so the final -pins or pinconf) should reference common TLMM pin definition. Signed-off-by:
-
Krzysztof Kozlowski authored
Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by:
-
Krzysztof Kozlowski authored
Bindings example should be indented with 4-spaces. Signed-off-by:
-
