- 09 Jan, 2020 22 commits
-
-
Johan Hovold authored
Make sure to use the current alternate setting, which need not be the first one by index, when verifying the endpoint descriptors and initialising the URBs. Failing to do so could cause the driver to misbehave or trigger a WARN() in usb_submit_urb() that kernels with panic_on_warn set would choke on. Fixes: 26ff6313 ("[media] Add support for the IguanaWorks USB IR Transceiver") Fixes: ab1cbdf1 ("media: iguanair: add sanity checks") Cc: stable <stable@vger.kernel.org> # 3.6 Cc: Oliver Neukum <oneukum@suse.com> Signed-off-by:
Johan Hovold <johan@kernel.org> Signed-off-by:
Sean Young <sean@mess.org> Signed-off-by:
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
-
Wolfram Sang authored
Use the newer API returning an ERRPTR and use the new helper to bail out. Signed-off-by:
Wolfram Sang <wsa+renesas@sang-engineering.com> Signed-off-by:
-
Wolfram Sang authored
Use the newer API returning an ERRPTR and use the new helper to bail out. Signed-off-by:
-
Wolfram Sang authored
Use the newer API returning an ERRPTR and use the new helper to bail out. Signed-off-by:
-
Wolfram Sang authored
Use the newer API returning an ERRPTR and use the new helper to bail out. Signed-off-by:
-
Wolfram Sang authored
Use the newer API returning an ERRPTR and use the new helper to bail out. Signed-off-by:
-
Wolfram Sang authored
Use the newer API returning an ERRPTR and use the new helper to bail out. Signed-off-by:
-
Wolfram Sang authored
Use the newer API returning an ERRPTR and use the new helper to bail out. Reviewed-by:
Patrice Chotard <patrice.chotard@st.com> Signed-off-by:
-
Wolfram Sang authored
Use the newer API returning an ERRPTR and use the new helper to bail out. Signed-off-by:
-
Wolfram Sang authored
Use the newer API returning an ERRPTR and use the new helper to bail out. Signed-off-by:
-
Wolfram Sang authored
Use the newer API returning an ERRPTR and use the new helper to bail out. Signed-off-by:
-
Wolfram Sang authored
Use the newer API returning an ERRPTR and use the new helper to bail out. Signed-off-by:
-
Wolfram Sang authored
Use the newer API returning an ERRPTR and use the new helper to bail out. Signed-off-by:
-
Wolfram Sang authored
Use the newer API returning an ERRPTR and use the new helper to bail out. Signed-off-by:
-
Wolfram Sang authored
Use the newer API returning an ERRPTR and use the new helper to bail out. Signed-off-by:
-
Wolfram Sang authored
Use the newer API returning an ERRPTR and use the new helper to bail out. Signed-off-by:
-
Dan Carpenter authored
This can't be NULL and we've already dereferenced it so let's remove the check. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by:
-
Colin Ian King authored
In the case where v4l2_event_dequeue fails the structure ev is not being filled and this garbage data from the stack is being copied to the ev32 structure and being copied back to userspace on the VIDIOC_DQEVENT_TIME32 ioctl. Fix this by ensuring the ev structure is zero'd to ensure uninitialized data is not leaked back. Addresses-Coverity: ("Uninitialized scalar variable") Fixes: 1a6c0b36 ("media: v4l2-core: fix VIDIOC_DQEVENT for time64 ABI") Signed-off-by:Colin Ian King <colin.king@canonical.com> Acked-by:
Arnd Bergmann <arnd@arndb.de> Signed-off-by:
-
Alexandre Courbot authored
Despite using M2M in both the decoder and encoder, this driver used vb2_v4l2_buffer as its base buffer structure, and placed a list_head right after the buffer declaration in order to match the layout of a v4l2_m2m_buffer. This is very dangerous as it means the driver will break should the layout of v4l2_m2m_buffer change. Fix this by directly using v4l2_m2m_buffer and updating the sites that accessed the buffer accordingly. Signed-off-by:
Alexandre Courbot <acourbot@chromium.org> Signed-off-by:
-
Aditya Pakki authored
In vpfe_register_ccdc_device(), failure to allocate dev->hw_ops fields calls BUG_ON(). This patch returns the error to callers instead of crashing. The issue was identified by a static analysis tool, written by us. Signed-off-by:
Aditya Pakki <pakki001@umn.edu> Signed-off-by:
-
Jernej Skrabec authored
Add luma bit depth. Signed-off-by:
Jernej Skrabec <jernej.skrabec@siol.net> Acked-by:
Paul Kocialkowski <paul.kocialkowski@bootlin.com> Signed-off-by:
-
Jernej Skrabec authored
It seems that for some HEVC videos at least one bitstream parsing trigger must be called in order to be decoded correctly. There is no explanation why this helps, but it was observed that several videos with this fix are now decoded correctly and there is no regression with others. Without this fix, those same videos totally crash HEVC decoder (other decoder engines are unaffected). After decoding those problematic videos, HEVC decoder always returns only green image (all zeros). Only complete HW reset helps. This fix is similar to that for H264. Signed-off-by:
-
- 08 Jan, 2020 18 commits
-
-
Hans Verkuil authored
Remove several functions that are no longer used now that the conversion of cec drivers to cec_notifier_conn_(un)register() and cec_notifier_cec_adap_(un)register() is complete. Signed-off-by:
-
Jia-Ju Bai authored
The driver may sleep while holding a spinlock. The function call path (from bottom to top) in Linux 4.19 is: drivers/media/platform/sti/bdisp/bdisp-hw.c, 385: msleep in bdisp_hw_reset drivers/media/platform/sti/bdisp/bdisp-v4l2.c, 341: bdisp_hw_reset in bdisp_device_run drivers/media/platform/sti/bdisp/bdisp-v4l2.c, 317: _raw_spin_lock_irqsave in bdisp_device_run To fix this bug, msleep() is replaced with udelay(). This bug is found by a static analysis tool STCheck written by myself. Signed-off-by:Jia-Ju Bai <baijiaju1990@gmail.com> Reviewed-by:
Fabien Dessenne <fabien.dessenne@st.com> Signed-off-by:
-
Ma Feng authored
Fixes coccicheck warning: drivers/media/usb/pvrusb2/pvrusb2-encoder.c:288:2-3: Unneeded semicolon Reported-by:
Hulk Robot <hulkci@huawei.com> Signed-off-by:
Ma Feng <mafeng.ma@huawei.com> Signed-off-by:
-
Helen Koike authored
boundary->width and boundary->height are sizes relative to boundary->left and boundary->top coordinates, but they were not being taken into consideration to adjust r->left and r->top, leading to the following error: Consider the follow as initial values for boundary and r: struct v4l2_rect boundary = { .left = 100, .top = 100, .width = 800, .height = 600, } struct v4l2_rect r = { .left = 0, .top = 0, .width = 1920, .height = 960, } calling v4l2_rect_map_inside(&r, &boundary) was modifying r to: r = { .left = 0, .top = 0, .width = 800, .height = 600, } Which is wrongly outside the boundary rectangle, because: v4l2_rect_set_max_size(r, boundary); // r->width = 800, r->height = 600 ... if (r->left + r->width > boundary->width) // true r->left = boundary->width - r->width; // r->left = 800 - 800 if (r->top + r->height > boundary->height) // true r->top = boundary->height - r->height; // r->height = 600 - 600 Fix this by considering top/left coordinates from boundary. Fixes: ac49de8c ("[media] v4l2-rect.h: new header with struct v4l2_rect helper functions") Signed-off-by:Helen Koike <helen.koike@collabora.com> Cc: <stable@vger.kernel.org> # for v4.7 and up Signed-off-by:
-
Wolfram Sang authored
Move from the deprecated i2c_new_probed_device() to the new i2c_new_scanned_device(). Make use of the new ERRPTR if suitable. Change the legacy function to simply return void because the retval was never used anywhere. Signed-off-by:
-
Wolfram Sang authored
Move from the deprecated i2c_new_probed_device() to the new i2c_new_scanned_device(). Make use of the new ERRPTR if suitable. Signed-off-by:
-
Wolfram Sang authored
Move from the deprecated i2c_new_probed_device() to the new i2c_new_scanned_device(). Make use of the new ERRPTR if suitable. Signed-off-by:
-
Wolfram Sang authored
Here, this only means to update a comment in the driver. Signed-off-by:
-
Wolfram Sang authored
Move from the deprecated i2c_new_probed_device() to the new i2c_new_scanned_device(). Make use of the new ERRPTR if suitable. Signed-off-by:
-
Aditya Pakki authored
In video_begin and video_end, saa7146_format_by_fourcc can return NULL and is checked via BUG_ON. However, by returning the error to the callers upstream, we can avoid the crash and handle it via recovery code. Signed-off-by:
-
Aditya Pakki authored
In cx231xx_i2c_register, if dev->cx231xx_send_usb_command is NULL, the code crashes. However, the callers in cx231xx-core are able to handle the error without crashing. This patch fixes this issue. Signed-off-by:
-
Dmitry Osipenko authored
Replace #ifdef with __maybe_unused attribute just to keep code cleaner a tad. Signed-off-by:
Dmitry Osipenko <digetx@gmail.com> Signed-off-by:
-
Dmitry Osipenko authored
Keep the alphabetical order for consistency. Signed-off-by:
-
Dmitry Osipenko authored
There were several reports of building failures due to IOVA being selected inconsistently by different drivers. All drivers that are using IOVA API should select it unconditionally in order to avoid the compilation problems, tegra-vde is one of those drivers. Link: https://patchwork.kernel.org/patch/11057831/Signed-off-by:
-
Daniel Gomez authored
Fix documentation fourcc names for the 12-bit and 14-bit packed Bayer formats. Signed-off-by:
Daniel Gomez <daniel@qtec.com> Signed-off-by:
-
Hans Verkuil authored
This reverts commit 2b016c47. Wrong patch was merged, revert this first before applying the right patch. Signed-off-by:
-
Arnd Bergmann authored
The memset() got moved out of the check for _IOC_NONE, so passing a made-up command number with a size but no direction would allow clearing data on user-provided pointers. Move video_get_user() back into the _IOC_NONE check where it belongs. Reported-by: syzbot+54fd8cca4b7226c94b8e@syzkaller.appspotmail.com Fixes: 6c625c01c7a6 ("media: v4l2-core: split out data copy from video_usercopy") Signed-off-by: -
Shawn Guo authored
The IR device on Hi3796CV300 SoC is mostly same as hix5hd2, except the following two things. - IR_CLK offset is 0x60 instead of 0x48. - It needs to set an extra bit in IR_ENABLE register to enable IR. The following changes are made to deal with them. - Define a SoC specific data to accommodate IR_CLK offset and the flag telling requirement of extra enable bit. - Create function hix5hd2_ir_enable() to handle IR enabling. The original hix5hd2_ir_enable() is all about managing IR clock, so gets renamed to hix5hd2_ir_clk_enable(). - Device table hix5hd2_ir_table[] gets moved forward, as it's being used by hix5hd2_ir_probe() now. Signed-off-by:
Shawn Guo <shawn.guo@linaro.org> Signed-off-by:
-
