Commits · 1b76d1df1a3683b6b23cd1c813d13c5e6a9d35e5 · Kirill Smelkov / linux

25 Jan, 2021 40 commits

nfsd: remove unused stats counters · 1b76d1df

Amir Goldstein authored Jan 06, 2021

Commit 501cb184 ("nfsd: rip out the raparms cache") removed the
code that updates read-ahead cache stats counters,
commit 8bbfa9f3 ("knfsd: remove the nfsd thread busy histogram")
removed code that updates the thread busy stats counters back in 2009
and code that updated filehandle cache stats was removed back in 2002.

Remove the unused stats counters from nfsd_stats struct and print
hardcoded zeros in /proc/net/rpc/nfsd.
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

1b76d1df

NFSD: Clean up after updating NFSv3 ACL decoders · 9cee763e
Chuck Lever authored Oct 20, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
9cee763e
NFSD: Update the NFSv2 SETACL argument decoder to use struct xdr_stream · 68519ff2
Chuck Lever authored Nov 17, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
68519ff2
NFSD: Update the NFSv3 GETACL argument decoder to use struct xdr_stream · 05027eaf
Chuck Lever authored Nov 17, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
05027eaf
NFSD: Clean up after updating NFSv2 ACL decoders · baadce65
Chuck Lever authored Oct 19, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
baadce65
NFSD: Update the NFSv2 ACL ACCESS argument decoder to use struct xdr_stream · 64063892
Chuck Lever authored Nov 17, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
64063892

NFSD: Update the NFSv2 ACL GETATTR argument decoder to use struct xdr_stream · 571d31f3

Chuck Lever authored Nov 17, 2020

Since the ACL GETATTR procedure is the same as the normal GETATTR
procedure, simply re-use nfssvc_decode_fhandleargs.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

571d31f3

NFSD: Update the NFSv2 SETACL argument decoder to use struct xdr_stream · 427eab3b
Chuck Lever authored Nov 17, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
427eab3b
NFSD: Add an xdr_stream-based decoder for NFSv2/3 ACLs · 6bb844b4
Chuck Lever authored Nov 17, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
6bb844b4
NFSD: Update the NFSv2 GETACL argument decoder to use struct xdr_stream · 635a45d3
Chuck Lever authored Nov 17, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
635a45d3

NFSD: Remove argument length checking in nfsd_dispatch() · 5650682e

Chuck Lever authored Oct 20, 2020

Now that the argument decoders for NFSv2 and NFSv3 use the
xdr_stream mechanism, the version-specific length checking logic in
nfsd_dispatch() is no longer necessary.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

5650682e

NFSD: Update the NFSv2 SYMLINK argument decoder to use struct xdr_stream · 09f75a53
Chuck Lever authored Oct 21, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
09f75a53
NFSD: Update the NFSv2 CREATE argument decoder to use struct xdr_stream · 7dcf65b9
Chuck Lever authored Oct 21, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
7dcf65b9
NFSD: Update the NFSv2 SETATTR argument decoder to use struct xdr_stream · 2fdd6bd2
Chuck Lever authored Oct 21, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
2fdd6bd2
NFSD: Update the NFSv2 LINK argument decoder to use struct xdr_stream · 77edcdf9
Chuck Lever authored Oct 21, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
77edcdf9
NFSD: Update the NFSv2 RENAME argument decoder to use struct xdr_stream · 62aa557e
Chuck Lever authored Oct 21, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
62aa557e
NFSD: Update NFSv2 diropargs decoding to use struct xdr_stream · 6d742c18
Chuck Lever authored Oct 19, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
6d742c18

NFSD: Update the NFSv2 READDIR argument decoder to use struct xdr_stream · 8688361a

Chuck Lever authored Oct 19, 2020

As an additional clean up, move code not related to XDR decoding
into readdir's .pc_func call out.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

8688361a

NFSD: Add helper to set up the pages where the dirlist is encoded · 788cd46e
Chuck Lever authored Nov 13, 2020
```
Add a helper similar to nfsd3_init_dirlist_pages().
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
788cd46e

NFSD: Update the NFSv2 READLINK argument decoder to use struct xdr_stream · 1fcbd1c9

Chuck Lever authored Oct 21, 2020

If the code that sets up the sink buffer for nfsd_readlink() is
moved adjacent to the nfsd_readlink() call site that uses it, then
the only argument is a file handle, and the fhandle decoder can be
used instead.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

1fcbd1c9

NFSD: Update the NFSv2 WRITE argument decoder to use struct xdr_stream · a51b5b73
Chuck Lever authored Oct 21, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
a51b5b73

NFSD: Update the NFSv2 READ argument decoder to use struct xdr_stream · 8c293ef9

Chuck Lever authored Oct 21, 2020

The code that sets up rq_vec is refactored so that it is now
adjacent to the nfsd_read() call site where it is used.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

8c293ef9

NFSD: Update the NFSv2 GETATTR argument decoder to use struct xdr_stream · ebcd8e8b
Chuck Lever authored Oct 21, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
ebcd8e8b

NFSD: Update the MKNOD3args decoder to use struct xdr_stream · f8a38e2d

Chuck Lever authored Oct 20, 2020

This commit removes the last usage of the original decode_sattr3(),
so it is removed as a clean-up.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

f8a38e2d

NFSD: Update the SYMLINK3args decoder to use struct xdr_stream · da392016

Chuck Lever authored Oct 20, 2020

Similar to the WRITE decoder, code that checks the sanity of the
payload size is re-wired to work with xdr_stream infrastructure.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

da392016

NFSD: Update the MKDIR3args decoder to use struct xdr_stream · 83374c27
Chuck Lever authored Oct 20, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
83374c27
NFSD: Update the CREATE3args decoder to use struct xdr_stream · 6b3a1196
Chuck Lever authored Oct 20, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
6b3a1196
NFSD: Update the SETATTR3args decoder to use struct xdr_stream · 9cde9360
Chuck Lever authored Oct 20, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
9cde9360
NFSD: Update the LINK3args decoder to use struct xdr_stream · efaa1e7c
Chuck Lever authored Oct 19, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
efaa1e7c
NFSD: Update the RENAME3args decoder to use struct xdr_stream · d181e0a4
Chuck Lever authored Oct 20, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
d181e0a4
NFSD: Update the NFSv3 DIROPargs decoder to use struct xdr_stream · 54d1d43d
Chuck Lever authored Oct 20, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
54d1d43d
NFSD: Update COMMIT3arg decoder to use struct xdr_stream · c8d26a0a
Chuck Lever authored Oct 20, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
c8d26a0a

NFSD: Update READDIR3args decoders to use struct xdr_stream · 9cedc2e6

Chuck Lever authored Oct 19, 2020

As an additional clean up, neither nfsd3_proc_readdir() nor
nfsd3_proc_readdirplus() make use of the dircount argument, so
remove it from struct nfsd3_readdirargs.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

9cedc2e6

NFSD: Add helper to set up the pages where the dirlist is encoded · 40116ebd

Chuck Lever authored Nov 17, 2020

De-duplicate some code that is used by both READDIR and READDIRPLUS
to build the dirlist in the Reply. Because this code is not related
to decoding READ arguments, it is moved to a more appropriate spot.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

40116ebd

NFSD: Fix returned READDIR offset cookie · 0a8f37fb

Chuck Lever authored Nov 10, 2020

Code inspection shows that the server's NFSv3 READDIR implementation
handles offset cookies slightly differently than the NFSv2 READDIR,
NFSv3 READDIRPLUS, and NFSv4 READDIR implementations,
and there doesn't seem to be any need for this difference.

As a clean up, I copied the logic from nfsd3_proc_readdirplus().
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

0a8f37fb

NFSD: Update READLINK3arg decoder to use struct xdr_stream · 224c1c89

Chuck Lever authored Oct 24, 2020

The NFSv3 READLINK request takes a single filehandle, so it can
re-use GETATTR's decoder.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

224c1c89

NFSD: Update WRITE3arg decoder to use struct xdr_stream · c43b2f22

Chuck Lever authored Oct 22, 2020

As part of the update, open code that sanity-checks the size of the
data payload against the length of the RPC Call message has to be
re-implemented to use xdr_stream infrastructure.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

c43b2f22

NFSD: Update READ3arg decoder to use struct xdr_stream · be63bd2a

Chuck Lever authored Oct 20, 2020

The code that sets up rq_vec is refactored so that it is now
adjacent to the nfsd_read() call site where it is used.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

be63bd2a

NFSD: Update ACCESS3arg decoder to use struct xdr_stream · 3b921a2b
Chuck Lever authored Oct 20, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
3b921a2b
NFSD: Update GETATTR3args decoder to use struct xdr_stream · 9575363a
Chuck Lever authored Oct 20, 2020
```
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
```
9575363a