- 01 Oct, 2012 2 commits
-
-
Steve French authored
make menuconfig for cifs shows multiple entries toward the end of the list with the incorrect indentation (probably a bug in Kconfig parsing of items that are dependant on the module (cifs=m instead of just CONFIG_CIFS). This patch fixes the indentation of all but the last entry (CIFS_ACL) which I don't know how to fix. It also clarifies wording in two places Reviewed-by:
Jeff Layton <jlayton@redhat.com> Signed-off-by:
Steve French <smfrench@gmail.com>
-
Steve French authored
Based on whether the user (on mount command) chooses: vers=3.0 (for smb3.0 support) vers=2.1 (for smb2.1 support) or (with subsequent patch, which will allow SMB2 support) vers=2.0 (for original smb2.02 dialect support) send only one dialect at a time during negotiate (we had been sending a list). Reviewed-by:
-
- 28 Sep, 2012 1 commit
-
-
Shirish Pargaonkar authored
Rebased and resending the patch. Path based queries can fail for lack of access, especially during lookup during open. open itself would actually succeed becasue of back up intent bit but queries (either path or file handle based) do not have a means to specifiy backup intent bit. So query the file info during lookup using trans2 / findfirst / file_id_full_dir_info to obtain file info as well as file_id/inode value. Signed-off-by:
Shirish Pargaonkar <shirishpargaonkar@gmail.com> Acked-by:
Jeff Layton <jlayton@samba.org> Signed-off-by:
-
- 27 Sep, 2012 3 commits
-
-
Pavel Shilovsky authored
Signed-off-by:
Pavel Shilovsky <piastry@etersoft.ru> Signed-off-by:
-
Pavel Shilovsky authored
and remove redundant (rsp == NULL) checks after SendReceive2. Signed-off-by:
-
Pavel Shilovsky authored
Signed-off-by:
-
- 26 Sep, 2012 1 commit
-
-
Jeff Layton authored
ERRnoresource is an ERRSRV level (aka server-side) error and means "No resources currently available for request". Currently that maps to POSIX -ENOBUFS. No NT errors map to it currently. NT_STATUS_INSUFFICIENT_RESOURCES and NT_STATUS_INSUFF_SERVER_RESOURCES are also similar in meaning. Currently the client maps those to ERRnomem, which maps to -ENOMEM in POSIX. All of these mappings seem to be quite wrong to me and are confusing for users. All of the above errors indicate problems on the server, not the client. Reporting -ENOMEM or -ENOBUFS implies that the client is running out of resources. This patch changes those mappings. The NT_* errors are changed to map to the SRV level ERRnoresource. That error is in turn changed to return -EREMOTEIO which is the only POSIX error I could find that conveys that something went wrong on the server. While we're at it, change the SMB2 equivalent error to return the same. Signed-off-by:
Suresh Jayaraman <sjayaraman@suse.com> Signed-off-by:
-
- 25 Sep, 2012 33 commits
-
-
Jeff Layton authored
...and make the default cache=strict as promised for 3.7. Signed-off-by:
-
Jeff Layton authored
...as promised for 3.7. Signed-off-by:
-
Pavel Shilovsky authored
and add missed increments of failed async read and write requests. Signed-off-by:
-
Pavel Shilovsky authored
by making it __le64 rather than __u64 in FILE_AL_INFO structure. Signed-off-by:
-
Steve French authored
Some trivial endian fixes for the SMB2 code. One warning remains which I asked Pavel to look at. Reviewed-by:
-
Steve French authored
Now that the merge of the remaining pieces needed for SMB2 (SMB2.1 dialect) are in, and most test cases pass, we can consider SMB2.1 EXPERIMENTAL rather than "BROKEN." Reviewed-by:
-
Steve French authored
With SMB2 support, update from version 1.79 to 2.0 to make it easier for users to recognize which version has SMB2 support. Signed-off-by:
Steve French <sfrench@us.ibm.com> Reviewed-by:
-
Jeff Layton authored
FL_CLOSE is quite common when you close a file on which you hold a lock. The spurious "Unknown lock flags" message in cFYI is confusing in this case. Reported-by:
Alexander Bokovoy <abokovoy@redhat.com> Signed-off-by:
-
Sachin Prabhu authored
The string for "unc=" in /proc/mounts needs to be escaped. The current behaviour can create problems in cases when mounting a share starting with a number. example: >mount -t cifs -o username=test,password=x vm140-31:/17000-test /mnt >mount -o remount,password=x /mnt mount error: could not resolve address for vm140-31x00-test: Unknown error The sub-string "\170" which is part of the unc for the mount above in /proc/mounts is interpreted as character'x' in the case above. Escaping the string fixes the problem. Signed-off-by:
Sachin Prabhu <sprabhu@redhat.com> Reviewed-by:
-
Jeff Layton authored
Rename inode pointers for better clarity. Move the d_instantiate call to the end of the function to prevent other tasks from seeing it before we've finished constructing it. Since we should have exclusive access to the inode at this point, remove the spinlock around i_nlink update. Reviewed-by:
-
Pavel Shilovsky authored
Now we walk though cifsFileInfo's list for every incoming lease break and look for an equivalent there. That approach misses lease breaks that come just after an open response - we don't have time to populate new cifsFileInfo structure to the list. Fix this by adding new list of pending opens and look for a lease there if we didn't find it in the list of cifsFileInfo structures. Signed-off-by:
Pavel Shilovsky <pshilovsky@etersoft.ru> Signed-off-by:
-
Pavel Shilovsky authored
Signed-off-by:
Pavel Shilovsky <pshilovsky@samba.org> Signed-off-by:
-
Pavel Shilovsky authored
When we have a file opened with read oplock and we are writing a data to this file, we need to store the data in the cache and then send to the server to ensure that the next read operation will get a coherent data. Also mark it as CONFIG_CIFS_SMB2 because it's more suitable for SMB2 code but can fix some CIFS problems too (when server delays sending an oplock break after a write request). We can drop this ifdefs dependence in future. Signed-off-by:
-
Pavel Shilovsky authored
if server supports them and we need oplocks. Signed-off-by:
Pavel Shilovsky <piastryyy@gmail.com> Signed-off-by:
-
Pavel Shilovsky authored
Currently CIFS code accept read/write ops on mandatory locked area when two processes use the same file descriptor - it's wrong. Fix this by serializing io and brlock operations on the inode. Signed-off-by:
-
Pavel Shilovsky authored
and allow several processes to walk through the lock list and read can_cache_brlcks value if they are not going to modify them. Signed-off-by:
-
Pavel Shilovsky authored
Signed-off-by:
-
Pavel Shilovsky authored
Signed-off-by: -
Pavel Shilovsky authored
Signed-off-by: -
Pavel Shilovsky authored
Signed-off-by: -
Pavel Shilovsky authored
Now we need to lock/unlock a spinlock while processing brlock ops on the inode. Move brlocks of a fid to a separate list and attach all such lists to the inode. This let us not hold a spinlock. Signed-off-by: -
Pavel Shilovsky authored
to let us negotiate SMB2 without specifying sec type explicitly. Signed-off-by: -
Jeff Layton authored
Now that we aren't abusing the kmap address space, there's no need for this lock or to impose a limit on the rsize. Signed-off-by: -
Jeff Layton authored
The array is no longer needed. We just need a single kvec to hold the header for signature checking. Signed-off-by: -
Jeff Layton authored
Replace the "marshal_iov" function with a "read_into_pages" function. That function will copy the read data off the socket and into the pages array, kmapping and reading pages one at a time. Signed-off-by: -
Jeff Layton authored
We'll need an array to put into a smb_rqst, so convert this into an array instead of (ab)using the lru list_head. Signed-off-by: -
Jeff Layton authored
Eventually, we're going to want to append a list of pages to cifs_readdata instead of a list of kvecs. To prepare for that, turn the kvec array allocation into a separate one and just keep a pointer to it in the readdata. Signed-off-by: -
Jeff Layton authored
Now that we're using TCP_CORK on the socket, there's no value in continuting to support this option. Schedule it for removal in 3.9. Reviewed-by:
-
Jeff Layton authored
Now that we're not kmapping so much at once, there's no need to cap the wsize at the amount that can be simultaneously kmapped. Reviewed-by:
-
Jeff Layton authored
Reviewed-by:
-
Jeff Layton authored
For now, none of the callers populate rq_pages. That will be done for writes in a later patch. While we're at it, change the prototype of setup_async_request not to need a return pointer argument. Just return the pointer to the mid_q_entry or an ERR_PTR. Reviewed-by:
-
Jeff Layton authored
Use the smb_send_rqst helper function to kmap each page in the array and update the hash for that chunk. Reviewed-by:
-
Jeff Layton authored
Add code that allows smb_send_rqst to send an array of pages after the initial kvec array has been sent. For now, we simply kmap the page array and send it using the standard smb_send_kvec function. Eventually, we may want to convert this code to use kernel_sendpage under the hood and avoid the kmap altogether for the page data. Reviewed-by:
-
