- 25 Oct, 2023 18 commits
-
-
Umang Jain authored
Move vchiq_log_error() custom logging wrapper based on printk, to use dynamic debug. To categorise, enum vchiq_log_category has been introduced, which will become the part of the error string format that will be logged to dynamic debug (for grep). All the vchiq_log_error() calls are adjusted to use the dynamic debug wrapper. vchiq_loud_error_*() has been removed as a part of this patch and replaced with dev_err (so that they directly end up in kernel log, even if dynamic debug isn't enabled), which serves the purpose. Signed-off-by:
Umang Jain <umang.jain@ideasonboard.com> Link: https://lore.kernel.org/r/20231024114428.443528-4-umang.jain@ideasonboard.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Umang Jain authored
Pass struct device pointer to vchiq_init_slots(). In subsequent commits, vchiq_log_* macros will be ported to use dynamic debug (dev_dbg()), hence they need access to a struct device pointer. No functional changes intended in this commit. Signed-off-by:
-
Umang Jain authored
Pass struct device pointer to vchiq_log_dump_mem(). In subsequent commits, vchiq_log_* macros will be ported to use dynamic debug (dev_dbg()), hence they need access to a struct device pointer. No functional changes intended in this commit. Signed-off-by:
-
Michael Straube authored
Using strcpy has potential for buffer overflows. It should be replaced with strscpy where possible. In this case the return value of strcpy is not used, so we can safely replace it with strscpy. Signed-off-by:
Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20231023090001.7273-1-straube.linux@gmail.comSigned-off-by:
-
Philipp Hortmann authored
Remove unused variables to shorten code. Signed-off-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/04ce3eaaaf3897a22dcb95ce2f449658199770d8.1698042685.git.philipp.g.hortmann@gmail.comSigned-off-by:
-
Philipp Hortmann authored
Remove union qos_tclas as it is just set to 0 and never used. Signed-off-by:
-
Philipp Hortmann authored
Remove last three parameters of MakeTSEntry() as those are always Null or 0. Signed-off-by:
-
Philipp Hortmann authored
Remove unused struct acm to shorten code. Signed-off-by:
-
Philipp Hortmann authored
Replace union qos_tsinfo with embedded struct as it has only one element. Signed-off-by:
-
Philipp Hortmann authored
Replace union tspec_body including embedded struct with embedded union as it has only one element. This will increase readability of the code. Signed-off-by:
-
Philipp Hortmann authored
Remove unused variables to shorten code. Signed-off-by:
-
Philipp Hortmann authored
Remove variable ucUP as its value is written but never evaluated. Signed-off-by:
-
Philipp Hortmann authored
Remove unused variables ucReserved, ucSchedule, ucTSInfoAckPolicy, ucPSB, ucAggregation, ucAccessPolicy, ucTrafficType and charData. Signed-off-by:
-
Philipp Hortmann authored
Replace custom macros BIT10 to BIT31 with standard kernel macros BIT(10) to BIT(31) to shorten code. Signed-off-by:
-
Philipp Hortmann authored
Replace custom macros BIT0 to BIT9 with standard kernel macros BIT(0) to BIT(9) to shorten code. Signed-off-by:
-
Nandha Kumar Singaram authored
Adhere to linux coding style. Reported by checkpatch.pl: WARNING: Unnecessary ftrace-like logging - prefer using ftrace Signed-off-by:
Nandha Kumar Singaram <nandhakumar.singaram@gmail.com> Link: https://lore.kernel.org/r/39be7bb04ce1362b00aa31a638ebe2e88dd81fec.1697976302.git.nandhakumar.singaram@gmail.comSigned-off-by:
-
Nandha Kumar Singaram authored
Adhere to linux coding style. Reported by checkpatch.pl: CHECK: Lines should not end with a '(' Signed-off-by: -
Nandha Kumar Singaram authored
Adhere to linux coding style. Reported by checkpatch.pl: CHECK: Alignment should match open parenthesis Signed-off-by:
-
- 22 Oct, 2023 5 commits
-
-
Gilbert Adikankwu authored
Remove byte Type encoding "by" from variable name and replace camelcase with snakecase. Fix checkpatch.pl error: CHECK: Avoid CamelCase: <byEIFS> Signed-off-by:
Gilbert Adikankwu <gilbertadikankwu@gmail.com> Tested-by:
-
Gilbert Adikankwu authored
Remove byte Type encoding "by" from variable name and replace camelcase with snakecase Fix checkpatch.pl error: CHECK: Avoid CamelCase: <byDIFS> Signed-off-by:
-
Gilbert Adikankwu authored
Remove byte Type encoding "by" from variable name and replace camelcase with snakecase Fix checkpatch.pl error: CHECK: Avoid CamelCase: <bySIFS> Signed-off-by:
-
Gilbert Adikankwu authored
Remove byte Type encoding "by" from variable name and replace camelcase with snakecase. Fix checkpatch.pl error: CHECK: Avoid CamelCase: <bySlot> Signed-off-by:
-
Gilbert Adikankwu authored
Remove byte Type encoding "by" from variable name and replace camelcase with snakecase Fix checkpatch.pl error: CHECK: Avoid CamelCase: <byCWMaxMin> Signed-off-by:
-
- 21 Oct, 2023 17 commits
-
-
Michael Straube authored
Clean up comparisons to NULL to improve readability. Reported by checkpatch. if (x == NULL) -> if (!x) if (x != NULL) -> if (x) Signed-off-by:
-
Soumya Negi authored
vme_check_window() uses printk() for logging error message. This leads to the following checkpatch warning: WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Use dev_err() instead. Pass VME bridge device to vme_check_window() so that the error message can be logged with the bridge device context. Signed-off-by:Soumya Negi <soumya.negi97@gmail.com> Suggested-by:
-
Soumya Negi authored
Don't check for empty bridge device & resource in vme_alloc_consistent() & vme_free_consistent() since they can not be NULL. Both the VME bridge device and the VME resource that are used in these functions are set at probe time. Signed-off-by:
-
Soumya Negi authored
Don't log error message in find_bridge(). The printk() triggers a checkpatch warning: WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... It can't be replaced by dev_err() & using pr_err() is not helpful as it doesn't give much context to the user. It is better to remove it. Signed-off-by: -
Soumya Negi authored
Replace function names in message strings with __func__ to fix all checkpatch warnings like: WARNING: Prefer using '"%s...", __func__' to using 'vme_lm_get', this function's name, in a string Signed-off-by:Andi Shyti <andi.shyti@linux.intel.com> Link: https://lore.kernel.org/r/db4ad6b878c4bb08fd5d15cf4a9287d7bb8c30df.1697763267.git.soumya.negi97@gmail.comSigned-off-by:
-
Soumya Negi authored
vme.c uses printk() to log messages. To improve and standardize message formatting, use logging mechanisms dev_err()/dev_warn() instead. Retain the printk log levels of the messages during replacement. Issue found by checkpatch.pl Signed-off-by:
-
Gary Rookard authored
Renamed from Pascal/CamelCase to Snake case the variable HTUpdateDefaultSetting, HTUpateDefaultSetting -> ht_update_default_setting Linux kernel coding style (cleanup), checkpatch Avoid CamelCase. Driver rtl8192e compiles. Signed-off-by:
Gary Rookard <garyrookard@fastmail.org> Link: https://lore.kernel.org/r/20231021014759.29844-1-garyrookard@fastmail.orgSigned-off-by:
-
Dorcas AnonoLitunya authored
Drops variable ret as it is unused in the code. This therefore modifies the return type of program_mode_registers() to void from int since the return value is being ignored in all function calls. This improves code readability and maintainability. Suggested-by:
Dorcas AnonoLitunya <anonolitunya@gmail.com> Link: https://lore.kernel.org/r/20231019101348.22076-3-anonolitunya@gmail.comSigned-off-by:
-
Calvince Otieno authored
The function snd_bcm2835_new_ctl() is declared but not defined. Its definition was removed 1 year ago in the commit 143b67f1 ("staging: bcm2835-audio: remove compat ALSA card") Signed-off-by:
Calvince Otieno <calvncce@gmail.com> Link: https://lore.kernel.org/r/ZTDap2d5X7eXXPo2@lab-ubuntuSigned-off-by:
-
Soumya Negi authored
Fix WARNING: Missing a blank line after declarations Issue found by checkpatch.pl Signed-off-by:
-
Calvince Otieno authored
Checkpatch suggests using strscpy() instead of strcpy(). The advantages of strscpy() are that it always adds a NUL terminator and prevents read/write overflows if the source string is not properly terminated. strcpy() lacks built-in bounds checking for the destination buffer, making it susceptible to buffer overflows. These overflows can lead to various unpredictable behaviors. In this specific context, both strscpy and strcpy performs the same operation without any functional difference. The reason for this equivalence is that the driver_name string "vme_fake" is shorter than the size of the fake_bridge->name array which is defined as 16 characters (struct vme_bridge {char name[VMENAMSIZ];...}). Thus, there is no risk of buffer overflow in either case. VMENAMSIZ variable holds a constant value of 16 (#define VMENAMSIZ 16) The null-terminated "vme_fake" string (static const char driver_name[] = "vme_fake";) can be safely copied into fake_bridge->name using either strscpy or strcpy. While using strscpy() does not address any bugs, it is considered a better practice and aligns with checkpatch recommendations. Reviewed-by:Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by:
-
Umang Jain authored
Drop MODULE_ALIAS in favour of MODULE_DEVICE_TABLE as the module alias should be picked from there. Signed-off-by:
Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by:
Kieran Bingham <kieran.bingham@ideasonboard.com> Link: https://lore.kernel.org/r/20231019090128.430297-4-umang.jain@ideasonboard.comSigned-off-by:
-
Umang Jain authored
Drop MODULE_ALIAS in favour of MODULE_DEVICE_TABLE as the module alias should be dropped from there. Signed-off-by:
-
Umang Jain authored
VC04 has now a independent bus vchiq_bus to register its devices. However, the module auto-loading for bcm2835-audio and bcm2835-camera currently happens through MODULE_ALIAS() macro specified explicitly. The correct way to auto-load a module, is when the alias is picked out from MODULE_DEVICE_TABLE(). In order to get there, we need to introduce vchiq_device_id and add relevant entries in file2alias.c infrastructure so that aliases can be generated. This patch targets adding vchiq_device_id and do_vchiq_entry, in order to generate those alias using the /script/mod/file2alias.c. Going forward the MODULE_ALIAS() from bcm2835-camera and bcm2835-audio will be dropped, in favour of MODULE_DEVICE_TABLE being used there. The alias format for vchiq_bus devices will be "vchiq:<dev_name>". Adjust the vchiq_bus_uevent() to reflect that. Signed-off-by:
-
Umang Jain authored
As per device_register() documentation, this kfree() on error path will crash. The call to put_device() is all that is needed here to free the memory. Fixes: 027e5703 ("staging: vc04_services: vchiq_arm: Add new bus type and device type") Signed-off-by:
Stefan Wahren <stefan.wahren@i2se.com> Link: https://lore.kernel.org/r/20231018055228.825524-1-umang.jain@ideasonboard.comSigned-off-by:
-
Benjamin Poirier authored
No significant improvements have been done to this driver since commit a7c3ddf2 ("staging: qlge: clean up debugging code in the QL_ALL_DUMP ifdef land") in January 2021. The driver should not stay in staging forever. Since it has been abandoned by the vendor and no one has stepped up to maintain it, delete it. If some users manifest themselves, the driver will be restored to drivers/net/ as suggested in the linked message. Link: https://lore.kernel.org/netdev/20231019074237.7ef255d7@kernel.org/Suggested-by:
Jakub Kicinski <kuba@kernel.org> Cc: Manish Chopra <manishc@marvell.com> Cc: Coiby Xu <coiby.xu@gmail.com> Signed-off-by:
Benjamin Poirier <benjamin.poirier@gmail.com> Acked-by:
-
Benjamin Poirier authored
Update TODO file to reflect the changes that have been done: * multiple functions were renamed to have the "qlge_" prefix in commit f8c047be ("staging: qlge: use qlge_* prefix to avoid namespace clashes with other qlogic drivers") * a redundant memset() was removed in commit 953b9400 ("staging: qlge: Initialize devlink health dump framework") * the loop boundary in ql(ge)_alloc_rx_buffers() was updated in commit e4c911a7 ("staging: qlge: Remove rx_ring.type") * pci_enable_msi() was replaced in commit 4eab532d ("staging: qlge/qlge_main.c: Replace depracated MSI API.") * pci_dma_* were replaced in commit e955a071 ("staging: qlge: replace deprecated apis pci_dma_*") * the while loops were rewritten in commit 41e1bf81 ("Staging: qlge: Rewrite two while loops as simple for loops") * indentation was fixed in commit 0eb79fd1 ("staging: qlge: cleanup indent in qlge_main.c") I also slipped in one new TODO item, naughty me! Signed-off-by:
-
