- 23 Mar, 2010 1 commit
-
-
Stephen Hemminger authored
Minor perlcritic warning: headerdep.pl: "return" statement with explicit "undef" at line 84, column 2. See page 199 of PBP. (Severity: 5) The rationale according to PBP is that an explicit return of undef (contrary to most people's expectations) doesn't always evaluate as false. It has to with the fact that perl return value depends on context the function is called. If function is used in list context, the appropriate return value for false is an empty list; whereas in scalar context the return value for false is undefined. By just using a "return" both cases are handled. In the context of a trivial script this doesn't matter. But one script may be cut-paste into later code (most people like me only know 50% of perl), that is why perlcritic always complains Signed-off-by:
Stephen Hemminger <shemminger@vyatta.com> Signed-off-by:
Michal Marek <mmarek@suse.cz>
-
- 11 Mar, 2010 1 commit
-
-
Wu Zhangjin authored
The output of LZO is not aligned with the other output: ... CC drivers/usb/mon/usbmon.mod.o LZO arch/mips/boot/compressed/vmlinux.lzo ... This patch fixes it. Signed-off-by:
Wu Zhangjin <wuzhangjin@gmail.com> Signed-off-by:
-
- 10 Mar, 2010 1 commit
-
-
Michal Marek authored
The previous approach didn't work if one did make modules && make modules_install Add modules.builtin as dependency of _modinst_, which is the target that actually needs the file. Reported-by:
Andrew Morton <akpm@linux-foundation.org> Signed-off-by:
-
- 08 Mar, 2010 2 commits
-
-
Michal Marek authored
This reverts commit eb8f844c. Ian Campbell writes: > I keep my kernel source tree on a more powerful build box where I run my > builds etc (including "make cscope") but run my editor from my > workstation with an NFS mount to the source. This worked fine for me > using relative paths for cscope. Using absolute paths in cscope breaks > this previously working setup because the root path is not the same on > both systems. I guess this is similar to moving the source tree around. > > Without wanting to start a flamewar it really sounds to me like we are > working around a vim (or cscope) bug here, emacs with cscope bindings > works fine in this configuration. Given that absolute paths can be forced by make O=. cscope, change the default back to relative paths. Ian Campbell <ijc@hellion.org.uk> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by:
-
Michal Marek authored
Only regenerate it if the configuration has changed. Also, do this after the modules build to fix errors with some weird Makefiles that are generated during build. Reported-by:
Eric Miao <eric.y.miao@gmail.com> Signed-off-by:
-
- 07 Mar, 2010 9 commits
-
-
Stephen Hemminger authored
Better practice to use 3 arg open and local file handles. Signed-off-by:
WANG Cong <amwang@redhat.com> Cc: Michal Marek <mmarek@suse.cz> Signed-off-by:
-
Stephen Hemminger authored
According to PBP; best way practice is to use local reference for file handle and three argument open. Also perl prototypes are a mistake. Signed-off-by:
-
Stephen Hemminger authored
Use local file handles, use three argument open. Don't modify arguments in perl grep (use sed instead) Signed-off-by:
-
Stephen Hemminger authored
Turn on strict checking. Simplify code by using "unless" statement. Signed-off-by:
-
Stephen Hemminger authored
Use local file handle not global. Make loop and other variables local in scope. Signed-off-by:
-
Stephen Hemminger authored
Turn on strict checking. Use three arguement open Standard practice in perl is to use undef not zero for false Signed-off-by:
-
Stephen Hemminger authored
Turn on strict checking. Use local file handles. Use three argument open. Signed-off-by:
-
Stephen Hemminger authored
Cleanup checkstack script: * Turn on strict checking * Fix resulting error message because the declaration syntax was incorrect. * Remove incorrect and misleading use of prototype - prototype not required for this type of sort function because $a and $b are being used in this contex - if prototype was being used it should be for both arguments * Use closure for sort function Signed-off-by: -
FEJES Jozsef authored
This patch creates the standard md5sums file for 'make deb-pkg' just like the dh_md5sums debhelper script. Signed-off-by:
Jozsef Fejes <fejes@joco.name> Signed-off-by:
-
- 03 Mar, 2010 25 commits
-
-
Denys Vlasenko authored
Signed-off-by:
Denys Vlasenko <vda.linux@googlemail.com> Signed-off-by:
-
Denys Vlasenko authored
Signed-off-by:
-
Denys Vlasenko authored
Signed-off-by:
-
Denys Vlasenko authored
Signed-off-by:
-
Denys Vlasenko authored
Signed-off-by:
-
Denys Vlasenko authored
Signed-off-by:
-
Denys Vlasenko authored
Signed-off-by:
-
Denys Vlasenko authored
Signed-off-by:
-
Denys Vlasenko authored
Signed-off-by:
-
Denys Vlasenko authored
Signed-off-by:
-
Denys Vlasenko authored
Signed-off-by:
-
Denys Vlasenko authored
Signed-off-by:
-
Denys Vlasenko authored
Signed-off-by:
-
Denys Vlasenko authored
Signed-off-by:
-
Denys Vlasenko authored
Signed-off-by:
-
Denys Vlasenko authored
Signed-off-by:
-
Denys Vlasenko authored
Signed-off-by:
-
Denys Vlasenko authored
Signed-off-by:
-
Tim Abbott authored
Signed-off-by:
Tim Abbott <tabbott@ksplice.com> Cc: Sam Ravnborg <sam@ravnborg.org> Signed-off-by:
-
Tim Abbott authored
Signed-off-by:
-
Tim Abbott authored
There is already an architecture-independent __page_aligned_data macro for this purpose, so removing the powerpc-specific macro should be harmless. Signed-off-by:
-
Tim Abbott authored
Signed-off-by:
-
Tim Abbott authored
Signed-off-by:
-
John Kacur authored
make ALLSOURCE_ARCHS=all tags - Document this in kbuild.txt Without this change you have to type each arch separately. Signed-off-by:
John Kacur <jkacur@redhat.com> Signed-off-by:
-
John Kacur authored
Signed-off-by:
-
- 22 Feb, 2010 1 commit
-
-
Michal Marek authored
$ make mrproper $ make tags GEN tags find: `arch/x86_64/': No such file or directory Caused by commit f81b1be4 (tags: include headers before source files) Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de> Acked-by:
WANG Cong <xiyou.wangcong@gmail.com> Signed-off-by:
-
