1. 30 Aug, 2021 3 commits
    • Linus Torvalds's avatar
      vt_kdsetmode: extend console locking · 2287a51b
      Linus Torvalds authored
      As per the long-suffering comment.
      Reported-by: default avatarMinh Yuan <yuanmingbuaa@gmail.com>
      Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
      Cc: Jiri Slaby <jirislaby@kernel.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      2287a51b
    • nick black's avatar
      console: consume APC, DM, DCS · 3a2b2eb5
      nick black authored
      The Linux console's VT102 implementation already consumes OSC
      ("Operating System Command") sequences, probably because that's how
      palette changes are transmitted.
      
      In addition to OSC, there are three other major clases of ANSI control
      strings: APC ("Application Program Command"), PM ("Privacy Message"),
      and DCS ("Device Control String").  They are handled similarly to OSC in
      terms of termination.
      
      Source: vt100.net
      
      Add three new enumerated states, one for each of these types.  All three
      are handled the same way right now--they simply consume input until
      terminated.  I hope to expand upon this firmament in the future.  Add
      new predicate ansi_control_string(), returning true for any of these
      states.  Replace explicit checks against ESosc with calls to this
      function.  Transition to these states appropriately from the escape
      initiation (ESesc) state.
      
      This was motivated by the following Notcurses bugs:
      
       https://github.com/dankamongmen/notcurses/issues/2050
       https://github.com/dankamongmen/notcurses/issues/1828
       https://github.com/dankamongmen/notcurses/issues/2069
      
      where standard VT sequences are not consumed by the Linux console.  It's
      not necessary that the Linux console *support* these sequences, but it
      ought *consume* these well-specified classes of sequences.
      
      Tested by sending a variety of escape sequences to the console, and
      verifying that they still worked, or were now properly consumed.
      Verified that the escapes were properly terminated at a generic level.
      Verified that the Notcurses tools continued to show expected output on
      the Linux console, except now without escape bleedthrough.
      
      Link: https://lore.kernel.org/lkml/YSydL0q8iaUfkphg@schwarzgerat.orthanc/Signed-off-by: default avatarnick black <dankamongmen@gmail.com>
      Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
      Cc: Jiri Slaby <jirislaby@kernel.org>
      Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
      Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      3a2b2eb5
    • Linus Torvalds's avatar
      string: improve default out-of-line memcmp() implementation · 291d47cc
      Linus Torvalds authored
      This just does the "if the architecture does efficient unaligned
      handling, start the memcmp using 'unsigned long' accesses", since
      Nikolay Borisov found a load that cares.
      
      This is basically the minimal patch, and limited to architectures that
      are known to not have slow unaligned handling.  We've had the stupid
      byte-at-a-time version forever, and nobody has ever even noticed before,
      so let's keep the fix minimal.
      
      A potential further improvement would be to align one of the sources in
      order to at least minimize unaligned cases, but the only real case of
      bigger memcmp() users seems to be the FIDEDUPERANGE ioctl().  As David
      Sterba says, the dedupe ioctl is typically called on ranges spanning
      many pages so the common case will all be page-aligned anyway.
      
      All the relevant architectures select HAVE_EFFICIENT_UNALIGNED_ACCESS,
      so I'm not going to worry about the combination of a very rare use-case
      and a rare architecture until somebody actually hits it.  Particularly
      since Nikolay also tested the more complex patch with extra alignment
      handling code, and it only added overhead.
      
      Link: https://lore.kernel.org/lkml/20210721135926.602840-1-nborisov@suse.com/Reported-by: default avatarNikolay Borisov <nborisov@suse.com>
      Cc: David Sterba <dsterba@suse.cz>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      291d47cc
  2. 29 Aug, 2021 8 commits
  3. 28 Aug, 2021 3 commits
  4. 27 Aug, 2021 18 commits
  5. 26 Aug, 2021 8 commits
    • Marek Marczykowski-Górecki's avatar
      PCI/MSI: Skip masking MSI-X on Xen PV · 1a519dc7
      Marek Marczykowski-Górecki authored
      When running as Xen PV guest, masking MSI-X is a responsibility of the
      hypervisor. The guest has no write access to the relevant BAR at all - when
      it tries to, it results in a crash like this:
      
          BUG: unable to handle page fault for address: ffffc9004069100c
          #PF: supervisor write access in kernel mode
          #PF: error_code(0x0003) - permissions violation
          RIP: e030:__pci_enable_msix_range.part.0+0x26b/0x5f0
           e1000e_set_interrupt_capability+0xbf/0xd0 [e1000e]
           e1000_probe+0x41f/0xdb0 [e1000e]
           local_pci_probe+0x42/0x80
          (...)
      
      The recently introduced function msix_mask_all() does not check the global
      variable pci_msi_ignore_mask which is set by XEN PV to bypass the masking
      of MSI[-X] interrupts.
      
      Add the check to make this function XEN PV compatible.
      
      Fixes: 7d5ec3d3 ("PCI/MSI: Mask all unused MSI-X entries")
      Signed-off-by: default avatarMarek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
      Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
      Acked-by: default avatarBjorn Helgaas <bhelgaas@google.com>
      Cc: stable@vger.kernel.org
      Link: https://lore.kernel.org/r/20210826170342.135172-1-marmarek@invisiblethingslab.com
      1a519dc7
    • Linus Torvalds's avatar
      Merge tag 'nfsd-5.14-1' of git://linux-nfs.org/~bfields/linux · 73367f05
      Linus Torvalds authored
      Pull nfsd fix from Bruce Fields:
       "This is a one-liner fix for a serious bug that can cause the server to
        become unresponsive to a client, so I think it's worth the last-minute
        inclusion for 5.14"
      
      * tag 'nfsd-5.14-1' of git://linux-nfs.org/~bfields/linux:
        SUNRPC: Fix XPT_BUSY flag leakage in svc_handle_xprt()...
      73367f05
    • Linus Torvalds's avatar
      Merge tag 'net-5.14-rc8' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net · 8a2cb8bd
      Linus Torvalds authored
      Pull networking fixes from Jakub Kicinski:
       "Networking fixes, including fixes from can and bpf.
      
        Closing three hw-dependent regressions. Any fixes of note are in the
        'old code' category. Nothing blocking release from our perspective.
      
        Current release - regressions:
      
         - stmmac: revert "stmmac: align RX buffers"
      
         - usb: asix: ax88772: move embedded PHY detection as early as
           possible
      
         - usb: asix: do not call phy_disconnect() for ax88178
      
         - Revert "net: really fix the build...", from Kalle to fix QCA6390
      
        Current release - new code bugs:
      
         - phy: mediatek: add the missing suspend/resume callbacks
      
        Previous releases - regressions:
      
         - qrtr: fix another OOB Read in qrtr_endpoint_post
      
         - stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings
      
        Previous releases - always broken:
      
         - inet: use siphash in exception handling
      
         - ip_gre: add validation for csum_start
      
         - bpf: fix ringbuf helper function compatibility
      
         - rtnetlink: return correct error on changing device netns
      
         - e1000e: do not try to recover the NVM checksum on Tiger Lake"
      
      * tag 'net-5.14-rc8' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net: (43 commits)
        Revert "net: really fix the build..."
        net: hns3: fix get wrong pfc_en when query PFC configuration
        net: hns3: fix GRO configuration error after reset
        net: hns3: change the method of getting cmd index in debugfs
        net: hns3: fix duplicate node in VLAN list
        net: hns3: fix speed unknown issue in bond 4
        net: hns3: add waiting time before cmdq memory is released
        net: hns3: clear hardware resource when loading driver
        net: fix NULL pointer reference in cipso_v4_doi_free
        rtnetlink: Return correct error on changing device netns
        net: dsa: hellcreek: Adjust schedule look ahead window
        net: dsa: hellcreek: Fix incorrect setting of GCL
        cxgb4: dont touch blocked freelist bitmap after free
        ipv4: use siphash instead of Jenkins in fnhe_hashfun()
        ipv6: use siphash in rt6_exception_hash()
        can: usb: esd_usb2: esd_usb2_rx_event(): fix the interchange of the CAN RX and TX error counters
        net: usb: asix: ax88772: fix boolconv.cocci warnings
        net/sched: ets: fix crash when flipping from 'strict' to 'quantum'
        qede: Fix memset corruption
        net: stmmac: fix kernel panic due to NULL pointer dereference of buf->xdp
        ...
      8a2cb8bd
    • Jens Axboe's avatar
      Revert "block/mq-deadline: Prioritize high-priority requests" · 7b05bf77
      Jens Axboe authored
      This reverts commit fb926032.
      
      Zhen reports that this commit slows down mq-deadline on a 128 thread
      box, going from 258K IOPS to 170-180K. My testing shows that Optane
      gen2 IOPS goes from 2.3M IOPS to 1.2M IOPS on a 64 thread box.
      
      Looking in detail at the code, the main culprit here is needing to sum
      percpu counters in the dispatch hot path, leading to very high CPU
      utilization there. To make matters worse, the code currently needs to
      sum 2 percpu counters, and it does so in the most naive way of iterating
      possible CPUs _twice_.
      
      Since we're close to release, revert this commit and we can re-do it
      with regular per-priority counters instead for the 5.15 kernel.
      
      Link: https://lore.kernel.org/linux-block/20210826144039.2143-1-thunder.leizhen@huawei.com/Reported-by: default avatarZhen Lei <thunder.leizhen@huawei.com>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      7b05bf77
    • Linus Torvalds's avatar
      Merge tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux · 1a6d80ff
      Linus Torvalds authored
      Pull arm64 fix from Will Deacon:
       "We received a report this week that the generic version of
        pfn_valid(), which we switched to this merge window in 16c9afc7
        ("arm64/mm: drop HAVE_ARCH_PFN_VALID"), interacts badly with
        dma_map_resource() due to the following check:
      
              /* Don't allow RAM to be mapped */
              if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
                      return DMA_MAPPING_ERROR;
      
        Since the ongoing saga to determine the semantics of pfn_valid() is
        unlikely to be resolved this week (does it indicate valid memory, or
        just the presence of a struct page, or whether that struct page has
        been initialised?), just revert back to our old version of pfn_valid()
        for 5.14.
      
        Summary:
      
         - Fix dma_map_resource() by reverting back to old pfn_valid() code"
      
      * tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux:
        Partially revert "arm64/mm: drop HAVE_ARCH_PFN_VALID"
      1a6d80ff
    • Linus Torvalds's avatar
      Merge tag 'ceph-for-5.14-rc8' of git://github.com/ceph/ceph-client · 97d8cc20
      Linus Torvalds authored
      Pull ceph fixes from Ilya Dryomov:
       "Two memory management fixes for the filesystem"
      
      * tag 'ceph-for-5.14-rc8' of git://github.com/ceph/ceph-client:
        ceph: fix possible null-pointer dereference in ceph_mdsmap_decode()
        ceph: correctly handle releasing an embedded cap flush
      97d8cc20
    • Kalle Valo's avatar
      Revert "net: really fix the build..." · 9ebc2758
      Kalle Valo authored
      This reverts commit ce78ffa3.
      
      Wren and Nicolas reported that ath11k was failing to initialise QCA6390
      Wi-Fi 6 device with error:
      
      qcom_mhi_qrtr: probe of mhi0_IPCR failed with error -22
      
      Commit ce78ffa3 ("net: really fix the build..."), introduced in
      v5.14-rc5, caused this regression in qrtr. Most likely all ath11k
      devices are broken, but I only tested QCA6390. Let's revert the broken
      commit so that ath11k works again.
      Reported-by: default avatarWren Turkal <wt@penguintechs.org>
      Reported-by: default avatarNicolas Schichan <nschichan@freebox.fr>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      Link: https://lore.kernel.org/r/20210826172816.24478-1-kvalo@codeaurora.orgSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      9ebc2758
    • Linus Torvalds's avatar
      Merge tag 'for-5.14-rc7-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux · 9b49ceb8
      Linus Torvalds authored
      Pull btrfs fix from David Sterba:
       "One more fix that I think qualifies for a late merge. It's a revert of
        a one-liner fix that meanwhile got backported to stable kernels and we
        got reports from users.
      
        The broken fix prevents creating compressed inline extents, which
        could be noticeable on space consumption.
      
        Technically it's a regression as the patch was merged in 5.14-rc1 but
        got propagated to several stable kernels and has higher exposure than
        a 'typical' development cycle bug"
      
      * tag 'for-5.14-rc7-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux:
        Revert "btrfs: compression: don't try to compress if we don't have enough pages"
      9b49ceb8