- 02 Jan, 2015 9 commits
-
-
Greg Kroah-Hartman authored
When removing a connection with no protocol assigned to it, the kernel oopses as we always thought protocols were always there. Fix that problem, oopses are bad. Signed-off-by:
Greg Kroah-Hartman <greg@kroah.com> Reviewed-by:
Alex Elder <elder@linaro.org>
-
Greg Kroah-Hartman authored
We want to be able to "blame" a protocol for things at times, so give them a name we can refer to them by. Announce when they are added or removed from the system so we have a chance to know what is going on in the kernel logs. Signed-off-by:
-
Greg Kroah-Hartman authored
Use the list that the driver core keeps of our structure, no need to duplicate it with a local list as well. This gets rid of a static lock too, always a nice thing to do. Signed-off-by:
-
Greg Kroah-Hartman authored
The i2c protocol belongs in the gpbridge driver, so move it there. Signed-off-by:
-
Greg Kroah-Hartman authored
This bundles together the existing GP Bridged PHY protocols that were part of the Greybus core: USB, UART, SDIO, PWM, and GPIO. This is now a stand-alone kernel module. More logic will be moving here in the future to handle bridged devices. Signed-off-by:
-
Greg Kroah-Hartman authored
This moves the battery class protocol to be a stand-alone kernel module. Signed-off-by:
-
Greg Kroah-Hartman authored
We can't use the gb_protocol_driver() macro here as we need to do some init and exit logic when loading and removing, so "open code" the module init and exit functions. Signed-off-by:
-
Greg Kroah-Hartman authored
Now that protocols can be in a module, we need to reference count them to lock them into memory so they can't be removed while in use. So add a module owner structure, and have it automatically be assigned when registering the protocol. Signed-off-by:
-
Greg Kroah-Hartman authored
Use a "name" for when we don't have a valid device id yet, instead of a magic value of 0xff. Reported-by:
-
- 24 Dec, 2014 5 commits
-
-
Greg Kroah-Hartman authored
This splits the i2c-gb protocol into a stand-alone kernel module. It's not going to stay in this fashion for long, this was done to test the "can a protcol be loaded later" logic. Future refactoring is going to move the gpbridge protocols to a separate kernel module, where this protocol is going to live. But for now, split it out, it is good to test with, and shows a bug in gbsim at the moment. Reviewed-by:
-
Greg Kroah-Hartman authored
When adding a new protocol to the system, walk all bundles and try to hook up any connections that do not have a protocol already. This sets the stage to allow for protocols to be loaded at any time, not just before the device is seen in the system. Reviewed-by:
-
Greg Kroah-Hartman authored
Protocol handlers need some greybus symbols, so export them so that they can be built outside of the greybus core. Reviewed-by:
-
Greg Kroah-Hartman authored
We will want to return this value as a return value for module_init() and bool does not play well with module_init(). So make it a "real" error value and return int and fix up all callers of the function. Reviewed-by:
-
Greg Kroah-Hartman authored
The list was global and had no locking. It's not like we were ever parsing more than one manifest at the same time right now, but we might in the future. And we really want this to be local to the interface itself, for future work redoing how to bind protocols to bundles, so move the list to the interface structure. Reviewed-by:
-
- 23 Dec, 2014 1 commit
-
-
Greg Kroah-Hartman authored
Modules in the greybus system sit above the interface, so insert them early in the sysfs tree. We dynamically create them when we have an interface that references a module, as we don't get a "module create" message directly. They also dynamically go away when the last interface associated with a module is removed. Naming scheme for modules/interfaces/bundles/connections is bumped up by one ':', and now looks like the following: /sys/bus/greybus $ tree . ├── devices │ ├── 7 -> ../../../devices/pci0000:00/0000:00:14.0/usb1/1-1/7 │ ├── 7:7 -> ../../../devices/pci0000:00/0000:00:14.0/usb1/1-1/7/7:7 │ ├── 7:7:0 -> ../../../devices/pci0000:00/0000:00:14.0/usb1/1-1/7/7:7/7:7:0 │ └── 7:7:0:1 -> ../../../devices/pci0000:00/0000:00:14.0/usb1/1-1/7/7:7/7:7:0/7:7:0:1 ├── drivers ├── drivers_autoprobe ├── drivers_probe └── uevent 6 directories, 3 files /sys/bus/greybus $ grep . devices/*/uevent devices/7/uevent:DEVTYPE=greybus_module devices/7:7/uevent:DEVTYPE=greybus_interface devices/7:7:0/uevent:DEVTYPE=greybus_bundle devices/7:7:0:1/uevent:DEVTYPE=greybus_connection We still have some "confusion" about interface ids and module ids, which will be cleaned up later when the svc control protocol changes die down, right now we just name a module after the interface as we don't have any modules that have multiple interfaces in our systems. This has been tested with gbsim. Signed-off-by:
-
- 19 Dec, 2014 9 commits
-
-
Greg Kroah-Hartman authored
It's a local interface lock, not a modules lock, so rename it. Reviewed-by:
-
Greg Kroah-Hartman authored
This is really a list of interfaces, not modules, so rename it so that we don't get confused when we really do add modules to the whole system later on. Reviewed-by:
-
Greg Kroah-Hartman authored
rename gb_add_module -> gb_add_interface rename gb_remove_modules -> gb_remove_interfaces rename gb_remove_module -> gb_remove_interface And move the function prototypes to interface.h, where they belong. Reviewed-by:
-
Greg Kroah-Hartman authored
Align up the BIT() #defines and properly comment the include block define. Reviewed-by:
-
Greg Kroah-Hartman authored
MAX_CPORTS_PER_MODULE and MAX_STRINGS_PER_MODULE are not used anywhere anymore, so remove them lest someone thing we have limits. Signed-off-by:
-
Greg Kroah-Hartman authored
This moves the id structure name to not have "block" in it, as that doesn't make sense anymore with the renaming of the gb_interface structure. Reviewed-by:
-
Greg Kroah-Hartman authored
Rename struct gb_interface_block to struct gb_interface Lots of renaming, and variable renames as well (gb_ib->intf), but all should be sane with regards to the new naming scheme we are using. Reviewed-by:
-
Greg Kroah-Hartman authored
Interface_block is being renamed to interface, so move the file first. Reviewed-by:
-
Greg Kroah-Hartman authored
Alex pointed out one rename I missed previously, this fixes up the interface_block list of bundles name. Reviewed-by:
-
- 13 Dec, 2014 3 commits
-
-
Greg Kroah-Hartman authored
Rename struct gb_interface to struct gb_bundle It's a lot of renaming, some structures got renamed and also some fields, but the goal was to rename things to make sense with the new naming of how the system is put together in the 'driver model' view. Reviewed-by:
-
Greg Kroah-Hartman authored
-EPROTO happens when devices are starting to go away in a system, or there is something wrong on the USB connection. Either way, it's safe to resubmit the urb for this error, don't complain to userspace about this, as the user will see this for every device removed, which looks scary, but means nothing. Signed-off-by:
-
Greg Kroah-Hartman authored
We are renameing the "interface" term to "bundle" so rename the files before we start changing structure names to make it easier for people to see what really is happening in the changes. Signed-off-by:
-
- 12 Dec, 2014 13 commits
-
-
Alex Elder authored
I was asked to add a Linaro copyright to all Greybus source files that anyone at Linaro has modified. This patch does that. Signed-off-by:
-
Greg Kroah-Hartman authored
Because of this, rename greybus_module_id to greybus_interface_block_id. We still need to add a way for a "class" driver to be bound to an interface, but for now, all we really need is the vendor/product pair as the GP Bridge interface block is going to be our main user. Reviewed-by:
-
Greg Kroah-Hartman authored
Yes, an interface has a device id sysfs file, so we need to document it. Reviewed-by:
-
Greg Kroah-Hartman authored
Document what the sysfs files are for connections, so that people have a chance to understand what they can be used for. Reviewed-by:
-
Greg Kroah-Hartman authored
No need to keep these out in sysfs.c, move them into the interface_block.c file so that we can see them easier, and remove some variable definitions by taking advantage of the attribute group macro. Reviewed-by:
-
Greg Kroah-Hartman authored
Documentation, what, really? Yes. Reviewed-by:
-
Greg Kroah-Hartman authored
The sysfs files for an interface block should not have 'module' in them. This was a hold-over from when we thought we were going to have all attributes of a "module" in one directory. Remove the prefix as it's not needed, and is confusing considering modules can not have strings or any of these attributes. Reviewed-by:
-
Greg Kroah-Hartman authored
Rename struct gb_module to struct gb_interface_block It's a complex rename, some functions got their name changed where needed, but primarily this change is focused on the structure and where it is used. Future changes will clean up the remaining usages of the term "module" in individual changes, this one spanned the whole subsystem so do it all at once. Reviewed-by:
-
Greg Kroah-Hartman authored
"modules" in the driver model here, are really "interface blocks" as that is what they are physically tied to. So rename the files before we start changing the code to make it obvious what is going on. Reviewed-by:
-
Greg Kroah-Hartman authored
We aren't using this anymore, so remove gb_tty from struct gb_module. Reviewed-by:
-
Greg Kroah-Hartman authored
We removed the module version from the spec, so remove them from the code as well. It's still in the manifest as we need to sync with gbsim / firmware when we do that, which will happen sometime in the next weeks. Reviewed-by:
-
Greg Kroah-Hartman authored
No need to specifically include the greybus module.h here, greybus.h already does so and we will be renaming it soon. Reviewed-by:
-
Alex Elder authored
In talking with Perry today I learned that the CPort id expected to supplied over the HSIC interface to the APB is different from the way I understood it. My understanding was that the CPort id to supply always specified the CPort id on the other end of a connection. However, Perry says the mapping between local CPort id and remote CPort id (and device id) is done by the host UniPro interface. So whether sending or receiving data, the CPort id that the Greybus code should supply to the AP Bridge is the one representing the AP side of a connection. This patch fixes this. The receive side already used that CPort id; it's only the sending code that needed to be changed. Signed-off-by:
-
