1. 27 Oct, 2023 1 commit
    • Damien Le Moal's avatar
      scsi: sd: Introduce manage_shutdown device flag · 24eca2dc
      Damien Le Moal authored
      Commit aa3998db ("ata: libata-scsi: Disable scsi device
      manage_system_start_stop") change setting the manage_system_start_stop
      flag to false for libata managed disks to enable libata internal
      management of disk suspend/resume. However, a side effect of this change
      is that on system shutdown, disks are no longer being stopped (set to
      standby mode with the heads unloaded). While this is not a critical
      issue, this unclean shutdown is not recommended and shows up with
      increased smart counters (e.g. the unexpected power loss counter
      "Unexpect_Power_Loss_Ct").
      
      Instead of defining a shutdown driver method for all ATA adapter
      drivers (not all of them define that operation), this patch resolves
      this issue by further refining the sd driver start/stop control of disks
      using the new flag manage_shutdown. If this new flag is set to true by
      a low level driver, the function sd_shutdown() will issue a
      START STOP UNIT command with the start argument set to 0 when a disk
      needs to be powered off (suspended) on system power off, that is, when
      system_state is equal to SYSTEM_POWER_OFF.
      
      Similarly to the other manage_xxx flags, the new manage_shutdown flag is
      exposed through sysfs as a read-write device attribute.
      
      To avoid any confusion between manage_shutdown and
      manage_system_start_stop, the comments describing these flags in
      include/scsi/scsi.h are also improved.
      
      Fixes: aa3998db ("ata: libata-scsi: Disable scsi device manage_system_start_stop")
      Cc: stable@vger.kernel.org
      Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218038
      Link: https://lore.kernel.org/all/cd397c88-bf53-4768-9ab8-9d107df9e613@gmail.com/Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
      Reviewed-by: default avatarNiklas Cassel <niklas.cassel@wdc.com>
      Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
      Reviewed-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
      Acked-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      24eca2dc
  2. 10 Oct, 2023 5 commits
  3. 08 Oct, 2023 4 commits
  4. 07 Oct, 2023 10 commits
  5. 06 Oct, 2023 20 commits