1. 17 May, 2021 40 commits
    • Jiapeng Chong's avatar
      net/packet: Remove redundant assignment to ret · 25c55b38
      Jiapeng Chong authored
      Variable ret is set to '0' or '-EBUSY', but this value is never read
      as it is not used later on, hence it is a redundant assignment and
      can be removed.
      
      Clean up the following clang-analyzer warning:
      
      net/packet/af_packet.c:3936:4: warning: Value stored to 'ret' is never
      read [clang-analyzer-deadcode.DeadStores].
      
      net/packet/af_packet.c:3933:4: warning: Value stored to 'ret' is never
      read [clang-analyzer-deadcode.DeadStores].
      
      No functional change.
      Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
      Signed-off-by: default avatarJiapeng Chong <jiapeng.chong@linux.alibaba.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      25c55b38
    • David S. Miller's avatar
      Merge branch 'stmmac-xpcs-eee' · 8ed2e60b
      David S. Miller authored
      Michael Sit Wei Hong says:
      
      ====================
      Introducing support for DWC xpcs Energy Efficient Ethernet
      
      The goal of this patch set is to enable EEE in the xpcs so that when
      EEE is enabled, the MAC-->xpcs-->PHY have all the EEE related
      configurations enabled.
      
      Patch 1 adds the functions to enable EEE in the xpcs and sets it to
      transparent mode.
      Patch 2 adds the callbacks to configure the xpcs EEE mode.
      
      The results are tested by checking the lpi counters of the tx and rx
      path of the interface. When EEE is enabled, the lpi counters should
      increament as it enters and exits lpi states.
      
      host@EHL$ ethtool --show-eee enp0s30f4
      EEE Settings for enp0s30f4:
              EEE status: disabled
              Tx LPI: disabled
              Supported EEE link modes:  100baseT/Full
                                         1000baseT/Full
              Advertised EEE link modes:  Not reported
              Link partner advertised EEE link modes:  100baseT/Full
                                                       1000baseT/Full
      host@EHL$ ethtool -S enp0s30f4 | grep lpi
           irq_tx_path_in_lpi_mode_n: 0
           irq_tx_path_exit_lpi_mode_n: 0
           irq_rx_path_in_lpi_mode_n: 0
           irq_rx_path_exit_lpi_mode_n: 0
      host@EHL$ ethtool --set-eee enp0s30f4 eee on
      host@EHL$ [  110.265154] intel-eth-pci 0000:00:1e.4 enp0s30f4: Link is Down
      [  112.315155] intel-eth-pci 0000:00:1e.4 enp0s30f4: Link is Up - 1Gbps/Full - flow control off
      [  112.324612] IPv6: ADDRCONF(NETDEV_CHANGE): enp0s30f4: link becomes ready
      host@EHL$ ethtool --show-eee enp0s30f4
      EEE Settings for enp0s30f4:
              EEE status: enabled - active
              Tx LPI: 1000000 (us)
              Supported EEE link modes:  100baseT/Full
                                         1000baseT/Full
              Advertised EEE link modes:  100baseT/Full
                                          1000baseT/Full
              Link partner advertised EEE link modes:  100baseT/Full
                                                       1000baseT/Full
      host@EHL$ ethtool -S enp0s30f4 | grep lpi
           irq_tx_path_in_lpi_mode_n: 6
           irq_tx_path_exit_lpi_mode_n: 5
           irq_rx_path_in_lpi_mode_n: 7
           irq_rx_path_exit_lpi_mode_n: 6
      host@EHL$ ping 192.168.1.1
      PING 192.168.1.1 (192.168.1.1) 56(84) bytes of data.
      64 bytes from 192.168.1.1: icmp_seq=1 ttl=64 time=1.02 ms
      64 bytes from 192.168.1.1: icmp_seq=2 ttl=64 time=0.510 ms
      64 bytes from 192.168.1.1: icmp_seq=3 ttl=64 time=0.489 ms
      64 bytes from 192.168.1.1: icmp_seq=4 ttl=64 time=0.484 ms
      64 bytes from 192.168.1.1: icmp_seq=5 ttl=64 time=0.504 ms
      64 bytes from 192.168.1.1: icmp_seq=6 ttl=64 time=0.466 ms
      64 bytes from 192.168.1.1: icmp_seq=7 ttl=64 time=0.529 ms
      64 bytes from 192.168.1.1: icmp_seq=8 ttl=64 time=0.519 ms
      64 bytes from 192.168.1.1: icmp_seq=9 ttl=64 time=0.518 ms
      64 bytes from 192.168.1.1: icmp_seq=10 ttl=64 time=0.501 ms
      
      --- 192.168.1.1 ping statistics ---
      10 packets transmitted, 10 received, 0% packet loss, time 9216ms
      rtt min/avg/max/mdev = 0.466/0.553/1.018/0.155 ms
      host@EHL$ ethtool -S enp0s30f4 | grep lpi
           irq_tx_path_in_lpi_mode_n: 22
           irq_tx_path_exit_lpi_mode_n: 21
           irq_rx_path_in_lpi_mode_n: 21
           irq_rx_path_exit_lpi_mode_n: 20
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      8ed2e60b
    • Michael Sit Wei Hong's avatar
      net: stmmac: Add callbacks for DWC xpcs Energy Efficient Ethernet · e80fe71b
      Michael Sit Wei Hong authored
      Link xpcs callback functions for MAC to configure the xpcs EEE feature.
      
      The clk_eee frequency is used to calculate the MULT_FACT_100NS. This is
      to adjust the clock tic closer to 100ns.
      Signed-off-by: default avatarMichael Sit Wei Hong <michael.wei.hong.sit@intel.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e80fe71b
    • Michael Sit Wei Hong's avatar
      net: pcs: Introducing support for DWC xpcs Energy Efficient Ethernet · 7617af3d
      Michael Sit Wei Hong authored
      Add DWC xpcs EEE support callbacks.The callback function is used to
      set EEE registers on xpcs.
      
      xpcs transparent mode is enabled to allow PHY to detect MAC EEE status.
      Signed-off-by: default avatarMichael Sit Wei Hong <michael.wei.hong.sit@intel.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7617af3d
    • Dan Carpenter's avatar
      alx: fix a double unlock in alx_probe() · 9d8a29ae
      Dan Carpenter authored
      We're not holding the lock at this point so "goto unlock;" should be
      "goto unmap;"
      
      Fixes: 4a5fe57e ("alx: use fine-grained locking instead of RTNL")
      Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      9d8a29ae
    • Loic Poulain's avatar
      net: wwan: Add WWAN port type attribute · b3e22e10
      Loic Poulain authored
      The port type is by default part of the WWAN port device name.
      However device name can not be considered as a 'stable' API and
      may be subject to change in the future. This change adds a proper
      device attribute that can be used to determine the WWAN protocol/
      type.
      Signed-off-by: default avatarLoic Poulain <loic.poulain@linaro.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      b3e22e10
    • David S. Miller's avatar
      Merge branch 'stmmac-RK3568' · 885e4056
      David S. Miller authored
      Ezequiel Garcia says:
      
      ====================
      stmmmac: RK3568
      
      Here's the third version of this patchset, taking
      the feedback from Heiko and Chen-Yu Tsai.
      
      Although this solution is a tad ugly as it hardcodes
      the register addresses, we believe it's the most robust approach.
      
      See:
      
      https://lore.kernel.org/netdev/CAGb2v67ZBR=XDFPeXQc429HNu_dbY__-KN50tvBW44fXMs78_w@mail.gmail.com/
      
      This is tested on RK3566 EVB2 and seems to work well.
      Once the RK3568 devicetree lands upstream, we'll post
      patches to add network support for RK3566 and RK3568.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      885e4056
    • David Wu's avatar
      net: stmmac: Add RK3566/RK3568 SoC support · 3bb3d6b1
      David Wu authored
      Add constants and callback functions for the dwmac present
      on RK3566/RK3568 SoCs.
      
      RK3568 has two MACs, and RK3566 just one, but it's otherwise
      the same IP core.
      Signed-off-by: default avatarDavid Wu <david.wu@rock-chips.com>
      [Ezequiel: Separate rk3566-gmac support]
      Signed-off-by: default avatarEzequiel Garcia <ezequiel@collabora.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      3bb3d6b1
    • Ezequiel Garcia's avatar
      dt-bindings: net: rockchip-dwmac: add rk3568 compatible string · f9da1c9d
      Ezequiel Garcia authored
      Add compatible string for RK3568 gmac, and constrain it to
      be compatible with Synopsys dwmac 4.20a.
      Signed-off-by: default avatarEzequiel Garcia <ezequiel@collabora.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f9da1c9d
    • David Wu's avatar
      net: stmmac: dwmac-rk: Check platform-specific ops · 37c80d15
      David Wu authored
      Add a check for non-null struct rk_gmac_ops for the
      configured PHY interface mode, failing if unsupported.
      Signed-off-by: default avatarDavid Wu <david.wu@rock-chips.com>
      [Ezequiel: Refactor so it fails if unsupported]
      Signed-off-by: default avatarEzequiel Garcia <ezequiel@collabora.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      37c80d15
    • Ezequiel Garcia's avatar
      net: stmmac: Don't set has_gmac if has_gmac4 is set · d6b06251
      Ezequiel Garcia authored
      Some Rockchip platforms have a GMAC4 core, and therefore
      'plat_stmmacenet_data.has_gmac' shouldn't be set if
      'plat_stmmacenet_data.has_gmac4' is set.
      Signed-off-by: default avatarEzequiel Garcia <ezequiel@collabora.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d6b06251
    • Yejune Deng's avatar
      net: Remove the member netns_ok · 5796254e
      Yejune Deng authored
      Every protocol has the 'netns_ok' member and it is euqal to 1. The
      'if (!prot->netns_ok)' always false in inet_add_protocol().
      Signed-off-by: default avatarYejune Deng <yejunedeng@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      5796254e
    • David S. Miller's avatar
      Merge branch 'mlxsw-next' · 609c8ae8
      David S. Miller authored
      Ido Schimmel says:
      
      ====================
      mlxsw: Various updates
      
      This patchset contains various updates to the mlxsw driver and related
      selftests.
      
      Patches #1-#5 contain various updates to mlxsw selftests. The most
      significant change is the conversion of the DCB selftests to use the new
      iproute2 DCB support.
      
      Patches #6-#9 contain mostly trivial changes to the driver itself. No
      user facing changes.
      
      Patches #10-#11 remove support for SwitchX-2 and SwitchIB ASICs that did
      not see any updates in the last 4-5 years and will not see any in the
      future. See individual commit messages for detailed explanation as to
      why it is OK to remove these drivers from the kernel.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      609c8ae8
    • Amit Cohen's avatar
      mlxsw: Remove Mellanox SwitchX-2 ASIC support · b0d80c01
      Amit Cohen authored
      Initial support for the Mellanox SwitchX-2 ASIC was added in July 2015.
      Since then all development efforts shifted towards the Mellanox Spectrum
      ASICs and development of this driver stopped beside trivial fixes and
      refactoring. Therefore, the driver does not support any switch offloads
      and simply traps all traffic to the CPU, rendering it irrelevant for
      deployment.
      
      In addition, support for this ASIC was dropped by Mellanox a few years
      ago.
      
      Given the driver is not used by any users and that there is no
      intention of investing in its development, remove it from the kernel.
      Signed-off-by: default avatarAmit Cohen <amcohen@nvidia.com>
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      b0d80c01
    • Amit Cohen's avatar
      mlxsw: Remove Mellanox SwitchIB ASIC support · 9b43fbb8
      Amit Cohen authored
      Initial support for the Mellanox SwitchIB and SwitchIB-2 ASICs was added
      in October 2016, but since then development of this driver stopped.
      Therefore, the driver does not support any offloads and simply registers
      devlink ports for its front panel ports, rendering it irrelevant for
      deployment.
      
      Given the driver is not used by any users and that there is no intention
      of investing in its development, remove it from the kernel.
      Signed-off-by: default avatarAmit Cohen <amcohen@nvidia.com>
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      9b43fbb8
    • Ido Schimmel's avatar
      mlxsw: spectrum_router: Avoid missing error code warning · 51746a35
      Ido Schimmel authored
      Explicitly set the error code to zero before the goto statement to avoid
      the following smatch warning:
      
      drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c:3598 mlxsw_sp_nexthop_group_refresh() warn: missing error code 'err'
      
      The warning is a false positive, but the change both suppresses the
      warning and makes it clear to future readers that this is not an error
      path.
      
      The original report and discussion can be found here [1].
      
      [1] https://lore.kernel.org/lkml/202105141823.Td2h3Mbi-lkp@intel.com/
      
      Cc: Dan Carpenter <dan.carpenter@oracle.com>
      Suggested-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Reviewed-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      51746a35
    • Ido Schimmel's avatar
      mlxsw: core: Avoid unnecessary EMAD buffer copy · 8c2b58e6
      Ido Schimmel authored
      mlxsw_emad_transmit() takes care of sending EMAD transactions to the
      device. Since these transactions can time out, the driver performs up to
      5 retransmissions, each time copying the skb with the original request.
      
      The data of the skb does not change throughout the process, so there is
      no need to copy it each time. Instead, only the skb itself can be
      copied. Therefore, use skb_clone() instead of skb_copy().
      
      This reduces the latency of the function by about 16%.
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      8c2b58e6
    • Danielle Ratson's avatar
      mlxsw: Verify the accessed index doesn't exceed the array length · 837ec05c
      Danielle Ratson authored
      There are few cases in which an array index queried from a fw register,
      is accessed without any validation that it doesn't exceed the array
      length.
      
      Add a proper length validation, so accessing memory past the end of an
      array will be forbidden.
      Signed-off-by: default avatarDanielle Ratson <danieller@nvidia.com>
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      837ec05c
    • Danielle Ratson's avatar
      mlxsw: spectrum_buffers: Switch function arguments · ece5df87
      Danielle Ratson authored
      In the call path:
      
      mlxsw_sp_hdroom_bufs_reset_sizes()
          mlxsw_sp_hdroom_int_buf_size_get()
              ->int_buf_size_get()
      
      The 'speed' and 'mtu' arguments were mistakenly switched twice. The two
      bugs thus canceled each other.
      
      Clean this up by switching the arguments in both call sites, so that
      they are passed in the right order.
      
      Found during manual code inspection.
      Signed-off-by: default avatarDanielle Ratson <danieller@nvidia.com>
      Reviewed-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      ece5df87
    • Petr Machata's avatar
      selftests: mlxsw: qos_lib: Drop __mlnx_qos · b4d78694
      Petr Machata authored
      Now that the two users of this helper have been converted to iproute2 dcb,
      it is not necessary anymore. Drop it.
      Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      b4d78694
    • Petr Machata's avatar
      selftests: mlxsw: qos_pfc: Convert to iproute2 dcb · b0bab229
      Petr Machata authored
      There is a dedicated tool for configuration of DCB in iproute2 now. Use it
      in the selftest instead of mlnx_qos.
      Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      b0bab229
    • Petr Machata's avatar
      selftests: mlxsw: qos_headroom: Convert to iproute2 dcb · 9a1cac06
      Petr Machata authored
      There is a dedicated tool for configuration of DCB in iproute2 now. Use it
      in the selftest instead of mlnx_qos.
      Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      9a1cac06
    • Ido Schimmel's avatar
      selftests: mlxsw: Make sampling test more robust · 16355c0b
      Ido Schimmel authored
      The test sometimes fails with an error message such as:
      
      TEST: tc sample (w/ flower) rate (egress)                           [FAIL]
      	Expected 100 packets, got 70 packets, which is -30% off. Required accuracy is +-25%
      
      Make the test more robust by generating more packets, therefore
      increasing the number of expected samples. Decrease the transmission
      delay in order not to needlessly prolong the test.
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      16355c0b
    • Danielle Ratson's avatar
      selftests: mlxsw: Make the unsplit array global in port_scale test · 5d01071e
      Danielle Ratson authored
      Currently, the array of the ports that were split in the port_scale test
      is local, so the port_cleanup() unsplits an empty array.
      
      Make the array global so the cleanup will be preformed properly.
      Suggested-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarDanielle Ratson <danieller@nvidia.com>
      Reviewed-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      5d01071e
    • David S. Miller's avatar
      Merge branch 'func-names-comment' · 16145dbd
      David S. Miller authored
      Yang Shen says:
      
      ====================
      Rid W=1 warnings in net
      
      This is a set to fully clean drivers/net.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      16145dbd
    • Yang Shen's avatar
      net: hisilicon: hns: Fix wrong function name in comments · 5a9594cf
      Yang Shen authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c:121: warning: expecting prototype for hns_mac_is_adjust_link(). Prototype was for hns_mac_need_adjust_link() instead
       drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c:386: warning: expecting prototype for hns_mac_queue_config_bc_en(). Prototype was for hns_mac_port_config_bc_en() instead
       drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c:607: warning: expecting prototype for hns_mac_set_autoneg(). Prototype was for hns_mac_set_pauseparam() instead
       drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:236: warning: expecting prototype for hns_ppe_qid_cfg(). Prototype was for hns_dsaf_ppe_qid_cfg() instead
       drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:623: warning: expecting prototype for dsaf_tbl_tcam_mcast_cfg(). Prototype was for hns_dsaf_tbl_tcam_mcast_cfg() instead
       drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:1220: warning: expecting prototype for hns_dsaf_tbl_tcam_init(). Prototype was for hns_dsaf_comm_init() instead
       drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:2121: warning: expecting prototype for dsaf_pfc_unit_cnt(). Prototype was for hns_dsaf_pfc_unit_cnt() instead
       drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:2153: warning: expecting prototype for dsaf_port_work_rate_cfg(). Prototype was for hns_dsaf_port_work_rate_cfg() instead
       drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:2745: warning: expecting prototype for hns_dsaf_get_sset_count(). Prototype was for hns_dsaf_get_regs_count() instead
       drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:2957: warning: expecting prototype for dsaf_probe(). Prototype was for hns_dsaf_probe() instead
       drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:3011: warning: expecting prototype for dsaf_remove(). Prototype was for hns_dsaf_remove() instead
       drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c:366: warning: expecting prototype for hns_dsaf_srst_chns(). Prototype was for hns_dsaf_srst_chns_acpi() instead
       drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c:509: warning: expecting prototype for hns_mac_get_sds_mode(). Prototype was for hns_mac_get_phy_if() instead
       drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c:303: warning: expecting prototype for ppe_init_hw(). Prototype was for hns_ppe_init_hw() instead
       drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c:350: warning: expecting prototype for ppe_uninit_hw(). Prototype was for hns_ppe_uninit_hw() instead
       drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c:391: warning: expecting prototype for hns_ppe_reset(). Prototype was for hns_ppe_reset_common() instead
       drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c:464: warning: expecting prototype for ppe_get_strings(). Prototype was for hns_ppe_get_strings() instead
       drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c:920: warning: expecting prototype for rcb_get_sset_count(). Prototype was for hns_rcb_get_ring_regs_count() instead
       drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c:112: warning: expecting prototype for hns_xgmac_tx_lf_rf_insert(). Prototype was for hns_xgmac_lf_rf_insert() instead
       drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c:122: warning: expecting prototype for hns_xgmac__lf_rf_control_init(). Prototype was for hns_xgmac_lf_rf_control_init() instead
       drivers/net/ethernet/hisilicon/hns/hns_enet.c:777: warning: expecting prototype for hns_nic_adp_coalesce(). Prototype was for hns_nic_adpt_coalesce() instead
       drivers/net/ethernet/hisilicon/hns/hns_ethtool.c:202: warning: expecting prototype for hns_nic_set_link_settings(). Prototype was for hns_nic_set_link_ksettings() instead
       drivers/net/ethernet/hisilicon/hns/hns_ethtool.c:837: warning: expecting prototype for get_ethtool_stats(). Prototype was for hns_get_ethtool_stats() instead
       drivers/net/ethernet/hisilicon/hns/hns_ethtool.c:894: warning: expecting prototype for get_strings(). Prototype was for hns_get_strings() instead
      
      Cc: Yisen Zhuang <yisen.zhuang@huawei.com>
      Cc: Salil Mehta <salil.mehta@huawei.com>
      Signed-off-by: default avatarYang Shen <shenyang39@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      5a9594cf
    • Yang Shen's avatar
      net: phy: Demote non-compliant kernel-doc headers · 1f2d109e
      Yang Shen authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/net/phy/adin.c:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
       drivers/net/phy/rockchip.c:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
      
      Cc: Heiner Kallweit <hkallweit1@gmail.com>
      Cc: Russell King <linux@armlinux.org.uk>
      Signed-off-by: default avatarYang Shen <shenyang39@huawei.com>
      Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      1f2d109e
    • Yang Shen's avatar
      net: via: Fix wrong function name in comments · 03055a25
      Yang Shen authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/net/ethernet/via/via-velocity.c:1908: warning: expecting prototype for tx_srv(). Prototype was for velocity_tx_srv() instead
       drivers/net/ethernet/via/via-velocity.c:2466: warning: expecting prototype for velocity_get_status(). Prototype was for velocity_get_stats() instead
       drivers/net/ethernet/via/via-velocity.c:3734: warning: expecting prototype for velocity_cleanup(). Prototype was for velocity_cleanup_module() instead
      
      Cc: Francois Romieu <romieu@fr.zoreil.com>
      Signed-off-by: default avatarYang Shen <shenyang39@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      03055a25
    • Yang Shen's avatar
      net: ti: Fix wrong struct name in comments · 85ead77d
      Yang Shen authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/net/ethernet/ti/cpsw_ale.c:88: warning: expecting prototype for struct ale_dev_id. Prototype was for struct cpsw_ale_dev_id instead
      
      Cc: Cyril Chemparathy <cyril@ti.com>
      Cc: Grygorii Strashko <grygorii.strashko@ti.com>
      Signed-off-by: default avatarYang Shen <shenyang39@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      85ead77d
    • Yang Shen's avatar
      net: socionext: Demote non-compliant kernel-doc headers · 40d9fca8
      Yang Shen authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/net/ethernet/socionext/sni_ave.c:28: warning: expecting prototype for sni_ave.c(). Prototype was for AVE_IDR() instead
      Signed-off-by: default avatarYang Shen <shenyang39@huawei.com>
      Reviewed-by: default avatarKunihiko Hayashi <hayashi.kunihiko@socionext.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      40d9fca8
    • Yang Shen's avatar
      net: samsung: sxgbe: Fix wrong function name in comments · 61633d71
      Yang Shen authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c:797: warning: expecting prototype for sxgbe_tx_clean(). Prototype was for sxgbe_tx_all_clean() instead
       drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c:1026: warning: expecting prototype for sxgbe_init_tx_coalesce(). Prototype was for sxgbe_tx_init_coalesce() instead
      
      Cc: Byungho An <bh74.an@samsung.com>
      Signed-off-by: default avatarYang Shen <shenyang39@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      61633d71
    • Yang Shen's avatar
      net: calxeda: Fix wrong function name in comments · 9f2e6fb6
      Yang Shen authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c:761: warning: expecting prototype for qlcnic_83xx_idc_cold_state(). Prototype was for qlcnic_83xx_idc_cold_state_handler() instead
       drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_vnic.c:192: warning: expecting prototype for qlcnic_83xx_vnic_opmode(). Prototype was for qlcnic_83xx_config_vnic_opmode() instead
      
      Cc: Shahed Shaikh <shshaikh@marvell.com>
      Cc: Manish Chopra <manishc@marvell.com>
      Signed-off-by: default avatarYang Shen <shenyang39@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      9f2e6fb6
    • Yang Shen's avatar
      net: netronome: nfp: Fix wrong function name in comments · a507b164
      Yang Shen authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/net/ethernet/netronome/nfp/ccm_mbox.c:52: warning: expecting prototype for struct nfp_ccm_mbox_skb_cb. Prototype was for struct nfp_ccm_mbox_cmsg_cb instead
       drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c:35: warning: expecting prototype for struct nfp_tun_pre_run_rule. Prototype was for struct nfp_tun_pre_tun_rule instead
       drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nffw.c:38: warning: expecting prototype for NFFW_INFO_VERSION history(). Prototype was for NFFW_INFO_VERSION_CURRENT() instead
      
      Cc: Simon Horman <simon.horman@netronome.com>
      Cc: Jakub Kicinski <kuba@kernel.org>
      Signed-off-by: default avatarYang Shen <shenyang39@huawei.com>
      Reviewed-by: default avatarSimon Horman <simon.horman@netronome.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      a507b164
    • Yang Shen's avatar
      net: neterion: vxge: Fix wrong function name in comments · 146c91e2
      Yang Shen authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/net/ethernet/neterion/vxge/vxge-config.c:4895: warning: expecting prototype for vxge_hw_vpath_rx_doorbell_post(). Prototype was for vxge_hw_vpath_rx_doorbell_init() instead
       drivers/net/ethernet/neterion/vxge/vxge-main.c:1814: warning: expecting prototype for vxge_poll(). Prototype was for vxge_poll_msix() instead
       drivers/net/ethernet/neterion/vxge/vxge-main.c:4761: warning: expecting prototype for vxge_rem_nic(). Prototype was for vxge_remove() instead
      
      Cc: Jon Mason <jdmason@kudzu.us>
      Signed-off-by: default avatarYang Shen <shenyang39@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      146c91e2
    • Yang Shen's avatar
      net: neterion: Fix wrong function name in comments · dc432f5a
      Yang Shen authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/net/ethernet/neterion/s2io.c:2759: warning: expecting prototype for s2io_poll(). Prototype was for s2io_poll_msix() instead
       drivers/net/ethernet/neterion/s2io.c:5304: warning: expecting prototype for s2io_ethtol_get_link_ksettings(). Prototype was for s2io_ethtool_get_link_ksettings() instead
      
      Cc: Jon Mason <jdmason@kudzu.us>
      Signed-off-by: default avatarYang Shen <shenyang39@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      dc432f5a
    • Yang Shen's avatar
      net: microchip: Demote non-compliant kernel-doc headers · 331a3219
      Yang Shen authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/net/ethernet/microchip/encx24j600.c:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
      
      Cc: Jon Ringle <jringle@gridpoint.com>
      Signed-off-by: default avatarYang Shen <shenyang39@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      331a3219
    • Yang Shen's avatar
      net: micrel: Fix wrong function name in comments · 229fd41f
      Yang Shen authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/net/ethernet/micrel/ksz884x.c:2163: warning: expecting prototype for sw_get_board_storm(). Prototype was for sw_get_broad_storm() instead
       drivers/net/ethernet/micrel/ksz884x.c:2985: warning: expecting prototype for port_w_phy(). Prototype was for hw_w_phy() instead
       drivers/net/ethernet/micrel/ksz884x.c:4792: warning: expecting prototype for transmit_done(). Prototype was for tx_done() instead
      
      Cc: Tristram Ha <Tristram.Ha@micrel.com>
      Signed-off-by: default avatarYang Shen <shenyang39@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      229fd41f
    • Yang Shen's avatar
      net: huawei: hinic: Fix wrong function name in comments · d6174870
      Yang Shen authored
      Fixes the following W=1 kernel build warning(s):
       drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:604: warning: expecting prototype for cmdq_arm_ceq_handler(). Prototype was for cmdq_sync_cmd_handler() instead
       drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c:59: warning: expecting prototype for get_capability(). Prototype was for parse_capability() instead
       drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c:101: warning: expecting prototype for get_cap_from_fw(). Prototype was for get_capability() instead
       drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c:355: warning: expecting prototype for clear_io_resource(). Prototype was for clear_io_resources() instead
       drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c:1100: warning: expecting prototype for hinic_hwdev_get_sq(). Prototype was for hinic_hwdev_get_rq() instead
       drivers/net/ethernet/huawei/hinic/hinic_hw_if.c:341: warning: expecting prototype for dma_attr_table_init(). Prototype was for dma_attr_init() instead
       drivers/net/ethernet/huawei/hinic/hinic_hw_qp.c:904: warning: expecting prototype for hinic_put_wqe(). Prototype was for hinic_rq_put_wqe() instead
       drivers/net/ethernet/huawei/hinic/hinic_main.c:241: warning: expecting prototype for create_txqs(). Prototype was for create_rxqs() instead
       drivers/net/ethernet/huawei/hinic/hinic_main.c:295: warning: expecting prototype for free_txqs(). Prototype was for free_rxqs() instead
       drivers/net/ethernet/huawei/hinic/hinic_tx.c:667: warning: expecting prototype for free_all_rx_skbs(). Prototype was for free_all_tx_skbs() instead
      
      Cc: Bin Luo <luobin9@huawei.com>
      Signed-off-by: default avatarYang Shen <shenyang39@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d6174870
    • Yang Shen's avatar
      net: chelsio: cxgb4vf: Fix wrong function name in comments · 1eb00ff5
      Yang Shen authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/net/ethernet/chelsio/cxgb4vf/sge.c:966: warning: expecting prototype for check_ring_tx_db(). Prototype was for ring_tx_db() instead
      
      Cc: Raju Rangoju <rajur@chelsio.com>
      Signed-off-by: default avatarYang Shen <shenyang39@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      1eb00ff5
    • Yang Shen's avatar
      net: chelsio: cxgb4: Fix wrong function name in comments · e0333b1b
      Yang Shen authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/net/ethernet/chelsio/cxgb3/sge.c:677: warning: expecting prototype for free_qset(). Prototype was for t3_free_qset() instead
       drivers/net/ethernet/chelsio/cxgb3/sge.c:1266: warning: expecting prototype for eth_xmit(). Prototype was for t3_eth_xmit() instead
      
      Cc: Raju Rangoju <rajur@chelsio.com>
      Signed-off-by: default avatarYang Shen <shenyang39@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e0333b1b