1. 10 Jan, 2013 8 commits
  2. 09 Jan, 2013 9 commits
  3. 08 Jan, 2013 5 commits
  4. 07 Jan, 2013 14 commits
  5. 04 Jan, 2013 4 commits
    • YOSHIFUJI Hideaki / 吉藤英明's avatar
      ndisc: Remove unused space at tail of skb for ndisc messages. (TAKE 3) · b7dc8c39
      YOSHIFUJI Hideaki / 吉藤英明 authored
      Currently, the size of skb allocated for NDISC is MAX_HEADER +
      LL_RESERVED_SPACE(dev) + packet length + dev->needed_tailroom,
      but only LL_RESERVED_SPACE(dev) bytes is "reserved" for headers.
      As a result, the skb looks like this (after construction of the
      message):
      
      head       data                   tail                       end
      +--------------------------------------------------------------+
      +           |                      |          |                |
      +--------------------------------------------------------------+
      |<-hlen---->|<---ipv6 packet------>|<--tlen-->|<--MAX_HEADER-->|
          =LL_                               = dev
           RESERVED_                           ->needed_
           SPACE(dev)                            tailroom
      
      As the name implies, "MAX_HEADER" is used for headers, and should
      be "reserved" in prior to packet construction.  Or, if some space
      is really required at the tail of ther skb, it should be
      explicitly documented.
      
      We have several option after construction of NDISC message:
      
      Option 1:
      
      head       data                   tail       end
      +---------------------------------------------+
      +           |                      |          |
      +---------------------------------------------+
      |<-hlen---->|<---ipv6 packet------>|<--tlen-->|
         =LL_                                = dev
          RESERVED_                           ->needed_
          SPACE(dev)                            tailroom
      
      Option 2:
      
      head            data                   tail       end
      +--------------------------------------------------+
      +                |                      |          |
      +--------------------------------------------------+
      |<--MAX_HEADER-->|<---ipv6 packet------>|<--tlen-->|
                                                  = dev
                                                   ->needed_
                                                     tailroom
      
      Option 3:
      
      head                        data                   tail       end
      +--------------------------------------------------------------+
      +                |           |                      |          |
      +--------------------------------------------------------------+
      |<--MAX_HEADER-->|<-hlen---->|<---ipv6 packet------>|<--tlen-->|
                          =LL_                                = dev
                           RESERVED_                          ->needed_
                           SPACE(dev)                           tailroom
      
      Our tunnel drivers try expanding headroom and the space for tunnel
      encapsulation was not a mandatory space -- so we are not seeing
      bugs here --, but just for optimization for performance critial
      situations.
      
      Since NDISC messages are not performance critical unlike TCP,
      and as we know outgoing device, LL_RESERVED_SPACE(dev) should be
      just enough for the device in most (if not all) cases:
        LL_RESERVED_SPACE(dev) <= LL_MAX_HEADER <= MAX_HEADER
      Note that LL_RESERVED_SPACE(dev) is also enough for NDISC over
      SIT (e.g., ISATAP).
      
      So, I think Option 1 is just fine here.
      Signed-off-by: default avatarYOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
      Acked-by: default avatarEric Dumazet <edumazet@google.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      b7dc8c39
    • Frank Li's avatar
      NET: FEC: dynamtic check DMA desc buff type · ff43da86
      Frank Li authored
      MX6 and mx28 support enhanced DMA descriptor buff to support 1588
      ptp. But MX25, MX3x, MX5x can't support enhanced DMA descriptor buff.
      Check fec type and choose correct DMA descriptor buff type.
      
      Remove static config CONFIG_FEC_PTP.
      ptp function will be auto detected.
      Signed-off-by: default avatarFrank Li <Frank.Li@freescale.com>
      Acked-by: default avatarSascha Hauer <s.hauer@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      ff43da86
    • Peter Hüwe's avatar
      ethernet/broadcom/tg3: Fix sparse warning: constant 0x7fffffffffffffff is so big it is long long · 579e1d81
      Peter Hüwe authored
      Sparse complains that:
      drivers/net/ethernet/broadcom/tg3.c:5670:55: sparse: constant
      0x7fffffffffffffff is so big it is long long (on x86/32 bit)
      
      so we suffix the constant with LL in the header file.
      Reported-by: default avatarFengguang Wu <fengguang.wu@intel.com>
      Signed-off-by: default avatarPeter Huewe <peterhuewe@gmx.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      579e1d81
    • Steve Glendinning's avatar
      smsc95xx: enable dynamic autosuspend · b2d4b150
      Steve Glendinning authored
      This patch enables USB dynamic autosuspend for LAN9500A.  This
      saves very little power in itself, but it allows power saving
      in upstream hubs/hosts.
      
      The earlier devices in this family (LAN9500/9512/9514) do not
      support this feature.
      Signed-off-by: default avatarSteve Glendinning <steve.glendinning@shawell.net>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      b2d4b150