1. 06 Jan, 2009 12 commits
    • Ron Mercer's avatar
      qlge: Fix sparse warning regarding rx buffer queues. · 2c9a0d41
      Ron Mercer authored
      Warnings:
      drivers/net/qlge/qlge_main.c:909:17: warning: incorrect type in assignment (different base types)
      drivers/net/qlge/qlge_main.c:909:17:    expected unsigned int [unsigned] [usertype] addr_lo
      drivers/net/qlge/qlge_main.c:909:17:    got restricted unsigned int [usertype] <noident>
      drivers/net/qlge/qlge_main.c:911:17: warning: incorrect type in assignment (different base types)
      drivers/net/qlge/qlge_main.c:911:17:    expected unsigned int [unsigned] [usertype] addr_hi
      drivers/net/qlge/qlge_main.c:911:17:    got restricted unsigned int [usertype] <noident>
      drivers/net/qlge/qlge_main.c:974:17: warning: incorrect type in assignment (different base types)
      drivers/net/qlge/qlge_main.c:974:17:    expected unsigned int [unsigned] [usertype] addr_lo
      drivers/net/qlge/qlge_main.c:974:17:    got restricted unsigned int [usertype] <noident>
      drivers/net/qlge/qlge_main.c:975:17: warning: incorrect type in assignment (different base types)
      drivers/net/qlge/qlge_main.c:975:17:    expected unsigned int [unsigned] [usertype] addr_hi
      drivers/net/qlge/qlge_main.c:975:17:    got restricted unsigned int [usertype] <noident>
      drivers/net/qlge/qlge_main.c:2132:16: warning: incorrect type in assignment (different base types)
      drivers/net/qlge/qlge_main.c:2132:16:    expected unsigned int [unsigned] [usertype] addr_lo
      drivers/net/qlge/qlge_main.c:2132:16:    got restricted unsigned int [usertype] <noident>
      drivers/net/qlge/qlge_main.c:2133:16: warning: incorrect type in assignment (different base types)
      drivers/net/qlge/qlge_main.c:2133:16:    expected unsigned int [unsigned] [usertype] addr_hi
      drivers/net/qlge/qlge_main.c:2133:16:    got restricted unsigned int [usertype] <noident>
      drivers/net/qlge/qlge_main.c:2212:15: warning: incorrect type in assignment (different base types)
      drivers/net/qlge/qlge_main.c:2212:15:    expected unsigned int [unsigned] [usertype] addr_lo
      drivers/net/qlge/qlge_main.c:2212:15:    got restricted unsigned int [usertype] <noident>
      drivers/net/qlge/qlge_main.c:2214:15: warning: incorrect type in assignment (different base types)
      drivers/net/qlge/qlge_main.c:2214:15:    expected unsigned int [unsigned] [usertype] addr_hi
      drivers/net/qlge/qlge_main.c:2214:15:    got restricted unsigned int [usertype] <noident>
      Signed-off-by: default avatarRon Mercer <ron.mercer@qlogic.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      2c9a0d41
    • Ron Mercer's avatar
      qlge: Fix sparse endian warning in ql_hw_csum_setup(). · fd2df4f7
      Ron Mercer authored
      Changed u16 to __sum16 usage.
      
      Warnings:
      drivers/net/qlge/qlge_main.c:1897:9: warning: incorrect type in assignment (different base types)
      drivers/net/qlge/qlge_main.c:1897:9:    expected unsigned short [usertype] *check
      drivers/net/qlge/qlge_main.c:1897:9:    got restricted unsigned short *<noident>
      drivers/net/qlge/qlge_main.c:1903:9: warning: incorrect type in assignment (different base types)
      drivers/net/qlge/qlge_main.c:1903:9:    expected unsigned short [usertype] *check
      drivers/net/qlge/qlge_main.c:1903:9:    got restricted unsigned short *<noident>
      drivers/net/qlge/qlge_main.c:1909:9: warning: incorrect type in assignment (different base types)
      drivers/net/qlge/qlge_main.c:1909:9:    expected unsigned short [unsigned] [short] [usertype] <noident>
      Signed-off-by: default avatarRon Mercer <ron.mercer@qlogic.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      fd2df4f7
    • Ron Mercer's avatar
      qlge: Fix sparse endian warning for inbound packet control block flags. · a303ce09
      Ron Mercer authored
      Changed flags element from __le32 to 3 reserved bytes and one byte of
      flags.  Changed flags bit definitions to reflect byte width instead of
      __le32 width.
      
      Warnings:
      drivers/net/qlge/qlge_main.c:1206:16: warning: restricted degrades to integer
      drivers/net/qlge/qlge_main.c:1207:16: warning: restricted degrades to integer
      drivers/net/qlge/qlge_main.c:1233:17: warning: restricted degrades to integer
      drivers/net/qlge/qlge_main.c:1276:17: warning: restricted degrades to integer
      drivers/net/qlge/qlge_main.c:1349:19: warning: restricted degrades to integer
      Signed-off-by: default avatarRon Mercer <ron.mercer@qlogic.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      a303ce09
    • Ron Mercer's avatar
      qlge: Fix sparse warnings for byte swapping in qlge_ethool.c · 8306c952
      Ron Mercer authored
      drivers/net/qlge/qlge_ethtool.c:59:23: warning: cast to restricted type
      drivers/net/qlge/qlge_ethtool.c:59:21: warning: incorrect type in assignment (different base types)
      drivers/net/qlge/qlge_ethtool.c:59:21:    expected restricted unsigned short [usertype] irq_delay
      drivers/net/qlge/qlge_ethtool.c:59:21:    got unsigned short [unsigned] [usertype] <noident>
      drivers/net/qlge/qlge_ethtool.c:61:8: warning: cast to restricted type
      drivers/net/qlge/qlge_ethtool.c:60:21: warning: incorrect type in assignment (different base types)
      drivers/net/qlge/qlge_ethtool.c:60:21:    expected restricted unsigned short [usertype] pkt_delay
      drivers/net/qlge/qlge_ethtool.c:60:21:    got unsigned short [unsigned] [usertype] <noident>
      drivers/net/qlge/qlge_ethtool.c:82:23: warning: cast to restricted type
      drivers/net/qlge/qlge_ethtool.c:82:21: warning: incorrect type in assignment (different base types)
      drivers/net/qlge/qlge_ethtool.c:82:21:    expected restricted unsigned short [usertype] irq_delay
      drivers/net/qlge/qlge_ethtool.c:82:21:    got unsigned short [unsigned] [usertype] <noident>
      drivers/net/qlge/qlge_ethtool.c:84:8: warning: cast to restricted type
      drivers/net/qlge/qlge_ethtool.c:83:21: warning: incorrect type in assignment (different base types)
      drivers/net/qlge/qlge_ethtool.c:83:21:    expected restricted unsigned short [usertype] pkt_delay
      drivers/net/qlge/qlge_ethtool.c:83:21:    got unsigned short [unsigned] [usertype] <noident>
      Signed-off-by: default avatarRon Mercer <ron.mercer@qlogic.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      8306c952
    • Brice Goglin's avatar
      myri10ge: print MAC and serial number on probe failure · 0f840011
      Brice Goglin authored
      To help board identification and diagnosis, print the MAC
      and serial number on probe failure if they are available.
      Signed-off-by: default avatarBrice Goglin <brice@myri.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      0f840011
    • Jarek Poplawski's avatar
      pkt_sched: cls_u32: Fix locking in u32_change() · 6f573214
      Jarek Poplawski authored
      New nodes are inserted in u32_change() under rtnl_lock() with wmb(),
      so without tcf_tree_lock() like in other classifiers (e.g. cls_fw).
      This isn't enough without rmb() on the read side, but on the other
      hand adding such barriers doesn't give any savings, so the lock is
      added instead.
      Reported-by: default avatarm0sia <m0sia@plotinka.ru>
      Signed-off-by: default avatarJarek Poplawski <jarkao2@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      6f573214
    • Heiko Carstens's avatar
      iucv: fix cpu hotplug · f1d3e4dc
      Heiko Carstens authored
      If the iucv module is compiled in/loaded but no user is registered cpu
      hot remove doesn't work. Reason for that is that the iucv cpu hotplug
      notifier on CPU_DOWN_PREPARE checks if the iucv_buffer_cpumask would
      be empty after the corresponding bit would be cleared. However the bit
      was never set since iucv wasn't enable. That causes all cpu hot unplug
      operations to fail in this scenario.
      To fix this use iucv_path_table as an indicator wether iucv is enabled
      or not.
      Signed-off-by: default avatarHeiko Carstens <heiko.carstens@de.ibm.com>
      Signed-off-by: default avatarUrsula Braun <ursula.braun@de.ibm.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f1d3e4dc
    • Hendrik Brueckner's avatar
      af_iucv: Free iucv path/socket in path_pending callback · 65dbd7c2
      Hendrik Brueckner authored
      Free iucv path after iucv_path_sever() calls in iucv_callback_connreq()
      (path_pending() iucv callback).
      If iucv_path_accept() fails, free path and free/kill newly created socket.
      Signed-off-by: default avatarHendrik Brueckner <brueckner@linux.vnet.ibm.com>
      Signed-off-by: default avatarUrsula Braun <ursula.braun@de.ibm.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      65dbd7c2
    • Ursula Braun's avatar
      af_iucv: avoid left over IUCV connections from failing connects · 18becbc5
      Ursula Braun authored
      For certain types of AFIUCV socket connect failures IUCV connections
      are left over. Add some cleanup-statements to avoid cluttered IUCV
      connections.
      Signed-off-by: default avatarUrsula Braun <ursula.braun@de.ibm.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      18becbc5
    • Hendrik Brueckner's avatar
      af_iucv: New error return codes for connect() · 55cdea9e
      Hendrik Brueckner authored
      If the iucv_path_connect() call fails then return an error code that
      corresponds to the iucv_path_connect() failure condition; instead of
      returning -ECONNREFUSED for any failure.
      
      This helps to improve error handling for user space applications
      (e.g.  inform the user that the z/VM guest is not authorized to
      connect to other guest virtual machines).
      
      The error return codes are based on those described in connect(2).
      Signed-off-by: default avatarHendrik Brueckner <brueckner@linux.vnet.ibm.com>
      Signed-off-by: default avatarUrsula Braun <ursula.braun@de.ibm.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      55cdea9e
    • Stephen Rothwell's avatar
      net/ehea: bitops work on unsigned longs · 48e4cc77
      Stephen Rothwell authored
      The flags field of struct ehea_port is only used with test_bit(),
      clear_bit() and set_bit() and these interfaces only work on
      "unsigned long"s, so change the field to be an "unsigned long".  Also,
      this field only has two bits defined for it (0 and 1) so will still be
      fine if someone builds this driver for a 32 bit arch (at least as far as
      this flags field is concerned).
      
      Also note that ehea_driver_flags is only used in ehca_main.c, so make it
      static in there.
      Signed-off-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      48e4cc77
    • David S. Miller's avatar
      Revert "net: Fix for initial link state in 2.6.28" · c276e098
      David S. Miller authored
      This reverts commit 22604c86.
      
      We can't fix this issue in this way, because we now can try
      to take the dev_base_lock rwlock as a writer in software interrupt
      context and that is not allowed without major surgery elsewhere.
      
      This initial link state problem needs to be solved in some other
      way.
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      c276e098
  2. 05 Jan, 2009 28 commits