- 29 Feb, 2016 40 commits
-
-
Carolyn Wyborny authored
BugLink: http://bugs.launchpad.net/bugs/1536474 This patch fixes an issue where adminq init failures always provided a message that NVM was newer than expected. This is not always the case for init_adminq failures. Without this patch, if adminq init fails for any reason, newer NVM message would be given. This problem is fixed by adding a check for that specific error condition and a different hopefully helpful message otherwise. Change-ID: Iaeaebee4e398989eae40bb70f943ab66a3a521a5 Signed-off-by:
Carolyn Wyborny <carolyn.wyborny@intel.com> Tested-by:
Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (cherry picked from commit 2b2426a7) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Helin Zhang authored
BugLink: http://bugs.launchpad.net/bugs/1536474 This patch adds new fields to i40e_vsi to store user configured RSS config data and code to use it. Change-ID: Ic5d3db8d9df52182b560248f8cdca9c5c7546879 Signed-off-by:
Helin Zhang <helin.zhang@intel.com> Tested-by:
Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (cherry picked from commit 66f9af85) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Helin Zhang authored
BugLink: http://bugs.launchpad.net/bugs/1536474 There are two ways to get RSS, this patch implements two functions with the same input parameters, and creates a more generic function for getting RSS configuration. Change-ID: I12d3b712c21455d47dd0a5aae58fc9b7c680db59 Signed-off-by:
Helin Zhang <helin.zhang@intel.com> Tested-by:
Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (cherry picked from commit 90b02b43) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Helin Zhang authored
BugLink: http://bugs.launchpad.net/bugs/1536474 There are two ways to configure RSS, this patch adjusts those two functions with the same input parameters, and creates a more generic function for configuring RSS. Change-ID: Iace73bdeba4831909979bef221011060ab327f71 Signed-off-by:
Helin Zhang <helin.zhang@intel.com> Tested-by:
Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (cherry picked from commit 2c86ac3c) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Helin Zhang authored
BugLink: http://bugs.launchpad.net/bugs/1536474 This patch renames old VF adapter specific RSS function to clarify its scope. Change-ID: Ie5253083a44c677ebb7709a8a3a18402ad2dc6a6 Signed-off-by:
Helin Zhang <helin.zhang@intel.com> Tested-by:
Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (cherry picked from commit 96a81986) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Jesse Brandeburg authored
BugLink: http://bugs.launchpad.net/bugs/1536474 Issue a prefetch for data early in the transmit path. This should not be generally needed for Tx traffic, but it helps immensely for pktgen workloads and should help for forwarding workloads as well. Change-ID: Iefee870c20599e0c4240e1d8637e4f16b625f83a Signed-off-by:
Jesse Brandeburg <jesse.brandeburg@intel.com> Tested-by:
Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (cherry picked from commit b74118f0) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Anjali Singhai Jain authored
BugLink: http://bugs.launchpad.net/bugs/1536474 This patch fixes the issue of forcing WB too often causing us to not benefit from NAPI. Without this patch we were forcing WB/arming interrupt too often taking away the benefits of NAPI and causing a performance impact. With this patch we disable force WB in the clean routine for X710 and XL710 adapters. X722 adapters do not enable interrupt to force a WB and benefit from WB_ON_ITR and hence force WB is left enabled for those adapters. For XL710 and X710 adapters if we have less than 4 packets pending a software Interrupt triggered from service task will force a WB. This patch also changes the conditions for setting RS bit as described in code comments. This optimizes when the HW does a tail bump amd when it does a WB. It also optimizes when we do a wmb. Change-ID: Id831e1ae7d3e2ec3f52cd0917b41ce1d22d75d9d Signed-off-by:
Anjali Singhai Jain <anjali.singhai@intel.com> Tested-by:
Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (cherry picked from commit 6a7fded7) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Helin Zhang authored
BugLink: http://bugs.launchpad.net/bugs/1536474 This patch renames rss_size to alloc_rss_size in i40e_pf, which is clearer and avoids confusion. It also adds comments to the other related structure members to help clarify usage. Change-ID: Ia90090609d006ab589cb639975bb8a0af795d16f Signed-off-by:
Helin Zhang <helin.zhang@intel.com> Tested-by:
Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (cherry picked from commit acd65448) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Helin Zhang authored
BugLink: http://bugs.launchpad.net/bugs/1536474 This patch adds new fields to i40e_vsi to store user configured RSS config data and code to use it. Signed-off-by:
Helin Zhang <helin.zhang@intel.com> Change-ID: I73886469dca9e9f6b16d842182a87f3f4009f95d Tested-by:
Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (cherry picked from commit 28c5869f) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Catherine Sullivan authored
BugLink: http://bugs.launchpad.net/bugs/1536474 Bump. Change-ID: I2d1ce93b2ce74e4eef2394c932aef52cba99713f Signed-off-by:
Catherine Sullivan <catherine.sullivan@intel.com> Tested-by:
Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (cherry picked from commit 1c2df9e5) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Helin Zhang authored
BugLink: http://bugs.launchpad.net/bugs/1536474 This patch renames the old pf-specific function in order to clarify its scope. This patch also creates a more generic configure RSS function with the old name. This patch also creates a new more generic function to get RSS configuration, using the appropriate method. Change-ID: Ieddca2707b708ef19f1ebccdfd03a0a0cd63d3af Signed-off-by:
Helin Zhang <helin.zhang@intel.com> Tested-by:
Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (cherry picked from commit 043dd650) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Helin Zhang authored
BugLink: http://bugs.launchpad.net/bugs/1536474 Adjust the RSS configure functions so that there is a generic way to hook to ethtool hooks. Change-ID: If446e34fcfaf1bc3320d9d319829a095b5976e67 Signed-off-by:
Helin Zhang <helin.zhang@intel.com> Tested-by:
Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (cherry picked from commit e69ff813) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Helin Zhang authored
BugLink: http://bugs.launchpad.net/bugs/1536474 This patch fixes a problem where using ethtool rxnfc command could let RX flow hash be set on disabled queues. This patch fixes the problem by returning the number of enabled queues before setting rxnfc. Change-ID: Idbac86b0b47ddacc8deee7cd257e41de01cbe5c0 Signed-off-by:
Helin Zhang <helin.zhang@intel.com> Tested-by:
Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (cherry picked from commit 3e3aa21f) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Mitch Williams authored
BugLink: http://bugs.launchpad.net/bugs/1536474 When a lot (many hundreds) of MAC or VLAN filters are added at one time, we can overflow the Admin Queue buffer size with all the requests. Unfortunately, the driver would then calculate the message size incorrectly, causing it to be rejected by the PF. Furthermore, there was no mechanism to trigger another request to allow for configuring the rest of the filters that didn't fit into the first request. To fix this, recalculate the correct buffer size when we detect the overflow condition instead of just assuming the max buffer size. Also, don't clear the request bit in adapter->aq_required when we have an overflow, so that the rest of the filters can be processed later. Change-ID: Idd7cbbc5af31315e0dcb1b10e6a02ad9817ce65c Signed-off-by:
Mitch Williams <mitch.a.williams@intel.com> Tested-by:
Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (cherry picked from commit 1418c345) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Mitch Williams authored
BugLink: http://bugs.launchpad.net/bugs/1536474 Clean up and enhance error messages related to VF MAC/VLAN filters. Indicate which VF is having issues, and if possible indicate the MAC address or VLAN involved. Also, when an error is returned from the PF driver, print useful information about what went wrong, for the most likely cases. Change-ID: Ib3d15eef9e3369a78fd142948671e5fa26d921b8 Signed-off-by:
Mitch Williams <mitch.a.williams@intel.com> Tested-by:
Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (cherry picked from commit 8d8f2295) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Helin Zhang authored
BugLink: http://bugs.launchpad.net/bugs/1536474 Add a comment to the #endif to more easily match it with its #if. Change-ID: I47eb0a60a17dc6d2f01a930e45006d2dc82e044f Signed-off-by:
Helin Zhang <helin.zhang@intel.com> Tested-by:
Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (cherry picked from commit 2f175f55) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Catherine Sullivan authored
BugLink: http://bugs.launchpad.net/bugs/1536474 The watchdog only calls link_event not handle_link_event which means that we need to save the old information in link_event. Previously when polling we were comparing current data to the old data saved the last time we actually received a link event. This means that the polling would only fix link status changes in one direction depending on what the last old data saved off was. Change-ID: Ie590f30fdbcb133d0ddad4e07e3eb1aad58255b3 Signed-off-by:
Catherine Sullivan <catherine.sullivan@intel.com> Tested-by:
Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (cherry picked from commit 1f9610e4) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Anjali Singhai Jain authored
BugLink: http://bugs.launchpad.net/bugs/1536474 When in NAPI with interrupts disabled, the HW needs to be forced to do a write back on TX if the number of descriptors pending are less than a cache line. This stat helps keep track of how many times we get into this situation. Change-ID: I76c1bcc7ebccd6bffcc5aa33bfe05f2fa1c9a984 Signed-off-by:
Anjali Singhai Jain <anjali.singhai@intel.com> Tested-by:
Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (cherry picked from commit 164c9f54) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Anjali Singhai Jain authored
BugLink: http://bugs.launchpad.net/bugs/1536474 HW/NVM sets a limit of no less than 256 bytes for MSS. Stack can send as low as 76 bytes MSS. This patch lowers the HW limit to 64 bytes to avoid MDDs from firing and causing a reset when the MSS is lower than 256. Change-ID: I36b500a6bb227d283c3e321a7718e0672b11fab0 Signed-off-by:
Anjali Singhai Jain <anjali.singhai@intel.com> Tested-by:
Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (cherry picked from commit 4f2f017c) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Shannon Nelson authored
BugLink: http://bugs.launchpad.net/bugs/1536474 There's no need to kill the kernel thread here. If this condition was true, the probe() would have died long before we got here. In any case, we'll get the same result when this code tries to use the VSI pointer being checked. Prompted by a recent Linus diatribe. Change-ID: I62f531cac34d4fc28ff9657d5b2d9523ae5e33a4 Signed-off-by:
Shannon Nelson <shannon.nelson@intel.com> Tested-by:
Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (cherry picked from commit f9b26ebb) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Shannon Nelson authored
BugLink: http://bugs.launchpad.net/bugs/1536474 There's really no reason to kill the kernel thread just because of a little info string. This reworks the code to use snprintf's limiting to assure that the string is never too long, and WARN_ON to still put out a warning that we might want to look at the feature list length. Prompted by a recent Linus diatribe. Change-ID: If52ba5ca1c2344d8bf454a31bbb805eb5d2c5802 Signed-off-by:
Shannon Nelson <shannon.nelson@intel.com> Tested-by:
Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (cherry picked from commit 7fd89545) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Shannon Nelson authored
BugLink: http://bugs.launchpad.net/bugs/1536474 There's no need to kill the thread and eventually the kernel in this case. In fact, the remainder of the code won't hurt anything anyway, so just complain that we're here and move along. Prompted by a recent Linus diatribe. Change-ID: Iec020d8bcfedffc1cd2553cc6905fd915bb3e670 Signed-off-by:
Shannon Nelson <shannon.nelson@intel.com> Tested-by:
Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (cherry picked from commit b875f99b) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Shannon Nelson authored
BugLink: http://bugs.launchpad.net/bugs/1536474 Code was moved into a separate function some time ago. Change-ID: Icabbe71ce05cf5d716d3e1152cdd9cd41d11bcb5 Signed-off-by:
Shannon Nelson <shannon.nelson@intel.com> Tested-by:
Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (cherry picked from commit 9c883bd3) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Rasmus Villemoes authored
BugLink: http://bugs.launchpad.net/bugs/1536474 This code is pretty confused. The variable name 'bytes_not_copied' clearly indicates that the programmer knew the semantics of copy_{to,from}_user, but then the return value is checked for being negative and used as a -Exxx return value. I'm not sure this is the proper fix, but at least we get rid of the dead code which pretended to check for access faults. Signed-off-by:
Rasmus Villemoes <linux@rasmusvillemoes.dk> Acked-by:
Shannon Nelson <shannon.nelson@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (cherry picked from commit 0286c67e) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Jesse Brandeburg authored
BugLink: http://bugs.launchpad.net/bugs/1536474 Compiler complained of an unused variable, which the driver was just using to store the result of a rd32 which is used to clear a register unconditionally. Just drop the unused variable and re-use one. Signed-off-by:
Jesse Brandeburg <jesse.brandeburg@intel.com> Tested-by:
Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (cherry picked from commit cfbe4dba) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Tim Gardner authored
Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Tim Gardner authored
BugLink: http://bugs.launchpad.net/bugs/1536719Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Colin Ian King authored
UBUNTU: SAUCE: ACPI / tables: Add acpi_force_32bit_fadt_addr option to force 32 bit FADT addresses (LP: #1529381) BugLink: https://bugs.launchpad.net/bugs/1529381 Some HP laptops seem to have invalid 64 bit FADT X_PM* addresses which are causing various boot issues. In these cases, it would be useful to force ACPI to use the valid legacy 32 bit equivalent PM addresses. Add a acpi_force_32bit_fadt_addr to set the ACPICA acpi_gbl_use32_bit_fadt_addresses to TRUE to force this override. Signed-off-by:
Colin Ian King <colin.king@canonical.com> Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Tim Gardner authored
Ignore: yes Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Tim Gardner authored
Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Tim Gardner authored
BugLink: http://bugs.launchpad.net/bugs/1517142 This reverts commit 659743b0. Signed-off-by:
Tim Gardner <tim.gardner@canonical.com> Conflicts: drivers/scsi/bnx2i/bnx2i_iscsi.c drivers/scsi/iscsi_tcp.c drivers/scsi/libiscsi.c
-
Tim Gardner authored
Ignore: yes Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Tim Gardner authored
Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Alistair Popple authored
BugLink: http://bugs.launchpad.net/bugs/1522415 Move __raw_rm_writeq() from platforms/powernv/pci-ioda.c to include/asm/io.h so that it can be used by other code. Signed-off-by:
Alistair Popple <alistair@popple.id.au> Signed-off-by:
Michael Ellerman <mpe@ellerman.id.au> (cherry picked from commit a84bf321) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Alistair Popple authored
BugLink: http://bugs.launchpad.net/bugs/1522415 This commit removed the pcidev field from struct pci_dn as it was no longer in use by the kernel. However to support finding the association of Nvlink devices to GPU devices from the device-tree this field is required. This reverts commit 250c7b27 ("powerpc/pci: Remove unused struct pci_dn.pcidev field"). Signed-off-by:
Alistair Popple <alistair@popple.id.au> Signed-off-by:
Michael Ellerman <mpe@ellerman.id.au> (cherry picked from commit 94973b24) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Tim Gardner authored
Ignore: yes Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Tim Gardner authored
Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Andy Whitcroft authored
We wish to use the arm64 buildds to build armhf binaries in 32bit chroots. To make this work we need uname to return armv7l machine type. To achieve this add a kernel command line override for the 32bit machine type. Add compat_uts_machine=<type> to allow the LINUX32 personality to return that type for uname. Signed-off-by:
Andy Whitcroft <apw@canonical.com>
-
Andy Whitcroft authored
Signed-off-by:
Andy Whitcroft <apw@canonical.com>
-
Tim Gardner authored
BugLink: http://bugs.launchpad.net/bugs/1533382Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-