Coding style issue, checkpatch Avoid CamelCase,
rename it. IOTPeer -> iot_peer
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
Link: https://lore.kernel.org/r/20231208015827.21185-1-garyrookard@fastmail.orgSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Coding style issue, checkpatch Avoid CamelCase,
rename it. HTIOTActIsCCDFsync -> ht_iot_act_is_ccd_fsync
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
Link: https://lore.kernel.org/r/20231208015536.21013-5-garyrookard@fastmail.orgSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Coding style issue, checkpatch avoid CamelCase,
rename it. CCKOFDMRate -> cck_of_dm_rate
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
Link: https://lore.kernel.org/r/20231208015536.21013-4-garyrookard@fastmail.orgSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Coding style issue, checkpatch Avoid CamelCase,
rename it. bCurShortGI20MHz -> cur_short_gi_20mhz
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
Link: https://lore.kernel.org/r/20231208015536.21013-3-garyrookard@fastmail.orgSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Coding style issue, checkpatch Avoid CamelCase,
rename it. bCurShortGI40MHz -> cur_short_gi_40mhz
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
Link: https://lore.kernel.org/r/20231208015536.21013-2-garyrookard@fastmail.orgSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove files dot11d.c and dot11d.h as they are empty.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/ed7de82ade0fde1835bbd88aafba74aeb128beed.1701989555.git.philipp.g.hortmann@gmail.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove function dot11d_channel_map() as it is empty.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/877c0efcf56977cbf0943b34beda4ff2ca514714.1701989555.git.philipp.g.hortmann@gmail.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove variable dot11d_info as it is unused. Remove unused struct
channel_list and empty struct rt_dot11d_info.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/2438971feb0c02c5c72776f57201a4011f249190.1701989555.git.philipp.g.hortmann@gmail.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove variable channel_map as it is initialized but not used. Remove
channel_array as well as it is without channel_map unused.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/19ca762b4b9d5a3e857b31c22f0688324ca3bd9d.1701989555.git.philipp.g.hortmann@gmail.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove function rtllib_update_active_chan_map() as "active_channel_map"
and "channel_map" have the same content.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/bae3ddeffe96e4ac7d929127ce3a72cd23fae8dd.1701989555.git.philipp.g.hortmann@gmail.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Coding style issue, checkpatch Avoid CamelCase,
rename it. bTxEnableFwCalcDur -> tx_enable_fw_calc_dur
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
Link: https://lore.kernel.org/r/20231206230404.1721-6-garyrookard@fastmail.orgSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Coding style issue, checkpatch Avoid CamelCase,
rename it. MPDU_Density -> mpdu_density
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
Link: https://lore.kernel.org/r/20231206230404.1721-5-garyrookard@fastmail.orgSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Coding style issue, checkpatch Avoid CamelCase,
rename it. AMPDU_Factor -> ampdu_factor
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
Link: https://lore.kernel.org/r/20231206230404.1721-4-garyrookard@fastmail.orgSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Coding style issue, checkpatch Avoid CamelCase,
rename it. bAMPDUEnable -> ampdu_enable
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
Link: https://lore.kernel.org/r/20231206230404.1721-3-garyrookard@fastmail.orgSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Coding style issue, checkpatch Avoid CamelCase,
rename it. bAMSDU_Suppport -> amsdu_support
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
Link: https://lore.kernel.org/r/20231206230404.1721-2-garyrookard@fastmail.orgSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Solves the following Smatch warnings:
vchiq_release() warn: argument 7 to %lx specifier is cast from pointer

%p will print the hashed pointer to dynamic debug.
In order to print the unmodified pointer address, one can use the
`no_hash_pointers` via kernel parameters.
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Link: https://lore.kernel.org/r/20231207083837.153843-3-umang.jain@ideasonboard.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Solves the following Smatch warnings:
service_callback() warn: argument 7 to %lx specifier is cast from pointer
service_callback() warn: argument 11 to %lx specifier is cast from pointer
service_callback() warn: argument 12 to %lx specifier is cast from pointer
service_callback() warn: argument 13 to %lx specifier is cast from pointer

%p will print the hashed pointer to dynamic debug.
In order to print the unmodified pointer address, one can use the
`no_hash_pointers` via kernel parameters.
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Link: https://lore.kernel.org/r/20231207083837.153843-2-umang.jain@ideasonboard.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Drop vchiq_log_debug() macro which wraps dev_dbg(). Introduce the usage
of dev_dbg() directly.

Meanwhile at it, drop the usage of __func__ from the logs.
Dynamic debug supports this via the 'f'  decorator flag.

Remove the entry from TODO regarding custom logging. VC04 is now
aligned according to the standard kernel logging mechanisms.
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Link: https://lore.kernel.org/r/20231205084157.73819-5-umang.jain@ideasonboard.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Drop vchiq_log_trace() macro which wraps dev_dbg(). Introduce the usage
of dev_dbg() directly.

Meanwhile at it, drop the usage of __func__ from the logs.
Dynamic debug supports this via the 'f'  decorator flag.
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Link: https://lore.kernel.org/r/20231205084157.73819-4-umang.jain@ideasonboard.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Drop vchiq_log_warning() macro which wraps dev_dbg(). Introduce the usage
of dev_warn() directly.
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Link: https://lore.kernel.org/r/20231205084157.73819-3-umang.jain@ideasonboard.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Drop vchiq_log_error() macro which wraps dev_dbg(). Introduce the usage
of dev_err() directly.
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Link: https://lore.kernel.org/r/20231205084157.73819-2-umang.jain@ideasonboard.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Coding style issue, checkpatch Avoid CamelCase,
rename it nAMSDU_MaxSize -> amsdu_max_size
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
Link: https://lore.kernel.org/r/20231205231623.23070-6-garyrookard@fastmail.orgSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Coding style issue, checkpatch Avoid CamelCase,
rename it bRegSuppCCK -> reg_supp_cck
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
Link: https://lore.kernel.org/r/20231205231623.23070-5-garyrookard@fastmail.orgSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Coding style issue, checkpatch Avoid CamelCase,
rename it bRegBW40MHz -> reg_bw_40mhz
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
Link: https://lore.kernel.org/r/20231205231623.23070-4-garyrookard@fastmail.orgSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Coding style issue, checkpatch Avoid CamelCase,
rename it bRegShortGI40MHz -> reg_short_gi_40mhz
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
Link: https://lore.kernel.org/r/20231205231623.23070-3-garyrookard@fastmail.orgSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Coding style issue, checkpatch Avoid CamelCase,
rename it bRegShortGI20MHz -> reg_short_gi_20mhz
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
Link: https://lore.kernel.org/r/20231205231623.23070-2-garyrookard@fastmail.orgSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

vchiq_add_connected_callback() logs using vchiq_log_error() macro,
but passes NULL instead of a struct device pointer. Fix it.

vchiq_add_connected_callback() is not used anywhere in the vc04_services
as of now. It will be used when we add new drivers(VC shared memory and
bcm2835-isp), hence it kept as it is for now.

Fixes: 1d8915cf ("staging: vc04: Convert vchiq_log_error() to use dynamic debug")
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Link: https://lore.kernel.org/r/20231128201926.489269-2-umang.jain@ideasonboard.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

The handle_to_service() helper can return NULL, so `service` pointer
can indeed be set to NULL. So, do not log through service pointer
(which can cause NULL-deference), instead, use the vchiq_instance
function argument to get access to the struct device.

Fixes: f67af594 ("staging: vc04: Convert(and rename) vchiq_log_info() to use dynamic debug")
Reviewed-by: Ricardo B. Marliere <ricardo@marliere.net>
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Link: https://lore.kernel.org/r/20231128201845.489237-1-umang.jain@ideasonboard.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Coding style issue, checkpatch Avoid CamelCase,
rename it nDataRate -> data-rate.
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
Link: https://lore.kernel.org/r/20231128181727.19504-4-garyrookard@fastmail.orgSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Coding style issue, checkpatch Avoid CamelCase,
rename it bCurBW40MHz -> cur_bw_40mhz.
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
Link: https://lore.kernel.org/r/20231128181727.19504-3-garyrookard@fastmail.orgSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Coding style issue, checkpatch Avoid CamelCase,
rename it nMcsRate -> mcs_rate.
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
Link: https://lore.kernel.org/r/20231128181727.19504-2-garyrookard@fastmail.orgSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename variable TsCommonInfo to ts_common_info to fix checkpatch
warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Link: https://lore.kernel.org/r/20231127054305.148276-16-tdavies@darkphysics.netSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename variable pAdmittedBA to admitted_ba to fix checkpatch
warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Link: https://lore.kernel.org/r/20231127054305.148276-15-tdavies@darkphysics.netSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename variable pBaTimeoutVal to ba_timeout_value to fix checkpatch
warning Avoid CamelCase, and make the name consistent with variables
of same name/type.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Link: https://lore.kernel.org/r/20231127054305.148276-14-tdavies@darkphysics.netSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename variable pBaParamSet to ba_param_set to fix checkpatch
warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Link: https://lore.kernel.org/r/20231127054305.148276-13-tdavies@darkphysics.netSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename variable DelbaParamSet to del_ba_param_set to fix checkpatch
warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Link: https://lore.kernel.org/r/20231127054305.148276-12-tdavies@darkphysics.netSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename variable TsAddBaTimer to ts_add_ba_timer to fix checkpatch
warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Link: https://lore.kernel.org/r/20231127054305.148276-11-tdavies@darkphysics.netSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename variable TxCurSeq to tx_cur_seq to fix checkpatch
warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Link: https://lore.kernel.org/r/20231127054305.148276-10-tdavies@darkphysics.netSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename variable pTsCommonInfo to ts_common_info to fix checkpatch
warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Link: https://lore.kernel.org/r/20231127054305.148276-9-tdavies@darkphysics.netSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename variable pDialogToken to dialog_token to fix checkpatch
warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Link: https://lore.kernel.org/r/20231127054305.148276-8-tdavies@darkphysics.netSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>