- 27 Jun, 2014 40 commits
-
-
Vincent Heuken authored
This is a patch for the slicoss.c file that fixes four instances of the following warning: WARNING: else is not generally useful after a break or return Signed-off-by:
Vincent Heuken <me@vincentheuken.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Sachin Kamat authored
module_platform_driver removes some boiler plate and makes code simpler. Signed-off-by:
Sachin Kamat <sachin.kamat@samsung.com> Signed-off-by:
-
Sachin Kamat authored
devm_request_and_ioremap has been removed since commit c9d53c0f ("devres: remove devm_request_and_ioremap()") Use devm_ioremap_resource instead. While at it, also remove redundant error message as it is now handled by devm_ioremap_resource. Without this patch we get the following build error: drivers/staging/emxx_udc/emxx_udc.c:3370:2: error: implicit declaration of function ‘devm_request_and_ioremap’ [-Werror=implicit-function-declaration] Signed-off-by:
-
Anil Belur authored
- this fixes some coding style issues "ERROR: "(foo*)" should be "(foo *)" Signed-off-by:
Anil Belur <askb23@gmail.com> Signed-off-by:
-
Anil Belur authored
- this fixes "WARNING: labels should not be indented" Signed-off-by:
-
Anil Belur authored
- this fixes "WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>" Signed-off-by:
-
Anil Belur authored
staging: lustre: llite: llite_capa.c - fixes checkpatch errors - unecessary init of static variables to 0 - this commit fixes some "ERROR: do not initialise statics to 0 or NULL" Signed-off-by:
-
Anil Belur authored
- this fixes "WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable" Signed-off-by:
-
Isaac Huang authored
If LNetMDUnlink has been called, all outgoing messages on that MD should be aborted before lnet_ni_send() is called. Signed-off-by:
Isaac Huang <he.huang@intel.com> Reviewed-on: http://review.whamcloud.com/8041 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4006Reviewed-by:
Liang Zhen <liang.zhen@intel.com> Reviewed-by:
Doug Oucharek <doug.s.oucharek@intel.com> Signed-off-by:
Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
-
Li Xi authored
After vvp_io_kernel_fault() locked the page, it should set VM_FAULT_LOCKED. Signed-off-by:
Li Xi <lixi@ddn.com> Reviewed-on: http://review.whamcloud.com/10740Reviewed-by:
Jinshan Xiong <jinshan.xiong@intel.com> Reviewed-by:
Emoly Liu <emoly.liu@intel.com> Signed-off-by:
-
Patrick Farrell authored
The mmap_sem is downed in vvp_mmap_locks, but in case of error from cl_io_lock_alloc_add, it is not upped. Credit to Paul Casella at Cray for finding this. Signed-off-by:
Patrick Farrell <paf@cray.com> Reviewed-on: http://review.whamcloud.com/10741 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5221Reviewed-by:
Andreas Dilger <andreas.dilger@intel.com> Signed-off-by:
-
Bob Glossman authored
Manually force loading of lustre.ko during client mounts with request_module for cases where autoloading doesn't happen. Signed-off-by:
Bob Glossman <bob.glossman@intel.com> Reviewed-on: http://review.whamcloud.com/10587 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4800Reviewed-by:
John L. Hammond <john.hammond@intel.com> Reviewed-by:
James Simmons <uja.ornl@gmail.com> Reviewed-by:
Yang Sheng <yang.sheng@intel.com> Reviewed-by:
-
Alexey Lyashkov authored
outgoning buffer may be hold by lnet and don't unlinked fast, it's break unloading a lustre modules as request hold a reference to the export/obd Signed-off-by:
Alexey Lyashkov <alexey_lyashkov@xyratex.com> Xyratex-bug-id: MRP-1848 Reviewed-on: http://review.whamcloud.com/10353 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5073Reviewed-by:
Mike Pershin <mike.pershin@intel.com> Reviewed-by:
-
Dmitry Eremin authored
'f.f_flags' might be used uninitialized in this function. xattr.c:248: 'f.f_flags' is declared. xattr.c:244: lump!= ( (void* )0) is true xattr.c:254: 'f.f_flags' is used, but is uninitialized. Signed-off-by:
Dmitry Eremin <dmitry.eremin@intel.com> Reviewed-on: http://review.whamcloud.com/10663 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629Reviewed-by:
-
Andriy Skulysh authored
The bug was caused by race between truncate & fsync. osc_extent_wait() doesn't takes into account oe_trunc_pending during setting oe_urgent. The race arises after osc_object_unlock(). osc_extent_wait() should ignore extents with oe_trunc_pending while waiting for OES_INV. osc_cache_truncate_end() will set oe_urgent and call osc_io_unplug_async() Signed-off-by:
Andriy Skulysh <Andriy_Skulysh@xyratex.com> Reviewed-on: http://review.whamcloud.com/10204 Xyratex-bug-id: LELUS-239 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4852Reviewed-by:
-
Dmitry Eremin authored
'sd.page_link' is used uninitialized in this function. 'ss.page_link' is used uninitialized in this function. 'sl.page_link' is used uninitialized in this function. Signed-off-by:
-
Christopher J. Morrone authored
Most ptlrpc sets are believed to be small and bounded in length. However at the very least the ptlrpcd reuses the ptlrpc sets at its primary work queue. This work queue can easily have work added faster than the ptlrpcd thread can process the work. The unbounded work can lead to the ptlrpcd monopolizing a CPU for hundreds of seconds. Obviously a well-behaved kernel function should obey the scheduler and share the processor. We address that problem by inserting a cond_resched() at the top of the main loop of ptlrpc_check_set(). Some have suggested putting the cond_resched() lower in the loop. However, the only current way to bound the number of loops that we exceed our allocated run time is to put the call at the top of the loop. Putting it lower would allow an unknown number (and since it is unknown, it might be excessively large at times) of cycles through the loop before a resched is allowed. Signed-off-by:
Christopher J. Morrone <morrone2@llnl.gov> Reviewed-on: http://review.whamcloud.com/10358 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5053Reviewed-by:
-
Cheng Shao authored
During client mount, the client will send an LDLM_ENQUEUE request to MGS with send delay set to MGC_ENQUEUE_LIMIT, which is hard coded to 50 seconds. On the other hand, the interval for pinger is deduced from obd_timeout. When obd_timeout is configured for a longer period of time, so does the pinger. We know that connecting to the secondary MGS node is triggered by the pinger. Now that we have a longer interval, the pinger will not be able to try the secondary before the LDLM_ENQUEUE request fails the mount using the same delay limit. This code change will replace the hard-coded send delay being mentioned above with a value that is long enough to give the client a chance to connect to the secondary MGS if exists. Signed-off-by:
Cheng Shao <cheng_shao@xyratex.com> Reviewed-on: http://review.whamcloud.com/9217 Xyratex-bug-id: MRP-1516 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4582Reviewed-by:
Ryan Haasken <haasken@cray.com> Reviewed-by:
-
Alexander.Boyko authored
Race between ptlrpc_resend_req() and ptlrpc_check_set(). 1 thread do ptlrpc_check_set()->after_reply() 2 thread do ptlrpc_resend_req() The result is request with rq_resend = 1 and MSG_REPLY flag. When this request will came to server it will cause client eviction. The patch skip ptlrpc_resend_req logic if rq_replied is set, and clear rq_resend flag at reply_in_callback() when client got reply. Signed-off-by:
Alexander Boyko <alexander_boyko@xyratex.com> Xyratex-bug-id: MRP-1888 Reviewed-on: http://review.whamcloud.com/10471 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5116Reviewed-by:
Chris Horn <hornc@cray.com> Signed-off-by:
-
Bobi Jam authored
Old code residue assumes initial checksum value as ~0, and relies on that to check whether OST server has calculated bulk data checksum. That is not the case anymore. Signed-off-by:
Bobi Jam <bobijam.xu@intel.com> Reviewed-on: http://review.whamcloud.com/10354 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4937Reviewed-by:
-
Andriy Skulysh authored
mgc import can be reconnected by pinger or ptlrpc_reconnect_import(). ptlrpc_invalidate_import() isn't protected against alteration of imp_invalid state. Import can be reconnected by pinger which makes imp_invalid equal to false. Thus LASSERT(imp->imp_invalid) fails in ptlrpc_invalidate_import(). It is safe to call ptlrpc_invalidate_import() when import is deactivated, but ptlrpc_reconnect_import() doesn't deactivate it. Let's use only pinger when available to reconnect import Signed-off-by:
Lai Siyao <lai.siyao@intel.com> Signed-off-by:
-
Dmitry Eremin authored
Pointer 'obd' checked for NULL at line 694 may be dereferenced at line 813. Pointer 'req->rq_export->exp_obd' checked for NULL at line 1155 may be dereferenced at line 1164. Also there is one similar error on line 1170. Signed-off-by:
-
Dmitry Eremin authored
Fixed implicit conversion from 'unsigned long long' to 'int'. Signed-off-by:
-
Nathaniel Clark authored
Check that attr mode is valid before using it when determining if to clear SGID and SUID bits in ll_setattr. Signed-off-by:
Nathaniel Clark <nathaniel.l.clark@intel.com> Reviewed-on: http://review.whamcloud.com/10153 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4924Reviewed-by:
-
Oleg Drokin authored
*_enlarge_reqbuf class of functions can change request body location for a request that's already in replay list, as such a parallel traverser of the list (after_reply -> ptlrpc_free_committed) might access freed and scrambled memory causing assertion. Since all such users only can get to this request under imp_lock, take imp_lock to protect against them in *_enlarge_reqbuf Signed-off-by:
-
Oleg Drokin authored
Changes introduced by 80db2734 unfortunately totally break lustre, we use this function to access not only socket proto obs, but also device ioctl like SIOCGIFCONF that now fail. Reverting part of the previous patch to regain the needed functionality. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> CC: Fredrick John Berchmans <fredrickprashanth@gmail.com> Signed-off-by:
-
Ben Chan authored
This patch fixes the following checkpatch warning: CHECK: Blank lines aren't necessary after an open brace '{' Signed-off-by:Ben Chan <benchan@chromium.org> Signed-off-by:
-
Ben Chan authored
This patch fixes the following checkpatch warnings, which are issued when the gdm72xx driver is moved out of staging into drivers/net/wimax: WARNING: networking block comments don't use an empty /* line, use /* Comment... WARNING: networking block comments start with * on subsequent lines WARNING: networking block comments put the trailing */ on a separate line Signed-off-by:
-
Ben Chan authored
Signed-off-by:
-
Pawel Lebioda authored
This patch fixes the following sparse warning: drivers/staging/cxt1e1/sbecrc.c:86:1: warning: symbol 'sbeCrc' was not declared. Should it be static? Furthermore it fixes wring sbeCrc return type in function declaration. Signed-off-by:
Pawel Lebioda <pawel.lebioda89@gmail.com> Signed-off-by:
-
Cheng-Wei Lee authored
This patch fixes the following checkpatch.pl issue in ft1000/ft1000-pcmcia/ft1000_dnld.c ERROR: code indent should use tabs where possible Signed-off-by:
Quentin Lee <lee.rhapsody@gmail.com> Signed-off-by:
-
Seunghun Lee authored
This patch fixes below warning. drivers/staging/ced1401/ced_ioc.c:703:30: warning: incorrect type in assignment (different address spaces) drivers/staging/ced1401/ced_ioc.c:703:30: expected void *[usertype] lpvBuff drivers/staging/ced1401/ced_ioc.c:703:30: got char [noderef] <asn:1>*puBuf Signed-off-by:
Seunghun Lee <waydi1@gmail.com> Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
No point carrying a bunch of code around that is never going to get called. Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
