- 12 Nov, 2009 8 commits
-
-
David S. Miller authored
Noticed by Thomas GLeixner. Signed-off-by:David S. Miller <davem@davemloft.net>
-
Anton Vorontsov authored
Before calling gfar_clean_tx_ring() the driver grabs an irqsave spinlock, and then tries to recycle skbs. But since skb_recycle_check() returns 0 with IRQs disabled, we'll never recycle any skbs. It appears that gfar_clean_tx_ring() and gfar_start_xmit() are mostly idependent and can work in parallel, except when they modify num_txbdfree. So we can drop the lock from most sections and thus fix the skb recycling. Signed-off-by:
Anton Vorontsov <avorontsov@ru.mvista.com> Acked-by:
Kumar Gala <galak@kernel.crashing.org> Signed-off-by:
-
Anton Vorontsov authored
gfar_error() can arrive at the middle of gfar_start_xmit() processing, and so it can trigger transfers of BDs that we don't yet expect to be transmitted. Fix this by locking the tx queues in gfar_error(). Signed-off-by:
-
Anton Vorontsov authored
We obviously want to write a modified 'temp' value back to the register, not the saved IRQ flags. Signed-off-by:
-
Anton Vorontsov authored
commit fba4ed03 ("gianfar: Add Multiple Queue Support") introduced the following build failure: CC gianfar.o gianfar.c: In function 'gfar_restore': gianfar.c:1249: error: request for member 'napi' in something not a structure or union This patch fixes the issue. Signed-off-by:
-
Anton Vorontsov authored
It is OK to poll with disabled IRQs, so remove the warning. Signed-off-by:
-
Anton Vorontsov authored
NAPI drivers try to recycle SKBs in their polling routine, but we generally don't know the context in which the polling will be called, and the skb recycling itself may require IRQs to be enabled. This patch adds irqs_disabled() test to the skb_recycle_check() routine, so that we'll not let the drivers hit the skb recycling path with IRQs disabled. As a side effect, this patch actually disables skb recycling for some [broken] drivers. E.g. gianfar driver grabs an irqsave spinlock during TX ring processing, and then tries to recycle an skb, and that caused the following badness: nf_conntrack version 0.5.0 (1008 buckets, 4032 max) ------------[ cut here ]------------ Badness at kernel/softirq.c:143 NIP: c003e3c4 LR: c423a528 CTR: c003e344 ... NIP [c003e3c4] local_bh_enable+0x80/0xc4 LR [c423a528] destroy_conntrack+0xd4/0x13c [nf_conntrack] Call Trace: [c15d1b60] [c003e32c] local_bh_disable+0x1c/0x34 (unreliable) [c15d1b70] [c423a528] destroy_conntrack+0xd4/0x13c [nf_conntrack] [c15d1b80] [c02c6370] nf_conntrack_destroy+0x3c/0x70 Signed-off-by: -
David S. Miller authored
Reported by Stephen Rothwell: -------------------- Today's linux-next build (x86_64 allmodconfig) produced this warning: net/ipv6/addrconf.c: In function 'inet6_dump_ifinfo': net/ipv6/addrconf.c:3833: warning: unused variable 'err' Introduced by commit 84d2697d ("ipv6: speedup inet6_dump_ifinfo()"). -------------------- Signed-off-by:
-
- 11 Nov, 2009 32 commits
-
-
John W. Linville authored
I may have botched my merge conflict resolution instructions for Dave... Signed-off-by:
John W. Linville <linville@tuxdriver.com> Signed-off-by:
-
David S. Miller authored
Conflicts: drivers/net/wireless/iwlwifi/iwl-1000.c drivers/net/wireless/iwlwifi/iwl-6000.c drivers/net/wireless/iwlwifi/iwl-core.h
-
stephen hemminger authored
Use new function to avoid doing read_lock(). Signed-off-by:
Stephen Hemminger <shemminger@vyatta.com> Acked-by:
Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by:
Oliver Hartkopp <oliver@hartkopp.net> Signed-off-by:
-
stephen hemminger authored
This also needs to be optimized for large number of devices. Signed-off-by:
-
stephen hemminger authored
When showing device statistics use RCU rather than read_lock(&dev_base_lock) Compile tested only. Signed-off-by:
-
stephen hemminger authored
This is similar to other cases where for_each_netdev_rcu can be used when gathering information. By inspection, don't have platform or cross-build environment to validate. Signed-off-by:
-
stephen hemminger authored
Use RCU to walk list of network devices in qdisc dump. This could be optimized for large number of devices. Signed-off-by:
-
stephen hemminger authored
Do not need to use read_lock(&dev_base_lock), use RCU instead. Signed-off-by:
-
stephen hemminger authored
This adds an RCU macro for continuing search, useful for some network devices like vlan. Signed-off-by:
-
Brian Haley authored
Change udp6_portaddr_hash() to use ipv6_addr_v4mapped() inline instead of ipv6_addr_type(). Signed-off-by:
Brian Haley <brian.haley@hp.com> Acked-by:
-
Eric Dumazet authored
Use for_each_netdev_rcu() and dont lock dev_base_lock anymore Signed-off-by:
-
Herbert Xu authored
This patch rearranges the SIT DF bit handling using the new IPIP DF code. The only externally visible effect should be the case where PMTU is enabled and the MTU is exactly 1280 bytes. In this case the previous code would send packets out with DF off while the new code would set the DF bit. This is inline with RFC 4213. Signed-off-by:
Herbert Xu <herbert@gondor.apana.org.au> Thanks, Signed-off-by:
-
Eric Dumazet authored
Apparently, inet6_dump_addr() is not able to handle more than 64 ipv6 addresses per device. We must break from inner loops in case skb is full, or else cursor is put at the end of list. Signed-off-by:
-
Eric Dumazet authored
When handling large number of netdevice, inet6_dump_ifinfo() is very slow because it has O(N^2) complexity. Instead of scanning one single list, we can use the 256 sub lists of the dev_index hash table, and RCU lookups. Signed-off-by:
-
Cyrill Gorcunov authored
Use guard DECLARE_SOCKADDR in a few more places which allow us to catch if the structure copied back is too big. Signed-off-by:
Cyrill Gorcunov <gorcunov@openvz.org> Signed-off-by:
-
Ben Hutchings authored
Some usbnet drivers update link state while others do not due to hardware limitations. Add a flag to distinguish those that do, and set the link down initially for their devices. This is intended to fix this bug: http://bugs.debian.org/444043Signed-off-by:
Ben Hutchings <ben@decadent.org.uk> Signed-off-by:
-
Marin Mitov authored
Use DMA_BIT_MASK(44) instead of deprecated DMA_44BIT_MASK Signed-off-by:
Marin Mitov <mitov@issp.bas.bg> Signed-off-by:
-
Eric Dumazet authored
UDP bind() can be O(N^2) in some pathological cases. Thanks to secondary hash tables, we can make it O(N) Signed-off-by:
-
Eilon Greenstein authored
Signed-off-by:
Eilon Greenstein <eilong@broadcom.com> Signed-off-by:
-
Eilon Greenstein authored
Signed-off-by:
-
Eilon Greenstein authored
Failing to allocate MSI-X vectors is not an error and should not be printed as such Signed-off-by:
-
Eilon Greenstein authored
Making sure that whenever the FW/HW is configured for GSO, it is also configured to CSUM offload Signed-off-by:
-
Rémi Denis-Courmont authored
Signed-off-by:
Rémi Denis-Courmont <remi.denis-courmont@nokia.com> Signed-off-by:
-
Rémi Denis-Courmont authored
Signed-off-by:
-
Ben Hutchings authored
Signed-off-by:
-
Ben Hutchings authored
Signed-off-by:
-
Ben Hutchings authored
Signed-off-by:
-
Ben Hutchings authored
Signed-off-by:
-
Ben Hutchings authored
Signed-off-by:
-
Ben Hutchings authored
Replace run-time string formatting with preprocessor string manipulation. Signed-off-by:
Divy Le Ray <divy@chelsio.com> Signed-off-by:
-
Ben Hutchings authored
Replace run-time string formatting with preprocessor string manipulation. Signed-off-by:
-
Ben Hutchings authored
Signed-off-by:
-
