An error occurred fetching the project authors.
- 22 May, 2012 2 commits
-
-
Peter Ujfalusi authored
With the common irq the driver only needs to use one interrupt line, and it provides better debugging possibilites compared to the legacy TX/RX interrupt lines. Signed-off-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Acked-by:
Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by:
Liam Girdwood <lrg@ti.com>
-
Peter Ujfalusi authored
The frame dma_op_mode has never been used, and it is just creating confusion for users/developers. Signed-off-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Acked-by:
Mark Brown <broonie@opensource.wolfsonmicro.com> Acked-by:
Jarkko Nikula <jarkko.nikula@bitmer.com> Signed-off-by:
Liam Girdwood <lrg@ti.com>
-
- 12 Mar, 2012 10 commits
-
-
Peter Ujfalusi authored
Use single function for the CLKR/FSR mux configuration. OMAP2/3 has 6 pin configuration on McBSP1 instance, while on OMAP4 McBSP4 instance have the 6 pin configuration so the omap2_mcbsp1_mux_* is not correct name for all support OMAP versions Signed-off-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Acked-by:
Jarkko Nikula <jarkko.nikula@bitmer.com> Acked-by:
Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by:
Liam Girdwood <lrg@ti.com>
-
Peter Ujfalusi authored
Clock signal muxing, and functional clock related defines are only needed in ASoC drivers. Signed-off-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Acked-by:
Jarkko Nikula <jarkko.nikula@bitmer.com> Acked-by:
Mark Brown <broonoie@opensource.wolfsonmicro.com> Signed-off-by:
Liam Girdwood <lrg@ti.com>
-
Peter Ujfalusi authored
Configure the DMA request line, port address, and stream name at probe time instead of every time we start a stream. These settings are static in the system. Signed-off-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Tested-by:
Grazvydas Ignotas <notasas@gmail.com> Tested-by:
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> Acked-by:
Mark Brown <broonie@opensource.wolfsonmicro.com> Acked-by:
Jarkko Nikula <jarkko.nikula@bitmer.com> Signed-off-by:
Liam Girdwood <lrg@ti.com>
-
Peter Ujfalusi authored
Since the drivers has been merged, merge the two structures together. Signed-off-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Tested-by:
Grazvydas Ignotas <notasas@gmail.com> Tested-by:
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> Acked-by:
Mark Brown <broonie@opensource.wolfsonmicro.com> Acked-by:
Jarkko Nikula <jarkko.nikula@bitmer.com> Signed-off-by:
Liam Girdwood <lrg@ti.com>
-
Peter Ujfalusi authored
Use devm_* where it is possible to save on cleanup path. Start merging the two mcbsp file content. Move pm_runtime_enable/disable calls to ASoC probe, remove from module probe/remove time. Signed-off-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Tested-by:
Grazvydas Ignotas <notasas@gmail.com> Tested-by:
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> Acked-by:
Mark Brown <broonie@opensource.wolfsonmicro.com> Acked-by:
Jarkko Nikula <jarkko.nikula@bitmer.com> Signed-off-by:
Liam Girdwood <lrg@ti.com>
-
Peter Ujfalusi authored
We no longer need accessor functions for max_tx/rx_threshold, dma_op_mode or for the FIFO size. Signed-off-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Tested-by:
Grazvydas Ignotas <notasas@gmail.com> Tested-by:
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> Acked-by:
Mark Brown <broonie@opensource.wolfsonmicro.com> Acked-by:
Jarkko Nikula <jarkko.nikula@bitmer.com> Signed-off-by:
Liam Girdwood <lrg@ti.com>
-
Peter Ujfalusi authored
Use BIT() for bit position, correct field definition by adding mask to them, and also adding the missing spaces around '<<' Signed-off-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Tested-by:
Grazvydas Ignotas <notasas@gmail.com> Tested-by:
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> Acked-by:
Mark Brown <broonie@opensource.wolfsonmicro.com> Acked-by:
Jarkko Nikula <jarkko.nikula@bitmer.com> Signed-off-by:
Liam Girdwood <lrg@ti.com>
-
Peter Ujfalusi authored
The OMAP McBSP driver stack used to contain two different drivers. One of them was used as kind low-level access to the IP, while the other driver was the ASoC DAI driver. There were global, shared structures, in different places, the McBSP instances are reffered with id numbers (sometimes 0 based, in other cases 1 based id numbers). Create one single driver for OMAP McBSP with name: omap-mcbsp. Convert the old omap-mcbsp driver initially to be a library for the omap-mcbsp DAI driver. With this change we can get rid of all global variables, structures. Further cleanup is coming... Signed-off-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Tested-by:
Grazvydas Ignotas <notasas@gmail.com> Tested-by:
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> Acked-by:
Mark Brown <broonie@opensource.wolfsonmicro.com> Acked-by:
Jarkko Nikula <jarkko.nikula@bitmer.com> Signed-off-by:
Liam Girdwood <lrg@ti.com>
-
Peter Ujfalusi authored
Move most of the content of the plat/mcbsp.h header file under sound/soc/omap/ to help further cleanups. Signed-off-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Tested-by:
Grazvydas Ignotas <notasas@gmail.com> Tested-by:
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> Acked-by:
Mark Brown <broonie@opensource.wolfsonmicro.com> Acked-by:
Jarkko Nikula <jarkko.nikula@bitmer.com> Signed-off-by:
Liam Girdwood <lrg@ti.com>
-
Peter Ujfalusi authored
Convert the plat-omap/mcbsp.c driver to be proper platform driver. Remove the omap_mcbsp_init function call which was called from mach-omap1/2/mcbsp.c to register the platform driver for the just created platform device in the same function. Signed-off-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Acked-by:
Tony Lindgren <tony@atomide.com> Tested-by:
Grazvydas Ignotas <notasas@gmail.com> Tested-by:
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> Acked-by:
Jarkko Nikula <jarkko.nikula@bitmer.com> Signed-off-by:
Liam Girdwood <lrg@ti.com>
-
- 27 Sep, 2011 12 commits
-
-
Jarkko Nikula authored
This generalizes the omap2_mcbsp1_mux_clkr_src and omap2_mcbsp1_mux_fsr_src implementation between generic McBSP and OMAP2 specific McBSP code. These functions are used to select source for CLKR and FSR signals on OMAP2+. Start generalizing the code by implementing an optional mux_signal function pointer in platform data that will implement the actual muxing and which is called now from omap2_mcbsp1_mux_clkr_src and omap2_mcbsp1_mux_fsr_src. These functions are to be removed later and cleanup the API so that mux_signal gets its arguments directly from client code. Signed-off-by:
Jarkko Nikula <jarkko.nikula@bitmer.com> Acked-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Tested-by:
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> Signed-off-by:
Tony Lindgren <tony@atomide.com>
-
Jarkko Nikula authored
This generalizes the omap2_mcbsp_set_clks_src implementation between generic McBSP and OMAP2 specific McBSP code. Currently this function is used to select either internal fclk or clks pin as a McBSP CLKS source on OMAP2+. Implement generalization by having an optional set_clk_src function pointer in platform data that is used to select parent for a given clock. Idea is to pass higher level source clock name (later coming from client driver) that platform specific code will map to platform specific clock name. API cleanup between McBSP and client code comes later. Signed-off-by:
Jarkko Nikula <jarkko.nikula@bitmer.com> Acked-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Tested-by:
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> Signed-off-by:
Tony Lindgren <tony@atomide.com>
-
Jarkko Nikula authored
These address definitions are OMAP1 specific can be in single source file. Signed-off-by:
Jarkko Nikula <jarkko.nikula@bitmer.com> Acked-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Tested-by:
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> Signed-off-by:
Tony Lindgren <tony@atomide.com>
-
Jarkko Nikula authored
hardware.h is not needed here and let the definition for struct clk to come via linux/clk.h. Signed-off-by:
Jarkko Nikula <jarkko.nikula@bitmer.com> Acked-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Tested-by:
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> Signed-off-by:
Tony Lindgren <tony@atomide.com>
-
Jarkko Nikula authored
Sidetone resource is already registered for a device so there is no need for cpu_is_omap34xx() and McBSP port number tests in the driver. We can cleanup and make the code generic by dropping remaining CONFIG_ARCH_OMAP3 conditional compilations and then using sidetone resource and st_data variable for runtime tests. Signed-off-by:
Jarkko Nikula <jarkko.nikula@bitmer.com> Acked-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Tested-by:
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> Signed-off-by:
Tony Lindgren <tony@atomide.com>
-
Jarkko Nikula authored
Active sidetone requires that McBSP interface clock doesn't idle and there is no mechanism in hwmod to turn autoidling on/off in runtime. McBSP2 and 3 in OMAP34xx share their interface clock with McBSP sidetone module and that interface clock must be active when the sidetone is operating. Sidetone has its own autoidle bit which should keep the interface clock active but it is broken. Putting the McBSP core to no-idle mode when the sidetone is active is no good either since it results to higher power consumption when using the threshold based DMA transfers. For making the McBSP code more generic, move this sidetone clock management with fixme comments to mach-omap2/mcbsp.c and pass pointer to it via platform data. Signed-off-by:
Jarkko Nikula <jhnikula@gmail.com> Cc: Paul Wamsley <paul@pwsan.com> Acked-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Tested-by:
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> Signed-off-by:
Tony Lindgren <tony@atomide.com>
-
Jarkko Nikula authored
Rationale here is to remove one global variable and to make possible to have variable size McBSP register maps inside SoC. Signed-off-by:
Jarkko Nikula <jarkko.nikula@bitmer.com> Acked-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Tested-by:
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> Signed-off-by:
Tony Lindgren <tony@atomide.com>
-
Jarkko Nikula authored
Remove CONFIG_ARCH_OMAP3 conditional compilation and cpu_is_omap34xx test around buffer threshold based transfer and DMA operating mode control. Use instead the buffer_size in platform data to determine when these sysfs controls are exposed and when to access related McBSP registers. Rationale for this is to make code generic and to allow to use it on OMAP4 that also supports threshold based transfers. Currently buffer_size variable is set only for OMAP3 SoCs but it is easy to extend to OMAP4 and any later OMAP version. Signed-off-by:
Jarkko Nikula <jarkko.nikula@bitmer.com> Acked-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Tested-by:
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> Signed-off-by:
Tony Lindgren <tony@atomide.com>
-
Jarkko Nikula authored
McBSP transmit and receive configuration control registers must be set up for OMAP2430 and later. Replace is_omap tests in generic code with a new feature flag has_ccr in platform data so that there is no need to change code for any upcoming OMAP version. Signed-off-by:
Jarkko Nikula <jarkko.nikula@bitmer.com> Acked-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Tested-by:
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> Signed-off-by:
Tony Lindgren <tony@atomide.com>
-
Jarkko Nikula authored
Currently wakeup control code is compiled only when CONFIG_ARCH_OMAP3 is set even it should be available for CONFIG_ARCH_OMAP4 only builds also. Fix this by making wakeup control generic so that it is executed whenever new feature flag has_wakeup in platform data is set. Currently flag is set for McBSP config types 3 and 4. Remove also old comments about idle mode settings and HW bug workarounds that were not updated during hwmod conversion. Signed-off-by:
Jarkko Nikula <jarkko.nikula@bitmer.com> Acked-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Tested-by:
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> Signed-off-by:
Tony Lindgren <tony@atomide.com>
-
Jarkko Nikula authored
Register access can be made more generic by calculating register address offsets runtime from common register definitions and by using reg_size and reg_step variables that are passed via platform data. Common register definitions are possible since McBSP registers are ordered similarly between OMAP versions. Remove also references to OMAP2+ specific config_type variable from generic McBSP code since other variables and feature flags are better to carry needed information from platform code. Signed-off-by:
Jarkko Nikula <jarkko.nikula@bitmer.com> Acked-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Tested-by:
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> Signed-off-by:
Tony Lindgren <tony@atomide.com>
-
Jarkko Nikula authored
Only OMAP1s are using omap_mcbsp_register_board_cfg after OMAP2+ hwmod conversion so it can be moved to mach-omap1/mcbsp.c. Signed-off-by:
Jarkko Nikula <jarkko.nikula@bitmer.com> Acked-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Tested-by:
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> Signed-off-by:
Tony Lindgren <tony@atomide.com>
-
- 26 Sep, 2011 1 commit
-
-
Jarkko Nikula authored
These variables got unused after McBSP was converted to use resource structures. Signed-off-by:
Jarkko Nikula <jarkko.nikula@bitmer.com> Acked-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Tested-by:
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> Signed-off-by:
Tony Lindgren <tony@atomide.com>
-
- 07 Jul, 2011 2 commits
-
-
Jarkko Nikula authored
These McBSP port number enums are used only in two places in the McBSP code so we may remove then and just use numeric values like rest of the code does. Signed-off-by:
Jarkko Nikula <jhnikula@gmail.com> Signed-off-by:
Tony Lindgren <tony@atomide.com>
-
Jarkko Nikula authored
These variables got unused after ("omap: mcbsp: Drop in-driver transfer support") but was noticed only afterwards. Signed-off-by:
Jarkko Nikula <jhnikula@gmail.com> Signed-off-by:
Tony Lindgren <tony@atomide.com>
-
- 29 Jun, 2011 2 commits
-
-
Jarkko Nikula authored
We haven't seen either use for in-driver transfer API in McBSP driver over the years so it looks they can be removed too. Signed-off-by:
Jarkko Nikula <jhnikula@gmail.com> Signed-off-by:
Tony Lindgren <tony@atomide.com>
-
Jarkko Nikula authored
We haven't seen any use for the SPI API in McBSP driver over the years. More over, Peter Ujfalusi <peter.ujfalusi@ti.com> noticed that SPI mode is not even supported since OMAP2430 so it's very unlikely that we'll see any use for it in the future either. Signed-off-by:
Jarkko Nikula <jhnikula@gmail.com> Acked-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Signed-off-by:
Tony Lindgren <tony@atomide.com>
-
- 24 Feb, 2011 9 commits
-
-
Kishon Vijay Abraham I authored
Information like base address and DMA channel nubers should no longer be obtained using macros. These information should be obtained from hwmod database. Hence the macros that define the base address are removed. Signed-off-by:
Kishon Vijay Abraham I <kishon@ti.com> Signed-off-by:
Charulatha V <charu@ti.com> Acked-by:
Peter Ujfalusi <peter.ujfalusi@nokia.com> Acked-by:
Jarkko Nikula <jhnikula@gmail.com> Acked-by:
Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by:
Tony Lindgren <tony@atomide.com>
-
Kishon Vijay Abraham I authored
After McBSP driver is hwmod adapted, the information about the hw would be obtained from the hwmod database by the mcbsp driver. Since DMA programming is handled by the client driver, APIs are provided to pass the DMA channel number and base address of data register required by the client driver for DMA programming. Signed-off-by:
Kishon Vijay Abraham I <kishon@ti.com> Signed-off-by:
Charulatha V <charu@ti.com> Acked-by:
Peter Ujfalusi <peter.ujfalusi@nokia.com> Acked-by:
Jarkko Nikula <jhnikula@gmail.com> Acked-by:
Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by:
Tony Lindgren <tony@atomide.com>
-
Kishon Vijay Abraham I authored
Add pm runtime support for McBSP driver. Reference to fclk is not removed because it is required when the functional clock is switched from one source to another. Signed-off-by:
Kishon Vijay Abraham I <kishon@ti.com> Cc: Paul Walmsley <paul@pwsan.com> Acked-by:
Peter Ujfalusi <peter.ujfalusi@nokia.com> Acked-by:
Jarkko Nikula <jhnikula@gmail.com> Acked-by:
Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by:
Tony Lindgren <tony@atomide.com>
-
Kishon Vijay Abraham I authored
Modify OMAP2+ McBSP to use omap hwmod framework APIs Signed-off-by:
Kishon Vijay Abraham I <kishon@ti.com> Signed-off-by:
Charulatha V <charu@ti.com> Signed-off-by:
Shubhrajyoti D <shubhrajyoti@ti.com> Acked-by:
Peter Ujfalusi <peter.ujfalusi@nokia.com> Acked-by:
Jarkko Nikula <jhnikula@gmail.com> Acked-by:
Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by:
Tony Lindgren <tony@atomide.com>
-
Kishon Vijay Abraham I authored
Since the sidetone block is tightly coupled to the mcbsp, sidetone information is directly added to mcbsp2 & 3 hwmod dev_attr. Signed-off-by:
Kishon Vijay Abraham I <kishon@ti.com> Signed-off-by:
Benoit Cousson <b-cousson@ti.com> Signed-off-by:
Tony Lindgren <tony@atomide.com>
-
Kishon Vijay Abraham I authored
Added a name to address space belonging to SDMA and MPU facilitating the driver to get the address space info by name. Added a revision member inorder to facilitate the driver to differentiate between mcbsp in different omap. Also added a platform_get_irq in probe to get irq number by index since from OMAP4, there will be a single irq line. Signed-off-by:
Benoit Cousson <b-cousson@ti.com> Signed-off-by:
Kishon Vijay Abraham I <kishon@ti.com> Signed-off-by:
Tony Lindgren <tony@atomide.com>
-
Charulatha V authored
Add McBSP hwmod data for OMAP3. Added a revision member inorder to facilitate the driver to differentiate between mcbsp in different omap. Signed-off-by:
Charulatha V <charu@ti.com> Signed-off-by:
Kishon Vijay Abraham I <kishon@ti.com> Signed-off-by:
Shubhrajyoti D <shubhrajyoti@ti.com> Cc: Benoit Cousson <b-cousson@ti.com> Signed-off-by:
Tony Lindgren <tony@atomide.com>
-
Charulatha V authored
Add McBSP hwmod data for OMAP2430. Added a revision member inorder to facilitate the driver to differentiate between mcbsp in different omap. Signed-off-by:
Charulatha V <charu@ti.com> Signed-off-by:
Kishon Vijay Abraham I <kishon@ti.com> Signed-off-by:
Shubhrajyoti D <shubhrajyoti@ti.com> Cc: Benoit Cousson <b-cousson@ti.com> Signed-off-by:
Tony Lindgren <tony@atomide.com>
-
Kishon Vijay Abraham I authored
Implement McBSP as platform device and add support for registering through platform device layer using resource structures. Later in this patch series, OMAP2+ McBSP driver would be modified to use hwmod framework after populating the omap2+ hwmod database. Signed-off-by:
Kishon Vijay Abraham I <kishon@ti.com> Acked-by:
Peter Ujfalusi <peter.ujfalusi@nokia.com> Acked-by:
Jarkko Nikula <jhnikula@gmail.com> Acked-by:
Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by:
Tony Lindgren <tony@atomide.com>
-
- 14 Feb, 2011 1 commit
-
-
Kishon Vijay Abraham I authored
Some macros defined in mcbsp.h related to audio, which are never being used is removed. Signed-off-by:
Kishon Vijay Abraham I <kishon@ti.com> Reviewed-by:
Charulatha V <charu@ti.com> Cc: Jarkko Nikula <jhnikula@gmail.com> Acked-by:
Jarkko Nikula <jhnikula@gmail.com> Acked-by:
Peter Ujfalusi <peter.ujfalusi@nokia.com> Acked-by:
G, Manjunath Kondaiah <manjugk@ti.com> Signed-off-by:
Tony Lindgren <tony@atomide.com>
-
- 08 Oct, 2010 1 commit
-
-
Jarkko Nikula authored
This is just a readability and debugging improvement. As selection bit in DEVCONF register is cleared when using 96 MHz PRCM source and set when using external CLKS pin, change definitions to be sync with these. Signed-off-by:
Jarkko Nikula <jhnikula@gmail.com> Acked-by:
Paul Walmsley <paul@pwsan.com> Acked-by:
Peter Ujfalusi <peter.ujfalusi@nokia.com>
-