- 14 Aug, 2013 2 commits
-
-
Johan Hovold authored
Make sure serial DMA-buffers are allocated separately from containing structure to prevent potential memory corruption on non-cache-coherent systems. Signed-off-by:
Johan Hovold <jhovold@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Johan Hovold authored
Make sure serial DMA-buffers are allocated separately from containing structure to prevent potential memory corruption on non-cache-coherent systems. Signed-off-by:
-
- 17 Jun, 2013 1 commit
-
-
Greg Kroah-Hartman authored
This moves the allocation of minor device numbers from a static array to be dynamic, using the idr interface. This means that you could potentially get "gaps" in a minor number range for a single USB serial device with multiple ports, but all should still work properly. We remove the 'minor' field from the usb_serial structure, as it no longer makes any sense for it (use the field in the usb_serial_port structure if you really want to know this number), and take the fact that we were overloading a number in this field to determine if we had initialized the minor numbers or not, and just use a flag variable instead. Note, we still have the limitation of 255 USB to serial devices in the system, as that is all we are registering with the TTY layer at this point in time. Tested-by:
Tobias Winter <tobias@linuxdingsda.de> Reviewed-by:
-
- 10 Jun, 2013 1 commit
-
-
Greg Kroah-Hartman authored
The usb_serial_port structure had the number field, which was the minor number for the port, which almost no one really cared about. They really wanted the number of the port within the device, which you had to subtract from the minor of the parent usb_serial_device structure. To clean this up, provide the real minor number of the port, and the number of the port within the serial device separately, as these numbers might not be related in the future. Bonus is that this cleans up a lot of logic in the drivers, and saves lines overall. Tested-by:
-
- 17 May, 2013 1 commit
-
-
Sachin Kamat authored
'qt2_process_read_urb' is referenced only in this file. Make it static. Signed-off-by:
Sachin Kamat <sachin.kamat@linaro.org> Signed-off-by:
-
- 25 Mar, 2013 3 commits
-
-
Johan Hovold authored
Always try to disable the uart on close. Since the switch to tty ports, close will be called as part of shutdown before disconnect returns. Hence there is no need to check the disconnected flag, and we can put devices in disabled states also on driver unbind. Signed-off-by:
-
Johan Hovold authored
Switch to the generic TIOCMIWAIT implementation. This also fixes the issue with processes waiting for modem-status-changes not being woken up at disconnect. Signed-off-by:
-
Johan Hovold authored
Switch to the generic get_icount implementation. Signed-off-by:
-
- 21 Mar, 2013 2 commits
-
-
Greg Kroah-Hartman authored
This reverts commit 27b351c5 . It caused problems with the build. Reported-by:
Stephen Rothwell <sfr@canb.auug.org.au> Cc: Bill Pemberton <wfp5p@viridian.itc.virginia.edu> Cc: Jiri Slaby <jslaby@suse.cz> Signed-off-by:
-
Johan Hovold authored
Use the port wait queue and make sure to check the serial disconnected flag before accessing private port data after waking up. This is is needed as the private port data (including the wait queue itself) can be gone when waking up after a disconnect. Cc: stable <stable@vger.kernel.org> Signed-off-by:
-
- 20 Mar, 2013 1 commit
-
-
Bill Pemberton authored
This reverts commit 27b351c5 . Calling tty_flip_buffer_push on an unopened tty is legal, so the driver doesn't need track if port has been opened. Reverting this allows the entire is_open logic to be removed. Signed-off-by:
Bill Pemberton <wfp5p@virginia.edu> Signed-off-by:
-
- 18 Mar, 2013 1 commit
-
-
Jiri Slaby authored
tty->ops->break_ctl cannot be called outside the gap between open and close. So there is no need to check whether the port is open in break_ctl in quatech2. Remove the check and also that member completely. Signed-off-by:
Jiri Slaby <jslaby@suse.cz> Cc: Bill Pemberton <wfp5p@virginia.edu> Signed-off-by:
-
- 13 Mar, 2013 1 commit
-
-
Bill Pemberton authored
The commit 2e124b4a removed the checks that prevented qt2_process_read_urb() from trying to put chars into ttys that weren't actually opened. This resulted in 'tty is NULL' warnings from flush_to_ldisc() when the device was used. The devices use just one read urb for all ports. As a result qt2_process_read_urb() may be called with the current port set to a port number that has not been opened. Add a check if the port is open before calling tty_flip_buffer_push(). Signed-off-by:
-
- 13 Feb, 2013 1 commit
-
-
Johan Hovold authored
Make sure serial-driver dtr_rts is called with disc_mutex held after checking the disconnected flag. Due to a bug in the tty layer, dtr_rts may get called after a device has been disconnected and the tty-device unregistered. Some drivers have had individual checks for disconnect to make sure the disconnected interface was not accessed, but this should really be handled in usb-serial core (at least until the long-standing tty-bug has been fixed). Note that the problem has been made more acute with commit 0998d063 ("device-core: Ensure drvdata = NULL when no driver is bound") as the port data is now also NULL when dtr_rts is called resulting in further oopses. Reported-by:
Chris Ruehl <chris.ruehl@gtsys.com.hk> Cc: stable <stable@vger.kernel.org> Signed-off-by:
-
- 16 Jan, 2013 3 commits
-
-
Jiri Slaby authored
Now, we start converting tty buffer functions to actually use tty_port. This will allow us to get rid of the need of tty in many call sites. Only tty_port will needed and hence no more tty_port_tty_get in those paths. Now, the one where most of tty_port_tty_get gets removed: tty_flip_buffer_push. IOW we also closed all the races in drivers not using tty_port_tty_get at all yet. Also we move tty_flip_buffer_push declaration from include/linux/tty.h to include/linux/tty_flip.h to all others while we are changing it anyway. Signed-off-by:
-
Jiri Slaby authored
Now, we start converting tty buffer functions to actually use tty_port. This will allow us to get rid of the need of tty in many call sites. Only tty_port will needed and hence no more tty_port_tty_get in those paths. tty_insert_flip_string this time. Signed-off-by:
-
Jiri Slaby authored
Now, we start converting tty buffer functions to actually use tty_port. This will allow us to get rid of the need of tty pointer in many call sites. Only tty_port will be needed and hence no more tty_port_tty_get calls in those paths. Here we start with tty_buffer_request_room. Signed-off-by:
-
- 31 Oct, 2012 1 commit
-
-
Johan Hovold authored
Remove all MODULE_VERSION macros and driver-version information (except for garmin_gps which uses it in a status reply). It is the kernel version that matters and not some private version scheme which rarely even gets updated. Signed-off-by:
-
- 25 Oct, 2012 4 commits
-
-
Johan Hovold authored
Make sure no control urb is submitted during close after a disconnect by checking the disconnected flag. Cc: <stable@vger.kernel.org> Signed-off-by:
-
Johan Hovold authored
Kill urbs unconditionally at close and disconnect. Note that URB status is not valid outside of completion handler. Cc: <stable@vger.kernel.org> Signed-off-by:
-
Johan Hovold authored
Fix port-data memory leak by moving port data allocation and deallocation to port_probe and port_remove. Since commit 0998d063 (device-core: Ensure drvdata = NULL when no driver is bound) the port private data is no longer freed at release as it is no longer accessible. Note that this also fixes memory leaks in the error path of attach where the write urbs were not freed on errors. Make sure all interface-data deallocation is done in release by moving the read urb deallocation from disconnect. Note that the write urb is killed during close so that the call in disconnect was superfluous. Compile-only tested. Cc: Bill Pemberton <wfp5p@virginia.edu> Cc: <stable@vger.kernel.org> Signed-off-by:
-
Johan Hovold authored
Fix memory leak in attach error path where the read urb was never freed. Cc: Bill Pemberton <wfp5p@virginia.edu> Cc: <stable@vger.kernel.org> Signed-off-by:
-
- 18 Sep, 2012 1 commit
-
-
Greg Kroah-Hartman authored
It should be calling dev_err() instead of printk(KERN_INFO...) so this change fixes that up properly. Cc: Bill Pemberton <wfp5p@virginia.edu> Signed-off-by:
-
- 14 Sep, 2012 1 commit
-
-
Greg Kroah-Hartman authored
Now that the dbg() macro is no longer being used in the driver, the debug module parameter doesn't do anything at all. So remove it so as to not confuse people. CC: Bill Pemberton <wfp5p@virginia.edu> Signed-off-by:
-
- 16 Jul, 2012 1 commit
-
-
Alan Cox authored
This will let us sort out a whole pile of tty related races. The alternative would be to keep points and refcount the termios objects. However 1. They are tiny anyway 2. Many devices don't use the stored copies 3. We can remove a pty special case Signed-off-by:
Alan Cox <alan@linux.intel.com> Signed-off-by:
-
- 20 Jun, 2012 1 commit
-
-
Bill Pemberton authored
qt2_open() and qt2_close() both set a serial_priv variable but never used it. Remove the variable from the functions. Signed-off-by:
-
- 10 May, 2012 2 commits
-
-
Bill Pemberton authored
Add a copyright and license statement to the head of quatech.c source file. No code change here. Signed-off-by:
-
Bill Pemberton authored
This supports the Quatech USB 2 usb to serial adapters. Signed-off-by:
-
