1. 03 Feb, 2018 13 commits
    • Dmitry Torokhov's avatar
      Input: trackpoint - combine calls to ps2_command() · 3aceaa34
      Dmitry Torokhov authored
      We do not need to call ps2_command() several times in a row, transmitting
      every byte as it were a command byte, we can often pack it all in a single
      command.
      
      Also, now that ps2_command() handles retransmission, we do not need to do
      it ourselves in trackpoint_power_on_reset().
      Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
      3aceaa34
    • Dmitry Torokhov's avatar
      Input: libps2 - relax command byte ACK handling · 29acc42e
      Dmitry Torokhov authored
      When we probe PS/2 devices we first issue "Get ID" command and only if we
      receive what we consider a valid keyboard or mouse ID we disable the device
      and continue with protocol detection. That means that the device may be
      transmitting motion or keystroke data, while we expect ACK response.
      
      Instead of signaling failure if we see anything but ACK/NAK let's ignore
      "garbage" response until we see ACK for the command byte (first byte). The
      checks for subsequent ACKs of command parameters will continue be strict.
      Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
      29acc42e
    • Dmitry Torokhov's avatar
      Input: libps2 - support retransmission of command data · b99e1f2a
      Dmitry Torokhov authored
      The devices are allowed to respond to either command byte or command
      parameter with a NAK (0xfe), and the host is supposed to resend the
      "correct" byte. The device then will either respond with ACK or ERR (0xfc).
      Let's teach libps2 to handle the NAK responses properly, so that individual
      drivers do not need to handle them.
      Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
      b99e1f2a
    • Dmitry Torokhov's avatar
      Input: libps2 - add debugging statements · 147b903d
      Dmitry Torokhov authored
      Debugging via i8042.debug and analyzing raw PS/2 data stream may be
      cumbersome as you need to locate the boundaries of commands, decipher the
      sliced commands, etc, etc. Let's add a bit more high level debug statements
      for ps2_sendbyte(), ps2_command(), and ps2_sliced_command().
      
      We do not introduce a new module parameter, but rater rely on the kernel
      having dynamic debug facility enabled (which most everyone has nowadays).
      Enable with:
      
      echo "file libps2.c +pf" > /sys/kernel/debug/dynamic_debug/control
      
      or add "libps2.dyndbg=+pf" to the kernel command line.
      Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
      147b903d
    • Dmitry Torokhov's avatar
      Input: psmouse - move sliced command implementation to libps2 · 08be954b
      Dmitry Torokhov authored
      In preparation to adding some debugging statements to PS/2 control
      sequences let's move psmouse_sliced_command() into libps2 and rename it
      to ps2_sliced_command().
      Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
      08be954b
    • Dmitry Torokhov's avatar
      Input: libps2 - use BIT() for bitmask constants · 3a92dd33
      Dmitry Torokhov authored
      Let's explicitly document bit numbers with BIT() macro.
      Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
      3a92dd33
    • Dmitry Torokhov's avatar
      Input: libps2 - use u8 for byte data · b28bad65
      Dmitry Torokhov authored
      Instead of using unsigned char for the byte data switch to using u8. Also
      use unsigned int for the command codes and timeouts, and have
      ps2_handle_ack() and ps2_handle_response() return bool instead of int, as
      they do not return error codes but rather signal whether a byte was handled
      or not handled. ps2_is_keyboard_id() now returns bool as well.
      Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
      b28bad65
    • Dmitry Torokhov's avatar
      Input: libps2 - fix switch statement formatting · d5e0d918
      Dmitry Torokhov authored
      Individual labels of switch statements should have the same indentation
      level as the switch statement itself.
      Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
      d5e0d918
    • Stephen Lyons's avatar
      Input: psmouse - add support for 2nd wheel on A4Tech Dual-Scroll wheel mice · 4c711ef6
      Stephen Lyons authored
      This Far-Eastern company's PS/2 mice use a deviant format for the data
      relating to movement of the scroll wheels for, at least, their dual wheel
      mice, such as their "Optical GreatEye Wheelmouse" model "WOP-35".  This
      product has five "buttons" (one of which is the click action on the first
      wheel) and TWO scroll wheels.  However for a byte comprising d0-d7 instead
      of setting one of d6-7 in the forth byte of the mouse data packet and a
      twos complement number of scroll steps in the remaining d5-d0 (or d3-d0
      should there be a fourth (BTN_SIDE - d4) or fifth (BTN_EXTRA - d5) button
      to report; they only report a single +/- event for each wheel and use a bit
      pattern that corresponds to +/-1 for the first wheel and +/- 2 for the
      second in the lower nibble of the fourth byte.
      
      The effect with existing code is that the second mouse wheel merely repeats
      the effect of the first but providing two steps per click rather than the
      one of the first wheel - so there is no HORIZONTAL scroll wheel movement
      detected from the device as far as the rest of the kernel sees it.
      
      This patch, if enabled by the "a4tech_workaround" module parameter modifies
      the handling just for mice of type PSMOUSE_IMEX so that the second scroll
      wheel movement gets correctly reported as REL_HWHEEL events.  Should this
      module parameter be activated for other mice of the same PSMOUSE_IMEX type
      then it is possible that at the point where the mouse reports more than a
      single movement step the user may start seeing horizontal rather than
      vertical wheel events, but should the movement steps get to be more than
      two at a time the hack will get immediately deactivated and the behaviour
      will revert to the past code.
      
      This was discussed around *fifteen* *years* *ago* on the LKML and the best
      summary is in post https://lkml.org/lkml/2002/7/18/111 "Re: PS2 Input Core
      Support" by Vojtech Pavlik. I was not able to locate any discussion later
      than this on this topic.
      
      Given that most users of the "psmouse" module will NOT want this additional
      feature enabled I have taken the apparently erroneous step of defaulting
      the module parameter that enables it to be "disabled" - this functionality
      may interfere with the operation of "normal" mice of this type (until a
      large enough scroll wheel movement is detected) so I cannot see how it
      would want to be enabled for "normal" users - i.e.  everyone without this
      brand of mouse.
      
      I am using this patch at the moment and I can confirm that it is working
      for me as both a module and compiled into the kernel for my mouse that is
      of the type (WOP-35) described - I note that it is still available from
      certain on-line retailers and that the manufacturers site does not list
      GNU/Linux as being supported on the product page - this patch however does
      enable full use of this product:
      http://www.a4tech.com/product.asp?cid=3D1&scid=3D8&id=3D22Signed-off-by: default avatarStephen Lyons <slysven@virginmedia.com>
      Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
      4c711ef6
    • Dmitry Torokhov's avatar
      Input: lifebook - clean up code · c13b4186
      Dmitry Torokhov authored
      - use u8 instead of unsigned char for byte data
      - use input_set_capability() instead of manipulating capabilities bits
        directly
      - do not abuse -1 as error code, propagate errors from various calls.
      Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
      c13b4186
    • Dmitry Torokhov's avatar
      Input: logips2pp - clean up code · 592c352b
      Dmitry Torokhov authored
      - switch to using BIT() macros
      - use u8 instead of unsigned char for byte data
      - use input_set_capability() instead of manipulating capabilities bits
        directly
      - use sign_extend32() when extracting wheel data.
      - do not abuse -1 as error code, propagate errors from various calls.
      Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
      592c352b
    • Dmitry Torokhov's avatar
      Input: psmouse - clean up code · ba667650
      Dmitry Torokhov authored
      - switch to using BIT() macros
      - use u8 instead of unsigned char for byte data
      - use input_set_capability() instead of manipulating capabilities bits
        directly
      - use sign_extend32() when extracting wheel data.
      - do not abuse -1 as error code, propagate errors from various calls.
      Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
      ba667650
    • Dmitry Torokhov's avatar
      Input: psmouse - create helper for reporting standard buttons/motion · 1ef85805
      Dmitry Torokhov authored
      Many protocol driver re-implement code to parse buttons or motion data from
      the standard PS/2 protocol. Let's split the parsing into separate
      functions and reuse them in protocol drivers.
      Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
      1ef85805
  2. 28 Jan, 2018 8 commits
  3. 27 Jan, 2018 2 commits
    • Thomas Gleixner's avatar
      hrtimer: Reset hrtimer cpu base proper on CPU hotplug · d5421ea4
      Thomas Gleixner authored
      The hrtimer interrupt code contains a hang detection and mitigation
      mechanism, which prevents that a long delayed hrtimer interrupt causes a
      continous retriggering of interrupts which prevent the system from making
      progress. If a hang is detected then the timer hardware is programmed with
      a certain delay into the future and a flag is set in the hrtimer cpu base
      which prevents newly enqueued timers from reprogramming the timer hardware
      prior to the chosen delay. The subsequent hrtimer interrupt after the delay
      clears the flag and resumes normal operation.
      
      If such a hang happens in the last hrtimer interrupt before a CPU is
      unplugged then the hang_detected flag is set and stays that way when the
      CPU is plugged in again. At that point the timer hardware is not armed and
      it cannot be armed because the hang_detected flag is still active, so
      nothing clears that flag. As a consequence the CPU does not receive hrtimer
      interrupts and no timers expire on that CPU which results in RCU stalls and
      other malfunctions.
      
      Clear the flag along with some other less critical members of the hrtimer
      cpu base to ensure starting from a clean state when a CPU is plugged in.
      
      Thanks to Paul, Sebastian and Anna-Maria for their help to get down to the
      root cause of that hard to reproduce heisenbug. Once understood it's
      trivial and certainly justifies a brown paperbag.
      
      Fixes: 41d2e494 ("hrtimer: Tune hrtimer_interrupt hang logic")
      Reported-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
      Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Sebastian Sewior <bigeasy@linutronix.de>
      Cc: Anna-Maria Gleixner <anna-maria@linutronix.de>
      Cc: stable@vger.kernel.org
      Link: https://lkml.kernel.org/r/alpine.DEB.2.20.1801261447590.2067@nanos
      d5421ea4
    • H. Peter Anvin's avatar
      x86: Mark hpa as a "Designated Reviewer" for the time being · 8a95b74d
      H. Peter Anvin authored
      Due to some unfortunate events, I have not been directly involved in
      the x86 kernel patch flow for a while now.  I have also not been able
      to ramp back up by now like I had hoped to, and after reviewing what I
      will need to work on both internally at Intel and elsewhere in the near
      term, it is clear that I am not going to be able to ramp back up until
      late 2018 at the very earliest.
      
      It is not acceptable to not recognize that this load is currently
      taken by Ingo and Thomas without my direct participation, so I mark
      myself as R: (designated reviewer) rather than M: (maintainer) until
      further notice.  This is in fact recognizing the de facto situation
      for the past few years.
      
      I have obviously no intention of going away, and I will do everything
      within my power to improve Linux on x86 and x86 for Linux.  This,
      however, puts credit where it is due and reflects a change of focus.
      
      This patch also removes stale entries for portions of the x86
      architecture which have not been maintained separately from arch/x86
      for a long time.  If there is a reason to re-introduce them then that
      can happen later.
      Signed-off-by: default avatarH. Peter Anvin <h.peter.anvin@intel.com>
      Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
      Cc: Bruce Schlobohm <bruce.schlobohm@intel.com>
      Cc: Linus Torvalds <torvalds@linux-foundation.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Link: http://lkml.kernel.org/r/20180125195934.5253-1-hpa@zytor.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
      8a95b74d
  4. 26 Jan, 2018 13 commits
  5. 25 Jan, 2018 4 commits
    • Lyude Paul's avatar
      drm/nouveau: Move irq setup/teardown to pci ctor/dtor · 0fd189a9
      Lyude Paul authored
      For a while we've been having issues with seemingly random interrupts
      coming from nvidia cards when resuming them. Originally the fix for this
      was thought to be just re-arming the MSI interrupt registers right after
      re-allocating our IRQs, however it seems a lot of what we do is both
      wrong and not even nessecary.
      
      This was made apparent by what appeared to be a regression in the
      mainline kernel that started introducing suspend/resume issues for
      nouveau:
      
              a0c9259d (irq/matrix: Spread interrupts on allocation)
      
      After this commit was introduced, we started getting interrupts from the
      GPU before we actually re-allocated our own IRQ (see references below)
      and assigned the IRQ handler. Investigating this turned out that the
      problem was not with the commit, but the fact that nouveau even
      free/allocates it's irqs before and after suspend/resume.
      
      For starters: drivers in the linux kernel haven't had to handle
      freeing/re-allocating their IRQs during suspend/resume cycles for quite
      a while now. Nouveau seems to be one of the few drivers left that still
      does this, despite the fact there's no reason we actually need to since
      disabling interrupts from the device side should be enough, as the
      kernel is already smart enough to know to disable host-side interrupts
      for us before going into suspend. Since we were tearing down our IRQs by
      hand however, that means there was a short period during resume where
      interrupts could be received before we re-allocated our IRQ which would
      lead to us getting an unhandled IRQ. Since we never handle said IRQ and
      re-arm the interrupt registers, this would cause us to miss all of the
      interrupts from the GPU and cause our init process to start timing out
      on anything requiring interrupts.
      
      So, since this whole setup/teardown every suspend/resume cycle is
      useless anyway, move irq setup/teardown into the pci subdev's ctor/dtor
      functions instead so they're only called at driver load and driver
      unload. This should fix most of the issues with pending interrupts on
      resume, along with getting suspend/resume for nouveau to work again.
      
      As well, this probably means we can also just remove the msi rearm call
      inside nvkm_pci_init(). But since our main focus here is to fix
      suspend/resume before 4.15, we'll save that for a later patch.
      Signed-off-by: default avatarLyude Paul <lyude@redhat.com>
      Cc: Karol Herbst <kherbst@redhat.com>
      Cc: Thomas Gleixner <tglx@linutronix.de>
      Cc: Mike Galbraith <efault@gmx.de>
      Cc: stable@vger.kernel.org
      Signed-off-by: default avatarBen Skeggs <bskeggs@redhat.com>
      0fd189a9
    • Nicolas Dichtel's avatar
      net: don't call update_pmtu unconditionally · f15ca723
      Nicolas Dichtel authored
      Some dst_ops (e.g. md_dst_ops)) doesn't set this handler. It may result to:
      "BUG: unable to handle kernel NULL pointer dereference at           (null)"
      
      Let's add a helper to check if update_pmtu is available before calling it.
      
      Fixes: 52a589d5 ("geneve: update skb dst pmtu on tx path")
      Fixes: a93bf0ff ("vxlan: update skb dst pmtu on tx path")
      CC: Roman Kapl <code@rkapl.cz>
      CC: Xin Long <lucien.xin@gmail.com>
      Signed-off-by: default avatarNicolas Dichtel <nicolas.dichtel@6wind.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f15ca723
    • Linus Torvalds's avatar
      Merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm · 6e20630e
      Linus Torvalds authored
      Pull KVM fixes from Radim Krčmář:
       "Fix races and a potential use after free in the s390 cmma migration
        code"
      
      * tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm:
        KVM: s390: add proper locking for CMMA migration bitmap
      6e20630e
    • Linus Torvalds's avatar
      Merge tag 'for-4.15-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux · 525273fb
      Linus Torvalds authored
      Pull btrfs fix from David Sterba:
       "It's been reported recently that readdir can list stale entries under
        some conditions. Fix it."
      
      * tag 'for-4.15-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux:
        Btrfs: fix stale entries in readdir
      525273fb