- 24 Feb, 2020 40 commits
-
-
David S. Miller authored
Leon Romanovsky says: ==================== Clean driver, module and FW versions Change log: v1: * Split all FW cleanups patches to separate patches * Fixed commit message * Deleted odd DRV_RELDATE * Added everyone from MAINTAINERS file v0: https://lore.kernel.org/netdev/20200220145855.255704-1-leon@kernel.org This is first patchset to netdev (already sent RDMA [1] and arch/um [2]) in attempt to unify the version management for in-tree kernel code. The patches follow already accepted ethtool change [3] to set as a default linux kernel version. It allows us to remove driver version and present to the users unified picture of driver version, which is similar to default MODULE_VERSION(). As part of this series, I deleted various creative attempts to mark absence of FW. There is no need to set "N/A" in ethtool ->fw_version field and it is enough to do not set it. 1. The code is compile tested and passes 0-day kbuild. 2. The proposed changes are based on commit: 2bb07f4e ("tc-testing: updated tdc tests for basic filter") 3. WIP branch is [4]. [1] https://lore.kernel.org/linux-rdma/20200220071239.231800-1-leon@kernel.org/ [2] http://lists.infradead.org/pipermail/linux-um/2020-February/002913.html [3] https://lore.kernel.org/linux-rdma/20200127072028.19123-1-leon@kernel.org/ [4] https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git/log/?h=ethtool ==================== Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Leon Romanovsky authored
Use linux kernel version for ethtool and module versions. Signed-off-by:
Leon Romanovsky <leonro@mellanox.com> Acked-by:
Chris Snook <chris.snook@gmail.com> Signed-off-by:
-
Leon Romanovsky authored
Drop constant driver version in favour of global linux kernel. Signed-off-by:
-
Leon Romanovsky authored
There is no need to keep module and driver versions in in-tree kernel code. Signed-off-by:
-
Leon Romanovsky authored
There is no need to set "N/A" if FW is not available. Signed-off-by:
-
Leon Romanovsky authored
Delete module version in favor of global and unique linux kernel. Signed-off-by:
-
Leon Romanovsky authored
Convert AMD drivers to respect universal linux kernel version. Signed-off-by:
-
Leon Romanovsky authored
Upstream drivers are managed inside global repository and released all together, this ensure that driver version is the same as linux kernel, so update amazon drivers to properly reflect it. Signed-off-by:
-
Leon Romanovsky authored
Convert to use default version provided by ethtool. Signed-off-by:
-
Leon Romanovsky authored
The acenic driver assigns FW version in driver version field, as part of cleanup driver version, set FW version properly. Signed-off-by:
-
Leon Romanovsky authored
There is no need in custom driver version for in-tree code. Signed-off-by:
Maxime Ripard <mripard@kernel.org> Signed-off-by:
-
Leon Romanovsky authored
Use standard variant of the driver version. Signed-off-by:
-
Leon Romanovsky authored
There is no need in driver version for in-tree kernel code. Signed-off-by:
-
Leon Romanovsky authored
If FW version is not available, it is enough to leave that field as empty, there is no need to write N/A. Signed-off-by:
-
Leon Romanovsky authored
If FW version is not available, it is enough to leave that field as empty, there is no need to write N/A. The driver version is replaced in favor of generally available in-tree variant. Signed-off-by:
-
Leon Romanovsky authored
Delete useless driver version in favor of default ones. Signed-off-by:
-
Leon Romanovsky authored
There is no need to mislead users by providing different versions for driver, ethtool and modules. Delete driver assignments and let use the default one. Signed-off-by:
-
Leon Romanovsky authored
Delete constant driver and module versions in favor of standard global version which is unique to whole kernel. Signed-off-by:
-
Leon Romanovsky authored
The in-kernel code has already unique version, which is based on Linus's tag, update the bond driver to be consistent with that version. Signed-off-by:
-
Colin Ian King authored
The pointer 'client' is being initialized with a value that is never read, it is being updated later on. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by:Colin Ian King <colin.king@canonical.com> Signed-off-by:
-
Colin Ian King authored
There is a spelling mistake in a literal string. Fix it. Signed-off-by:
Jiri Pirko <jiri@mellanox.com> Signed-off-by:
-
David Ahern authored
generic_xdp_tx and xdp_do_generic_redirect are only used by builtin code, so remove the EXPORT_SYMBOL_GPL for them. Signed-off-by:
David Ahern <dsahern@gmail.com> Signed-off-by:
-
Li RongQing authored
After commit 2690048c ("net: igmp: Allow user-space configuration of igmp unsolicited report interval"), they are not used now Signed-off-by:
Li RongQing <lirongqing@baidu.com> Signed-off-by:
-
Roman Mashak authored
Signed-off-by:
Roman Mashak <mrv@mojatatu.com> Signed-off-by:
-
Heiner Kallweit authored
Only call rtl8169_xmit_frags() if the skb is actually fragmented. This avoid a small overhead for non-fragmented skb's, and it allows to simplify rtl8169_xmit_frags() a little. Signed-off-by:
Heiner Kallweit <hkallweit1@gmail.com> Signed-off-by:
-
Colin Ian King authored
The non-zero check on rc is redundant as a previous non-zero check on rc will always return and the second check is never reached, hence it is redundant and can be removed. Also remove a blank line. Addresses-Coverity: ("Logically dead code") Signed-off-by: -
David Ahern authored
The BUG_ON for NULL tfile is now redundant due to a recently added null check after the rcu_dereference. Remove the BUG_ON. Cc: Jason Wang <jasowang@redhat.com> Signed-off-by:
-
David S. Miller authored
Jiri Pirko says: ==================== mlxsw: Cosmetic fixes This is a set of mainly action/trap related cosmetic fixes. No functional changes. ==================== Signed-off-by: -
Ido Schimmel authored
Since commit f3a52c61 ("mlxsw: pci: Utilize MRSR register to perform FW reset") the driver no longer issues a reset via the PCI BAR, so the offset of the reset bit is unused. Remove it. Signed-off-by:
Ido Schimmel <idosch@mellanox.com> Acked-by:
-
Jiri Pirko authored
During packet receive, only the first matching RX listener in rx_listener_list is going to get the packet. So there is no meaning in registering two equal listeners with different privs. Remove priv from equality comparison and disable possibility of doing it. Signed-off-by:
-
Jiri Pirko authored
There are couple of places where block pointer as a function argument can be const. So make those const. Signed-off-by:
-
Jiri Pirko authored
The global arrays are treated as const, they should be const, so make them const. Signed-off-by:
-
Jiri Pirko authored
No need to initialize to false, so remove it. Signed-off-by:
-
Jiri Pirko authored
No need for these two flags to be bool. Covert them to bits of u8. Signed-off-by:
-
Jiri Pirko authored
The dummy name for union is no longer needed, remove it. Signed-off-by:
-
Jiri Pirko authored
Commit 0791051c ("mlxsw: core: Create a generic function to register / unregister traps") moved this field to struct mlxsw_listener, but forgot to remove it from struct mlxsw_rx_listener. Remove the unused field. Signed-off-by:
-
Jiri Pirko authored
No need to initialize a single policer multiple times for each group. So move the initialization to be done from mlxsw_sp_trap_init(), making the function much simpler. Also, rename it so it is with sync with spectrum.c policers initialization. Signed-off-by:
-
Jiri Pirko authored
The Trap / Discard Action action got renamed in PRM, so rename it in the code as well. Signed-off-by:
-
Jiri Pirko authored
No need to have forward declarations for mlxsw_sp_rx_drop_listener() and mlxsw_sp_rx_exception_listener(). Just move them up and avoid it. Signed-off-by:
-
Jiri Pirko authored
When calling mlxsw_sp_rx_listener(), use err variable instead of directly checking func return value. Signed-off-by:
-
