- 27 Jan, 2023 37 commits
-
-
Martin Kaiser authored
usb_ops_linux.h has a number of defines that strip the regs parameter from function that should be used as urb callbacks. Remove the defines for functions that don't exist in the r8188eu driver. Signed-off-by:
Martin Kaiser <martin@kaiser.cx> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150 Link: https://lore.kernel.org/r/20230124210108.62170-3-martin@kaiser.cxSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Martin Kaiser authored
Remove the regs parameter from usb_read_port_complete, it is not used. Without the regs parameter, there's no need for the define that makes usb_read_port_complete usable as urb callback function. Signed-off-by:
-
Philipp Hortmann authored
txbytesmulticast, txbytesbroadcast and signal_quality are initialized and increased or set but never read. Remove dead code. Signed-off-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/c469f82619625fecbed95532967cc7ec2b12e5f9.1674675808.git.philipp.g.hortmann@gmail.comSigned-off-by:
-
Philipp Hortmann authored
txbeaconerr, txmanageokint and txcmdpktokint are initialized and increased but never read. Remove dead code. Signed-off-by:
-
Philipp Hortmann authored
txviokint, txvookint and txbeaconokint are initialized and increased but never read. Remove dead code. Signed-off-by:
-
Philipp Hortmann authored
txoverflow, txbeokint and txbkokint are initialized and increased but never read. Remove dead code. Signed-off-by:
-
Philipp Hortmann authored
rxint, ints and shints are initialized and increased but never read. Remove dead code. Signed-off-by:
-
Philipp Hortmann authored
num_process_phyinfo, received_bwtype and rxoverflow are initialized and increased but never read. Remove dead code. As a result prxsc is unused which in result makes rxsc_sgien_exflg unused. Remove prxsc and rxsc_sgien_exflg as well. Reported-by:
kernel test robot <lkp@intel.com> Signed-off-by:
-
Philipp Hortmann authored
numqry_phystatus, numqry_phystatusCCK and numqry_phystatusHT are initialized and increased but never read. Remove dead code. Signed-off-by:
-
Philipp Hortmann authored
numpacket_toself, numpacket_matchbssid and received_preamble_GI are initialized and increased but never read. Remove dead code. As a result the local variable preamble_guardinterval is unused. Remove it also. Reported-by:
-
Philipp Hortmann authored
rxcrcerrmin, rxcrcerrmax and rxcrcerrmid are initialized and increased but never read. Remove dead code. Signed-off-by:
-
Philipp Hortmann authored
rxdatacrcerr and rxmgmtcrcerr are initialized and increased but never read. Remove dead code. Signed-off-by:
-
Philipp Hortmann authored
rxrdu and rxok are initialized and increased but never read. Remove dead code. Signed-off-by:
-
Stefan Wahren authored
During sending the base address of the slots to the VideoCore firmware via mailbox property, issues could happened on the ARM and on the VideoCore side. So better separate the error handling in order to provide more details. This should help to narrow down the possible cause. Signed-off-by:
Stefan Wahren <stefan.wahren@i2se.com> Reviewed-by:
Umang Jain <umang.jain@ideasonboard.com> Link: https://lore.kernel.org/r/20230123191629.21019-1-stefan.wahren@i2se.comSigned-off-by:
-
Martin Kaiser authored
rtw_free_hwxmits is called only by _rtw_free_xmit_priv. We can merge the two functions and make the code a bit shorter. Signed-off-by:
-
Martin Kaiser authored
apsd_setting in struct tx_servq is not used, it can be removed. Signed-off-by:
-
Martin Kaiser authored
struct agg_pkt_info is not used in the r8188eu driver. Remove it. Signed-off-by:
-
Martin Kaiser authored
The rtw_xmitframe_enqueue function is only one line. We can remove it and call rtw_xmit_classifier directly. Signed-off-by:
-
Martin Kaiser authored
In function rtw_xmitframe_enqueue, we can simply relay the error code from rtw_xmit_classifier. Signed-off-by:
-
Martin Kaiser authored
struct hw_xmit's sta_list points to one of vo, vi, be or bk_pending in struct xmit_priv. All of these are defined as struct __queue, which is a list plus a spinlock. For these components, the spinlock is unused, we need only the list. This patch converts sta_list and vo, vi, be and bk_pending to struct list_head. Signed-off-by:
-
Martin Kaiser authored
dequeue_one_xmitframe is a small function that is called only from rtw_dequeue_xframe. Merge the two functions. Signed-off-by:
-
Martin Kaiser authored
The r8188eu driver defines a struct __queue that contains a list_head and a spinlock. struct tx_servq describes a station for which we have pending tx packets. This struct contains a __queue for the pending packets (a __queue of struct xmit_frame entries). In this particular case, the queue's spinlock is not used, we need only the list_head. rtw_dequeue_xframe uses a local variable for such an xmit_frame queue. This patch replaces this variable with a list_head. Signed-off-by:
-
Martin Kaiser authored
Simplify the dequeue_one_xmitframe function without changing its behaviour. Drop the temporary variable xmitframe_plist. Signed-off-by:
-
Martin Kaiser authored
rtw_dequeue_xframe calls dequeue_one_xmitframe and passes a struct tx_servq. The only use for this parameter is to decrement its qcnt if an xmit_frame could be extracted. It makes more sense to remove the struct tx_servq parameter from dequeue_one_xmitframe and decrement qcnt in the calling function when dequeue_one_xmitframe returns success, i.e. when an xmit_frame was extracted. Signed-off-by:
-
Martin Kaiser authored
Both callers of rtw_chk_hi_queue_cmd do not check the return value. Convert rtw_chk_hi_queue_cmd to a void function. Signed-off-by:
-
Martin Kaiser authored
The rtl8188eu_xmitframe_complete function takes two parameters: adapter and xmit_priv. xmit_priv is part of struct adapter, this parameter can be removed. Signed-off-by:
-
Martin Kaiser authored
Revert the if condition and exit immediately if the list of xmitframes is empty. Hopefully, this makes the code a little bit simpler. Signed-off-by:
-
Martin Kaiser authored
Use list_empty to check for an empty list instead of coding the check manually. Signed-off-by:
-
Martin Kaiser authored
There's no point in moving xmitframe_plist to the next list element. xmitframe_plist is not used any more after this assignment. Signed-off-by:
-
Martin Kaiser authored
The pxmitpriv parameter in function dequeue_one_xmitframe is not needed. It can be removed. Signed-off-by:
-
Martin Kaiser authored
Remove an obsolete comment in rtw_dequeue_xframe. There is no break statement any more. Signed-off-by:
-
Martin Kaiser authored
Simplify the code to initialise the inx array in function rtw_dequeue_xframe and make the code a tiny bit smaller. Signed-off-by:
-
Martin Kaiser authored
Use list_for_each_entry_safe to iterate over the station entries in function rtw_dequeue_xframe instead of coding the loop manually. We have to use the safe version, the loop body may remove a station from the list over which we iterate. Signed-off-by:
-
Martin Kaiser authored
struct intf_priv is not used in the r8188eu driver. It can be removed. Signed-off-by:
-
Martin Kaiser authored
There are no more users of struct intf_hdl in the r8188eu driver. We can now remove this struct. Signed-off-by:
-
Martin Kaiser authored
The usb_write function takes a struct intf_hdl only to extract the struct adapter from it. We can pass struct adapter directly. Signed-off-by:
-
Martin Kaiser authored
struct xmit_priv contains a pointer to an array of struct hw_xmit entries. xmit_priv's (ill-named) hwxmit_entry component stores the size of this array, i.e. the number of hw_xmit entries that are used. The array size is constant, it's initialised to HWXMIT_ENTRY and never updated. Simplify the code accordingly. Remove hwxmit_entry, do not pass the array size as a function parameter and use HWXMIT_ENTRY in the code that handles the array. Signed-off-by:
-
- 23 Jan, 2023 3 commits
-
-
Umang Jain authored
Drop the include directive. They can break the build, when one only wants to build a subdirectory. Replace with "../" for the includes, in the interface/ files instead. Suggested-by:
-
Umang Jain authored
Drop the include directive. They can break the build, when one only wants to build a subdirectory. Replace with "../" for the includes, in the mmal-vchiq.c instead. Suggested-by:
-
Umang Jain authored
Drop the include directive. They can break the build, when one only wants to build a subdirectory. Replace with "../" for the includes, in the bcm2835-camera files instead. Suggested-by:
Laurent Pinchart <laurent.pinchart@ideasonboard.com> Link: https://lore.kernel.org/r/20230120201104.606876-4-umang.jain@ideasonboard.comSigned-off-by:
-
