1. 21 Mar, 2024 23 commits
    • Ian Rogers's avatar
      perf cpumap: Clean up use of perf_cpu_map__has_any_cpu_or_is_empty · 3e5deb70
      Ian Rogers authored
      Most uses of what was perf_cpu_map__empty but is now
      perf_cpu_map__has_any_cpu_or_is_empty want to do something with the
      CPU map if it contains CPUs. Replace uses of
      perf_cpu_map__has_any_cpu_or_is_empty with other helpers so that CPUs
      within the map can be handled.
      Reviewed-by: default avatarJames Clark <james.clark@arm.com>
      Signed-off-by: default avatarIan Rogers <irogers@google.com>
      Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Alexandre Ghiti <alexghiti@rivosinc.com>
      Cc: Andrew Jones <ajones@ventanamicro.com>
      Cc: André Almeida <andrealmeid@igalia.com>
      Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
      Cc: Atish Patra <atishp@rivosinc.com>
      Cc: Changbin Du <changbin.du@huawei.com>
      Cc: Darren Hart <dvhart@infradead.org>
      Cc: Davidlohr Bueso <dave@stgolabs.net>
      Cc: Huacai Chen <chenhuacai@kernel.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: John Garry <john.g.garry@oracle.com>
      Cc: K Prateek Nayak <kprateek.nayak@amd.com>
      Cc: Kajol Jain <kjain@linux.ibm.com>
      Cc: Kan Liang <kan.liang@linux.intel.com>
      Cc: Leo Yan <leo.yan@linaro.org>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Mike Leach <mike.leach@linaro.org>
      Cc: Nick Desaulniers <ndesaulniers@google.com>
      Cc: Paolo Bonzini <pbonzini@redhat.com>
      Cc: Paran Lee <p4ranlee@gmail.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Ravi Bangoria <ravi.bangoria@amd.com>
      Cc: Sandipan Das <sandipan.das@amd.com>
      Cc: Sean Christopherson <seanjc@google.com>
      Cc: Steinar H. Gunderson <sesse@google.com>
      Cc: Suzuki Poulouse <suzuki.poulose@arm.com>
      Cc: Thomas Gleixner <tglx@linutronix.de>
      Cc: Will Deacon <will@kernel.org>
      Cc: Yang Jihong <yangjihong1@huawei.com>
      Cc: Yang Li <yang.lee@linux.alibaba.com>
      Cc: Yanteng Si <siyanteng@loongson.cn>
      Link: https://lore.kernel.org/r/20240202234057.2085863-6-irogers@google.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      3e5deb70
    • Ian Rogers's avatar
      perf intel-pt/intel-bts: Switch perf_cpu_map__has_any_cpu_or_is_empty use · 291dcd77
      Ian Rogers authored
      Switch perf_cpu_map__has_any_cpu_or_is_empty() to
      perf_cpu_map__is_any_cpu_or_is_empty() as a CPU map may contain CPUs as
      well as the dummy event and perf_cpu_map__is_any_cpu_or_is_empty() is a
      more correct alternative.
      Signed-off-by: default avatarIan Rogers <irogers@google.com>
      Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Alexandre Ghiti <alexghiti@rivosinc.com>
      Cc: Andrew Jones <ajones@ventanamicro.com>
      Cc: André Almeida <andrealmeid@igalia.com>
      Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
      Cc: Atish Patra <atishp@rivosinc.com>
      Cc: Changbin Du <changbin.du@huawei.com>
      Cc: Darren Hart <dvhart@infradead.org>
      Cc: Davidlohr Bueso <dave@stgolabs.net>
      Cc: Huacai Chen <chenhuacai@kernel.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: James Clark <james.clark@arm.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: John Garry <john.g.garry@oracle.com>
      Cc: K Prateek Nayak <kprateek.nayak@amd.com>
      Cc: Kajol Jain <kjain@linux.ibm.com>
      Cc: Kan Liang <kan.liang@linux.intel.com>
      Cc: Leo Yan <leo.yan@linaro.org>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Mike Leach <mike.leach@linaro.org>
      Cc: Nick Desaulniers <ndesaulniers@google.com>
      Cc: Paolo Bonzini <pbonzini@redhat.com>
      Cc: Paran Lee <p4ranlee@gmail.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Ravi Bangoria <ravi.bangoria@amd.com>
      Cc: Sandipan Das <sandipan.das@amd.com>
      Cc: Sean Christopherson <seanjc@google.com>
      Cc: Steinar H. Gunderson <sesse@google.com>
      Cc: Suzuki Poulouse <suzuki.poulose@arm.com>
      Cc: Thomas Gleixner <tglx@linutronix.de>
      Cc: Will Deacon <will@kernel.org>
      Cc: Yang Jihong <yangjihong1@huawei.com>
      Cc: Yang Li <yang.lee@linux.alibaba.com>
      Cc: Yanteng Si <siyanteng@loongson.cn>
      Link: https://lore.kernel.org/r/20240202234057.2085863-5-irogers@google.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      291dcd77
    • Ian Rogers's avatar
      perf arm-spe/cs-etm: Directly iterate CPU maps · e28ee123
      Ian Rogers authored
      Rather than iterate all CPUs and see if they are in CPU maps, directly
      iterate the CPU map. Similarly make use of the intersect function
      taking care for when "any" CPU is specified. Switch
      perf_cpu_map__has_any_cpu_or_is_empty() to more appropriate
      alternatives.
      Reviewed-by: default avatarJames Clark <james.clark@arm.com>
      Signed-off-by: default avatarIan Rogers <irogers@google.com>
      Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Alexandre Ghiti <alexghiti@rivosinc.com>
      Cc: Andrew Jones <ajones@ventanamicro.com>
      Cc: André Almeida <andrealmeid@igalia.com>
      Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
      Cc: Atish Patra <atishp@rivosinc.com>
      Cc: Changbin Du <changbin.du@huawei.com>
      Cc: Darren Hart <dvhart@infradead.org>
      Cc: Davidlohr Bueso <dave@stgolabs.net>
      Cc: Huacai Chen <chenhuacai@kernel.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: John Garry <john.g.garry@oracle.com>
      Cc: K Prateek Nayak <kprateek.nayak@amd.com>
      Cc: Kajol Jain <kjain@linux.ibm.com>
      Cc: Kan Liang <kan.liang@linux.intel.com>
      Cc: Leo Yan <leo.yan@linaro.org>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Mike Leach <mike.leach@linaro.org>
      Cc: Nick Desaulniers <ndesaulniers@google.com>
      Cc: Paolo Bonzini <pbonzini@redhat.com>
      Cc: Paran Lee <p4ranlee@gmail.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Ravi Bangoria <ravi.bangoria@amd.com>
      Cc: Sandipan Das <sandipan.das@amd.com>
      Cc: Sean Christopherson <seanjc@google.com>
      Cc: Steinar H. Gunderson <sesse@google.com>
      Cc: Suzuki Poulouse <suzuki.poulose@arm.com>
      Cc: Thomas Gleixner <tglx@linutronix.de>
      Cc: Will Deacon <will@kernel.org>
      Cc: Yang Jihong <yangjihong1@huawei.com>
      Cc: Yang Li <yang.lee@linux.alibaba.com>
      Cc: Yanteng Si <siyanteng@loongson.cn>
      Link: https://lore.kernel.org/r/20240202234057.2085863-4-irogers@google.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      e28ee123
    • Ian Rogers's avatar
      libperf cpumap: Ensure empty cpumap is NULL from alloc · dcd45b37
      Ian Rogers authored
      Potential corner cases could cause a cpumap to be allocated with size
      0, but an empty cpumap should be represented as NULL. Add a path in
      perf_cpu_map__alloc() to ensure this.
      Suggested-by: default avatarJames Clark <james.clark@arm.com>
      Signed-off-by: default avatarIan Rogers <irogers@google.com>
      Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Alexandre Ghiti <alexghiti@rivosinc.com>
      Cc: Andrew Jones <ajones@ventanamicro.com>
      Cc: André Almeida <andrealmeid@igalia.com>
      Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
      Cc: Atish Patra <atishp@rivosinc.com>
      Cc: Changbin Du <changbin.du@huawei.com>
      Cc: Darren Hart <dvhart@infradead.org>
      Cc: Davidlohr Bueso <dave@stgolabs.net>
      Cc: Huacai Chen <chenhuacai@kernel.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: John Garry <john.g.garry@oracle.com>
      Cc: K Prateek Nayak <kprateek.nayak@amd.com>
      Cc: Kajol Jain <kjain@linux.ibm.com>
      Cc: Kan Liang <kan.liang@linux.intel.com>
      Cc: Leo Yan <leo.yan@linaro.org>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Mike Leach <mike.leach@linaro.org>
      Cc: Nick Desaulniers <ndesaulniers@google.com>
      Cc: Paolo Bonzini <pbonzini@redhat.com>
      Cc: Paran Lee <p4ranlee@gmail.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Ravi Bangoria <ravi.bangoria@amd.com>
      Cc: Sandipan Das <sandipan.das@amd.com>
      Cc: Sean Christopherson <seanjc@google.com>
      Cc: Steinar H. Gunderson <sesse@google.com>
      Cc: Suzuki Poulouse <suzuki.poulose@arm.com>
      Cc: Thomas Gleixner <tglx@linutronix.de>
      Cc: Will Deacon <will@kernel.org>
      Cc: Yang Jihong <yangjihong1@huawei.com>
      Cc: Yang Li <yang.lee@linux.alibaba.com>
      Cc: Yanteng Si <siyanteng@loongson.cn>
      Closes: https://lore.kernel.org/lkml/2cd09e7c-eb88-6726-6169-647dcd0a8101@arm.com/
      Link: https://lore.kernel.org/r/20240202234057.2085863-3-irogers@google.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      dcd45b37
    • Ian Rogers's avatar
      libperf cpumap: Add any, empty and min helpers · b6b4a62d
      Ian Rogers authored
      Additional helpers to better replace perf_cpu_map__has_any_cpu_or_is_empty().
      Signed-off-by: default avatarIan Rogers <irogers@google.com>
      Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Alexandre Ghiti <alexghiti@rivosinc.com>
      Cc: Andrew Jones <ajones@ventanamicro.com>
      Cc: André Almeida <andrealmeid@igalia.com>
      Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
      Cc: Atish Patra <atishp@rivosinc.com>
      Cc: Changbin Du <changbin.du@huawei.com>
      Cc: Darren Hart <dvhart@infradead.org>
      Cc: Davidlohr Bueso <dave@stgolabs.net>
      Cc: Huacai Chen <chenhuacai@kernel.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: James Clark <james.clark@arm.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: John Garry <john.g.garry@oracle.com>
      Cc: K Prateek Nayak <kprateek.nayak@amd.com>
      Cc: Kajol Jain <kjain@linux.ibm.com>
      Cc: Kan Liang <kan.liang@linux.intel.com>
      Cc: Leo Yan <leo.yan@linaro.org>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Mike Leach <mike.leach@linaro.org>
      Cc: Nick Desaulniers <ndesaulniers@google.com>
      Cc: Paolo Bonzini <pbonzini@redhat.com>
      Cc: Paran Lee <p4ranlee@gmail.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Ravi Bangoria <ravi.bangoria@amd.com>
      Cc: Sandipan Das <sandipan.das@amd.com>
      Cc: Sean Christopherson <seanjc@google.com>
      Cc: Steinar H. Gunderson <sesse@google.com>
      Cc: Suzuki Poulouse <suzuki.poulose@arm.com>
      Cc: Thomas Gleixner <tglx@linutronix.de>
      Cc: Will Deacon <will@kernel.org>
      Cc: Yang Jihong <yangjihong1@huawei.com>
      Cc: Yang Li <yang.lee@linux.alibaba.com>
      Cc: Yanteng Si <siyanteng@loongson.cn>
      Link: https://lore.kernel.org/r/20240202234057.2085863-2-irogers@google.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      b6b4a62d
    • Ethan Adams's avatar
      perf build: Fix out of tree build related to installation of sysreg-defs · efae55bb
      Ethan Adams authored
      It seems that a previous modification to sysreg-defs, which corrected
      emitting the header to the specified output directory, exposed missing
      subdir, prefix variables.
      
      This breaks out of tree builds of perf as the file is now built into the
      output directory, but still tries to descend into output directory as a
      subdir.
      
      Fixes: a29ee6ae ("perf build: Ensure sysreg-defs Makefile respects output dir")
      Reviewed-by: default avatarOliver Upton <oliver.upton@linux.dev>
      Reviewed-by: default avatarTycho Andersen <tycho@tycho.pizza>
      Signed-off-by: default avatarEthan Adams <j.ethan.adams@gmail.com>
      Tested-by: default avatarTycho Andersen <tycho@tycho.pizza>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Link: https://lore.kernel.org/r/20240314222012.47193-1-j.ethan.adams@gmail.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      efae55bb
    • Adrian Hunter's avatar
      perf auxtrace: Fix multiple use of --itrace option · bb69c912
      Adrian Hunter authored
      If the --itrace option is used more than once, the options are
      combined, but "i" and "y" (sub-)options can be corrupted because
      itrace_do_parse_synth_opts() incorrectly overwrites the period type and
      period with default values.
      
      For example, with:
      
      	--itrace=i0ns --itrace=e
      
      The processing of "--itrace=e", resets the "i" period from 0 nanoseconds
      to the default 100 microseconds.
      
      Fix by performing the default setting of period type and period only if
      "i" or "y" are present in the currently processed --itrace value.
      
      Fixes: f6986c95 ("perf session: Add instruction tracing options")
      Signed-off-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Andi Kleen <ak@linux.intel.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: stable@vger.kernel.org
      Link: https://lore.kernel.org/r/20240315071334.3478-2-adrian.hunter@intel.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      bb69c912
    • Adrian Hunter's avatar
      perf script: Show also errors for --insn-trace option · d4a98b45
      Adrian Hunter authored
      The trace could be misleading if trace errors are not taken into
      account, so display them also by adding the itrace "e" option.
      
      Note --call-trace and --call-ret-trace already add the itrace "e"
      option.
      
      Fixes: b585ebdb ("perf script: Add --insn-trace for instruction decoding")
      Reviewed-by: default avatarAndi Kleen <ak@linux.intel.com>
      Signed-off-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
      Cc: Andi Kleen <ak@linux.intel.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: stable@vger.kernel.org
      Link: https://lore.kernel.org/r/20240315071334.3478-1-adrian.hunter@intel.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      d4a98b45
    • James Clark's avatar
      perf docs arm_spe: Clarify more SPE requirements related to KPTI · 36f65f9b
      James Clark authored
      The question of exactly when KPTI needs to be disabled comes up a lot
      because it doesn't always need to be done. Add the relevant kernel
      function and some examples that describe the behavior.
      
      Also describe the interrupt requirement and that no error message will
      be printed if this isn't met.
      Reviewed-by: default avatarIan Rogers <irogers@google.com>
      Signed-off-by: default avatarJames Clark <james.clark@arm.com>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Link: https://lore.kernel.org/r/20240312132508.423320-1-james.clark@arm.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      36f65f9b
    • Arnaldo Carvalho de Melo's avatar
      tools headers: Remove almost unused copy of uapi/stat.h, add few conditional defines · a672af91
      Arnaldo Carvalho de Melo authored
      These were used to build perf to provide defines not available in older
      distros, but this was back in 2017, nowadays most the distros that are
      supported and I have build containers for work using just the system
      headers, so ditch them.
      
      For the few that don't have STATX_MNT_ID{_UNIQUE}, or STATX_MNT_DIOALIGN
      add them conditionally.
      
      Some of these older distros may not have things that are used in 'perf
      trace', but then they also don't have libtraceevent packages, so don't
      build 'perf trace'.
      
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Link: https://lore.kernel.org/lkml/20240315204835.748716-6-acme@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      a672af91
    • Arnaldo Carvalho de Melo's avatar
      tools headers: Remove now unused copies of uapi/{fcntl,openat2}.h and asm/fcntl.h · 8a1ad441
      Arnaldo Carvalho de Melo authored
      These were used to build perf to provide defines not available in older
      distros, but this was back in 2017, nowadays all the distros that are
      supported and I have build containers for work using just the system
      headers, so ditch them.
      
      Some of these older distros may not have things that are used in 'perf
      trace', but then they also don't have libtraceevent packages, so don't
      build 'perf trace'.
      
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Link: https://lore.kernel.org/lkml/20240315204835.748716-5-acme@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      8a1ad441
    • Arnaldo Carvalho de Melo's avatar
      perf beauty: Use the system linux/fcntl.h instead of a copy from the kernel · 6652830c
      Arnaldo Carvalho de Melo authored
      Builds ok all the way back to these older distros:
      
         1  almalinux:8    : Ok  gcc (GCC) 8.5.0 20210514 (Red Hat 8.5.0-20) , clang version 16.0.6 (Red Hat 16.0.6-2.module_el8.9.0+3621+df7f7146) flex 2.6.1
         3  alpine:3.15    : Ok  gcc (Alpine 10.3.1_git20211027) 10.3.1 20211027 , Alpine clang version 12.0.1 flex 2.6.4
        15  debian:10      : Ok  gcc (Debian 8.3.0-6) 8.3.0 , Debian clang version 11.0.1-2~deb10u1 flex 2.6.4
        32  opensuse:15.4  : Ok  gcc (SUSE Linux) 7.5.0 , clang version 15.0.7 flex 2.6.4
        23  fedora:35      : Ok  gcc (GCC) 11.3.1 20220421 (Red Hat 11.3.1-3) , clang version 13.0.1 (Fedora 13.0.1-1.fc35) flex 2.6.4
        38  ubuntu:18.04   : Ok  gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0  flex 2.6.4
      
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Link: https://lore.kernel.org/lkml/20240315204835.748716-4-acme@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      6652830c
    • Arnaldo Carvalho de Melo's avatar
      perf beauty: Move prctl.h files (uapi/linux and x86's) copy out of the directory used to build perf · eb01fe7a
      Arnaldo Carvalho de Melo authored
      It is used only to generate string tables, not to build perf, so move it
      to the tools/perf/trace/beauty/{include,arch}/ hierarchies, that is used
      just for scraping.
      
      This is a something that should've have happened, as happened with the
      linux/socket.h scrapper, do it now as Ian suggested while doing an
      audit/refactor session in the headers used by perf.
      
      No other tools/ living code uses it, just <linux/usbdevice_fs.h> coming
      from either 'make install_headers' or from the system /usr/include/
      directory.
      Suggested-by: default avatarIan Rogers <irogers@google.com>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Link: https://lore.kernel.org/lkml/20240315204835.748716-3-acme@kernel.org
      Link: https://lore.kernel.org/lkml/CAP-5=fWZVrpRufO4w-S4EcSi9STXcTAN2ERLwTSN7yrSSA-otQ@mail.gmail.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      eb01fe7a
    • Arnaldo Carvalho de Melo's avatar
      perf beauty: Stop using the copy of uapi/linux/prctl.h · f324b73c
      Arnaldo Carvalho de Melo authored
      Use the system one, nothing used in that file isn't available in the
      supported, active distros.
      
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Namhyung Kim <namhyung@kernel.org>
      To: Ian Rogers <irogers@google.com>
      Link: https://lore.kernel.org/lkml/20240315204835.748716-3-acme@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      f324b73c
    • Arnaldo Carvalho de Melo's avatar
      perf beauty: Move arch/x86/include/asm/irq_vectors.h copy out of the directory used to build perf · c8bfe3fa
      Arnaldo Carvalho de Melo authored
      It is used only to generate string tables, not to build perf, so move it
      to the tools/perf/trace/beauty/include/ hierarchy, that is used just for
      scraping.
      
      This is a something that should've have happened, as happened with the
      linux/socket.h scrapper, do it now as Ian suggested while doing an
      audit/refactor session in the headers used by perf.
      
      No other tools/ living code uses it.
      Suggested-by: default avatarIan Rogers <irogers@google.com>
      Reviewed-by: default avatarIan Rogers <irogers@google.com>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Link: https://lore.kernel.org/lkml/CAP-5=fWZVrpRufO4w-S4EcSi9STXcTAN2ERLwTSN7yrSSA-otQ@mail.gmail.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      c8bfe3fa
    • Arnaldo Carvalho de Melo's avatar
      perf beauty: Move uapi/sound/asound.h copy out of the directory used to build perf · 7050e33e
      Arnaldo Carvalho de Melo authored
      It is used only to generate string tables, not to build perf, so move it
      to the tools/perf/trace/beauty/include/ hierarchy, that is used just for
      scraping.
      
      This is a something that should've have happened, as happened with the
      linux/socket.h scrapper, do it now as Ian suggested while doing an
      audit/refactor session in the headers used by perf.
      Suggested-by: default avatarIan Rogers <irogers@google.com>
      Reviewed-by: default avatarIan Rogers <irogers@google.com>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Link: https://lore.kernel.org/lkml/CAP-5=fWZVrpRufO4w-S4EcSi9STXcTAN2ERLwTSN7yrSSA-otQ@mail.gmail.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      7050e33e
    • Arnaldo Carvalho de Melo's avatar
      perf beauty: Move uapi/linux/usbdevice_fs.h copy out of the directory used to build perf · 44512bd6
      Arnaldo Carvalho de Melo authored
      It is mostly used only to generate string tables, not to build perf, so
      move it to the tools/perf/trace/beauty/include/ hierarchy, that is used
      just for scraping.
      
      This is a something that should've have happened, as happened with the
      linux/socket.h scrapper, do it now as Ian suggested while doing an
      audit/refactor session in the headers used by perf.
      
      No other tools/ living code uses it, just <linux/usbdevice_fs.h> coming
      from either 'make install_headers' or from the system /usr/include/
      directory.
      Suggested-by: default avatarIan Rogers <irogers@google.com>
      Reviewed-by: default avatarIan Rogers <irogers@google.com>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Link: https://lore.kernel.org/lkml/CAP-5=fWZVrpRufO4w-S4EcSi9STXcTAN2ERLwTSN7yrSSA-otQ@mail.gmail.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      44512bd6
    • Arnaldo Carvalho de Melo's avatar
      perf beauty: Move uapi/linux/mount.h copy out of the directory used to build perf · ab331611
      Arnaldo Carvalho de Melo authored
      It is mostly used only to generate string tables, not to build perf, so
      move it to the tools/perf/trace/beauty/include/ hierarchy, that is used
      just for scraping.
      
      This is a something that should've have happened, as happened with the
      linux/socket.h scrapper, do it now as Ian suggested while doing an
      audit/refactor session in the headers used by perf.
      
      No other tools/ living code uses it, just <linux/mount.h> coming from
      either 'make install_headers' or from the system /usr/include/
      directory.
      Suggested-by: default avatarIan Rogers <irogers@google.com>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Link: https://lore.kernel.org/lkml/CAP-5=fWZVrpRufO4w-S4EcSi9STXcTAN2ERLwTSN7yrSSA-otQ@mail.gmail.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      ab331611
    • Arnaldo Carvalho de Melo's avatar
      perf beauty: Don't include uapi/linux/mount.h, use sys/mount.h instead · 22916d2c
      Arnaldo Carvalho de Melo authored
      The tools/include/uapi/linux/mount.h file is mostly used for scrapping
      defines into id->string tables, this is the only place were it is being
      directly used, stop doing so.
      
      Define MOUNT_ATTR_RELATIME and MOUNT_ATTR__ATIME if not available in the
      system's headers.
      
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      22916d2c
    • Arnaldo Carvalho de Melo's avatar
      perf beauty: Move uapi/linux/fs.h copy out of the directory used to build perf · faf7217a
      Arnaldo Carvalho de Melo authored
      It is mostly used only to generate string tables, not to build perf, so
      move it to the tools/perf/trace/beauty/include/ hierarchy, that is used
      just for scraping.
      
      The only case where it was being used to build was in
      tools/perf/trace/beauty/sync_file_range.c, because some older systems
      doesn't have the SYNC_FILE_RANGE_WRITE_AND_WAIT define, just use the
      system's linux/fs.h header instead, defining it if not available.
      
      This is a something that should've have happened, as happened with the
      linux/socket.h scrapper, do it now as Ian suggested while doing an
      audit/refactor session in the headers used by perf.
      
      No other tools/ living code uses it, just <linux/fs.h> coming from
      either 'make install_headers' or from the system /usr/include/
      directory.
      Suggested-by: default avatarIan Rogers <irogers@google.com>
      Reviewed-by: default avatarIan Rogers <irogers@google.com>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Link: https://lore.kernel.org/lkml/CAP-5=fWZVrpRufO4w-S4EcSi9STXcTAN2ERLwTSN7yrSSA-otQ@mail.gmail.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      faf7217a
    • Arnaldo Carvalho de Melo's avatar
      perf beauty: Fix dependency of tables using uapi/linux/mount.h · 5d8c6460
      Arnaldo Carvalho de Melo authored
      Several such tables were depending on uapi/linux/fs.h, cut and paste
      error when they were introduced, fix it.
      
      Cc: Ian Rogers <irogers@google.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Link: https://lore.kernel.org/lkml/Ze9vjxv42PN_QGZv@x1Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      5d8c6460
    • Bhaskar Chowdhury's avatar
      perf c2c: Fix a punctuation · 4b3761ee
      Bhaskar Chowdhury authored
      s/dont/don\'t/
      Signed-off-by: default avatarBhaskar Chowdhury <unixbhaskar@gmail.com>
      Acked-by: default avatarRandy Dunlap <rdunlap@infradead.org>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Link: https://lore.kernel.org/r/20210319232824.742-1-unixbhaskar@gmail.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      4b3761ee
    • Arnaldo Carvalho de Melo's avatar
      perf trace: Collect sys_nanosleep first argument · a9f4c6c9
      Arnaldo Carvalho de Melo authored
      That is a 'struct timespec' passed from userspace to the kernel as we
      can see with a system wide syscall tracing:
      
        root@number:~# perf trace -e nanosleep
             0.000 (10.102 ms): podman/9150 nanosleep(rqtp: { .tv_sec: 0, .tv_nsec: 10000000 })                   = 0
            38.924 (10.077 ms): podman/2195174 nanosleep(rqtp: { .tv_sec: 0, .tv_nsec: 10000000 })                   = 0
           100.177 (10.107 ms): podman/9150 nanosleep(rqtp: { .tv_sec: 0, .tv_nsec: 10000000 })                   = 0
           139.171 (10.063 ms): podman/2195174 nanosleep(rqtp: { .tv_sec: 0, .tv_nsec: 10000000 })                   = 0
           200.603 (10.105 ms): podman/9150 nanosleep(rqtp: { .tv_sec: 0, .tv_nsec: 10000000 })                   = 0
           239.399 (10.064 ms): podman/2195174 nanosleep(rqtp: { .tv_sec: 0, .tv_nsec: 10000000 })                   = 0
           300.994 (10.096 ms): podman/9150 nanosleep(rqtp: { .tv_sec: 0, .tv_nsec: 10000000 })                   = 0
           339.584 (10.067 ms): podman/2195174 nanosleep(rqtp: { .tv_sec: 0, .tv_nsec: 10000000 })                   = 0
           401.335 (10.057 ms): podman/9150 nanosleep(rqtp: { .tv_sec: 0, .tv_nsec: 10000000 })                   = 0
           439.758 (10.166 ms): podman/2195174 nanosleep(rqtp: { .tv_sec: 0, .tv_nsec: 10000000 })                   = 0
           501.814 (10.110 ms): podman/9150 nanosleep(rqtp: { .tv_sec: 0, .tv_nsec: 10000000 })                   = 0
           539.983 (10.227 ms): podman/2195174 nanosleep(rqtp: { .tv_sec: 0, .tv_nsec: 10000000 })                   = 0
           602.284 (10.199 ms): podman/9150 nanosleep(rqtp: { .tv_sec: 0, .tv_nsec: 10000000 })                   = 0
           640.208 (10.105 ms): podman/2195174 nanosleep(rqtp: { .tv_sec: 0, .tv_nsec: 10000000 })                   = 0
           702.662 (10.163 ms): podman/9150 nanosleep(rqtp: { .tv_sec: 0, .tv_nsec: 10000000 })                   = 0
           740.440 (10.107 ms): podman/2195174 nanosleep(rqtp: { .tv_sec: 0, .tv_nsec: 10000000 })                   = 0
           802.993 (10.159 ms): podman/9150 nanosleep(rqtp: { .tv_sec: 0, .tv_nsec: 10000000 })                   = 0
        ^Croot@number:~# strace -p 9150 -e nanosleep
      
      If we then use the ptrace method to look at that podman process:
      
        root@number:~# strace -p 9150 -e nanosleep
        strace: Process 9150 attached
        nanosleep({tv_sec=0, tv_nsec=10000000}, NULL) = 0
        nanosleep({tv_sec=0, tv_nsec=10000000}, NULL) = 0
        nanosleep({tv_sec=0, tv_nsec=10000000}, NULL) = 0
        nanosleep({tv_sec=0, tv_nsec=10000000}, NULL) = 0
        nanosleep({tv_sec=0, tv_nsec=10000000}, NULL) = 0
        nanosleep({tv_sec=0, tv_nsec=10000000}, NULL) = 0
        nanosleep({tv_sec=0, tv_nsec=10000000}, NULL) = 0
        ^Cstrace: Process 9150 detached
        root@number:~#
      
      With some changes we can get something closer to the strace output,
      still in system wide mode:
      
        root@number:~# perf config trace.show_arg_names=false
        root@number:~# perf config trace.show_duration=false
        root@number:~# perf config trace.show_timestamp=false
        root@number:~# perf config trace.show_zeros=true
        root@number:~# perf config trace.args_alignment=0
        root@number:~# perf trace -e nanosleep --max-events=10
        podman/2195174 nanosleep({ .tv_sec: 0, .tv_nsec: 10000000 }, NULL) = 0
        podman/9150 nanosleep({ .tv_sec: 0, .tv_nsec: 10000000 }, NULL) = 0
        podman/2195174 nanosleep({ .tv_sec: 0, .tv_nsec: 10000000 }, NULL) = 0
        podman/9150 nanosleep({ .tv_sec: 0, .tv_nsec: 10000000 }, NULL) = 0
        podman/2195174 nanosleep({ .tv_sec: 0, .tv_nsec: 10000000 }, NULL) = 0
        podman/9150 nanosleep({ .tv_sec: 0, .tv_nsec: 10000000 }, NULL) = 0
        podman/2195174 nanosleep({ .tv_sec: 0, .tv_nsec: 10000000 }, NULL) = 0
        podman/9150 nanosleep({ .tv_sec: 0, .tv_nsec: 10000000 }, NULL) = 0
        podman/2195174 nanosleep({ .tv_sec: 0, .tv_nsec: 10000000 }, NULL) = 0
        podman/9150 nanosleep({ .tv_sec: 0, .tv_nsec: 10000000 }, NULL) = 0
        root@number:~#
        root@number:~# perf config
        trace.show_arg_names=false
        trace.show_duration=false
        trace.show_timestamp=false
        trace.show_zeros=true
        trace.args_alignment=0
        root@number:~# cat ~/.perfconfig
        # this file is auto-generated.
        [trace]
        	show_arg_names = false
        	show_duration = false
        	show_timestamp = false
        	show_zeros = true
        	args_alignment = 0
        root@number:~#
      
      This will not get reused by any other syscall as nanosleep is the only
      one to have as its first argument a 'struct timespec" pointer argument
      passed from userspace to the kernel:
      
        root@number:~# grep timespec /sys/kernel/tracing/events/syscalls/sys_enter_*/format | grep offset:16
        /sys/kernel/tracing/events/syscalls/sys_enter_nanosleep/format:	field:struct __kernel_timespec * rqtp;	offset:16;	size:8;	signed:0;
        root@number:~#
      
      BTF based pretty printing will simplify all this, but then lets just get
      the low hanging fruits first.
      Reviewed-by: default avatarIan Rogers <irogers@google.com>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Link: https://lore.kernel.org/lkml/Zbq72dJRpOlfRWnf@kernel.org/Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      a9f4c6c9
  2. 20 Mar, 2024 8 commits
    • Linus Torvalds's avatar
      Merge tag 'v6.9-rc-smb3-server-fixes' of git://git.samba.org/ksmbd · 23956900
      Linus Torvalds authored
      Pull smb server updates from Steve French:
      
       - add support for durable file handles (an important data integrity
         feature)
      
       - fixes for potential out of bounds issues
      
       - fix possible null dereference in close
      
       - getattr fixes
      
       - trivial typo fix and minor cleanup
      
      * tag 'v6.9-rc-smb3-server-fixes' of git://git.samba.org/ksmbd:
        ksmbd: remove module version
        ksmbd: fix potencial out-of-bounds when buffer offset is invalid
        ksmbd: fix slab-out-of-bounds in smb_strndup_from_utf16()
        ksmbd: Fix spelling mistake "connction" -> "connection"
        ksmbd: fix possible null-deref in smb_lazy_parent_lease_break_close
        ksmbd: add support for durable handles v1/v2
        ksmbd: mark SMB2_SESSION_EXPIRED to session when destroying previous session
        ksmbd: retrieve number of blocks using vfs_getattr in set_file_allocation_info
        ksmbd: replace generic_fillattr with vfs_getattr
      23956900
    • Linus Torvalds's avatar
      Merge tag 'trace-tools-v6.9' of git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace · 42c2a756
      Linus Torvalds authored
      Pull trace tool updates from Steven Rostedt:
       "Tracing:
      
         - Update makefiles for latency-collector and RTLA, using tools/build/
           makefiles like perf does, inheriting its benefits. For example,
           having a proper way to handle library dependencies.
      
         - The timerlat tracer has an interface for any tool to use. rtla
           timerlat tool uses this interface dispatching its own threads as
           workload. But, rtla timerlat could also be used for any other
           process. So, add 'rtla timerlat -U' option, allowing the timerlat
           tool to measure the latency of any task using the timerlat tracer
           interface.
      
        Verification:
      
         - Update makefiles for verification/rv, using tools/build/ makefiles
           like perf does, inheriting its benefits. For example, having a
           proper way to handle dependencies"
      
      * tag 'trace-tools-v6.9' of git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace:
        tools/rtla: Add -U/--user-load option to timerlat
        tools/verification: Use tools/build makefiles on rv
        tools/rtla: Use tools/build makefiles to build rtla
        tools/tracing: Use tools/build makefiles on latency-collector
      42c2a756
    • Linus Torvalds's avatar
      Merge tag 'docs-6.9-2' of git://git.lwn.net/linux · dba89d1b
      Linus Torvalds authored
      Pull more documentation updates from Jonathan Corbet:
       "A handful of late-arriving documentation fixes and enhancements"
      
      * tag 'docs-6.9-2' of git://git.lwn.net/linux:
        docs: verify/bisect: remove a level of indenting
        docs: verify/bisect: drop 'v' prefix, EOL aspect, and assorted fixes
        docs: verify/bisect: check taint flag
        docs: verify/bisect: improve install instructions
        docs: handling-regressions.rst: Update regzbot command fixed-by to fix
        docs: *-regressions.rst: Add colon to regzbot commands
        doc: Fix typo in admin-guide/cifs/introduction.rst
        README: Fix spelling
      dba89d1b
    • Daniel Bristot de Oliveira's avatar
      tools/rtla: Add -U/--user-load option to timerlat · a23c05fd
      Daniel Bristot de Oliveira authored
      The timerlat tracer provides an interface for any application to wait
      for the timerlat's periodic wakeup. Currently, rtla timerlat uses it
      to dispatch its user-space workload (-u option).
      
      But as the tracer interface is generic, rtla timerlat can also be used
      to monitor any workload that uses it. For example, a user might
      place their own workload to wait on the tracer interface, and
      monitor the results with rtla timerlat.
      
      Add the -U option to rtla timerlat top and hist. With this option, rtla
      timerlat will not dispatch its workload but only setting up the
      system, waiting for a user to dispatch its workload.
      
      The sample code in this patch is an example of python application
      that loops in the timerlat tracer fd.
      
      To use it, dispatch:
      
       # rtla timerlat -U
      
      In a terminal, then run the python program on another terminal,
      specifying the CPU to run it. For example, setting on CPU 1:
      
       #./timerlat_load.py 1
      
      Then rtla timerlat will start printing the statistics of the
      ./timerlat_load.py app.
      
      An interesting point is that the "Ret user Timer Latency" value
      is the overall response time of the load. The sample load does
      a memory copy to exemplify that.
      
      The stop tracing options on rtla timerlat works in this setup
      as well, including auto analysis.
      
      Link: https://lkml.kernel.org/r/36e6bcf18fe15c7601048fd4c65aeb193c502cc8.1707229706.git.bristot@kernel.org
      
      Cc: Jonathan Corbet <corbet@lwn.net>
      Cc: Masami Hiramatsu <mhiramat@kernel.org>
      Signed-off-by: default avatarDaniel Bristot de Oliveira <bristot@kernel.org>
      a23c05fd
    • Daniel Bristot de Oliveira's avatar
      tools/verification: Use tools/build makefiles on rv · 012e4e77
      Daniel Bristot de Oliveira authored
      Use tools/build/ makefiles to build rv, inheriting the benefits of
      it. For example, having a proper way to handle dependencies.
      
      Link: https://lkml.kernel.org/r/2a38a8f7b8dc65fa790381ec9ab42fb62beb2e25.1710519524.git.bristot@kernel.org
      
      Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
      Cc: Josh Poimboeuf <jpoimboe@kernel.org>
      Cc: John Kacur <jkacur@redhat.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Suggested-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      Signed-off-by: default avatarDaniel Bristot de Oliveira <bristot@kernel.org>
      012e4e77
    • Daniel Bristot de Oliveira's avatar
      tools/rtla: Use tools/build makefiles to build rtla · 01474dc7
      Daniel Bristot de Oliveira authored
      Use tools/build/ makefiles to build rtla, inheriting the benefits of
      it. For example, having a proper way to handle dependencies.
      
      rtla is built using perf infra-structure when building inside the
      kernel tree.
      
      At this point, rtla diverges from perf in two points: Documentation
      and tarball generation/build.
      
      At the documentation level, rtla is one step ahead, placing the
      documentation at Documentation/tools/rtla/, using the same build
      tools as kernel documentation. The idea is to move perf
      documentation to the same scheme and then share the same makefiles.
      
      rtla has a tarball target that the (old) RHEL8 uses. The tarball was
      kept using a simple standalone makefile for compatibility. The
      standalone makefile shares most of the code, e.g., flags, with
      regular buildings.
      
      The tarball method was set as deprecated. If necessary, we can make
      a rtla tarball like perf, which includes the entire tools/build.
      But this would also require changes in the user side (the directory
      structure changes, and probably the deps to build the package).
      
      Inspired on perf and objtool.
      
      Link: https://lkml.kernel.org/r/57563abf2715d22515c0c54a87cff3849eca5d52.1710519524.git.bristot@kernel.org
      
      Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
      Cc: Josh Poimboeuf <jpoimboe@kernel.org>
      Cc: John Kacur <jkacur@redhat.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Suggested-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      Signed-off-by: default avatarDaniel Bristot de Oliveira <bristot@kernel.org>
      01474dc7
    • Daniel Bristot de Oliveira's avatar
      tools/tracing: Use tools/build makefiles on latency-collector · 9d56c88e
      Daniel Bristot de Oliveira authored
      Use tools/build/ makefiles to build latency-collector, inheriting
      the benefits of it. For example: Before this patch, a missing
      tracefs/traceevents headers will result in fail like this:
      
        ~/linux/tools/tracing/latency $ make
        cc -Wall -Wextra -g -O2  -o latency-collector latency-collector.c -lpthread
        latency-collector.c:26:10: fatal error: tracefs.h: No such file or directory
           26 | #include <tracefs.h>
              |          ^~~~~~~~~~~
        compilation terminated.
        make: *** [Makefile:14: latency-collector] Error 1
      
      Which is not that helpful. After this change it reports:
      
        ~/linux/tools/tracing/latency# make
      
        Auto-detecting system features:
        ...                           libtraceevent: [ OFF ]
        ...                              libtracefs: [ OFF ]
      
        libtraceevent is missing. Please install libtraceevent-dev/libtraceevent-devel
        libtracefs is missing. Please install libtracefs-dev/libtracefs-devel
        Makefile.config:29: *** Please, check the errors above..  Stop.
      
      This type of output is common across other tools in tools/ like perf
      and objtool.
      
      Link: https://lkml.kernel.org/r/872420b0880b11304e4ba144a0086c6478c5b469.1710519524.git.bristot@kernel.org
      
      Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
      Cc: Josh Poimboeuf <jpoimboe@kernel.org>
      Cc: John Kacur <jkacur@redhat.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Suggested-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      Signed-off-by: default avatarDaniel Bristot de Oliveira <bristot@kernel.org>
      9d56c88e
    • Linus Torvalds's avatar
      Merge tag 'bcachefs-2024-03-19' of https://evilpiepirate.org/git/bcachefs · a4145ce1
      Linus Torvalds authored
      Pull bcachefs fixes from Kent Overstreet:
       "Assorted bugfixes.
      
        Most are fixes for simple assertion pops; the most significant fix is
        for a deadlock in recovery when we have to rewrite large numbers of
        btree nodes to fix errors. This was incorrectly running out of the
        same workqueue as the core interior btree update path - we now give it
        its own single threaded workqueue.
      
        This was visible to users as "bch2_btree_update_start(): error:
        BCH_ERR_journal_reclaim_would_deadlock" - and then recovery hanging"
      
      * tag 'bcachefs-2024-03-19' of https://evilpiepirate.org/git/bcachefs:
        bcachefs: Fix lost wakeup on journal shutdown
        bcachefs; Fix deadlock in bch2_btree_update_start()
        bcachefs: ratelimit errors from async_btree_node_rewrite
        bcachefs: Run check_topology() first
        bcachefs: Improve bch2_fatal_error()
        bcachefs: Fix lost transaction restart error
        bcachefs: Don't corrupt journal keys gap buffer when dropping alloc info
        bcachefs: fix for building in userspace
        bcachefs: bch2_snapshot_is_ancestor() now safe to call in early recovery
        bcachefs: Fix nested transaction restart handling in bch2_bucket_gens_init()
        bcachefs: Improve sysfs internal/btree_updates
        bcachefs: Split out btree_node_rewrite_worker
        bcachefs: Fix locking in bch2_alloc_write_key()
        bcachefs: Avoid extent entry type assertions in .invalid()
        bcachefs: Fix spurious -BCH_ERR_transaction_restart_nested
        bcachefs: Fix check_key_has_snapshot() call
        bcachefs: Change "accounting overran journal reservation" to a warning
      a4145ce1
  3. 19 Mar, 2024 9 commits
    • Linus Torvalds's avatar
      Merge tag 'soc-late-6.9' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc · 78c3925c
      Linus Torvalds authored
      Pull more ARM SoC updates from Arnd Bergmann:
       "These are changes that for some reason ended up not making it into the
        first four branches but that should still make it into 6.9:
      
         - A rework of the omap clock support that touches both drivers and
           device tree files
      
         - The reset controller branch changes that had a dependency on late
           bugfixes. Merging them here avoids a backmerge of 6.8-rc5 into the
           drivers branch
      
         - The RISC-V/starfive, RISC-V/microchip and ARM/Broadcom devicetree
           changes that got delayed and needed some extra time in linux-next
           for wider testing"
      
      * tag 'soc-late-6.9' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc: (31 commits)
        soc: fsl: dpio: fix kcalloc() argument order
        bus: ts-nbus: Improve error reporting
        bus: ts-nbus: Convert to atomic pwm API
        riscv: dts: starfive: jh7110: Add camera subsystem nodes
        ARM: bcm: stop selecing CONFIG_TICK_ONESHOT
        ARM: dts: omap3: Update clksel clocks to use reg instead of ti,bit-shift
        ARM: dts: am3: Update clksel clocks to use reg instead of ti,bit-shift
        clk: ti: Improve clksel clock bit parsing for reg property
        clk: ti: Handle possible address in the node name
        dt-bindings: pwm: opencores: Add compatible for StarFive JH8100
        dt-bindings: riscv: cpus: reg matches hart ID
        reset: Instantiate reset GPIO controller for shared reset-gpios
        reset: gpio: Add GPIO-based reset controller
        cpufreq: do not open-code of_phandle_args_equal()
        of: Add of_phandle_args_equal() helper
        reset: simple: add support for Sophgo SG2042
        dt-bindings: reset: sophgo: support SG2042
        riscv: dts: microchip: add specific compatible for mpfs pdma
        riscv: dts: microchip: add missing CAN bus clocks
        ARM: brcmstb: Add debug UART entry for 74165
        ...
      78c3925c
    • Linus Torvalds's avatar
      Merge tag 's390-6.9-2' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux · f9c03549
      Linus Torvalds authored
      Pull more s390 updates from Heiko Carstens:
      
       - Various virtual vs physical address usage fixes
      
       - Add new bitwise types and helper functions and use them in s390
         specific drivers and code to make it easier to find virtual vs
         physical address usage bugs.
      
         Right now virtual and physical addresses are identical for s390,
         except for module, vmalloc, and similar areas. This will be changed,
         hopefully with the next merge window, so that e.g. the kernel image
         and modules will be located close to each other, allowing for direct
         branches and also for some other simplifications.
      
         As a prerequisite this requires to fix all misuses of virtual and
         physical addresses. As it turned out people are so used to the
         concept that virtual and physical addresses are the same, that new
         bugs got added to code which was already fixed. In order to avoid
         that even more code gets merged which adds such bugs add and use new
         bitwise types, so that sparse can be used to find such usage bugs.
      
         Most likely the new types can go away again after some time
      
       - Provide a simple ARCH_HAS_DEBUG_VIRTUAL implementation
      
       - Fix kprobe branch handling: if an out-of-line single stepped relative
         branch instruction has a target address within a certain address area
         in the entry code, the program check handler may incorrectly execute
         cleanup code as if KVM code was executed, leading to crashes
      
       - Fix reference counting of zcrypt card objects
      
       - Various other small fixes and cleanups
      
      * tag 's390-6.9-2' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux: (41 commits)
        s390/entry: compare gmap asce to determine guest/host fault
        s390/entry: remove OUTSIDE macro
        s390/entry: add CIF_SIE flag and remove sie64a() address check
        s390/cio: use while (i--) pattern to clean up
        s390/raw3270: make class3270 constant
        s390/raw3270: improve raw3270_init() readability
        s390/tape: make tape_class constant
        s390/vmlogrdr: make vmlogrdr_class constant
        s390/vmur: make vmur_class constant
        s390/zcrypt: make zcrypt_class constant
        s390/mm: provide simple ARCH_HAS_DEBUG_VIRTUAL support
        s390/vfio_ccw_cp: use new address translation helpers
        s390/iucv: use new address translation helpers
        s390/ctcm: use new address translation helpers
        s390/lcs: use new address translation helpers
        s390/qeth: use new address translation helpers
        s390/zfcp: use new address translation helpers
        s390/tape: fix virtual vs physical address confusion
        s390/3270: use new address translation helpers
        s390/3215: use new address translation helpers
        ...
      f9c03549
    • Steven Rostedt (Google)'s avatar
      tracing: Just use strcmp() for testing __string() and __assign_str() match · 24f5bb9f
      Steven Rostedt (Google) authored
      As __assign_str() no longer uses its "src" parameter, there's a check to
      make sure nothing depends on it being different than what was passed to
      __string(). It originally just compared the pointer passed to __string()
      with the pointer passed into __assign_str() via the "src" parameter. But
      there's a couple of outliers that just pass in a quoted string constant,
      where comparing the pointers is UB to the compiler, as the compiler is
      free to create multiple copies of the same string constant.
      
      Instead, just use strcmp(). It may slow down the trace event, but this
      will eventually be removed.
      
      Also, fix the issue of passing NULL to strcmp() by adding a WARN_ON() to
      make sure that both "src" and the pointer saved in __string() are either
      both NULL or have content, and then checking if "src" is not NULL before
      performing the strcmp().
      
      Link: https://lore.kernel.org/all/CAHk-=wjxX16kWd=uxG5wzqt=aXoYDf1BgWOKk+qVmAO0zh7sjA@mail.gmail.com/
      
      Fixes: b1afefa6 ("tracing: Use strcmp() in __assign_str() WARN_ON() check")
      Reported-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      24f5bb9f
    • Linus Torvalds's avatar
      Merge tag 'pm-6.9-rc1-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm · fbd88dd0
      Linus Torvalds authored
      Pull more power management updates from Rafael Wysocki:
       "These update the Energy Model to make it prevent errors due to power
        unit mismatches, fix a typo in power management documentation, convert
        one driver to using a platform remove callback returning void, address
        two cpufreq issues (one in the core and one in the DT driver), and
        enable boost support in the SCMI cpufreq driver.
      
        Specifics:
      
         - Modify the Energy Model code to bail out and complain if the unit
           of power is not uW to prevent errors due to unit mismatches (Lukasz
           Luba)
      
         - Make the intel_rapl platform driver use a remove callback returning
           void (Uwe Kleine-König)
      
         - Fix typo in the suspend and interrupts document (Saravana Kannan)
      
         - Make per-policy boost flags actually take effect on platforms using
           cpufreq_boost_set_sw() (Sibi Sankar)
      
         - Enable boost support in the SCMI cpufreq driver (Sibi Sankar)
      
         - Make the DT cpufreq driver use zalloc_cpumask_var() for allocating
           cpumasks to avoid using unitinialized memory (Marek Szyprowski)"
      
      * tag 'pm-6.9-rc1-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
        cpufreq: scmi: Enable boost support
        firmware: arm_scmi: Add support for marking certain frequencies as turbo
        cpufreq: dt: always allocate zeroed cpumask
        cpufreq: Fix per-policy boost behavior on SoCs using cpufreq_boost_set_sw()
        Documentation: power: Fix typo in suspend and interrupts doc
        PM: EM: Force device drivers to provide power in uW
        powercap: intel_rapl: Convert to platform remove callback returning void
      fbd88dd0
    • Linus Torvalds's avatar
      Merge tag 'acpi-6.9-rc1-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm · 6d37f7e7
      Linus Torvalds authored
      Pull more ACPI updates from Rafael Wysocki:
       "These update ACPI documentation and kerneldoc comments.
      
        Specifics:
      
         - Add markup to generate links from footnotes in the ACPI enumeration
           document (Chris Packham)
      
         - Update the handle_eject_request() kerneldoc comment to document the
           arguments of the function and improve kerneldoc comments for ACPI
           suspend and hibernation functions (Yang Li)"
      
      * tag 'acpi-6.9-rc1-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
        ACPI: PM: Improve kerneldoc comments for suspend and hibernation functions
        ACPI: docs: enumeration: Make footnotes links
        ACPI: Document handle_eject_request() arguments
      6d37f7e7
    • Linus Torvalds's avatar
      Merge tag 'thermal-6.9-rc1-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm · ed302ad5
      Linus Torvalds authored
      Pull more thermal control updates from Rafael Wysocki:
       "These update thermal drivers for ARM platforms by adding new hardware
        support (r8a779h0, H616 THS), addressing issues (Mediatek LVTS,
        Mediatek MT7896, thermal-of) and cleaning up code.
      
        Specifics:
      
         - Fix memory leak in the error path at probe time in the Mediatek
           LVTS driver (Christophe Jaillet)
      
         - Fix control buffer enablement regression on Meditek MT7896 (Frank
           Wunderlich)
      
         - Drop spaces before TABs in different places: thermal-of, ST drivers
           and Makefile (Geert Uytterhoeven)
      
         - Adjust DT binding for NXP as fsl,tmu-range min/maxItems can vary
           among several SoC versions (Fabio Estevam)
      
         - Add support for the H616 THS controller on Sun8i platforms (Martin
           Botka)
      
         - Don't fail probe due to zone registration failure because there is
           no trip points defined in the DT (Mark Brown)
      
         - Support variable TMU array size for new platforms (Peng Fan)
      
         - Adjust the DT binding for thermal-of and make the polling time not
           required and assume it is zero when not found in the DT (Konrad
           Dybcio)
      
         - Add r8a779h0 support in both the DT and the rcar_gen3 driver (Geert
           Uytterhoeven)"
      
      * tag 'thermal-6.9-rc1-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
        thermal/drivers/rcar_gen3: Add support for R-Car V4M
        dt-bindings: thermal: rcar-gen3-thermal: Add r8a779h0 support
        thermal/of: Assume polling-delay(-passive) 0 when absent
        dt-bindings: thermal-zones: Don't require polling-delay(-passive)
        thermal/drivers/qoriq: Fix getting tmu range
        thermal/drivers/sun8i: Don't fail probe due to zone registration failure
        thermal/drivers/sun8i: Add support for H616 THS controller
        thermal/drivers/sun8i: Add SRAM register access code
        thermal/drivers/sun8i: Extend H6 calibration to support 4 sensors
        thermal/drivers/sun8i: Explain unknown H6 register value
        dt-bindings: thermal: sun8i: Add H616 THS controller
        soc: sunxi: sram: export register 0 for THS on H616
        dt-bindings: thermal: qoriq-thermal: Adjust fsl,tmu-range min/maxItems
        thermal: Drop spaces before TABs
        thermal/drivers/mediatek: Fix control buffer enablement on MT7896
        thermal/drivers/mediatek/lvts_thermal: Fix a memory leak in an error handling path
      ed302ad5
    • Linus Torvalds's avatar
      Merge tag 'ata-6.9-rc1-2' of git://git.kernel.org/pub/scm/linux/kernel/git/libata/linux · 2f3c2b39
      Linus Torvalds authored
      Pull ata fix from Niklas Cassel:
       "A single fix for ASMedia HBAs.
      
        These HBAs do not indicate that they support SATA Port Multipliers
        CAP.SPM (Supports Port Multiplier) is not set.
      
        Likewise, they do not allow you to probe the devices behind an
        attached PMP, as defined according to the SATA-IO PMP specification.
      
        Instead, they have decided to implement their own version of PMP,
        and because of this, plugging in a PMP actually works, even if the
        HBA claims that it does not support PMP.
      
        Revert a recent quirk for these HBAs, as that breaks ASMedia's own
        implementation of PMP.
      
        Unfortunately, this will once again give some users of these HBAs
        significantly increased boot time. However, a longer boot time for
        some, is the lesser evil compared to some other users not being able
        to detect their drives at all"
      
      * tag 'ata-6.9-rc1-2' of git://git.kernel.org/pub/scm/linux/kernel/git/libata/linux:
        ahci: asm1064: asm1166: don't limit reported ports
      2f3c2b39
    • Linus Torvalds's avatar
      Merge tag 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost · d95fcdf4
      Linus Torvalds authored
      Pull virtio updates from Michael Tsirkin:
      
       - Per vq sizes in vdpa
      
       - Info query for block devices support in vdpa
      
       - DMA sync callbacks in vduse
      
       - Fixes, cleanups
      
      * tag 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost: (35 commits)
        virtio_net: rename free_old_xmit_skbs to free_old_xmit
        virtio_net: unify the code for recycling the xmit ptr
        virtio-net: add cond_resched() to the command waiting loop
        virtio-net: convert rx mode setting to use workqueue
        virtio: packed: fix unmap leak for indirect desc table
        vDPA: report virtio-blk flush info to user space
        vDPA: report virtio-block read-only info to user space
        vDPA: report virtio-block write zeroes configuration to user space
        vDPA: report virtio-block discarding configuration to user space
        vDPA: report virtio-block topology info to user space
        vDPA: report virtio-block MQ info to user space
        vDPA: report virtio-block max segments in a request to user space
        vDPA: report virtio-block block-size to user space
        vDPA: report virtio-block max segment size to user space
        vDPA: report virtio-block capacity to user space
        virtio: make virtio_bus const
        vdpa: make vdpa_bus const
        vDPA/ifcvf: implement vdpa_config_ops.get_vq_num_min
        vDPA/ifcvf: get_max_vq_size to return max size
        virtio_vdpa: create vqs with the actual size
        ...
      d95fcdf4
    • Linus Torvalds's avatar
      Merge tag 'for-linus-6.9-rc1-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip · 0815d5cc
      Linus Torvalds authored
      Pull xen updates from Juergen Gross:
      
       - Xen event channel handling fix for a regression with a rare kernel
         config and some added hardening
      
       - better support of running Xen dom0 in PVH mode
      
       - a cleanup for the xen grant-dma-iommu driver
      
      * tag 'for-linus-6.9-rc1-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip:
        xen/events: increment refcnt only if event channel is refcounted
        xen/evtchn: avoid WARN() when unbinding an event channel
        x86/xen: attempt to inflate the memory balloon on PVH
        xen/grant-dma-iommu: Convert to platform remove callback returning void
      0815d5cc