- 23 May, 2024 40 commits
-
-
Johannes Berg authored
Add and use an mvm-specific guard for the mvm mutex. Signed-off-by:
Johannes Berg <johannes.berg@intel.com> Signed-off-by:
Miri Korenblit <miriam.rachel.korenblit@intel.com> Link: https://msgid.link/20240512152312.7391425b3af2.I1b109f56753dd3f35602dd2c5cf6e1e35aee313d@changeidSigned-off-by:
-
Johannes Berg authored
There's no need to calculate again whether data should be included or be handled externally, just check if any space for it was already reserved. Signed-off-by:
-
Johannes Berg authored
There's no need to allocate buf1 if we're not going to write anything to it, and the condition for writing is (correctly) "hdr_len > 0 && !iwl_trace_data()". Also allocate the event space only under the same condition. Signed-off-by:
-
Emmanuel Grumbach authored
When we crash the firmware, we need to know why we decided to do so. Almost all the callsites of iwl_force_nmi() print something in the logs that explain why the driver decided to crash the firmware. Debugfs doesn't print anything and it is then hard to understand why the firmware has crashed. Add a simple print in the debugfs hook to ease the debug. Signed-off-by:
Emmanuel Grumbach <emmanuel.grumbach@intel.com> Signed-off-by:
-
Miri Korenblit authored
When AUTO_EML is set to false, this change ignores the exit criteria, for testing purposes. Currently, if AUTO_EML is disabled, the driver will not select a link or enter EMLSR, but will still exit if one of the criteria is not fulfilled. Signed-off-by:
-
Benjamin Berg authored
Use ieee80211_vif_type_p2p instead of checking for IFTYPE_AP in combination with vif->p2p. Signed-off-by:
Benjamin Berg <benjamin.berg@intel.com> Signed-off-by:
-
Johannes Berg authored
We track which link is using which FW link ID, so there really isn't a need to separately track which link IDs are in use. Remove that code and check the table when looking for a new link ID to use. Signed-off-by:
-
Emmanuel Grumbach authored
All our firmware versions should now be printed in hex. Signed-off-by:
-
Johannes Berg authored
In practice, iwl_trans_get_rxq_dma_data() will not fail, it only can do that if called with the wrong arguments. But it does have an error value and doesn't initialize the argument when it fails, so don't use the value then. Signed-off-by:
-
Mukesh Sisodiya authored
Add new time point to get the details of scan failure While on it added other missing enum to match with FW. Signed-off-by:
Mukesh Sisodiya <mukesh.sisodiya@intel.com> Reviewed-by:
Pagadala Yesu Anjaneyulu <pagadala.yesu.anjaneyulu@intel.com> Signed-off-by:
-
Johannes Berg authored
The two versions of iwl_mei_set_power_limit() are a bit different, and while really the const isn't all that necessary on the inline, it's still better to have it be the same. Signed-off-by:
-
Johannes Berg authored
Just like with any other frame, mac80211 will do sanity checks on no-data RX (representing e.g. sounding PPDUs), and if e.g. the NSS is wrong, it will warn. This isn't a good idea if we already know the frame wasn't received well, e.g. has bad PLCP. Unless the firmware reports "no error", set the bad PLCP flag to skip checks in mac80211. Also, since we're now extracting two different values from the info field, use le32_get_bits() for both. Signed-off-by:
-
Miri Korenblit authored
Start supporting API version 91 for new devices. Signed-off-by:
-
Miri Korenblit authored
This is needed for debugging. Signed-off-by:
-
Miri Korenblit authored
The exiting code is checking the SMPS mode of deflink. Use the SMPS mode of the link_sta function parameter. Signed-off-by:
-
Miri Korenblit authored
This needs to be set only if the FW is not capable of selecting an antenna on its own. Signed-off-by:
-
Chaya Rachel Ivgi authored
The driver reads xtal_calib from NVM file, but actually never uses it. This is only used in dvm driver. Signed-off-by:
Chaya Rachel Ivgi <chaya.rachel.ivgi@intel.com> Reviewed-by:
Luciano Coelho <luciano.coelho@intel.com> Signed-off-by:
-
Shahar S Matityahu authored
fw_running assumes that memory can be retrieved only after alive. This assumption is no longer true as we support dump before alive. To avoid invalid access to the NIC, check that STATUS_DEVICE_ENABLED bit in trans status is set before dumping instead of the prior check. Signed-off-by:
Shahar S Matityahu <shahar.s.matityahu@intel.com> Reviewed-by:
-
Andrei Otcheretianski authored
These flags are not needed on 6 GHz channels, and anyway they were set incorrectly. This in turn resulted in alternating channel flags, preventing reg domain rules to be merged together, so cfg80211 couldn't even send them to the user space, as the regulatory domain was too large. Fix it. Signed-off-by:
Andrei Otcheretianski <andrei.otcheretianski@intel.com> Reviewed-by:
-
Miri Korenblit authored
The driver needs to call this function when the A-MSDU size changes. Signed-off-by:
-
Miri Korenblit authored
The existing code sets the max A-MSDU size to the deflink, set it on the given link instead. Signed-off-by:
-
Miri Korenblit authored
The link_sta pointer is now only used inside this if, so define it inside its scope. Signed-off-by:
-
Avraham Stern authored
Add an entry for setting the maximum TXOP time in microseconds. The configured value can be read from the same entry. Signed-off-by:
Avraham Stern <avraham.stern@intel.com> Reviewed-by:
Gregory Greenman <gregory.greenman@intel.com> Signed-off-by:
-
Avraham Stern authored
Allow UAPSD when P2P and BSS interfaces share the same channel. Signed-off-by:
-
Emmanuel Grumbach authored
uAPSD can't be enabled on BSS or P2P Client if there is another active interface (e.g. associated client). Allow the code that apply those limitations to run on BSS as well. Also forbid uAPSD if we have an IBSS or NAN interface in the system. Since we are now forbidding uAPSD in any concurrency scenario, we don't need to check the number of PHY contexts. Signed-off-by:
-
Johannes Berg authored
The logic here is rather convoluted - we cannot get here with lq_sta being NULL as mac80211 will (no longer) call us like that, and since I removed the rate_control_send_low() call in this function there's no longer any point in setting priv_sta to NULL either. So the only thing that remains to check is if we have actually initialized our lq_sta->drv pointer, and exit if we didn't in which case we'll use the data mac80211 already set up for the low rate usage. Reviewed-by:
-
Johannes Berg authored
If the TPE (transmit power envelope) is changed, detect and report that to the driver. Reviewed-by:
-
Johannes Berg authored
Instead of passing the full TPE elements, in all their glory and mixed up data formats for HE backward compatibility, parse them fully into the right values, and pass that to the drivers. Also introduce proper validation already in mac80211, so that drivers don't need to do it, and parse the EHT portions. The code now passes the values in the right order according to the channel used by an interface, which could also be a subset of the data advertised by the AP, if we couldn't connect with the full bandwidth (for whatever reason.) Also add kunit tests for the more complicated bits of it. Reviewed-by:
Kalle Valo <kvalo@kernel.org> Link: https://msgid.link/20240506214536.2aa839969b60.I265b28209e0b29772b2f125f7f83de44a4da877b@changeidSigned-off-by:
-
Johannes Berg authored
The chanctx can be shared, but it seems like the TPE values for this vif should only reflect the channel that the vif uses, which is captured in bss_conf->chanreq.oper rather than the chanctx. Use that when calculating defaults, a similar issue is where the data from the AP is processed, but I'm moving that to mac80211. Acked-by:
-
Johannes Berg authored
The define IEEE80211_MAX_NUM_PWR_LEVEL doesn't make much sense. Yes, that table has a maximum value of 8, and the table will actually remain that way, but EHT introduced a way to encode more levels for 320 MHz channels. Remove IEEE80211_MAX_NUM_PWR_LEVEL and, for ath11k being the only user, add ATH11K_NUM_PWR_LEVELS, where it makes sense since it cannot support 320 MHz channels. Acked-by:
-
Mukesh Sisodiya authored
6 GHz AP power type details are required to set proper tx power used to send frames. Update AP power type received in beacon while preparing for connection instead of after association so the frames before association can use the correct tx power. Reviewed-by:
-
Johannes Berg authored
There's no need to have a lockdep assert and then call another function, just move everything into one place. Reviewed-by:
-
Johannes Berg authored
These comments are no longer correct, it's a wiphy work now so it will go away immediately when canceled. Reviewed-by:
-
Johannes Berg authored
Add trace events to trace when wiphy works are queued (or delayed ones scheduled), and other APIs are called. Also add an event when the worker starts, before acquiring the mutex, to be able to see potential delays due to locking. Reviewed-by:
-
Johannes Berg authored
They were meant to be split into ops and APIs, but some ops were added in the wrong place. Fix that. Reviewed-by:
-
Johannes Berg authored
Setting the AP channel width is meant for use with the normal 20/40/... MHz channel width progression, and switching around in S1G or narrow channels isn't supported. Disallow that. Reported-by: syzbot+bc0f5b92cc7091f45fb6@syzkaller.appspotmail.com Link: https://msgid.link/20240515141600.d4a9590bfe32.I19a32d60097e81b527eafe6b0924f6c5fbb2dc45@changeidSigned-off-by:
-
Johannes Berg authored
Add some documentation to ieee80211_is_timing_measurement() and ieee80211_is_ftm(). Link: https://msgid.link/20240515093852.229aa69e972c.Ifae6762a698e79cd5a49a055fe4c32330e826200@changeidSigned-off-by:
-
Johannes Berg authored
These are all missing, as pointed out when running kernel-doc. Add return value documentation and fix some small things while at it. Link: https://msgid.link/20240515093852.1cd5ad8f354d.Idc16e9767fa42de80b659c32efc58aea38c26996@changeidSigned-off-by:
-
Johannes Berg authored
This is actually completely equivalent to the other function ieee80211_is_s1g_short_beacon(), but open-codes the logic. Implement the necessary logic in ieee80211_is_s1g_short_beacon() and remove ieee80211_next_tbtt_present(). Link: https://msgid.link/20240515093852.774ced74dea8.I152525b4cff6e6a25be6c48fe6a4b89f17bab8a9@changeidSigned-off-by:
-
Johannes Berg authored
Document the return value of ieee80211_get_radiotap_len() in the proper kernel-doc format. Link: https://msgid.link/20240515093852.143aadfdb094.I8795ec1e8cfd7106d58325fb514bae92625fb45c@changeidSigned-off-by:
-
