- 20 Sep, 2021 29 commits
-
-
Michael Straube authored
Clean up indentation in odm_RegDefine11N.h. Signed-off-by:
Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20210918181904.12000-15-straube.linux@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Michael Straube authored
Remove unused defines from odm_RegDefine11N.h. Signed-off-by:
-
Michael Straube authored
Finally the header odm_RegDefine11AC.h is unused now. Remove it. Signed-off-by:
-
Michael Straube authored
The macros ODM_IC_11N_SERIES and ODM_IC_11AC_SERIES are unused now. Remove them. Signed-off-by:
-
Michael Straube authored
(pDM_Odm->SupportICType & ODM_IC_11N_SERIES) is true in this driver. There is an if statement that checks this. Remove it and its never executed else arm. Signed-off-by:
-
Michael Straube authored
(pDM_Odm->SupportICType & ODM_IC_11AC_SERIES) is always false and (pDM_Odm->SupportICType & ODM_IC_11N_SERIES) is always true since SupportICType is ODM_RTL8188E in this driver. Remove unnecessary if statements that check for this. Signed-off-by:
-
Michael Straube authored
Replace and remove the macro ODM_BIT to make the code cleaner. Signed-off-by:
-
Michael Straube authored
Replace and remove the macro ODM_REG to make the code cleaner. Signed-off-by:
-
Michael Straube authored
SupportICType is ODM_RTL8188E in this driver. Remove code that is never executed. Signed-off-by:
-
Michael Straube authored
SupportPlatform is ODM_CE in this driver. Remove an unnecessary if statement that checks the SupportPlatform value. Signed-off-by:
-
Michael Straube authored
In this driver SupportPlatform is ODM_CE, so code in the "else if (pDM_Odm->SupportPlatform & (ODM_AP | ODM_ADSL))" is never executed. Remove it. Signed-off-by:
-
Michael Straube authored
((_ic_type) & ODM_IC_11N_SERIES) is always true since SupportICType is ODM_RTL8188E in this driver. Remove it from the _cat macro. Signed-off-by:
-
Michael Straube authored
Remove unused macros from odm_interface.h. Signed-off-by:
-
Michael Straube authored
In order to make further cleanup easier to review remove some unnecessary comments from odm_interface.h Signed-off-by:
-
Martin Kaiser authored
Commit f7b687d6 ("staging: r8188eu: remove NumTotalRFPath from struct hal_data_8188e") removed a for loop around a block of code that is executed only once when i == 0. However, without the for loop, i will never be set to 0 before the code block is executed. i remains at 2, which is the final value after the previous loop. This results in a write past the end of the powerlevel and MCSBase arrays. [ 28.480809] Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: rtl8188e_PHY_RF6052SetOFDMTxPower+0x124/0x128 [r8188eu] [ 28.493752] ---[ end Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: rtl8188e_PHY_RF6052SetOFDMTxPower+0x124/0x128 [r8188eu] ]--- Fix this by replacing i with 0 in the code block that used to be the body of the loop. While at it, remove the powerlevel array that was just holding a temporary value. Tested with Edimax EW-7811Un V2 on an ARM32 embedded system. Fixes: f7b687d6 ("staging: r8188eu: remove NumTotalRFPath from struct hal_data_8188e") Acked-by:
Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20210918134024.23837-1-martin@kaiser.cxSigned-off-by:
-
Michael Straube authored
Function EFUSE_Read1Byte() is not used, remove it. Signed-off-by:
-
Michael Straube authored
Function rtl8188e_set_rssi_cmd() is not used, remove it. Signed-off-by:
-
Michael Straube authored
Function rtw_IOL_cmd_tx_pkt_buf_dump() is not used, remove it. Signed-off-by:
-
Michael Straube authored
Function HalDetectPwrDownMode88E() is not used, remove it. Signed-off-by:
-
Michael Straube authored
Remove unused struct rf_shadow. Signed-off-by:
-
Michael Straube authored
Function rtl8188e_RF_ChangeTxPath() is not used, remove it. Signed-off-by:
-
Michael Straube authored
Function ODM_DIG_LowerBound_88E() is not used, remove it. Signed-off-by:
-
Michael Straube authored
Function odm_ConfigRF_RadioB_8188E() is not used, remove it. Signed-off-by:
-
Michael Straube authored
Function rtw_set_macaddr_acl() is not used, remove it. Signed-off-by:
-
Michael Straube authored
Function rtw_check_beacon_data() is not used, remove it. It is the only user of start_bss_network() which is the only user of update_hw_ht_param(). Remove these two functions as well. Signed-off-by:
-
Michael Straube authored
Function rtw_ap_inform_ch_switch() is not used, remove it. Signed-off-by:
-
Michael Straube authored
Function rtw_acl_remove_sta() is not used, remove it. Signed-off-by:
-
Michael Straube authored
Function rtw_acl_add_sta() is not used, remove it. Signed-off-by:
-
Michael Straube authored
Function ap_sta_info_defer_update() is not used, remove it. Signed-off-by:
-
- 18 Sep, 2021 5 commits
-
-
Benjamin Philip authored
This commit removes unnecessary parentheses, that have been flagged by checkpatch.pl in ms.c Signed-off-by:
Benjamin Philip <benjamin.philip495@gmail.com> Link: https://lore.kernel.org/r/20210918065744.26304-1-benjamin.philip495@gmail.comSigned-off-by:
-
Martin Kaiser authored
Setting HW_VAR_CHECK_TXBUF is an empty operation. Signed-off-by:
-
Martin Kaiser authored
The rtw_free_pwrctrl_priv has already been removed in commit 6729e754 ("staging: r8188eu: _free_pwrlock is empty"). Remove the prototype as well. Signed-off-by:
-
Martin Kaiser authored
Commit c0a099b7 ("staging: r8188eu: bHWPwrPindetect is always false") removed the only call to rtw_hw_resume. Signed-off-by:
-
Martin Kaiser authored
As a consequence of the bHWPwrPindetect removal, brfoffbyhw is never set to true any more. Remove the variable and code that depends on brfoffbyhw == true. Signed-off-by:
-
- 17 Sep, 2021 6 commits
-
-
Pavel Skripkin authored
Finally struct _io_ops is unused, so remove it. Reviewed-by:
Dan Carpenter <dan.carpenter@oracle.com> Co-developed-by:
Fabio M. De Francesco <fmdefrancesco@gmail.com> Signed-off-by:
Pavel Skripkin <paskripkin@gmail.com> Link: https://lore.kernel.org/r/20210917071837.10926-15-fmdefrancesco@gmail.comSigned-off-by:
-
Pavel Skripkin authored
There are only unused functions and macros and one function which can be open-coded. So, removed core/rtw_io.c at all, removed core/rtw_io.c from Makefile and open-coded rtw_init_io_priv Reviewed-by:
-
Pavel Skripkin authored
Remove the unnecessary _rtw_write_port_cancel() and usb_write_port_cancel() and embed their code into the caller (i.e., rtw_write_port_cancel()). _rtw_write_port_cancel() is a mere redefinition of rtw_write_port_cancel() and it is unneeded. usb_write_port_cancel() was the only functions assigned to the (*_usb_write_port_cancel) pointer, so we can simply remove it and make a direct call. This patch is in preparation for the _io_ops structure removal. Reviewed-by:
-
Pavel Skripkin authored
Remove the unnecessary _rtw_read_port_cancel() and usb_read_port_cancel() and embed their code into the caller (i.e., rtw_read_port_cancel()). _rtw_read_port_cancel() is a mere redefinition of rtw_read_port_cancel() and it is unneeded. usb_read_port_cancel() was the only functions assigned to the (*_usb_read_port_cancel) pointer, so we can simply remove it and make a direct call. This patch is in preparation for the _io_ops structure removal. Reviewed-by:
-
Pavel Skripkin authored
Remove the unnecessary _rtw_write_port() and usb_write_port() and embed their code into the caller (i.e., rtw_write_port()). _rtw_write_port() is a mere redefinition of rtw_write_port() and it is unneeded. usb_write_port() was the only functions assigned to the (*_usb_write_port) pointer, so we can simply remove it and make a direct call. This patch is in preparation for the _io_ops structure removal. Reviewed-by:
-
Pavel Skripkin authored
Remove the unnecessary _rtw_read_port() and usb_read_port() and embed their code into the caller (i.e., rtw_read_port()). _rtw_read_port() is a mere redefinition of rtw_read_port() and it is unneeded. usb_read_port() was the only functions assigned to the (*_usb_read_port) pointer, so we can simply remove it and make a direct call. This patch is in preparation for the _io_ops structure removal. Reviewed-by:
-
