- 09 May, 2018 16 commits
-
-
Robin Murphy authored
This reverts commit fc7f8fd4. Whilst the rationale for the above commit was in general correct, i.e. that users *consuming* the DMA addresses should rely on sglen rather than num_pages, it has always been the case that the DMA API itself still requires that dma_{sync,unmap}_sg() are called with the original number of entries as passed to dma_map_sg(), not the number of mapped entries it returned. Thus the particular changes made in that patch were erroneous. At worst this might lead to data loss at the tail end of mapped buffers on non-coherent hardware, while at best it's an example of incorrect DMA API usage which has proven to mislead readers. Signed-off-by:
Robin Murphy <robin.murphy@arm.com> Signed-off-by:
Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by:
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
-
Colin Ian King authored
Trivial fix to spelling mistake in proc text string Signed-off-by:
Colin Ian King <colin.king@canonical.com> Signed-off-by:
-
Philipp Zabel authored
Do not set context colorimetry on the raw (OUTPUT) queue for encoders. Always set colorimetry on the coded queue (CAPTURE for encoders, OUTPUT for decoders). This also skips propagation of capture queue format and selection rectangle on S_FMT(OUTPUT) to the CAPTURE queue for encoders. Signed-off-by:
Philipp Zabel <p.zabel@pengutronix.de> Signed-off-by:
-
Philipp Zabel authored
The driver helpfully resets the capture queue format and selection rectangle whenever output format is changed. This only works while the capture queue is not busy. Signed-off-by:
-
Philipp Zabel authored
Instead of duplicating the same code, call into coda_s_fmt_vid_out to propagate the output format to the capture queue. Signed-off-by:
-
Arvind Yadav authored
Replace the manual validity checks for the GPIO with the gpio_is_valid(). In vip_gpio_reserve(), Error checking for gpio pin is not correct. If pwr_pin = -1, It will return 0. This should be return an error. In sta2x11_vip_init_one(), Error checking for gpio 'reset_pin' is unnecessary. Because vip_gpio_reserve() is also checking for valid gpio pin. So removed extra error checking for gpio 'reset_pin'. Signed-off-by:
Arvind Yadav <arvind.yadav.cs@gmail.com> Signed-off-by:
-
Arvind Yadav authored
Replace the manual validity checks for the GPIO with the gpio_is_valid(). Signed-off-by:
-
Hans Verkuil authored
Fix this warning when building the docs: include/media/v4l2-dev.h:42: warning: Enum value 'VFL_TYPE_MAX' not described in enum 'vfl_devnode_type' Acked-by:
Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by:
-
Dan Carpenter authored
Smatch complains that "venc" could be uninitialized. There are a couple of error paths where it looks like maybe that could happen. I don't know if it's really a bug, but it's reasonable to set "venc" to NULL and silence the warning. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Hans Verkuil authored
This driver needs a pull up output GPIO, but devm_gpiod_get() is called with GPIOD_IN. This apparently works fine for the RPi3 where the DT correctly specifies a pull up GPIO, but on the i.MX6 it also needs to be specified with devm_gpiod_get(). Reported-by:
Henrik Mau <Henrik.Mau@linn.co.uk> Signed-off-by:
-
Wolfram Sang authored
We should get drvdata from struct device directly. Going via platform_device is an unneeded step back and forth. Signed-off-by:
Wolfram Sang <wsa+renesas@sang-engineering.com> Signed-off-by:
-
Souptick Joarder authored
Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type. Reference id -> 1c8f4220 ("mm: change return type to vm_fault_t") Signed-off-by:
Souptick Joarder <jrdr.linux@gmail.com> Acked-by:
-
Fengguang Wu authored
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1087:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 648a9576 ("media: vcodec: fix error return value from mtk_jpeg_clk_init()") CC: Ryder Lee <ryder.lee@mediatek.com> Signed-off-by:
Fengguang Wu <fengguang.wu@intel.com> Signed-off-by:
-
Simon Que authored
Improves code clarity in two ways: 1. The plural name makes it more clear that it is an array. 2. The name of the array is now no longer identical to the struct type name, so it is easier to find in the code. Signed-off-by:
Simon Que <sque@chromium.org> Acked-by:
Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by:
-
Niklas Söderlund authored
s/dose/does/ Fixes: d295c6a4 ("[media] media: entity: Add media_entity_get_fwnode_pad() function") Signed-off-by:
Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Reviewed-by:
Simon Horman <horms+renesas@verge.net.au> Signed-off-by:
-
Bingbu Cao authored
Interrupt behavior shows that some time the frame end and frame start of next frame is unstable and can range from several to hundreds of micro-sec. In the case of ~10us, isr may not clear next sof interrupt status in single handling, which prevents new interrupts from coming. Fix this by handling all pending IRQs before exiting isr, so any abnormal behavior results from very short interrupt status changes is protected. Signed-off-by:
Bingbu Cao <bingbu.cao@intel.com> Signed-off-by:
Andy Yeh <andy.yeh@intel.com> Signed-off-by:
Yong Zhi <yong.zhi@intel.com> Signed-off-by:
-
- 05 May, 2018 24 commits
-
-
Mauro Carvalho Chehab authored
Just checking for ifdefs cause build issues as reported by kernel test: config: openrisc-allmodconfig (attached as .config) compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental) All errors (new ones prefixed by >>): drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_init_connections': >> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:8: error: implicit declaration of function 'omapdss_find_mgr_from_display' [-Werror=implicit-function-declaration] mgr = omapdss_find_mgr_from_display(def_dssdev); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion] mgr = omapdss_find_mgr_from_display(def_dssdev); ^ drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_find_default_display': >> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:13: error: implicit declaration of function 'omapdss_get_default_display_name' [-Werror=implicit-function-declaration] def_name = omapdss_get_default_display_name(); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:11: warning: assignment makes pointer from integer without a cast [-Wint-conversion] def_name = omapdss_get_default_display_name(); ^ So, use IS_ENABLED() instead. Fixes: 771f7be8 ("media: omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP") Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Cc: Randy Dunlap <rdunlap@infradead.org> Cc: tomi.valkeinen@ti.com Cc: linux-omap@vger.kernel.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: -
Brad Love authored
0day build bot reported an unnoticed recursive dependency, fix it by removing the select statement. fixes: c66d4d99a8fb ("cx231xx: Add I2C_MUX dependency") Signed-off-by:Brad Love <brad@nextdimension.cc> Signed-off-by:
-
Hans de Goede authored
The recent "x86 ZONE_DMA love" discussion at LSF/MM pointed out that some gspca sub-drivvers are using GFP_DMA to allocate buffers which are used for USB bulk transfers, there is absolutely no need for this, drop it. Cc: "Luis R. Rodriguez" <mcgrof@kernel.org> Signed-off-by:
Hans de Goede <hdegoede@redhat.com> Signed-off-by:
-
Mauro Carvalho Chehab authored
This driver depends on sony-laptop driver, but this is available only for x86. So, add a stub function, in order to allow building it on non-x86 too. Signed-off-by:
Mauro Carvalho Chehab <mchehab@s-opensource.com> Signed-off-by:
-
Yasunari Takiguchi authored
This is the version update for this cxd2880 driver changing. Signed-off-by:
Yasunari Takiguchi <Yasunari.Takiguchi@sony.com> Signed-off-by:
Masayuki Yamamoto <Masayuki.Yamamoto@sony.com> Signed-off-by:
Hideki Nozawa <Hideki.Nozawa@sony.com> Signed-off-by:
Kota Yonezawa <Kota.Yonezawa@sony.com> Signed-off-by:
Toshihiko Matsumoto <Toshihiko.Matsumoto@sony.com> Signed-off-by:
Satoshi Watanabe <Satoshi.C.Watanabe@sony.com> Signed-off-by:
-
Yasunari Takiguchi authored
This is the optimization for SPI drive current and signal lock condition check part for BER/PER measure to ensure BER/PER are stable Signed-off-by:
-
Yasunari Takiguchi authored
This is the modification of structure declaration for spi_transfer. Signed-off-by:
-
Mauro Carvalho Chehab authored
As newer boards got added, update the cardlists. Signed-off-by: -
Marcel Stork authored
Extra code to be able to use this stick, only digital, not analog nor remote-control. Signed-off-by:
Marcel Stork <mjstork@gmail.com> Signed-off-by:
-
Marcel Stork authored
A cosmetic change by combining two sets of boards into one set because having the same arguments. Signed-off-by:
-
Niklas Söderlund authored
The VIN Gen3 hardware don't have Line Post-Clip capabilities as VIN Gen2 hardware have. To protect against writing outside the capture window enable field toggle after a set number of lines have been captured. Capturing outside the allocated capture buffer where observed on R-Car Gen3 Salvator-XS H3 from the CVBS input if the standard is misconfigured. That is if a PAL source is connected to the system but the adv748x standard is set to NTSC. In this case the format reported by the adv748x is 720x480 and that is what is used for the media pipeline. The PAL source generates frames in the format of 720x576 and the field is not toggled until the VSYNC is detected and at that time data have already been written outside the allocated capture buffer. With this change the capture in the situation described above results in garbage frames but that is far better then writing outside the capture buffer. Signed-off-by:
-
Niklas Söderlund authored
By setting VNMC_YCAL rcar-vin can support input video in MEDIA_BUS_FMT_UYVY8_1X16 format. Signed-off-by:
-
Niklas Söderlund authored
Store the group pointer before disassociating the VIN from the group. Fixes: 3bb4c3bc ("media: rcar-vin: add group allocator functions") Reported-by:
-
Niklas Söderlund authored
The compatible string "renesas,rcar-gen3-vin" was added before the Gen3 driver code was added but it's not possible to use. Each SoC in the Gen3 series require SoC specific knowledge in the driver to function. Remove it before it is added to any device tree descriptions. Signed-off-by:
Rob Herring <robh@kernel.org> Signed-off-by:
-
Devin Heitmueller authored
This was left over from the conversion to VB2, where the call was getting invoked both in buffer_queue and start_streaming, which was intermittently causing invalid opcodes on the VBI RISC queue. This change effectively mirrors the exact same change Hans Verkuil made in cx88-video.c in commit 389208e1 ("[media] cx88: remove leftover start_video_dma() call"). Thanks to Daniel Glöckner for spotting the actual bug after I spent several days trying to chase down the issue. Fixes: 389208e1 ("[media] cx88: remove leftover start_video_dma() call") Signed-off-by:
Devin Heitmueller <dheitmueller@kernellabs.com> Thanks-to: Daniel Glöckner <daniel-gl@gmx.net> Cc: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by:
-
Luc Van Oostenryck authored
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by:
Luc Van Oostenryck <luc.vanoostenryck@gmail.com> Signed-off-by:
-
Luc Van Oostenryck authored
The method dvb_frontend_ops::search() is defined as returning an 'enum dvbfe_search', but the implementation in this driver returns an 'int'. Fix this by returning 'enum dvbfe_search' in this driver too. Signed-off-by:
-
Luc Van Oostenryck authored
The method dvb_frontend_ops::get_frontend_algo() is defined as returning an 'enum dvbfe_algo', but the implementation in this driver returns an 'int'. Fix this by returning 'enum dvbfe_algo' on drivers. [mchehab+samsung@kernel.org: merge similar patches and patch ddbridge-mci.c the same way] Signed-off-by:
-
Anders Roxell authored
Commit 7378f114 ("media: omap2: omapfb: allow building it with COMPILE_TEST") broke compilation without CONFIG_I2C selected. drivers/media/platform/fsl-viu.c: In function ‘viu_of_probe’: drivers/media/platform/fsl-viu.c:1452:7: error: implicit declaration of function ‘i2c_get_adapter’; did you mean ‘i2c_lock_adapter’? [-Werror=implicit-function-declaration] ad = i2c_get_adapter(0); ^~~~~~~~~~~~~~~ i2c_lock_adapter drivers/media/platform/fsl-viu.c:1452:5: warning: assignment makes pointer from integer without a cast [-Wint-conversion] ad = i2c_get_adapter(0); ^ drivers/media/platform/fsl-viu.c:1534:2: error: implicit declaration of function ‘i2c_put_adapter’; did you mean ‘i2c_lock_adapter’? [-Werror=implicit-function-declaration] i2c_put_adapter(ad); ^~~~~~~~~~~~~~~ i2c_lock_adapter Added I2C dependency in order to make all configurations work again. Signed-off-by:
Anders Roxell <anders.roxell@linaro.org> Signed-off-by:
-
Daniel Scheller authored
s/shifs/shifts/ Signed-off-by:
Daniel Scheller <d.scheller@gmx.net> Signed-off-by:
-
Daniel Scheller authored
Commit ee93340e ("media: ngene: deduplicate I2C adapter evaluation") added a helper to evaluate the I2C adapter to be used for demod/tuner attachment based on the given ngene_channel, and that helper is used in many attach functions to initialise the i2c_adapter variable. However, for some reason in tuner_attach_stv6110() and demod_attach_stv0900(), the adapter evaluation wasn't removed as in all other functions. Fix (or finalize, even) the helper use by cleaning up the superfluous I2C adapter evaluation leftover in these two functions. Signed-off-by:
-
Mauro Carvalho Chehab authored
As pointed by ktest: >> drivers/media//pci/pt1/pt1.c:1433:5: warning: "CONFIG_PM_SLEEP" is not defined, evaluates to 0 [-Wundef] #if CONFIG_PM_SLEEP ^~~~~~~~~~~~~~~ Reported-by:kbuild test robot <lkp@intel.com> Signed-off-by:
-
Colin Ian King authored
The value from a readl is being masked with ITE_REG_CIOCAN_MASK however this is not being used and cfg is being re-assigned. I believe the assignment operator should actually be instead the |= operator. Detected by CoverityScan, CID#1467987 ("Unused value") Signed-off-by:Sylwester Nawrocki <s.nawrocki@samsung.com> Signed-off-by:
-
Mauro Carvalho Chehab authored
drivers/media/usb/cx231xx/cx231xx-dvb.c: In function 'unregister_dvb': drivers/media/usb/cx231xx/cx231xx-dvb.c:607:21: warning: unused variable 'client' [-Wunused-variable] struct i2c_client *client; ^~~~~~ Fixes: a12481354656 ("media: cx231xx: Switch to using new dvb i2c helpers") Signed-off-by:
-
