- 13 Sep, 2024 4 commits
-
-
Christophe JAILLET authored
This file does not compile because <linux/mfd/sm5703.h> is missing. In KConfig, it depends on MFD_SM5703. Both MFD_SM5703 and the missing include rely on another patch that never got merged. The last iteration related to this patch is [1]. So remove this dead-code and undo commit e8858ba8 ("regulator: sm5703-regulator: Add regulators support for SM5703 MFD") [1]: https://lore.kernel.org/lkml/20220423085319.483524-5-markuss.broks@gmail.com/Signed-off-by:
Christophe JAILLET <christophe.jaillet@wanadoo.fr> Link: https://patch.msgid.link/0f5da91a05e7343d290c88e3c583b674cf6219ac.1725910247.git.christophe.jaillet@wanadoo.frSigned-off-by:
Mark Brown <broonie@kernel.org>
-
Chen-Yu Tsai authored
_regulator_get() contains a lot of common code doing checks prior to the regulator lookup and housekeeping work after the lookup. Almost all the code could be shared with a OF-specific variant of _regulator_get(). Split out the common parts so that they can be reused. The OF-specific version of _regulator_get() will be added in a subsequent patch. No functional changes were made. Signed-off-by:
Chen-Yu Tsai <wenst@chromium.org> Reviewed-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://patch.msgid.link/20240911072751.365361-4-wenst@chromium.orgSigned-off-by:
-
André Draszik authored
Some comments here are referring to a non-existent regulator_ops::get_voltage_vsel() where ::get_voltage_sel() is meant, and similar for ::set_voltage_vsel() / ::set_voltage_sel(). Update the comments. Signed-off-by:
André Draszik <andre.draszik@linaro.org> Link: https://patch.msgid.link/20240913-regulator-typos-v1-1-92781c93f638@linaro.orgSigned-off-by:
-
Jinjie Ruan authored
Use irq_get_trigger_type() to replace irq_get_irq_data() and then irqd_get_trigger_type(), if the irq data is NULL it will return 0. Signed-off-by:
Jinjie Ruan <ruanjinjie@huawei.com> Link: https://patch.msgid.link/20240913013503.3754712-1-ruanjinjie@huawei.comSigned-off-by:
-
- 11 Sep, 2024 2 commits
-
-
Wei Fang authored
The behavior of regulator_dev_lookup() for non-DT way has been broken since the commit b8c32554 ("regulator: Move OF-specific regulator lookup code to of_regulator.c"). Before the commit, of_get_regulator() was used to get the regulator, which returns NULL if the regulator is not found. So the regulator will be looked up through regulator_lookup_by_name() if no matching regulator is found in regulator_map_list. However, currently, of_regulator_dev_lookup() is used to instead of of_get_regulator(), but the variable 'r' is set to ERR_PTR(-ENODEV) instead of NULL if the regulator is not found. In this case, if no regulator is found in regulator_map_list, the variable 'r' is still ERR_PTR(-ENODEV), So regulator_dev_lookup() returns the value of 'r' directly instead of continuing to look up the regulator through regulator_lookup_by_name(). Fixes: b8c32554 ("regulator: Move OF-specific regulator lookup code to of_regulator.c") Signed-off-by:
Wei Fang <wei.fang@nxp.com> Link: https://patch.msgid.link/20240911120338.526384-1-wei.fang@nxp.comSigned-off-by:
-
Mark Brown authored
Merge series from Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>: Few cleanups (safer code), built tested. Last two patches should probably be tested.
-
- 10 Sep, 2024 17 commits
-
-
Krzysztof Kozlowski authored
Switch from rdev_get_drvdata() to container_of(), so the static 'struct max77650_regulator_desc' holding 'struct regulator_desc' can be made const for code safety. Signed-off-by:
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://patch.msgid.link/20240909-regulator-const-v1-17-8934704a5787@linaro.orgSigned-off-by:
-
Krzysztof Kozlowski authored
Switch from rdev_get_drvdata() to container_of(), so the static 'struct hi6421v530_regulator_info' holding 'struct regulator_desc' can be made const for code safety. Signed-off-by:
-
Krzysztof Kozlowski authored
The hi6421v530_regulator_info.eco_microamp is assigned once and never used again. Signed-off-by:
-
Krzysztof Kozlowski authored
Driver does not modify static data with regulator description (struct regulator_desc), so make it const for code safety. Signed-off-by:
-
Krzysztof Kozlowski authored
Driver does not modify static data with regulator description (struct pfuze_regulator), so make it const for code safety. Signed-off-by:
-
Krzysztof Kozlowski authored
Driver does not modify static data with regulator description (struct pcap_regulator), so make it const for code safety. Signed-off-by:
-
Krzysztof Kozlowski authored
Driver does not modify static data with regulator description (struct regulator_desc), so make it const for code safety. Signed-off-by:
-
Krzysztof Kozlowski authored
Driver does not modify static data with regulator description (struct regulator_desc), so make it const for code safety. Signed-off-by:
-
Krzysztof Kozlowski authored
The max77826_regulator_info.rdesc is assigned once and never used again. Signed-off-by:
-
Krzysztof Kozlowski authored
Driver does not modify static data with regulator description (struct tps_driver_data), so make it const for code safety. Signed-off-by:
-
Krzysztof Kozlowski authored
Driver does not modify static data with regulator description (struct hi6421_spmi_reg_info), so make it const for code safety. Signed-off-by:
-
Krzysztof Kozlowski authored
Driver does not modify static data with regulator description (struct hi6421_regulator_info), so make it const for code safety. Signed-off-by:
-
Krzysztof Kozlowski authored
Driver does not modify static data with regulator description (struct da9121_range), so make it const for code safety. Signed-off-by:
-
Krzysztof Kozlowski authored
Driver does not modify static data with device variant description (struct da9063_dev_model), so make it const for code safety. Signed-off-by:
-
Krzysztof Kozlowski authored
Driver does not modify static data with regulators description (struct da9055_regulator_info), so make it const for code safety. Signed-off-by:
-
Krzysztof Kozlowski authored
Driver does not modify static data with regulators description (struct da9052_regulator_info), so make it const for code safety. Signed-off-by:
-
Yu Jiaoliang authored
Fixed some confusing typographical errors: comptabile->compatible, asignment->assignment, Verison->Version, meansurement->measurement, offets->offsets. Signed-off-by:
Yu Jiaoliang <yujiaoliang@vivo.com> Link: https://patch.msgid.link/20240910064631.3223441-1-yujiaoliang@vivo.comSigned-off-by:
-
- 09 Sep, 2024 4 commits
-
-
Christophe JAILLET authored
'struct regulator_desc' is not modified in this driver. Constifying this structure moves some data to a read-only section, so increases overall security, especially when the structure holds some function pointers. On a x86_64, with allmodconfig: Before: ====== text data bss dec hex filename 4974 736 16 5726 165e drivers/regulator/tps6287x-regulator.o After: ===== text data bss dec hex filename 5294 416 16 5726 165e drivers/regulator/tps6287x-regulator.o -- Compile tested only Signed-off-by:
-
Christophe JAILLET authored
'struct regulator_desc' is not modified in this driver. Constifying this structure moves some data to a read-only section, so increases overall security, especially when the structure holds some function pointers. On a x86_64, with allmodconfig: Before: ====== text data bss dec hex filename 4419 2512 0 6931 1b13 drivers/regulator/wm8400-regulator.o After: ===== text data bss dec hex filename 6307 624 0 6931 1b13 drivers/regulator/wm8400-regulator.o -- Compile tested only Signed-off-by:
-
Christophe JAILLET authored
'struct regulator_desc' is not modified in this driver. Constifying this structure moves some data to a read-only section, so increase overall security, especially when the structure holds some function pointers. On a x86_64, with allmodconfig: Before: ====== text data bss dec hex filename 13982 2118 16 16116 3ef4 drivers/regulator/da9211-regulator.o After: ===== text data bss dec hex filename 14622 1478 16 16116 3ef4 drivers/regulator/da9211-regulator.o -- Compile tested only Signed-off-by:
-
Christophe JAILLET authored
'struct regulator_desc' is not modified in this driver. Constifying this structure moves some data to a read-only section, so increase overall security, especially when the structure holds some function pointers. On a x86_64, with allmodconfig: Before: ====== text data bss dec hex filename 3516 5320 32 8868 22a4 drivers/regulator/mp5416.o After: ===== text data bss dec hex filename 8508 320 32 8860 229c drivers/regulator/mp5416.o -- Compile tested only Signed-off-by:
-
- 07 Sep, 2024 1 commit
-
-
Mark Brown authored
Merge series from Andre Przywara <andre.przywara@arm.com>: This is remainder of the AXP717 fix series, containing support for the boost regulator. This is meant to increase the battery voltage to the 5 volts required to provide the USB VBUS power. It's the usual trinity of DT bindings patch (1/3), the MFD part describing the PMIC registers (2/3) and the final patch to model the regulator (3/3). Compared to v2, this drops the merged patches, and just retains the boost related parts. It also changes the internal name of the register to AXP717_MODULE_EN_CONTROL_2, since there is another control register we will need later for battery support.
-
- 06 Sep, 2024 3 commits
-
-
Andre Przywara authored
The AXP717 also contains an adjustable boost regulator, to provide the 5V USB VBUS rail when running on battery. Add the regulator description that states the voltage range this regulator can cover. Signed-off-by:
Andre Przywara <andre.przywara@arm.com> Reviewed-by:
John Watts <contact@jookia.org> Reviewed-by:
Chen-Yu Tsai <wens@csie.org> Link: https://patch.msgid.link/20240816001824.6028-4-andre.przywara@arm.comSigned-off-by:
-
Andre Przywara authored
The AXP717 also contains a boost regulator, to provide the 5V USB VBUS rail when running on battery. Add the registers to the MFD description to be able to use them from the regulator driver. Signed-off-by:
Lee Jones <lee@kernel.org> Reviewed-by:
-
Andre Przywara authored
The X-Powers AXP717 contains a boost regulator, that it meant to provide the 5V USB VBUS voltage when the devices operates on battery. Add the name "boost" to the regexp describing the allowed node names, to allow the regulator to be described in the devicetree. Signed-off-by:
-
- 05 Sep, 2024 1 commit
-
-
Andy Shevchenko authored
Refactor of_get_*regulator() to decrease indentation and increase readability. No functional changes intended. Signed-off-by:
Andy Shevchenko <andy.shevchenko@gmail.com> Reviewed-by:
-
- 04 Sep, 2024 1 commit
-
-
Chen-Yu Tsai authored
There's still a bit of OF-specific code in the regulator device lookup function. Move those bits of code over to of_regulator.c, and create a new function of_regulator_dev_lookup() to encapsulate the code moved out of regulator_dev_lookup(). Also mark of_find_regulator_by_node() as static, since there are no other users in other compile units. There are no functional changes. A line alignment was also fixed. Signed-off-by:
-
- 29 Aug, 2024 7 commits
-
-
Chen-Yu Tsai authored
Previous commits cleaning up kerneldoc used the term "negative error number" to refer to error condition return values. Update remaining instances of other terminology such as "error code" or "errno" as well so the whole regulator subsystem is unified. Signed-off-by:
-
Chen-Yu Tsai authored
of_regulator_bulk_get_all() has a comment section that pretty much resembles a kerneldoc block, except that the block begins with "/*" instead of "/**". Fix that and also rework the "Return" section and the error code terminology so that it is the same as the other kerneldoc blocks in the same file. Fixes: 27b9ecc7 ("regulator: Add of_regulator_bulk_get_all") Signed-off-by:
-
Chen-Yu Tsai authored
kernel-doc complains about missing "Return" section for the function regulator_irq_map_event_simple(). Add a "Return" section for it based on its behavior. The function actually always returns 0, but fills in fields in its @rid parameter as needed. Expand the description of the parameter to cover this. While at it fix a typo found in the description of the same function. Reported-by:
Matti Vaittinen <mazziesaccount@gmail.com> Closes: https://lore.kernel.org/all/e341240e-1c1f-49a2-91cd-440888fdbda0@gmail.com/Signed-off-by:
-
Chen-Yu Tsai authored
kernel-doc complains about missing "Return" section for the function regulator_register_always_on(). Add a "Return" section for it based on its behavior. Signed-off-by:
-
Chen-Yu Tsai authored
kernel-doc complains about missing "Return" section for kerneldoc of of_get_fixed_voltage_config(). The kerneldoc has a description about the return values, just not in the format kernel-doc wants. Convert it to use the proper "Return:" section header. The existing description have been reworded and moved around to fit the grammar and formatting. Signed-off-by:
-
Chen-Yu Tsai authored
kernel-doc complains about missing "Return" section for many documented functions in the regulator OF-specific code. These all have descriptions about the return values, just not in the format kernel-doc wants. Convert these to use the proper "Return:" section header. The existing descriptions have been reworded and moved around to fit the grammar and formatting. Signed-off-by:
-
Chen-Yu Tsai authored
kernel-doc complains about missing "Return" section for many documented functions in the regulator core. Some with free-form return value descriptions have been fixed in the previous patch. The remaining are completely missing any mention of return values. Add "Return" sections to these kerneldoc blocks with basic descriptions. In a few cases where the functions don't call even more functions and the error numbers are known, those are documented in detail. Signed-off-by:
-
